[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114504#comment-15114504 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12784066/ZOOKEEPER-2139-08.patch against trunk revision 1726354. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 42 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3012//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3012//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3012//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114498#comment-15114498 ] Arshad Mohammad commented on ZOOKEEPER-2139: [~pratima_namb...@yahoo.com] - you are correct. I handleled it in the patch ZOOKEEPER-2139-08.patch > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110876#comment-15110876 ] Pratima Nambiar commented on ZOOKEEPER-2139: [~arshad.mohammad] - https://issues.apache.org/jira/browse/ZOOKEEPER-2330 only closes the thread in one scenario. I think another close is needed in ClientCnxn.startConnect() just before the line - zooKeeperSaslClient = new ZooKeeperSaslClient(serverPrincipal, conf); > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110115#comment-15110115 ] Arshad Mohammad commented on ZOOKEEPER-2139: Thanks [~pratima_namb...@yahoo.com] and [~ste...@apache.org] for the feedback on the patch. close() is already added in ZooKeeperSaslClient as part of ZOOKEEPER-2330. I will soon submit new patch. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109140#comment-15109140 ] Steve Loughran commented on ZOOKEEPER-2139: --- +1 for a close; make it AutoCloseable and you can use try-with-resources to clean up > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108911#comment-15108911 ] Pratima Nambiar commented on ZOOKEEPER-2139: With this patch, the login variable in ZookeeperSaslClient.java is no longer statically scoped. Login is instance scoped to support different sasl configurations. This causes a side effect in that, the thread created in Login.java is not cleaned up when ClientCnxn is closed. We are seeing the number of login threads increase steadily. To resolve this, two things need to happen I think - 1. ZooKeeperSaslClient needs a close() method that will invoke login.shutdown(); 2. ZooKeeperSaslClient.close() should be called in ClientCnxn.disconnect() and in ClientCnxn.startConnect() just before the line - zooKeeperSaslClient = new ZooKeeperSaslClient(serverPrincipal, conf); [~arshad.mohammad] let me know what you think. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108894#comment-15108894 ] Pratima Nambiar commented on ZOOKEEPER-2139: With this patch, the login variable in ZookeeperSaslClient.java is no longer statically scoped. Login is instance scoped to support different sasl configurations. This causes a side effect in that, the thread created in Login.java is not cleaned up when ClientCnxn is closed. We are seeing the number of login threads increase steadily. To resolve this, two things need to happen I think - 1. ZooKeeperSaslClient needs a close() method that will invoke login.shutdown(); 2. ZooKeeperSaslClient.close() should be called in ClientCnxn.disconnect() and in ClientCnxn.startConnect() just before the line - zooKeeperSaslClient = new ZooKeeperSaslClient(serverPrincipal, conf); > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032302#comment-15032302 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774857/ZOOKEEPER-2139-07.patch against trunk revision 1715590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 42 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2970//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2970//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2970//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031959#comment-15031959 ] Arshad Mohammad commented on ZOOKEEPER-2139: Currently one {{org.apache.zookeeper.Login}} is shared among all the {{ZookeeperSaslClient}} instances. To have multiple Kerberos authenticated Zookeeepr client in the same JVM we have create at least one Login instance for each ZooKeeper client. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025468#comment-15025468 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774146/ZOOKEEPER-2139-06.patch against trunk revision 1715590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 42 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2967//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2967//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2967//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023914#comment-15023914 ] Arshad Mohammad commented on ZOOKEEPER-2139: Current patch supports only sasl related properties but I think It will be more appropriate to handle all the Client system properties . System properties are used at both client side as well as server side.There are some system properties which are common in bother client and server. Here is the detail. *Client specific system properties:* {noformat} zookeeper.sasl.client.username zookeeper.sasl.clientconfig zookeeper.sasl.client zookeeper.server.realm zookeeper.disableAutoWatchReset zookeeper.client.secure zookeeper.clientCnxnSocket {noformat} *Common Client and Server system properties* {noformat} zookeeper.ssl.keyStore.location zookeeper.ssl.keyStore.password zookeeper.ssl.trustStore.location zookeeper.ssl.trustStore.password zookeeper.ssl.authProvider jute.maxbuffer zookeeper.kinit sun.security.jgss.native java.security.auth.login.config java.security.krb5.conf {noformat} java.security.auth.login.config and java.security.krb5.conf will remain system properties even after this patch as these are java API required system properties > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023877#comment-15023877 ] Arshad Mohammad commented on ZOOKEEPER-2139: As [~ste...@apache.org] rightly said, This patch does not handle the scenario of different principal in different kdc. It handles different principal in same kdc. Also I don't think we can support, different principal in different kdc, scenario. Please let me know if any other opinion > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006497#comment-15006497 ] Steve Loughran commented on ZOOKEEPER-2139: --- OK. In that situation, if you actually be two different kerberos principals on the client, then we should have ZK handle it —as that has to be one of the key use cases, along with "one connection SASL, one connection not-SASL". > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006174#comment-15006174 ] Walllee li commented on ZOOKEEPER-2139: --- @Steve Loughran In my stage,i need to use different kerberos principals in different KDC. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003792#comment-15003792 ] Steve Loughran commented on ZOOKEEPER-2139: --- It's intended to support >1 SASL back end, by setting the relevant flag for each one, and, perhaps, different JASS Contexts. is there another problem, such as you needing to connect as two different kerberos principals? > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003497#comment-15003497 ] Walllee li commented on ZOOKEEPER-2139: --- In my stage, the client needs to connect two secure kerberos. The patch does not solve this stage.How can i deal with the stage? > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1552#comment-1552 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12771703/ZOOKEEPER-2139-05.patch against trunk revision 1713320. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2954//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2954//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2954//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998292#comment-14998292 ] Arshad Mohammad commented on ZOOKEEPER-2139: Thanks [~surendrasingh], I will soon test and submit the patch, assigning to myself. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997068#comment-14997068 ] Gary Helmling commented on ZOOKEEPER-2139: -- [~surendrasingh] Can you please re-attach the latest version of the patch? The June 30 version, which I am assuming to be the latest, is missing the ClientConfiguration class and won't compile. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997047#comment-14997047 ] Surendra Singh Lilhore commented on ZOOKEEPER-2139: --- Thanks [~ghelmling]. Appreciate your interests. It would be good if we can test this and will try to push this in. I tested in my env and please let me know your feedback as well. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996989#comment-14996989 ] Surendra Singh Lilhore commented on ZOOKEEPER-2139: --- [~arshad.mohammad] offline discussed with me few days back. I will confirm with him and assign accordingly. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996888#comment-14996888 ] Gary Helmling commented on ZOOKEEPER-2139: -- [~surendrasingh] are you still interested in working on this? If not, I would be happy to pick up the latest patch and try to get it in. Or if you are still working on this, maybe I can help test the latest patch? > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994236#comment-14994236 ] Gary Helmling commented on ZOOKEEPER-2139: -- The reliance on global system properties for configuration can impact HBase replication setups when using ZooKeeper SASL auth, so I would love to see some resolution to this. In this case, a single HBase cluster will need to connect with both a local ZK cluster and a remote ZK cluster for the replication peer. If the two clusters require different SASL configurations, for example different values for zookeeper.sasl.client.username, then authentication with the peer cluster will fail. Is the patch from June 30th the latest? It seems to be missing the ClientConfiguration class. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956759#comment-14956759 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742776/ZOOKEEPER-2139.patch against trunk revision 1706631. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2916//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2916//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956742#comment-14956742 ] caixiaofeng commented on ZOOKEEPER-2139: mark > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608170#comment-14608170 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742776/ZOOKEEPER-2139.patch against trunk revision 1688041. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2795//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2795//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608105#comment-14608105 ] Surendra Singh Lilhore commented on ZOOKEEPER-2139: --- [~rakeshr] and [~rgs] I have attached new updated patch, Please review > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605097#comment-14605097 ] Raul Gutierrez Segales commented on ZOOKEEPER-2139: --- Mind rebasing the patch given it didn't apply [~surendrasingh]? Thanks! > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: Surendra Singh Lilhore >Assignee: Surendra Singh Lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562646#comment-14562646 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708003/ZOOKEEPER-2139_2.patch against trunk revision 1680994. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2716//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562615#comment-14562615 ] surendra singh lilhore commented on ZOOKEEPER-2139: --- Thanks [~rakeshr] for comments and suggestion.. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562616#comment-14562616 ] surendra singh lilhore commented on ZOOKEEPER-2139: --- Thanks [~rakeshr] for comments and suggestion.. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541863#comment-14541863 ] Rakesh R commented on ZOOKEEPER-2139: - Since this is a new improvement adding to {{3.5.x aplha release}} I think it would be OK to introduce the {{commons-configuration-*.jar}} and do the ZooKeeper client side logic depending on this new jar. I hope others will also have comment/thoughts to my view, it would be great to see the feedback. Thanks! > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525162#comment-14525162 ] Rakesh R commented on ZOOKEEPER-2139: - Thanks [~surendrasingh] for pointing out new jar dependency. {{commons-configuration-*.jar}} will help to hide the complexity of managing the {{config properties}} data structures. But I'm not very clear about the way of introducing a new jar dependency to the project, existing users has any concerns with this ? Can we add a new jar at the client side in 3.5 branch? It would be really great to see the feedback from others. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514109#comment-14514109 ] surendra singh lilhore commented on ZOOKEEPER-2139: --- Thanks [~rakeshr] for reviewing.. I have one doubt for first comment. If I want to extend {{AbstractConfiguration}} then I need to add one new dependency for {{commons-configuration-*.jar}} and it will create compatibility issue. Please correct if I am wrong. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513559#comment-14513559 ] Rakesh R commented on ZOOKEEPER-2139: - Thanks [~surendrasingh] for the patch. Nice improvement! Please go through the following comments. Also, please raise a [review ticket|https://reviews.apache.org] for this, that would be easy for the reviewers. # Please do extends like {{ClientConfiguration extends AbstractConfiguration}}. This way we can avoid the usage of separate {{properties}} map in our code base. # Also, we can add system properties as follows in the ClientConfiguration constructor instead of setting system properties explicitly. {code} // add system properties addConfiguration(new SystemConfiguration()); {code} # In ZooKeeper.java, please rename method to #getConfig() # Please use term {{ZooKeeper}} with proper case. I could see some places {{Zookeeper}} with 'k' small letter # {{@param conf}} is missing in the following cases, please include the same. {code} public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, boolean canBeReadOnly, HostProvider aHostProvider, ClientConfiguration conf) throws IOException { public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, boolean canBeReadOnly, ClientConfiguration conf) throws IOException { {code} # Please set {{@Test (timeout=)}} in tests # Its good practise to add messages while asserting {{Assert.assertEquals("Message reflects the case", expVal, actualVal)}} {code} + Assert.assertEquals(conf.getProperty(ClientConfiguration.ZK_SASL_CLIENT_USERNAME), "zk"); {code} # Create the {{test.conf}} file relative to the tests, can use something like below. Also, safe to call flush {code} File tmpDir = ClientBase.createTmpDir(); File confFile = new File(tmpDir, "test.conf"); FileWriter fwriter = new FileWriter(confFile); // writer.flush(); writer.close(); {code} # Since {{ZooKeeper#getSaslClient()}} is exposed, could be an issue if anybody calls {{isEnabled}} API in their client application code. Probably others can give suggestions on this part. I suggest retain the following code and we can refer the constants to {{ClientConfiguration.ZK_SASL_CLIENT_USERNAME}} etc. Then we can mark these are deprecated, what do you say? # Please mention the overriding precedence in the {{ClientConfiguration}} javadoc like, System property -> user sets value -> file etc. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385671#comment-14385671 ] surendra singh lilhore commented on ZOOKEEPER-2139: --- Failed test case is not related to this patch and its passing locally. Please review. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385501#comment-14385501 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708003/ZOOKEEPER-2139_2.patch against trunk revision 1669062. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2595//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2595//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2595//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, > ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382266#comment-14382266 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707542/ZOOKEEPER-2139_1.patch against trunk revision 1669062. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2592//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2592//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378224#comment-14378224 ] Hadoop QA commented on ZOOKEEPER-2139: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706937/ZOOKEEPER-2139.patch against trunk revision 1667358. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2585//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2585//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2585//console This message is automatically generated. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2139.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375767#comment-14375767 ] Peter Shi commented on ZOOKEEPER-2139: -- This is good idea. Some suggestions 1) use Configuration like hdfs's configuration class, can load configuration from specified locations. So that user can have same experience like hadoop configuration. 2) remove the jaas.conf, instead, put all jaas.conf information into the configurations. 3) configuration class have fallback ability, if the required property is not set in configuration object, it will try to find it in system.properties. Maybe we can have a boolean flag to control whether to fallback to system properties. This can keep compatible with previous version's configuration. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371008#comment-14371008 ] Rakesh R commented on ZOOKEEPER-2139: - bq.my application needs to talk to multiple ZooKeeper clusters whose principals are different. Presently, this can be achieved by setting specific principal and zookeeper.sasl.clientconfig to the System property before establish a connection. I could see there is a room for improving the client side configurations by passing the {{Configuration}} instead of {{System property}}. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370938#comment-14370938 ] surendra singh lilhore commented on ZOOKEEPER-2139: --- I will attach patch soon... > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370934#comment-14370934 ] surendra singh lilhore commented on ZOOKEEPER-2139: --- Thanks [~rakeshr] and [~Jobo] looking in to this issue.. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370921#comment-14370921 ] BOB commented on ZOOKEEPER-2139: Yes, there are many scenarios that the custom applications want to connect to different zk clusters(with different auth config) to get some info in one JVM. so, pls give more attention about this, and we can discuss and give one patches for it. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370745#comment-14370745 ] Rakesh R commented on ZOOKEEPER-2139: - *Adding one more use case:* Consider a case where my application needs to talk to multiple ZooKeeper clusters whose principals are different. Here the zookeeper client should have the intelligence(configuration details) to connect to two different clusters. I think, with the proposed solution {{ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, Configuration conf)}}, the ZooKeeper client can accept the respective configuration through the constructor and instantiate it using the passed configuration values. > Zookeeper client configuration should not be java system property > - > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.0 >Reporter: surendra singh lilhore >Assignee: surendra singh lilhore > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > .. > .. > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)