[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526541#comment-14526541
]
Hudson commented on ZOOKEEPER-2174:
---
SUCCESS: Integrated in ZooKeeper-trunk #2681 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2681/])
ZOOKEEPER-2174 JUnit4ZKTestRunner logs test failure for all exceptions
JUnit4ZKTestRunner logs test failure for all exceptions, even if the test
method is annotated with an expected exception (Chris Nauroth via rgs). (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677460)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174-branch-3.4.004.patch,
ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, ZOOKEEPER-2174.003.patch,
ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525964#comment-14525964
]
Chris Nauroth commented on ZOOKEEPER-2174:
--
[~rgs], [~hdeng] and [~rakeshr], thank you for the reviews and the commit!
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174-branch-3.4.004.patch,
ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, ZOOKEEPER-2174.003.patch,
ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525165#comment-14525165
]
Rakesh R commented on ZOOKEEPER-2174:
-
+1 branch-3.4 patch looks good to me.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174-branch-3.4.004.patch,
ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, ZOOKEEPER-2174.003.patch,
ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522815#comment-14522815
]
Raul Gutierrez Segales commented on ZOOKEEPER-2174:
---
Thanks [~cnauroth]!
[~rakeshr], [~hdeng], [~michim]: can I get a +1 for the 3.4 patch as well, and
then I'll push to all branches - thanks!
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174-branch-3.4.004.patch,
ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, ZOOKEEPER-2174.003.patch,
ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522881#comment-14522881
]
Hadoop QA commented on ZOOKEEPER-2174:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12729718/ZOOKEEPER-2174-branch-3.4.004.patch
against trunk revision 1676359.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2664//console
This message is automatically generated.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174-branch-3.4.004.patch,
ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, ZOOKEEPER-2174.003.patch,
ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522562#comment-14522562
]
Raul Gutierrez Segales commented on ZOOKEEPER-2174:
---
Thanks for the patch [~cnauroth]! Could you generate one for the 3.4 branch as
well please?
[~rakeshr]: shall I commit the available one to trunk 3.5?
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
ZOOKEEPER-2174.003.patch, ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507555#comment-14507555
]
Hongchao Deng commented on ZOOKEEPER-2174:
--
Thanks for the code, [~cnauroth]!
Two nits:
1. can you add some comments so it's easier to understand?
2. add a logging when expected exception gets caught
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: ZOOKEEPER-2174.001.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507761#comment-14507761
]
Hadoop QA commented on ZOOKEEPER-2174:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12727298/ZOOKEEPER-2174.002.patch
against trunk revision 1672934.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2645//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2645//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2645//console
This message is automatically generated.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508399#comment-14508399
]
Rakesh R commented on ZOOKEEPER-2174:
-
Thanks [~cnauroth] for correcting all the cases.
bq. slf4j doesn't offer a method that accepts both a parameterized message and
an exception at the same time.
I could see similar usage in the project and it seems working fine. What do you
say?
{{StaticHostProvider.java}}
{code}
} catch (UnknownHostException ex) {
LOG.warn(No IP address found for server: {}, address, ex);
}
{code}
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
ZOOKEEPER-2174.003.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508418#comment-14508418
]
Hadoop QA commented on ZOOKEEPER-2174:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12727517/ZOOKEEPER-2174.003.patch
against trunk revision 1672934.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2646//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2646//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2646//console
This message is automatically generated.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
ZOOKEEPER-2174.003.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508493#comment-14508493
]
Rakesh R commented on ZOOKEEPER-2174:
-
Thanks [~cnauroth] for taking care this.
+1 latest patch looks good to me.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
ZOOKEEPER-2174.003.patch, ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508496#comment-14508496
]
Hadoop QA commented on ZOOKEEPER-2174:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12727532/ZOOKEEPER-2174.004.patch
against trunk revision 1672934.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2647//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2647//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2647//console
This message is automatically generated.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
ZOOKEEPER-2174.003.patch, ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506137#comment-14506137
]
Hadoop QA commented on ZOOKEEPER-2174:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12727036/ZOOKEEPER-2174.001.patch
against trunk revision 1672934.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2644//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2644//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2644//console
This message is automatically generated.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: ZOOKEEPER-2174.001.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506365#comment-14506365
]
Chris Nauroth commented on ZOOKEEPER-2174:
--
I reviewed the Jenkins output and checked for the tests that I've been seeing
logged as failures erroneously by the runner. These are no longer logging the
failure message, so it appears this patch had the desired effect.
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: ZOOKEEPER-2174.001.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
