[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712440#comment-14712440 ] caixiaofeng commented on ZOOKEEPER-2224: mark Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Components: java client Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.4.7, 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch, ZOOKEEPER-2224_br_3_4-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614612#comment-14614612 ] Hadoop QA commented on ZOOKEEPER-2224: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12743674/ZOOKEEPER-2224_br_3_4-04.patch against trunk revision 1689211. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2806//console This message is automatically generated. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Components: java client Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch, ZOOKEEPER-2224_br_3_4-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614210#comment-14614210 ] Hudson commented on ZOOKEEPER-2224: --- SUCCESS: Integrated in ZooKeeper-trunk #2744 (See [https://builds.apache.org/job/ZooKeeper-trunk/2744/]) ZOOKEEPER-2224: Four letter command hangs when network is slow (Arshad Mohammad via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1689211) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Components: java client Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614128#comment-14614128
]
Rakesh R commented on ZOOKEEPER-2224:
-
Committed to trunk : http://svn.apache.org/viewvc?view=revisionrevision=1689211
Committed to br3.5 : http://svn.apache.org/viewvc?view=revisionrevision=1689212
[~arshad.mohammad], I think the fix should go to {{branch-3.4}} as well. Could
you please provide a patch on {{branch-3.4}}. Will resolve the issue once
committed there.
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch,
ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611063#comment-14611063
]
Chris Nauroth commented on ZOOKEEPER-2224:
--
[~arshad.mohammad], thank you for updating the patch. I think the only thing
left is a nitpick in {{FourLetterWordsTest}}. Please rename {{timout}} to
{{timeout}}.
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch,
ZOOKEEPER-2224-03.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611511#comment-14611511 ] Rakesh R commented on ZOOKEEPER-2224: - Thanks [~arshad.mohammad] for taking care this. I'll commit the patch today. Thanks [~rgs], [~cnauroth] for the reviews. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611336#comment-14611336 ] Hadoop QA commented on ZOOKEEPER-2224: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12743184/ZOOKEEPER-2224-04.patch against trunk revision 1688505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2802//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2802//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2802//console This message is automatically generated. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609636#comment-14609636 ] Arshad Mohammad commented on ZOOKEEPER-2224: Thanks [~rakeshr] for reviewing the patch. Worked on the comments and submitted the patch again. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609607#comment-14609607
]
Rakesh R commented on ZOOKEEPER-2224:
-
Thanks [~arshad.mohammad] for the contribution. Few minor comments, please see:
# small typo: DEFAUL_SOCKET_TIMEOUTE, please remove extra E
# In general, it is good to follow the pattern - begin the test case name with
{{test}}. Please rename the test name as {{testValidateSocketTimeout}}. Also,
please add {{@Test(timeout=1)}} in test.
{code}
public void validateSocketTimeoute()
{code}
# Its good to add exception message when wrapping the actual exception like,
{code}
throw new IOException(Exception while executing four letter word: + cmd, e);
{code}
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609646#comment-14609646 ] Hadoop QA commented on ZOOKEEPER-2224: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12743009/ZOOKEEPER-2224-03.patch against trunk revision 1688505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2799//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2799//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2799//console This message is automatically generated. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611210#comment-14611210 ] Chris Nauroth commented on ZOOKEEPER-2224: -- +1 (non-binding) for patch v04. Thank you for contributing the patch, Arshad. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609330#comment-14609330 ] Hadoop QA commented on ZOOKEEPER-2224: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742976/ZOOKEEPER-2224-02.patch against trunk revision 1688505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2798//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2798//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2798//console This message is automatically generated. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609365#comment-14609365
]
Arshad Mohammad commented on ZOOKEEPER-2224:
Thanks [~rgs], [~cnauroth] for your comments. All comments handled except bellow
{quote}
Is the null check on host and special case for the loopback address required?
It seems host cannot be null here, because main enforces the expected number of
arguments.
{quote}
The exact same code is being used in Socket(host,port) constructor
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608176#comment-14608176 ] Hadoop QA commented on ZOOKEEPER-2224: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742771/ZOOKEEPER-2224-01.patch against trunk revision 1688041. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2796//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2796//console This message is automatically generated. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608083#comment-14608083 ] BASANT KUMAR commented on ZOOKEEPER-2224: - my page how to work show? Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608092#comment-14608092 ] Arshad Mohammad commented on ZOOKEEPER-2224: I did not get, can you please explain Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608091#comment-14608091 ] BASANT KUMAR commented on ZOOKEEPER-2224: - four letter command hangs when network is slow. Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.6.0 Attachments: ZOOKEEPER-2224-01.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608803#comment-14608803
]
Raul Gutierrez Segales commented on ZOOKEEPER-2224:
---
Thanks for the patch [~arshad.mohammad]! A few comments:
In:
{code}
public static String send4LetterWord(String host, int port, String cmd)
throws IOException, SSLContextException {
-return send4LetterWord(host, port, cmd, false);
+return send4LetterWord(host, port, cmd, false, 5000);
{code}
why not use DEFAUL_SOCKET_TIMEOUT instead of 5000?
Nit in:
{code}
+//in millisecond, socket should connect/read within this period otherwise
SocketTimeoutException
{code}
*milliseconds
In:
{code}
+}catch (SocketTimeoutException e)
+{
+throw new IOException(e);
{code}
please use proper spacing and { on the same line as catch:
{code}
+} catch (SocketTimeoutException e) {
+throw new IOException(e);
{code}
In:
{code}
+String resp = sendRequest(isro,2000);
{code}
space between isro, and 2000.
Thanks!
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608708#comment-14608708
]
Arshad Mohammad commented on ZOOKEEPER-2224:
I guess you want to know more about this defect.
The scenario is as follows.
We have three node zookeeper cluster, it is working fine.
We have an application which sends four letter command to one of the zookeeper
servers periodically.
We reduced the network connectivity to 1 KBps between our application and
zookeeper.
The application hanged immediately after reducing the network connectivity.
Even after restoring the connectivity application has not come out. It was
still hanged.
The root cause of the problem is the four letter command, it hangs while
reading from the socket.
class {{org.apache.zookeeper.client.FourLetterWordMain}} has similar code as
bellow
{code}
Socket sock = new Socket(host, port);
sock.read()
{code}
To fix this issue above code should be changed to
{code}
int timeout=someValue
Socket sock = new Socket();
sock.connect(hostaddress, timeout);
sock.setSoTimeout(timeout);
sock.read()
{code}
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608989#comment-14608989
]
Chris Nauroth commented on ZOOKEEPER-2224:
--
Hi Arshad. Nice catch! Here are a few more comments.
# The current patch is starting the SSL handshake before connecting the socket.
Is that the cause of the test failures?
# It looks like there is a small typo with {{DEFAUL_SOCKET_TIMEOUT}} missing
the 'T' in DEFAULT.
# Is the null check on {{host}} and special case for the loopback address
required? It seems {{host}} cannot be null here, because {{main}} enforces the
expected number of arguments.
# The test also appears to have a small typo: {{timout}} instead of {{timeout}}.
# Is it necessary for the test to create and close {{zk1}}? The test runs
{{isro}}, which just reports server read-only state, so I don't think there is
a dependency on any established client sessions.
Thank you!
Four letter command hangs when network is slow
--
Key: ZOOKEEPER-2224
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.6.0
Attachments: ZOOKEEPER-2224-01.patch
Four letter command hangs when network is slow or network goes down in
between the operation, and the application also, which calling this four
letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
