[jira] [Commented] (ZOOKEEPER-2622) ZooTrace.logQuorumPacket does nothing

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843934#comment-15843934
 ] 

Hudson commented on ZOOKEEPER-2622:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3254 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3254/])
ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing (arshad: rev 
edf75b5e31f0d9e2fbfadbd95bae9d1d6c4737f6)
* (edit) src/java/main/org/apache/zookeeper/server/ZooTrace.java


> ZooTrace.logQuorumPacket does nothing
> -
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Trivial
>  Labels: newbie
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2622) ZooTrace.logQuorumPacket does nothing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843893#comment-15843893
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2622:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/95


> ZooTrace.logQuorumPacket does nothing
> -
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Trivial
>  Labels: newbie
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2622) ZooTrace.logQuorumPacket does nothing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842890#comment-15842890
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2622:
---

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/95
  
Go ahead @arshadmohammad!  

My only observation is that this dead code is also in branch-3.4 and 
branch-3.5 so I would advise to cherry-pick it to those branches too, right 
@fpj ?


> ZooTrace.logQuorumPacket does nothing
> -
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Trivial
>  Labels: newbie
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2622) ZooTrace.logQuorumPacket does nothing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842622#comment-15842622
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2622:
---

Github user arshadmohammad commented on the issue:

https://github.com/apache/zookeeper/pull/95
  
LGTM, I will commit it.
@eribeiro  do you have any comment?


> ZooTrace.logQuorumPacket does nothing
> -
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Trivial
>  Labels: newbie
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2622) ZooTrace.logQuorumPacket does nothing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614872#comment-15614872
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2622:
---

GitHub user fpj opened a pull request:

https://github.com/apache/zookeeper/pull/95

ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing

DO NOT MERGE

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fpj/zookeeper ZK-2622

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #95


commit 76681a075e045107f149e5ab67756991faf1d8ba
Author: fpj 
Date:   2016-10-28T09:14:51Z

ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing




> ZooTrace.logQuorumPacket does nothing
> -
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Priority: Trivial
>  Labels: newbie
> Fix For: 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)