[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694265#comment-15694265
 ] 

Michael Han commented on ZOOKEEPER-2628:


[~fpj] Thanks for reviewing and merging this patch. Unfortunately I just 
noticed C client build was broken because of one change in the patch. Created 
ZOOKEEPER-2636 where I did post mortem analysis and the fix to the broken build.

> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693858#comment-15693858
 ] 

Hudson commented on ZOOKEEPER-2628:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3169 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3169/])
ZOOKEEPER-2628: Fix findbug warnings. (fpj: rev 
b9beabf5cfbb8e447f67a8050486ca2821132f61)
* (edit) src/java/main/org/apache/zookeeper/server/DataTree.java
* (edit) src/java/main/org/apache/jute/compiler/CGenerator.java
* (edit) 
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java
* (edit) src/java/main/org/apache/zookeeper/version/util/VerGen.java
* (edit) src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java
* (edit) 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
* (edit) src/java/main/org/apache/zookeeper/cli/DeleteCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java
* (edit) src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
* (edit) src/java/main/org/apache/jute/compiler/CppGenerator.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) src/java/test/config/findbugsExcludeFile.xml
* (edit) src/java/main/org/apache/zookeeper/ZooKeeperMain.java
* (edit) src/java/main/org/apache/jute/compiler/JRecord.java


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693655#comment-15693655
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/102


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690710#comment-15690710
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
@fpj Thank you for taking time to double check the patch.

>> I noticed that there are also unaddressed comments from @lvfangmin and 
@eribeiro .
The comments were about using Interface type instead of implementation 
type, and I addressed the comments by creating ZOOKEEPER-2630 because this 
issue is not a regression and is not specifically about findbug warnings, and I 
think it might be better to address them separately.

I've left replies on your other comments in PR, please take a look.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690675#comment-15690675
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89355986
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -403,168 +410,165 @@ public void genJavaCode(File outputDirectory) 
throws IOException {
 } else if (!pkgdir.isDirectory()) {
 throw new IOException(pkgpath + " is not a directory.");
 }
-File jfile = new File(pkgdir, getName()+".java");
-FileWriter jj = new FileWriter(jfile);
-jj.write("// File generated by hadoop record compiler. Do not 
edit.\n");
-jj.write("/**\n");
-jj.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-jj.write("* or more contributor license agreements.  See the 
NOTICE file\n");
-jj.write("* distributed with this work for additional 
information\n");
-jj.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-jj.write("* to you under the Apache License, Version 2.0 (the\n");
-jj.write("* \"License\"); you may not use this file except in 
compliance\n");
-jj.write("* with the License.  You may obtain a copy of the 
License at\n");
-jj.write("*\n");
-jj.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-jj.write("*\n");
-jj.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-jj.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
-jj.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-jj.write("* See the License for the specific language governing 
permissions and\n");
-jj.write("* limitations under the License.\n");
-jj.write("*/\n");
-jj.write("\n");
-jj.write("package "+getJavaPackage()+";\n\n");
-jj.write("import org.apache.jute.*;\n");
-jj.write("public class "+getName()+" implements Record {\n");
-for (Iterator i = mFields.iterator(); i.hasNext();) {
-JField jf = i.next();
-jj.write(jf.genJavaDecl());
-}
-jj.write("  public "+getName()+"() {\n");
-jj.write("  }\n");
+try (FileWriter jj = new FileWriter(new File(pkgdir, 
getName()+".java"))) {
+jj.write("// File generated by hadoop record compiler. Do not 
edit.\n");
+jj.write("/**\n");
+jj.write("* Licensed to the Apache Software Foundation (ASF) 
under one\n");
+jj.write("* or more contributor license agreements.  See the 
NOTICE file\n");
+jj.write("* distributed with this work for additional 
information\n");
+jj.write("* regarding copyright ownership.  The ASF licenses 
this file\n");
+jj.write("* to you under the Apache License, Version 2.0 
(the\n");
+jj.write("* \"License\"); you may not use this file except in 
compliance\n");
+jj.write("* with the License.  You may obtain a copy of the 
License at\n");
+jj.write("*\n");
+jj.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
+jj.write("*\n");
+jj.write("* Unless required by applicable law or agreed to in 
writing, software\n");
+jj.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
+jj.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
either express or implied.\n");
+jj.write("* See the License for the specific language 
governing permissions and\n");
+jj.write("* limitations under the License.\n");
+jj.write("*/\n");
+jj.write("\n");
+jj.write("package " + getJavaPackage() + ";\n\n");
+jj.write("import org.apache.jute.*;\n");
+jj.write("public class " + getName() + " implements Record 
{\n");
+for (Iterator i = mFields.iterator(); i.hasNext(); ) {
+JField jf = i.next();
+jj.write(jf.genJavaDecl());
+}
+jj.write("  public " + getName() + "() {\n");
+jj.write("  }\n");
 
-jj.write("  public "+getName()+"(\n");
-int fIdx = 0;
-int fLen = mFields.size();
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690676#comment-15690676
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89356018
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -576,174 +580,174 @@ public void genCsharpCode(File outputDirectory) 
throws IOException {
 } else if (!outputDirectory.isDirectory()) {
 throw new IOException(outputDirectory + " is not a 
directory.");
 }
-File csharpFile = new File(outputDirectory, getName()+".cs");
-FileWriter cs = new FileWriter(csharpFile);
-cs.write("// File generated by hadoop record compiler. Do not 
edit.\n");
-cs.write("/**\n");
-cs.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-cs.write("* or more contributor license agreements.  See the 
NOTICE file\n");
-cs.write("* distributed with this work for additional 
information\n");
-cs.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-cs.write("* to you under the Apache License, Version 2.0 (the\n");
-cs.write("* \"License\"); you may not use this file except in 
compliance\n");
-cs.write("* with the License.  You may obtain a copy of the 
License at\n");
-cs.write("*\n");
-cs.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-cs.write("*\n");
-cs.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-cs.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
-cs.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-cs.write("* See the License for the specific language governing 
permissions and\n");
-cs.write("* limitations under the License.\n");
-cs.write("*/\n");
-cs.write("\n");
-cs.write("using System;\n");
-cs.write("using Org.Apache.Jute;\n");
-cs.write("\n");
-cs.write("namespace "+getCsharpNameSpace()+"\n");
-cs.write("{\n");
-
-String className = getCsharpName();
-cs.write("public class "+className+" : IRecord, IComparable \n");
-cs.write("{\n");
-cs.write("  public "+ className +"() {\n");
-cs.write("  }\n");
-
-cs.write("  public "+className+"(\n");
-int fIdx = 0;
-int fLen = mFields.size();
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-cs.write(jf.genCsharpConstructorParam(jf.getCsharpName()));
-cs.write((fLen-1 == fIdx)?"":",\n");
-}
-cs.write(") {\n");
-fIdx = 0;
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-cs.write(jf.genCsharpConstructorSet(jf.getCsharpName()));
-}
-cs.write("  }\n");
-fIdx = 0;
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-cs.write(jf.genCsharpGetSet(fIdx));
+
+try (FileWriter cs = new FileWriter(new File(outputDirectory, 
getName() + ".cs"));) {
+cs.write("// File generated by hadoop record compiler. Do not 
edit.\n");
+cs.write("/**\n");
+cs.write("* Licensed to the Apache Software Foundation (ASF) 
under one\n");
+cs.write("* or more contributor license agreements.  See the 
NOTICE file\n");
+cs.write("* distributed with this work for additional 
information\n");
+cs.write("* regarding copyright ownership.  The ASF licenses 
this file\n");
+cs.write("* to you under the Apache License, Version 2.0 
(the\n");
+cs.write("* \"License\"); you may not use this file except in 
compliance\n");
+cs.write("* with the License.  You may obtain a copy of the 
License at\n");
+cs.write("*\n");
+cs.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
+cs.write("*\n");
+cs.write("* Unless required by applicable law or agreed to in 
writing, software\n");
+cs.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
+cs.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
either express or implied.\n");
+cs.write("* See the License for the specific language 

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689676#comment-15689676
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89287398
  
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -144,4 +144,10 @@
 
   
 
+  
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689664#comment-15689664
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
@hanm I've left a few comments, but in general looks pretty good. I noticed 
that there are also unaddressed comments from @lvfangmin and @eribeiro . Could 
you take care of those so that we can check this in, please?


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689656#comment-15689656
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89284431
  
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -144,4 +144,10 @@
 
   
 
+  
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689655#comment-15689655
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89283699
  
--- Diff: src/java/main/org/apache/zookeeper/cli/DeleteCommand.java ---
@@ -56,14 +56,7 @@ public CliCommand parse(String[] cmdArgs) throws 
CliParseException {
 }
 
 private void retainCompatibility(String[] cmdArgs) throws 
CliParseException {
-// delete path [version]
 if (args.length > 2) {
-// rewrite to option
-String [] newCmd = new String[4];
--- End diff --

Why are we removing this rewrite?


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689658#comment-15689658
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89264869
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -403,168 +410,165 @@ public void genJavaCode(File outputDirectory) 
throws IOException {
 } else if (!pkgdir.isDirectory()) {
 throw new IOException(pkgpath + " is not a directory.");
 }
-File jfile = new File(pkgdir, getName()+".java");
-FileWriter jj = new FileWriter(jfile);
-jj.write("// File generated by hadoop record compiler. Do not 
edit.\n");
-jj.write("/**\n");
-jj.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-jj.write("* or more contributor license agreements.  See the 
NOTICE file\n");
-jj.write("* distributed with this work for additional 
information\n");
-jj.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-jj.write("* to you under the Apache License, Version 2.0 (the\n");
-jj.write("* \"License\"); you may not use this file except in 
compliance\n");
-jj.write("* with the License.  You may obtain a copy of the 
License at\n");
-jj.write("*\n");
-jj.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-jj.write("*\n");
-jj.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-jj.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
-jj.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-jj.write("* See the License for the specific language governing 
permissions and\n");
-jj.write("* limitations under the License.\n");
-jj.write("*/\n");
-jj.write("\n");
-jj.write("package "+getJavaPackage()+";\n\n");
-jj.write("import org.apache.jute.*;\n");
-jj.write("public class "+getName()+" implements Record {\n");
-for (Iterator i = mFields.iterator(); i.hasNext();) {
-JField jf = i.next();
-jj.write(jf.genJavaDecl());
-}
-jj.write("  public "+getName()+"() {\n");
-jj.write("  }\n");
+try (FileWriter jj = new FileWriter(new File(pkgdir, 
getName()+".java"))) {
+jj.write("// File generated by hadoop record compiler. Do not 
edit.\n");
+jj.write("/**\n");
+jj.write("* Licensed to the Apache Software Foundation (ASF) 
under one\n");
+jj.write("* or more contributor license agreements.  See the 
NOTICE file\n");
+jj.write("* distributed with this work for additional 
information\n");
+jj.write("* regarding copyright ownership.  The ASF licenses 
this file\n");
+jj.write("* to you under the Apache License, Version 2.0 
(the\n");
+jj.write("* \"License\"); you may not use this file except in 
compliance\n");
+jj.write("* with the License.  You may obtain a copy of the 
License at\n");
+jj.write("*\n");
+jj.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
+jj.write("*\n");
+jj.write("* Unless required by applicable law or agreed to in 
writing, software\n");
+jj.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
+jj.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
either express or implied.\n");
+jj.write("* See the License for the specific language 
governing permissions and\n");
+jj.write("* limitations under the License.\n");
+jj.write("*/\n");
+jj.write("\n");
+jj.write("package " + getJavaPackage() + ";\n\n");
+jj.write("import org.apache.jute.*;\n");
+jj.write("public class " + getName() + " implements Record 
{\n");
+for (Iterator i = mFields.iterator(); i.hasNext(); ) {
+JField jf = i.next();
+jj.write(jf.genJavaDecl());
+}
+jj.write("  public " + getName() + "() {\n");
+jj.write("  }\n");
 
-jj.write("  public "+getName()+"(\n");
-int fIdx = 0;
-int fLen = mFields.size();
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689657#comment-15689657
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89285632
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -576,174 +580,174 @@ public void genCsharpCode(File outputDirectory) 
throws IOException {
 } else if (!outputDirectory.isDirectory()) {
 throw new IOException(outputDirectory + " is not a 
directory.");
 }
-File csharpFile = new File(outputDirectory, getName()+".cs");
-FileWriter cs = new FileWriter(csharpFile);
-cs.write("// File generated by hadoop record compiler. Do not 
edit.\n");
-cs.write("/**\n");
-cs.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-cs.write("* or more contributor license agreements.  See the 
NOTICE file\n");
-cs.write("* distributed with this work for additional 
information\n");
-cs.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-cs.write("* to you under the Apache License, Version 2.0 (the\n");
-cs.write("* \"License\"); you may not use this file except in 
compliance\n");
-cs.write("* with the License.  You may obtain a copy of the 
License at\n");
-cs.write("*\n");
-cs.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-cs.write("*\n");
-cs.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-cs.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
-cs.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-cs.write("* See the License for the specific language governing 
permissions and\n");
-cs.write("* limitations under the License.\n");
-cs.write("*/\n");
-cs.write("\n");
-cs.write("using System;\n");
-cs.write("using Org.Apache.Jute;\n");
-cs.write("\n");
-cs.write("namespace "+getCsharpNameSpace()+"\n");
-cs.write("{\n");
-
-String className = getCsharpName();
-cs.write("public class "+className+" : IRecord, IComparable \n");
-cs.write("{\n");
-cs.write("  public "+ className +"() {\n");
-cs.write("  }\n");
-
-cs.write("  public "+className+"(\n");
-int fIdx = 0;
-int fLen = mFields.size();
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-cs.write(jf.genCsharpConstructorParam(jf.getCsharpName()));
-cs.write((fLen-1 == fIdx)?"":",\n");
-}
-cs.write(") {\n");
-fIdx = 0;
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-cs.write(jf.genCsharpConstructorSet(jf.getCsharpName()));
-}
-cs.write("  }\n");
-fIdx = 0;
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-cs.write(jf.genCsharpGetSet(fIdx));
+
+try (FileWriter cs = new FileWriter(new File(outputDirectory, 
getName() + ".cs"));) {
+cs.write("// File generated by hadoop record compiler. Do not 
edit.\n");
+cs.write("/**\n");
+cs.write("* Licensed to the Apache Software Foundation (ASF) 
under one\n");
+cs.write("* or more contributor license agreements.  See the 
NOTICE file\n");
+cs.write("* distributed with this work for additional 
information\n");
+cs.write("* regarding copyright ownership.  The ASF licenses 
this file\n");
+cs.write("* to you under the Apache License, Version 2.0 
(the\n");
+cs.write("* \"License\"); you may not use this file except in 
compliance\n");
+cs.write("* with the License.  You may obtain a copy of the 
License at\n");
+cs.write("*\n");
+cs.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
+cs.write("*\n");
+cs.write("* Unless required by applicable law or agreed to in 
writing, software\n");
+cs.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
+cs.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
either express or implied.\n");
+cs.write("* See the License for the specific language 

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689659#comment-15689659
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89264584
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -403,168 +410,165 @@ public void genJavaCode(File outputDirectory) 
throws IOException {
 } else if (!pkgdir.isDirectory()) {
 throw new IOException(pkgpath + " is not a directory.");
 }
-File jfile = new File(pkgdir, getName()+".java");
-FileWriter jj = new FileWriter(jfile);
-jj.write("// File generated by hadoop record compiler. Do not 
edit.\n");
-jj.write("/**\n");
-jj.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-jj.write("* or more contributor license agreements.  See the 
NOTICE file\n");
-jj.write("* distributed with this work for additional 
information\n");
-jj.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-jj.write("* to you under the Apache License, Version 2.0 (the\n");
-jj.write("* \"License\"); you may not use this file except in 
compliance\n");
-jj.write("* with the License.  You may obtain a copy of the 
License at\n");
-jj.write("*\n");
-jj.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-jj.write("*\n");
-jj.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-jj.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
-jj.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-jj.write("* See the License for the specific language governing 
permissions and\n");
-jj.write("* limitations under the License.\n");
-jj.write("*/\n");
-jj.write("\n");
-jj.write("package "+getJavaPackage()+";\n\n");
-jj.write("import org.apache.jute.*;\n");
-jj.write("public class "+getName()+" implements Record {\n");
-for (Iterator i = mFields.iterator(); i.hasNext();) {
-JField jf = i.next();
-jj.write(jf.genJavaDecl());
-}
-jj.write("  public "+getName()+"() {\n");
-jj.write("  }\n");
+try (FileWriter jj = new FileWriter(new File(pkgdir, 
getName()+".java"))) {
+jj.write("// File generated by hadoop record compiler. Do not 
edit.\n");
+jj.write("/**\n");
+jj.write("* Licensed to the Apache Software Foundation (ASF) 
under one\n");
+jj.write("* or more contributor license agreements.  See the 
NOTICE file\n");
+jj.write("* distributed with this work for additional 
information\n");
+jj.write("* regarding copyright ownership.  The ASF licenses 
this file\n");
+jj.write("* to you under the Apache License, Version 2.0 
(the\n");
+jj.write("* \"License\"); you may not use this file except in 
compliance\n");
+jj.write("* with the License.  You may obtain a copy of the 
License at\n");
+jj.write("*\n");
+jj.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
+jj.write("*\n");
+jj.write("* Unless required by applicable law or agreed to in 
writing, software\n");
+jj.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
+jj.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
either express or implied.\n");
+jj.write("* See the License for the specific language 
governing permissions and\n");
+jj.write("* limitations under the License.\n");
+jj.write("*/\n");
+jj.write("\n");
+jj.write("package " + getJavaPackage() + ";\n\n");
+jj.write("import org.apache.jute.*;\n");
+jj.write("public class " + getName() + " implements Record 
{\n");
+for (Iterator i = mFields.iterator(); i.hasNext(); ) {
+JField jf = i.next();
+jj.write(jf.genJavaDecl());
+}
+jj.write("  public " + getName() + "() {\n");
+jj.write("  }\n");
 
-jj.write("  public "+getName()+"(\n");
-int fIdx = 0;
-int fLen = mFields.size();
-for (Iterator i = mFields.iterator(); i.hasNext(); fIdx++) 
{
-JField jf = i.next();
-

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689660#comment-15689660
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r89283922
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -151,9 +153,13 @@
  */
 public final static int telnetCloseCmd = 0xfff4fffd;
 
-public final static HashMap cmd2String =
+final static HashMap cmd2String =
--- End diff --

If we can remove this `public`, then I think we should. Also agree with the 
consistent `Map` declaration comment.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668763#comment-15668763
 ] 

Hadoop QA commented on ZOOKEEPER-2628:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/73//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/73//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/73//console

This message is automatically generated.

> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668708#comment-15668708
 ] 

Hadoop QA commented on ZOOKEEPER-2628:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 20 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/72//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/72//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/72//console

This message is automatically generated.

> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668696#comment-15668696
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Update: disable "Malicious code vulnerability Warnings" appertains to 
org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE, and we will use 
ZOOKEEPER-1362 for this work.

Can we get this merged? Would be good to have findbug clean again for 
pre-commit builds.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668685#comment-15668685
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

GitHub user hanm reopened a pull request:

https://github.com/apache/zookeeper/pull/102

ZOOKEEPER-2628: Fix findbug warnings.

This PR fixed 19 find bug warnings except this one, which might require 
interface change that potentially could break client side apps.

Malicious code vulnerability Warnings
org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE is a mutable collection
Bug type MS_MUTABLE_COLLECTION (click for details) 
In class org.apache.zookeeper.ZooDefs$Ids
Field org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE
At ZooDefs.java:[line 116]

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2628

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #102


commit fbb0957167f42ba64ab3eab15fae4b8dce9b0f4b
Author: Michael Han 
Date:   2016-11-15T23:09:02Z

ZOOKEEPER-2628: Fix findbug warnings.




> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668655#comment-15668655
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm closed the pull request at:

https://github.com/apache/zookeeper/pull/102


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654879#comment-15654879
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87466839
  
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1293,13 +1293,12 @@ public synchronized WatchesSummary 
getWatchesSummary() {
  * @param pwriter the output to write to
  */
 public void dumpEphemerals(PrintWriter pwriter) {
-Set keys = ephemerals.keySet();
 pwriter.println("Sessions with Ephemerals ("
-+ keys.size() + "):");
-for (long k : keys) {
-pwriter.print("0x" + Long.toHexString(k));
++ ephemerals.keySet().size() + "):");
+for (Entry entry : ephemerals.entrySet()) {
+pwriter.print("0x" + Long.toHexString(entry.getKey()));
 pwriter.println(":");
-HashSet tmp = ephemerals.get(k);
+HashSet tmp = entry.getValue();
--- End diff --

Ya @lvfangmin, one of my favourite books on Java, and was the reference to 
my comment above. Thanks pointing out. :smiley:

Agree with @hanm, better to create a separate issue for dealing with this 
legacy technical debt. :+1: 


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651880#comment-15651880
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user lvfangmin commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87265113
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -151,9 +153,13 @@
  */
 public final static int telnetCloseCmd = 0xfff4fffd;
 
-public final static HashMap cmd2String =
+final static HashMap cmd2String =
--- End diff --

Same here, we can also define this as Map to keep consistent with the 
others.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648697#comment-15648697
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Updated PR to address review comments from @eribeiro.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648179#comment-15648179
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87026194
  
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -50,10 +50,8 @@ public static void generateFile(File outputDir, Version 
version, int rev, String
 System.out.println(path + " is not a directory.");
 System.exit(1);
 }
-File file = new File(pkgdir, TYPE_NAME + ".java");
-FileWriter w = null;
-try {
-w = new FileWriter(file);
+
+try (FileWriter w = new FileWriter(new File(pkgdir, TYPE_NAME + 
".java"));) {
--- End diff --

nit: spurious ";"


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648175#comment-15648175
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87028116
  
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1293,13 +1293,12 @@ public synchronized WatchesSummary 
getWatchesSummary() {
  * @param pwriter the output to write to
  */
 public void dumpEphemerals(PrintWriter pwriter) {
-Set keys = ephemerals.keySet();
 pwriter.println("Sessions with Ephemerals ("
-+ keys.size() + "):");
-for (long k : keys) {
-pwriter.print("0x" + Long.toHexString(k));
++ ephemerals.keySet().size() + "):");
+for (Entry entry : ephemerals.entrySet()) {
+pwriter.print("0x" + Long.toHexString(entry.getKey()));
 pwriter.println(":");
-HashSet tmp = ephemerals.get(k);
+HashSet tmp = entry.getValue();
--- End diff --

Could we define `tmp` as `Set` instead of `HashSet`?


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648177#comment-15648177
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87027302
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 ---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set set){
  * Check if all groups have majority
  */
 int majGroupCounter = 0;
-for(long gid : expansion.keySet()) {
-LOG.debug("Group info: " + expansion.get(gid) + ", " + gid + 
", " + groupWeight.get(gid));
-if(expansion.get(gid) > (groupWeight.get(gid) / 2) )
+for (Entry entry : expansion.entrySet()) {
+Long gid = entry.getKey();
+LOG.debug("Group info: " + entry.getValue() + ", " + gid + ", 
" + groupWeight.get(gid));
+if(entry.getValue() > (groupWeight.get(gid) / 2) )
--- End diff --

nit: add space after the `if` and remove space before the last parenthesis.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648178#comment-15648178
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87038798
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -141,109 +141,128 @@ public String genCsharpWriteWrapper(String fname, 
String tag) {
 
 static HashMap vectorStructs = new HashMap();
 public void genCCode(FileWriter h, FileWriter c) throws IOException {
-for (JField f : mFields) {
-if (f.getType() instanceof JVector) {
-JVector jv = (JVector)f.getType();
-JType jvType = jv.getElementType();
-String struct_name = JVector.extractVectorName(jvType);
-if (vectorStructs.get(struct_name) == null) {
-vectorStructs.put(struct_name, struct_name);
-h.write("struct " + struct_name + " {\nint32_t 
count;\n" + jv.getElementType().genCDecl("*data") + "\n};\n");
-h.write("int serialize_" + struct_name + "(struct 
oarchive *out, const char *tag, struct " + struct_name + " *v);\n");
-h.write("int deserialize_" + struct_name + "(struct 
iarchive *in, const char *tag, struct " + struct_name + " *v);\n");
-h.write("int allocate_" + struct_name + "(struct " + 
struct_name + " *v, int32_t len);\n");
-h.write("int deallocate_" + struct_name + "(struct " + 
struct_name + " *v);\n");
-c.write("int allocate_" + struct_name + "(struct " + 
struct_name + " *v, int32_t len) {\n");
-c.write("if (!len) {\n");
-c.write("v->count = 0;\n");
-c.write("v->data = 0;\n");
-c.write("} else {\n");
-c.write("v->count = len;\n");
-c.write("v->data = calloc(sizeof(*v->data), 
len);\n");
-c.write("}\n");
-c.write("return 0;\n");
-c.write("}\n");
-c.write("int deallocate_" + struct_name + "(struct " + 
struct_name + " *v) {\n");
-c.write("if (v->data) {\n");
-c.write("int32_t i;\n");
-c.write("for(i=0;icount; i++) {\n");
-c.write("
deallocate_"+JRecord.extractMethodSuffix(jvType)+"(>data[i]);\n");
-c.write("}\n");
-c.write("free(v->data);\n");
-c.write("v->data = 0;\n");
-c.write("}\n");
-c.write("return 0;\n");
-c.write("}\n");
-c.write("int serialize_" + struct_name + "(struct 
oarchive *out, const char *tag, struct " + struct_name + " *v)\n");
-c.write("{\n");
-c.write("int32_t count = v->count;\n");
-c.write("int rc = 0;\n");
-c.write("int32_t i;\n");
-c.write("rc = out->start_vector(out, tag, 
);\n");
-c.write("for(i=0;icount;i++) {\n");
-genSerialize(c, jvType, "data", "data[i]");
-c.write("}\n");
-c.write("rc = rc ? rc : out->end_vector(out, 
tag);\n");
-c.write("return rc;\n");
-c.write("}\n");
-c.write("int deserialize_" + struct_name + "(struct 
iarchive *in, const char *tag, struct " + struct_name + " *v)\n");
-c.write("{\n");
-c.write("int rc = 0;\n");
-c.write("int32_t i;\n");
-c.write("rc = in->start_vector(in, tag, 
>count);\n");
-c.write("v->data = calloc(v->count, 
sizeof(*v->data));\n");
-c.write("for(i=0;icount;i++) {\n");
-genDeserialize(c, jvType, "value", "data[i]");
-c.write("}\n");
-c.write("rc = in->end_vector(in, tag);\n");
-c.write("return rc;\n");
-c.write("}\n");
-
+try {
+for (JField f : mFields) {
+if (f.getType() instanceof JVector) {
+JVector jv = (JVector) f.getType();
+JType 

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648176#comment-15648176
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87027160
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 ---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set set){
  * Check if all groups have majority
  */
 int majGroupCounter = 0;
-for(long gid : expansion.keySet()) {
-LOG.debug("Group info: " + expansion.get(gid) + ", " + gid + 
", " + groupWeight.get(gid));
-if(expansion.get(gid) > (groupWeight.get(gid) / 2) )
+for (Entry entry : expansion.entrySet()) {
+Long gid = entry.getKey();
+LOG.debug("Group info: " + entry.getValue() + ", " + gid + ", 
" + groupWeight.get(gid));
--- End diff --

We could use modern LOG printing here: 

``
LOG.debug("Group info: {}, {}, {}", entry.getValue(), gid, 
groupWeight.get(gid));
``


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

RE: [jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[Kanniappan, Mohanarangan (Nokia - IN/Bangalore)]

Please unsubscribe me.



-Original Message-
From: ASF GitHub Bot (JIRA) [mailto:j...@apache.org] 
Sent: Tuesday, November 08, 2016 11:27 AM
To: dev@zookeeper.apache.org
Subject: [jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug 
warnings


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646614#comment-15646614
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Updated PR to address review comments from @breed.



> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646614#comment-15646614
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Updated PR to address review comments from @breed.



> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646021#comment-15646021
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user breed commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r86903124
  
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -93,6 +93,14 @@ public static void generateFile(File outputDir, Version 
version, int rev, String
 } catch (IOException e) {
 System.out.println("Unable to generate version.Info file: "
 + e.getMessage());
+if (w != null) {
--- End diff --

wow this is a weird one... we have it in the finally... try with resources 
would make this a bit nicer too...


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645695#comment-15645695
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r86885871
  
--- Diff: src/java/main/org/apache/jute/compiler/CGenerator.java ---
@@ -61,70 +61,88 @@ void genCode() throws IOException {
 + outputDirectory);
 }
 }
-FileWriter c = new FileWriter(new File(outputDirectory, 
mName+".c"));
-FileWriter h = new FileWriter(new File(outputDirectory, 
mName+".h"));
 
-h.write("/**\n");
-h.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-h.write("* or more contributor license agreements.  See the NOTICE 
file\n");
-h.write("* distributed with this work for additional 
information\n");
-h.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-h.write("* to you under the Apache License, Version 2.0 (the\n");
-h.write("* \"License\"); you may not use this file except in 
compliance\n");
-h.write("* with the License.  You may obtain a copy of the License 
at\n");
-h.write("*\n");
-h.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-h.write("*\n");
-h.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-h.write("* distributed under the License is distributed on an \"AS 
IS\" BASIS,\n");
-h.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-h.write("* See the License for the specific language governing 
permissions and\n");
-h.write("* limitations under the License.\n");
-h.write("*/\n");
-h.write("\n");
+FileWriter c = null, h = null;
+try {
+c = new FileWriter(new File(outputDirectory, mName + ".c"));
+h = new FileWriter(new File(outputDirectory, mName + ".h"));
 
-c.write("/**\n");
-c.write("* Licensed to the Apache Software Foundation (ASF) under 
one\n");
-c.write("* or more contributor license agreements.  See the NOTICE 
file\n");
-c.write("* distributed with this work for additional 
information\n");
-c.write("* regarding copyright ownership.  The ASF licenses this 
file\n");
-c.write("* to you under the Apache License, Version 2.0 (the\n");
-c.write("* \"License\"); you may not use this file except in 
compliance\n");
-c.write("* with the License.  You may obtain a copy of the License 
at\n");
-c.write("*\n");
-c.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
-c.write("*\n");
-c.write("* Unless required by applicable law or agreed to in 
writing, software\n");
-c.write("* distributed under the License is distributed on an \"AS 
IS\" BASIS,\n");
-c.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied.\n");
-c.write("* See the License for the specific language governing 
permissions and\n");
-c.write("* limitations under the License.\n");
-c.write("*/\n");
-c.write("\n");
+h.write("/**\n");
+h.write("* Licensed to the Apache Software Foundation (ASF) 
under one\n");
+h.write("* or more contributor license agreements.  See the 
NOTICE file\n");
+h.write("* distributed with this work for additional 
information\n");
+h.write("* regarding copyright ownership.  The ASF licenses 
this file\n");
+h.write("* to you under the Apache License, Version 2.0 
(the\n");
+h.write("* \"License\"); you may not use this file except in 
compliance\n");
+h.write("* with the License.  You may obtain a copy of the 
License at\n");
+h.write("*\n");
+h.write("* http://www.apache.org/licenses/LICENSE-2.0\n;);
+h.write("*\n");
+h.write("* Unless required by applicable law or agreed to in 
writing, software\n");
+h.write("* distributed under the License is distributed on an 
\"AS IS\" BASIS,\n");
+h.write("* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
either express or implied.\n");
+h.write("* See the License for the specific language governing 
permissions and\n");
+h.write("* limitations under the License.\n");
+h.write("*/\n");
+h.write("\n");
 
-h.write("#ifndef 

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645632#comment-15645632
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

GitHub user hanm opened a pull request:

https://github.com/apache/zookeeper/pull/102

ZOOKEEPER-2628: Fix findbug warnings.

This PR fixed 19 find bug warnings except this one, which might require 
interface change that potentially could break client side apps.

Malicious code vulnerability Warnings
org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE is a mutable collection
Bug type MS_MUTABLE_COLLECTION (click for details) 
In class org.apache.zookeeper.ZooDefs$Ids
Field org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE
At ZooDefs.java:[line 116]

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2628

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #102


commit d6e059ef11dea0de725b7bebd14e7bba626bdf53
Author: Michael Han 
Date:   2016-11-07T22:09:10Z

ZOOKEEPER-2628: Fix findbug warnings.




> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)