[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124827#comment-16124827
 ] 

Hudson commented on ZOOKEEPER-2859:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3497 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3497/])
ZOOKEEPER-2859: Fix CMake build on OS X. (hanm: rev 
5bcffe9bc242d825ad97ff4f9d2dea6476983a9a)
* (edit) src/c/CMakeLists.txt


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Fix For: 3.5.4, 3.6.0, 3.4.11
>
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124808#comment-16124808
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/319
  
The precommit job failured was fixed separately, and irrelevant to this 
patch.

LGTM, merged to master: 
https://github.com/apache/zookeeper/commit/5bcffe9bc242d825ad97ff4f9d2dea6476983a9a
3.5: 
https://github.com/apache/zookeeper/commit/1bcf57dc775c5cec00f1f54414cf5a0e5f18e2f4
3.4: 
https://github.com/apache/zookeeper/commit/1f811a6281090e1b24152dc51507aa6a2bdeafe3


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Fix For: 3.5.4, 3.6.0, 3.4.11
>
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124806#comment-16124806
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/319


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109162#comment-16109162
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/319
  
I have cppunit.m4 under this path: 
/usr/local/Cellar/cppunit/1.13.2/share/aclocal. It was brew installed. Also I 
am able to build C client on mac. I can't remember how I did it, but checkout 
this link which might help: 
http://wiki.wsmoak.net/cgi-bin/wiki.pl?action=browse=1=ZooKeeperBuild


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107846#comment-16107846
 ] 

Hadoop QA commented on ZOOKEEPER-2859:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

-1 javadoc.  The javadoc tool appears to have generated 8 warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/913//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/913//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/913//console

This message is automatically generated.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106622#comment-16106622
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/319
  
Also, I'd like to test `Autotools` on OS X, because I believe it has the 
same problem (unconditionally adds `libm` and `librt`), but I can't get past 
`autoconf -if` since I don't have `cppunit.m4`. I'm looking high and low for 
it: it's not in `/usr/local/` nor `/opt`, the brew CppUnit didn't come with it, 
and none of the Autotools directories has it. I found 
[ZOOKEEPER-1454](https://issues.apache.org/jira/browse/ZOOKEEPER-1454), and it 
showed me how to specify where `cppunit.m4` is, but that's not much use if I 
don't have it.

Do you know, does anyone have this building on OS X?


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106550#comment-16106550
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/319
  
Any idea why precommit job generates java doc warnings? Seems not related 
to the patch.


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105688#comment-16105688
 ] 

Hadoop QA commented on ZOOKEEPER-2859:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

-1 javadoc.  The javadoc tool appears to have generated 8 warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/906//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/906//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/906//console

This message is automatically generated.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105681#comment-16105681
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/319
  
@hanm This has a few fixes for the CMake build for OS X.


> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102392#comment-16102392
 ] 

Hadoop QA commented on ZOOKEEPER-2859:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//console

This message is automatically generated.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102387#comment-16102387
 ] 

Hadoop QA commented on ZOOKEEPER-2859:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//console

This message is automatically generated.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102360#comment-16102360
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/319

ZOOKEEPER-2859: Fix CMake build on OS X.

And take care of a TODO for pthread.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper macos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit 050ece633b3a9eec70db139a7e95bc70015cb6ab
Author: Andrew Schwartzmeyer 
Date:   2017-07-26T22:01:40Z

ZOOKEEPER-2859: Fix CMake build on OS X.

And take care of a TODO for pthread.




> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Andrew Schwartzmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102320#comment-16102320
 ] 

Andrew Schwartzmeyer commented on ZOOKEEPER-2859:
-

Fixing the build of just the client is trivial. Change {{if(UNIX)}} to 
{{if(LINUX)}} where we guard {{target_link_libraries(zookeeper PUBLIC m rt)}}.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)