[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560592#comment-16560592
]
Hudson commented on ZOOKEEPER-3061:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #125 (See
[https://builds.apache.org/job/ZooKeeper-trunk/125/])
ZOOKEEPER-3061: add more details to 'Unhandled scenario for peer' (breed: rev
726587ef50339f071960d153cc4599882aa71ac7)
* (edit) src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-3061.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539180#comment-16539180
]
Hadoop QA commented on ZOOKEEPER-3061:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1923//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1923//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1923//console
This message is automatically generated.
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Labels: pull-request-available
> Attachments: ZOOKEEPER-3061.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533985#comment-16533985
]
Hadoop QA commented on ZOOKEEPER-3061:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1895//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1895//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1895//console
This message is automatically generated.
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Labels: pull-request-available
> Attachments: ZOOKEEPER-3061.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528006#comment-16528006
]
Hadoop QA commented on ZOOKEEPER-3061:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1888//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1888//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1888//console
This message is automatically generated.
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Labels: pull-request-available
> Attachments: ZOOKEEPER-3061.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526228#comment-16526228
]
maoling commented on ZOOKEEPER-3061:
If it needed,could you please give this issue a github pull request?The
contributor guide is
[here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute])
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: ZOOKEEPER-3061.patch
>
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525329#comment-16525329
]
Christine Poerschke commented on ZOOKEEPER-3061:
Thanks [~maoling] for the question on my initial patch!
{quote}... and we can use sid to associate them ...
{quote}
Yes, once one knows that the {{"Synchronizing with Follower sid: ..."}} INFO
logging mostly contains the meaning behind the {{"Unhandled scenario"}} WARN
phrase then a repeat of the details is not strictly necessary.
Including the extra details in the warning is aimed at users who have not yet
associated the two log lines, plus I'm suggesting for the warning to also log
the {{txnLogSyncEnabled}} variable which is used in the handling logic but not
logged by the adjacent INFO log line.
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: ZOOKEEPER-3061.patch
>
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523428#comment-16523428
]
maoling commented on ZOOKEEPER-3061:
[~cpoerschke] if log level is INFO,these two logs is adjacent,and we can use
sid to associate them.is it really to necessary to do this?
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: ZOOKEEPER-3061.patch
>
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
