Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread Cameron McCormack

Brian Smith wrote:

* When in blame mode, the revision number of the most change to the
line is shown. I would like a link next to every line's revision
number that links to the *previous* revision where the line changed.
That way, I can navigate the change history much easier.


Yes, I think being able to navigate the revision history like this is 
key to making minor edits like white space only changes etc. less 
disruptive.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread smaug

- Clicking on macros seem to lead to some results, but definitely not the one 
I'd expect -
  the definition of the macro.

- Trying to find files is hard. (Still haven't figured out how to get easily 
from the main page to Navigator.cpp on dom/base)

- cycleCollection on the right side may or may not do something useful.
  In most cases it just ignores all the stuff, so it might be better to not 
have it at all.

- How to mark certain range of code on particular revision?



On 10/02/2013 09:33 PM, Erik Rose wrote:

What features do you most use in MXR and DXR?

Over in the recently renamed Web Engineering group, we're working hard to 
retire MXR. It hasn't been maintained for a long time, and there's a lot of 
duplication between it and DXR, which rests upon a more modern foundation and 
has been developing like crazy. However, there are some holes we need to fill 
before we can expect you to make a Big Switch. An obvious one is indexing more 
trees: comm-central, aurora, etc. And we certainly have some bothersome UI bugs 
to squash. But I'd like to hear from you, the actual users, so it's not just me 
and Taras guessing at priorities.

What keeps you off DXR? (What are the MXR things you use constantly? Or the 
things which are seldom-used but vital?)

If you're already using DXR as part of your workflow, what could it do to make 
your work more fun?

Feel free to reply here, or attach a comment to this blog post, which talks 
about some of the things we've done recently and are considering for the future:

https://blog.mozilla.org/webdev/2013/09/30/dxr-gets-faster-hardware-vcs-integration-and-snazzier-indexing/

We'll use your input to build our priorities for Q4, so wish away!

Cheers,
Erik



___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread Erik Rose
What a lot of great input! Thank you! I'll reply individually to those I've 
missed in the days after the Summit.

In case you happen to be at the Mozilla Summit in Santa Clara, we're holding a 
DXR design session to mash all that juicy input together and make sure we have 
a UI/UX sketch that enables it.

Meet us at 14:30 in the Lounge by the whiteboard. I'm working right now on 
collecting and summarizing all the suggestions from this thread so we can 
shuffle them around more easily; expect a lot of additions to 
https://wiki.mozilla.org/DXR_UI_Refresh#Basic_Searchuse case in the next few 
hours.

Cheers,
Erik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Please specify if a clobber is Windows only in the CLOBBER file

2013-10-05 Thread Reuben Morais
In my experience, most of the recent changes to CLOBBER have been made to fix 
Windows-only build system bugs. It'd be helpful to people working on Linux and 
OS X if you could include in the CLOBBER file whether the clobber is only 
needed on Windows.

(That way you can do |cd $OBJDIR  touch CLOBBER  cd -  ./mach build| to 
ignore it)

Thanks!
-- reuben

smime.p7s
Description: S/MIME cryptographic signature
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread Nicolas B. Pierron

On 10/04/2013 04:14 PM, Nicolas B. Pierron wrote:

On 10/03/2013 02:38 PM, Ehsan Akhgari wrote:

On 2013-10-03 3:24 PM, Nicolas B. Pierron wrote:

DXR gives a nice contextual navigation, but the size of the code base is
overwhelming to have a clear understanding of what is going on.  One of
the thing that I am looking at in general is to understand the
conditionals which are giving a particular result, or the consequences
of a statement. Such overview is hard to get when you have ~30 DXR tabs
opened.  I would love to have a graph overview of these relations, as
well as seeing the conditionals/guards as part of the graph.


Can you please clarify what you mean here?


I mean that if we could keep track of the relation followed while browsing
the code such as caller / callee / references, this could help build a nice
graph overview of how the code is shaped, and help the navigation and
understanding of the code.


After discussing with Eshan, it seems like being able to add/remove lines of 
context to any search would be good step forward.


--
Nicolas B. Pierron
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform