خوبی چه خبر

[rehsid136800rexai]

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

سلام

[rehsid136800rexai]

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

[Gijs Kruitbosch]

On 22/08/2018 21:29, Mark Banner wrote:
I would like to propose that we require dangling commas for multi-line 
object/arrays in Javascript code for mozilla-central.


Strong +1 from me as well.

I would propose that we roll it out on 
a per-directory basis. For example, we could do all of browser/ at the 
start of the 64 cycle just after the merges (alternately the end of the 
63 cycle during soft freeze),


Out of these I'd prefer end-of-soft-freeze to make uplifts easier 
(because fewer conflicts).


Thanks for doing this!

Gijs
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

[Kris Maglione]

On Wed, Aug 22, 2018 at 09:29:26PM +0100, Mark Banner wrote:
I would like to propose that we require dangling commas for multi-line 
object/arrays in Javascript code for mozilla-central.


+1

I've lost count of the number of times I've hit an obscure 
failure because I added a new element to the end of an array or 
object without realizing the last element didn't have a comma. 
Most of the areas I'm responsible for already require this rule, 
and it's saved me a lot of headaches.


--
Kris Maglione

The use of COBOL cripples the mind; its teaching should therefore be
regarded as a criminal offense.
--Edsger W. Dijkstra

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

[Mark Banner]

I would like to propose that we require dangling commas for multi-line 
object/arrays in Javascript code for mozilla-central.


Why:

 * Multiple components in toolkit/ and browser/ already have
   comma-dangle enabled
   
.
 * Having asked around in a few locations, I'm seeing support from the
   Firefox developer team and others in favour of enabling it.
 * It helps make blame cleaner.
 * It makes editing easier, and helps for a consistent style.
 * Having automation available to cover the requirement reduces the
   need for review nits.

I realise not everyone necessarily loves the style, but having the 
cleaner blame, and consistent style requirements seems to outweigh the 
downsides.


How:

 * We would enable this via an ESLint rule, comma-dangle
   , with the
   "always-multiline" option set.
 * ESLint is able to automatically fix code that doesn't conform (e.g.
   bug 1476228 
   was entirely automatically generated very quickly)

Since there are a large amount of instances (approx 12k) that would need 
to be fixed across the code base, I would propose that we roll it out on 
a per-directory basis. For example, we could do all of browser/ at the 
start of the 64 cycle just after the merges (alternately the end of the 
63 cycle during soft freeze), then do toolkit/ at the next merge time, 
and then pick up the rest at the end. This will limit the scope of 
possible bitrotting to smaller chunks, as well as making the patch sizes 
more manageable.


This will only cover directories that ESLint currently covers - though 
as we roll out ESLint to new directories, they'll be covered automatically.


Feedback & thoughts welcome.

Standard8

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: PSA: mercurial-setup becomes vcs-setup and adds support for git

[Panos Astithas]

The --git flag to |mach vcs-setup| was short-lived after all. I've landed
bug 1484243 in autoland (thanks ahal!), so it will now figure out what VCS
is being used and do the right thing. When it merges to m-c you can forget
it was ever there.

Cheers,
Panos



On Fri, Aug 17, 2018 at 7:54 AM Andrew Halberstadt  wrote:

> This is awesome, thanks for working on it! I filed a follow-up to
> detect the vcs automatically (bug 1484243).
>
> In the meantime, if you are a git user you can create an alias in
> ~/.mozbuild/machrc:
> [alias]
> vcs-setup = vcs-setup --git
>
> On Fri, Aug 17, 2018 at 3:51 AM Panos Astithas  wrote:
>
>> Hi all,
>>
>> since bug 1257478 landed in m-c earlier today, you should now be using
>> 'mach vcs-setup' instead of 'mach mercurial-setup'. Nothing else changes in
>> your workflow (e.g. 'mach mercurial-setup -u' becomes 'mach vcs-setup -u')
>> and the spell checker will suggest vcs-setup if you try to use
>> mercurial-setup.
>>
>> If you are a git-cinnabar user, your workflow is now supported. 'mach
>> vcs-setup --git' will fetch the latest recommended version of git-cinnabar
>> and configure it for you. The --update-only flag is also available for git,
>> so it would be a good idea to run 'mach vcs-setup --git --update-only' (or
>> 'mach vcs-setup -gu') every now and then to make sure everything is up to
>> date.
>>
>> 'mach bootstrap' will also offer to update and configure your
>> git-cinnabar environment if a git checkout is detected.
>>
>> Cheers,
>> Panos
>>
>> ___
>> firefox-dev mailing list
>> firefox-...@mozilla.org
>> https://mail.mozilla.org/listinfo/firefox-dev
>>
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Introducing CI-Admin

[Dustin Mitchell]

We have been working on a new approach to configuring the Firefox-CI
installation of Taskcluster to suit Firefox's needs.  If you've ever needed
a scope assigned to a repository, wondered why your project branch wasn't
getting builds, or couldn't figure out what instance type a worker uses,
this is the tool for you.

I'd like to encourage broad familiarity with this system so that it can
become a shared resource.

I've written up an intro at
http://code.v.igoro.us/posts/2018/06/ci-admin.html  I'll also be holding
two "open house" sessions next week, in the TaskclusterPlatform vidyo
room.  I've sent out some invitations, but if you didn't get one, here are
the details:

  Aug 28, 21:00UTC (14:00 PDT)
  Aug 29, 13:00UTC (15:00 CEST)

(and feel free to ping me to be added to the event).

See you there!

Dustin
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform