Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds
thanks everyone for your comments on this. It sounds like from a practical standpoint until we can get the runtimes of PGO builds on try and in integration to be less than debug build times this is not a desirable change. A few common responses: * artifact opt builds on try are fast for quick iterations, a must have * can we do artifact builds for PGO? (thanks :nalexander for bug 1517533 and bug 1517532) * what about talos? we need to investigate this more, I have always argued against pgo only for talos, but maybe we can revisit that (bug 1514829) * do we turn off builds as well? I had proposed just the tests, if we decide to turn off talos it would make sense to turn off builds. Thanks all for the quick feedback, when the bugs in this thread are further along, or if I see another simpler solution for reducing the duplication, I will follow up. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds
On Fri, Jan 4, 2019 at 11:57 AM Nicholas Alexander wrote: > One reason we might not want to stop producing opt builds: we produce > artifact builds against opt (and debug, with --enable-debug in the local > mozconfig). It'll be very odd to have --enable-artifact-build and > _require_ --enable-pgo or whatever it is in the local mozconfig. This seems reasonable. (I'm in agreement with the people upthread that think we should have opt testing, but regardless of that particular outcome, not requiring people to put goo in their mozconfigs seems like a noble goal.) > I expect that these opt build platforms will be relatively inexpensive to > preserve, because step one (IIUC) of pgo is to build the same source files > as the opt builds. So with luck we get sccache hits between the jobs. > Perhaps somebody with more knowledge of pgo and sccache can confirm or > refute that assertion? PGO uses different compilation flags than a normal opt build in both the profiling and the profile use phases (for instrumentation, etc.), so I'd assume that opt builds and PGO builds would not share compiled objects. -Nathan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds
On Thu, Jan 3, 2019 at 1:47 PM Chris AtLee wrote: > Thank you Joel for writing up this proposal! > > Are you also proposing that we stop the linux64-opt and win64-opt builds as > well, except for leaving them as an available option on try? If we're not > testing them on integration or release branches, there doesn't seem to be > much purpose in doing the builds. > One reason we might not want to stop producing opt builds: we produce artifact builds against opt (and debug, with --enable-debug in the local mozconfig). It'll be very odd to have --enable-artifact-build and _require_ --enable-pgo or whatever it is in the local mozconfig. I expect that these opt build platforms will be relatively inexpensive to preserve, because step one (IIUC) of pgo is to build the same source files as the opt builds. So with luck we get sccache hits between the jobs. Perhaps somebody with more knowledge of pgo and sccache can confirm or refute that assertion? Nick ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Rust code coverage
On Fri, Jan 4, 2019 at 4:54 AM Marco Castelluccio wrote: > Hi everyone, > we have recently enabled collecting code coverage for Rust code too, > running Rust tests in coverage builds. It'll be great to finally see code coverage for the style system - thanks for doing this! > The support is still > experimental, file bugs in the "Testing::Code Coverage" component if you > see something fishy. > > The Rust reports are merged together with the C/C++/Java/JavaScript > reports, and as usual you can find them at one of these links (we are > working on a replacement for them, as they fail to scale to the size of > our repository, often timing out on load): > Yeah - I've been trying intermittently for the last ten minutes and haven't been able to load https://codecov.io/gh/mozilla/gecko-dev/tree/master/servo/components/style successfully. > https://codecov.io/gh/mozilla/gecko-dev > https://codecov.io/gh/marco-c/gecko-dev > https://coveralls.io/github/marco-c/gecko-dev > > - Marco. > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Rust code coverage
Hi everyone, we have recently enabled collecting code coverage for Rust code too, running Rust tests in coverage builds. The support is still experimental, file bugs in the "Testing::Code Coverage" component if you see something fishy. The Rust reports are merged together with the C/C++/Java/JavaScript reports, and as usual you can find them at one of these links (we are working on a replacement for them, as they fail to scale to the size of our repository, often timing out on load): https://codecov.io/gh/mozilla/gecko-dev https://codecov.io/gh/marco-c/gecko-dev https://coveralls.io/github/marco-c/gecko-dev - Marco. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds
Nicholas Alexander wrote on 03.01.19 18:41: > 1) automation builds need a special configuration piece in place to > properly support artifact builds. Almost certainly that's not in place for > PGO builds, since it's such an unusual thing to do: "you want to pack PGO > binaries into a development build... why?" But there's really no reason we > can't do that in automation so I've filed > https://bugzilla.mozilla.org/show_bug.cgi?id=15175323 for these things. This is actually: https://bugzilla.mozilla.org/show_bug.cgi?id=1517533 Thanks for filing those bugs. -- Henrik Skupin Senior Software Engineer Mozilla Corporation ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
