Re: Changing reftest required resolution
On Wednesday, August 29, 2012 11:35:52 AM UTC-4, Andrew Halberstadt wrote: On 08/29/2012 09:56 AM, Andrew Halberstadt wrote: On 08/28/2012 02:17 PM, L. David Baron wrote: On Tuesday 2012-08-28 12:52 -0400, Andrew Halberstadt wrote: I also don't think we should go quite as small as 400x400 -- and we want to come up with a common value with other browser vendors that are also using reftest. We don't want to be running our reftests at a size smaller than the accepted max size for reftests at W3C. Joel mentioned he was thinking of 600x400. I don't know that there's a magic size where things all of a sudden improve significantly. I'll ask around about panda/apc.io default resolutions. I'm told they do 1280x720, so we'd at least need to bump the height down. That is 720 height and reftest uses a subset of that (I believe 672) to account for the android task bar and the urlbar. 600 height as a maximum will work, likewise 480x640 or something like that. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Changing reftest required resolution
== The Problem == Reftests currently assume a window size of 800x1000. This is not possible on mobile devices, and using this resolution on tegras and pandas consumes too much memory and results in many timeouts and random-failures. Changing the resolution to something like 400x400 is very stable and only results in a handful of failures. The problem is it's difficult to figure out how many tests are false positives as a result of lost coverage. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=737961 == Possible Solutions == * Somehow figure out the exact pixel width/height required by each test and re-write the ones that are over the new target resolution * Scroll the contentView and use multiple drawWindow calls to stitch the canvases together piece by piece * Disable the DRAW_WIDGET_LAYERS flag so content is rendered off screen (I'm under the impression this is not a valid solution) * ? Things to keep in mind: * Needed for fennec and b2g (must work oop) * Some of the tests are shared (apparently?) outside of mozilla == Feedback == I'm looking for feedback on the best way to move forward. Also, does anyone have any opinions on what the new target resolution should be? Andrew ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Changing reftest required resolution
If the exact width/height could be found for each test then these could be marked in a manifest (theoretically, not speaking to the existing reftest manifest format per se). Then reftest could be modified to take a (e.g.) --resoltuion 400x400 argument and the test runner passing over any test that exceeds either dimension. Just a thought. Not sure how feasible this is. On 08/28/2012 09:52 AM, Andrew Halberstadt wrote: == The Problem == Reftests currently assume a window size of 800x1000. This is not possible on mobile devices, and using this resolution on tegras and pandas consumes too much memory and results in many timeouts and random-failures. Changing the resolution to something like 400x400 is very stable and only results in a handful of failures. The problem is it's difficult to figure out how many tests are false positives as a result of lost coverage. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=737961 == Possible Solutions == * Somehow figure out the exact pixel width/height required by each test and re-write the ones that are over the new target resolution * Scroll the contentView and use multiple drawWindow calls to stitch the canvases together piece by piece * Disable the DRAW_WIDGET_LAYERS flag so content is rendered off screen (I'm under the impression this is not a valid solution) * ? Things to keep in mind: * Needed for fennec and b2g (must work oop) * Some of the tests are shared (apparently?) outside of mozilla == Feedback == I'm looking for feedback on the best way to move forward. Also, does anyone have any opinions on what the new target resolution should be? Andrew ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Changing reftest required resolution
I've already done this work but we decided to just increase the resolution for our tegra board: See https://bugzilla.mozilla.org/show_bug.cgi?id=66 which includes an outdated patch that adds a screen(w,h) annotation to each test and a patch to compute the required size per test. On Tue, Aug 28, 2012 at 1:35 PM, Jeff Hammel jham...@mozilla.com wrote: If the exact width/height could be found for each test then these could be marked in a manifest (theoretically, not speaking to the existing reftest manifest format per se). Then reftest could be modified to take a (e.g.) --resoltuion 400x400 argument and the test runner passing over any test that exceeds either dimension. Just a thought. Not sure how feasible this is. On 08/28/2012 09:52 AM, Andrew Halberstadt wrote: == The Problem == Reftests currently assume a window size of 800x1000. This is not possible on mobile devices, and using this resolution on tegras and pandas consumes too much memory and results in many timeouts and random-failures. Changing the resolution to something like 400x400 is very stable and only results in a handful of failures. The problem is it's difficult to figure out how many tests are false positives as a result of lost coverage. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=737961 == Possible Solutions == * Somehow figure out the exact pixel width/height required by each test and re-write the ones that are over the new target resolution * Scroll the contentView and use multiple drawWindow calls to stitch the canvases together piece by piece * Disable the DRAW_WIDGET_LAYERS flag so content is rendered off screen (I'm under the impression this is not a valid solution) * ? Things to keep in mind: * Needed for fennec and b2g (must work oop) * Some of the tests are shared (apparently?) outside of mozilla == Feedback == I'm looking for feedback on the best way to move forward. Also, does anyone have any opinions on what the new target resolution should be? Andrew ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Changing reftest required resolution
On Wed, Aug 29, 2012 at 6:17 AM, L. David Baron dba...@dbaron.org wrote: We don't want to be running our reftests at a size smaller than the accepted max size for reftests at W3C. What is the current required size for W3C reftests? I can't find any documentation of that. Rob -- “You have heard that it was said, ‘Love your neighbor and hate your enemy.’ But I tell you, love your enemies and pray for those who persecute you, that you may be children of your Father in heaven. ... If you love those who love you, what reward will you get? Are not even the tax collectors doing that? And if you greet only your own people, what are you doing more than others? [Matthew 5:43-47] ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
