Re: Intent to remove: support for old drag events

2015-06-10 Thread Chris Peterson

On 6/9/15 10:21 PM, Karl Dubost wrote:

Jonas,

Le 10 juin 2015 à 13:44, Jonas Sicking jo...@sicking.cc a écrit :

But do we have any data that this won't break websites?


nope. But at first sight, it doesn't seem used at all.
https://github.com/search?q=draggesturetype=Issuesutf8=%E2%9C%93

And most of the JS code is also quite unrelated or from books
https://github.com/search?l=javascriptq=draggesturetype=Codeutf8=%E2%9C%93


It looks like some addons will be affected:

https://mxr.mozilla.org/addons/search?string=draggesture%22tree=addonscase=1

https://mxr.mozilla.org/addons/search?string=dragdrop%22tree=addonscase=1


___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to remove: support for old drag events

2015-06-09 Thread smaug

On 06/09/2015 05:17 PM, Neil Deakin wrote:

In bug 1162050, we'd like to remove support for the old non-standard drag 
events, which were left in for a period of compatibility.


yes please. Anything we can do to simplify dnd code is good.



-Olli


The 'draggesture' event should be replaced with the 'dragstart' event (such as 
ondragstart)
The 'dragdrop' event should be replaced with the 'drop' event.

If you use these events, they are fired in the same manner as the standard 
events, so it should be a simple matter of searching and replacing the
event names.

The non-standard dragexit event will remain as is, as it has no exact standard 
equivalent.

Firefox does not use these events in its code. I filed bug 1171979 for fixing 
this in Thunderbird and bug 1171980 for fixing this in Seamonkey.
If you use these events anywhere or you are the author of an add-on that uses 
these events, you will need to update your code as described above.

The standard drag and drop API is described at:

https://html.spec.whatwg.org/multipage/interaction.html#dnd
https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Drag_and_drop

In addition, we would like to remove the long-deprecated nsDragAndDrop.js 
script located in toolkit/content in favour of the standard drag and drop
API, described at the links above. To ease the transition, if necessary, you 
may wish to include this script (
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/nsDragAndDrop.js 
) directly in your project.

Please respond if there are any concerns.



___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Intent to remove: support for old drag events

2015-06-09 Thread Neil Deakin
In bug 1162050, we'd like to remove support for the old non-standard 
drag events, which were left in for a period of compatibility.


The 'draggesture' event should be replaced with the 'dragstart' event 
(such as ondragstart)

The 'dragdrop' event should be replaced with the 'drop' event.

If you use these events, they are fired in the same manner as the 
standard events, so it should be a simple matter of searching and 
replacing the event names.


The non-standard dragexit event will remain as is, as it has no exact 
standard equivalent.


Firefox does not use these events in its code. I filed bug 1171979 for 
fixing this in Thunderbird and bug 1171980 for fixing this in Seamonkey.
If you use these events anywhere or you are the author of an add-on that 
uses these events, you will need to update your code as described above.


The standard drag and drop API is described at:

https://html.spec.whatwg.org/multipage/interaction.html#dnd
https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Drag_and_drop

In addition, we would like to remove the long-deprecated 
nsDragAndDrop.js script located in toolkit/content in favour of the 
standard drag and drop API, described at the links above. To ease the 
transition, if necessary, you may wish to include this script ( 
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/nsDragAndDrop.js 
) directly in your project.


Please respond if there are any concerns.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to remove: support for old drag events

2015-06-09 Thread Karl Dubost
Jonas,

Le 10 juin 2015 à 13:44, Jonas Sicking jo...@sicking.cc a écrit :
 But do we have any data that this won't break websites?

nope. But at first sight, it doesn't seem used at all.
https://github.com/search?q=draggesturetype=Issuesutf8=%E2%9C%93

And most of the JS code is also quite unrelated or from books
https://github.com/search?l=javascriptq=draggesturetype=Codeutf8=%E2%9C%93


-- 
Karl Dubost, Mozilla
http://www.la-grange.net/karl/moz

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to remove: support for old drag events

2015-06-09 Thread Ehsan Akhgari

On 2015-06-09 10:17 AM, Neil Deakin wrote:

In bug 1162050, we'd like to remove support for the old non-standard
drag events, which were left in for a period of compatibility.


This is great!

As far as I know, these events have never been supported by another 
browser engine.  Is that correct?  If so, hopefully not a lot of 
websites would be affected by this these days.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to remove: support for old drag events

2015-06-09 Thread Jonas Sicking
On Wed, Jun 10, 2015 at 12:35 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote:
 On 2015-06-09 10:17 AM, Neil Deakin wrote:

 In bug 1162050, we'd like to remove support for the old non-standard
 drag events, which were left in for a period of compatibility.

 This is great!

I agree it's great if we can remove this. But do we have any data that
this won't break websites? We do know that websites quite often use
browser-specific features, including Gecko specific ones.

/ Jonas
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform