Re: Killing the Moz Audio Data API
On 10/17/2013 12:09 AM, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ I thought some games/emscripten still relied on the Moz Audio API. -Olli ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
The other day, while testing some B2G v1.2 stuff, I noticed the Moz Audio Data deprecation warning flying in adb logcat. So you probably need to check with B2G/Gaia people about the timing to kill this API. Benoit 2013/10/16 Ehsan Akhgari ehsan.akhg...@gmail.com I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
Looks like the comms app has some residual use of the old audio API: apps/communications/dialer/js/keypad.js:this._audio.mozSetup(1, this._sampleRate); apps/system/emergency-call/js/keypad.js: this._audio.mozSetup(2, this._sampleRate); Should be easy to replace. I will file a bug and make sure we do this for 1.3. Andreas On Oct 17, 2013, at 3:02 AM, Benoit Jacob jacob.benoi...@gmail.com wrote: The other day, while testing some B2G v1.2 stuff, I noticed the Moz Audio Data deprecation warning flying in adb logcat. So you probably need to check with B2G/Gaia people about the timing to kill this API. Benoit 2013/10/16 Ehsan Akhgari ehsan.akhg...@gmail.com I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
On 10/17/2013 2:28 AM, smaug wrote: On 10/17/2013 12:09 AM, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ I thought some games/emscripten still relied on the Moz Audio API. Can the moz audio API be implemented in terms of the web audio api as a JS shim? --BDS ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
On 2013-10-17 9:29 AM, Andreas Gal wrote: Looks like the comms app has some residual use of the old audio API: apps/communications/dialer/js/keypad.js:this._audio.mozSetup(1, this._sampleRate); apps/system/emergency-call/js/keypad.js: this._audio.mozSetup(2, this._sampleRate); Should be easy to replace. I will file a bug and make sure we do this for 1.3. I think Etienne is working on rewriting that code to use Web Audio already. Cheers, Ehsan On Oct 17, 2013, at 3:02 AM, Benoit Jacob jacob.benoi...@gmail.com wrote: The other day, while testing some B2G v1.2 stuff, I noticed the Moz Audio Data deprecation warning flying in adb logcat. So you probably need to check with B2G/Gaia people about the timing to kill this API. Benoit 2013/10/16 Ehsan Akhgari ehsan.akhg...@gmail.com I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
On 2013-10-16 6:56 PM, Matthew Gregan wrote: At 2013-10-16T17:09:50-0400, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Nice timing, I filed bug 927245 about this yesterday. I've got a patch that builds, but a few things still need to be addressed (mentioned in the initial comment). Great minds think alike! ;-) I commented on the bug. Thanks! Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
On 2013-10-17 10:06 AM, Benjamin Smedberg wrote: On 10/17/2013 2:28 AM, smaug wrote: On 10/17/2013 12:09 AM, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ I thought some games/emscripten still relied on the Moz Audio API. Can the moz audio API be implemented in terms of the web audio api as a JS shim? It can be approximated, but the exact semantics cannot be replicated. However that may be fine for small games using this API since they're probably not that performance intensive. Cheers, Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
Yes, I pinged him an hour ago, and he plans to replace all uses of Audio Data API by Web Audio. I think he posted in the bug. Paul. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Killing the Moz Audio Data API
I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Thanks! -- Ehsan http://ehsanakhgari.org/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
On Wed, Oct 16, 2013 at 10:09 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? For obscure DOM methods we do the warnings, then give it a try in nightlies and see if anyone screams. So yeah, you want to do that I think. -- http://annevankesteren.nl/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
On 2013-10-16 2:26 PM, Anne van Kesteren wrote: For obscure DOM methods we do the warnings, then give it a try in nightlies and see if anyone screams. So yeah, you want to do that I think. Sounds good to me. -r ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Killing the Moz Audio Data API
At 2013-10-16T17:09:50-0400, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch, and evangelize on the broken websites enough times so that we're able to remove the feature in a stable build? Nice timing, I filed bug 927245 about this yesterday. I've got a patch that builds, but a few things still need to be addressed (mentioned in the initial comment). -mjg ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
