Re: [ANNOUNCE] NSS 3.53 release

2020-06-10 Thread Martin Thomson
Is there an automated check we can run that will help us remember to
do this properly in future?  I really don't like having to remember
this sort of thing.

On Thu, Jun 11, 2020 at 3:52 AM Robert Relyea  wrote:
>
> On 6/1/20 5:18 PM, JC Jones wrote:
> > The NSS team released Network Security Services (NSS) 3.53 on 29 May 2020. 
> > NSS 3.53 will be a long-term support release, supporting Firefox 78 ESR.
>
>
> Looks like we updated certdata.txt without updating the version number
> in nssckbi.h. This caused some problems because I pulled the 3.52
> certdata.txt, but with 3.53 coming out I verified that version number
> didn't change and didn't pick up the 3.53 change.
>
> We need to make sure we bump the version number when we make changes.
> Just a reminder for the future...
>
> Fortunately our QA tests found this, and I had already pushed our
> version number because I removed a bunch of expired certs (that weren't
> explicitly marked as untrusted). I'll create a bug to remove those from
> the upstream certdata.txt and that will put the versions in sync again.
>
>
> bob
>
>
> --
> dev-tech-crypto mailing list
> dev-tech-crypto@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-tech-crypto
-- 
dev-tech-crypto mailing list
dev-tech-crypto@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-crypto


Re: [ANNOUNCE] NSS 3.53 release

2020-06-10 Thread Robert Relyea

On 6/1/20 5:18 PM, JC Jones wrote:

The NSS team released Network Security Services (NSS) 3.53 on 29 May 2020. NSS 
3.53 will be a long-term support release, supporting Firefox 78 ESR.



Looks like we updated certdata.txt without updating the version number 
in nssckbi.h. This caused some problems because I pulled the 3.52 
certdata.txt, but with 3.53 coming out I verified that version number 
didn't change and didn't pick up the 3.53 change.


We need to make sure we bump the version number when we make changes. 
Just a reminder for the future...


Fortunately our QA tests found this, and I had already pushed our 
version number because I removed a bunch of expired certs (that weren't 
explicitly marked as untrusted). I'll create a bug to remove those from 
the upstream certdata.txt and that will put the versions in sync again.



bob


--
dev-tech-crypto mailing list
dev-tech-crypto@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-crypto