date:20200913

Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

2020-09-13 Thread Wang, Jian J

Hi Bret,

Sorry to hear the Seattle's situation. I've been there for several times and 
love the city very much. Hope everything goes back normal soon.

And sorry for slow response. This patch series have been delegated to Dandan to 
review by Liming. She has completed security review from Intel perspective, and 
given back comments to you. It seems that you forgot to include her in the 
CC-list. Sorry I didn't notice it and told her to do review in time. She'll 
give comments ASAP.

Since MdeModulePkg is a huge package, I cannot do detail review for each patch 
for this package. And we have already modules reviewers designated . I think, 
usually, they should do the detailed review first. The package maintainer will 
do gate-keeper works as the last step. Correct me if any misunderstanding here.

Removed Chao from cc-list (his email is not valid) and added Dandan in loop.

Regards,
Jian

From: Bret Barkelew 
Sent: Friday, September 11, 2020 11:18 PM
To: devel@edk2.groups.io; b...@corthon.com; Wang, Jian J 
Cc: Yao, Jiewen ; Zhang, Chao B ; 
Wang, Jian J ; Wu, Hao A ; Gao, 
Liming ; Justen, Jordan L ; 
Laszlo Ersek ; Ard Biesheuvel ; 
Andrew Fish ; Ni, Ray 
Subject: RE: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

11 Days to go. I will single out an email every day...

Jian, today is your day.
How's it going? Life good? Yeah, I know. Things are crazy here, too. Seattle is 
covered in smoke.
You know what would brighten things up, though? A nice "reviewed by".

- Bret

From: Bret Barkelew via groups.io
Sent: Tuesday, September 8, 2020 3:20 PM
To: devel@edk2.groups.io; 
b...@corthon.com
Cc: Yao, Jiewen; Zhang, Chao 
B; Wang, Jian J; 
Wu, Hao A; liming.gao; 
Justen, Jordan L; Laszlo 
Ersek; Ard Biesheuvel; 
Andrew Fish; Ni, Ray; 
liming.gao
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy 
feature

Now that 2008 is labelled and everyone can take a breather... I still need 
reviews on the following patches (v7)...
Patch(es) 01, 02, 03,06,09,10,11,12,13,14

As such, the following email addresses may or may not be subscribed to 
CatFacts(tm) within the next 14 days if I get no responses:
Cc: Jian J Wang mailto:jian.j.w...@intel.com>>
Cc: Hao A Wu mailto:hao.a...@intel.com>>
Cc: Liming Gao mailto:liming@intel.com>>
Cc: Jordan Justen mailto:jordan.l.jus...@intel.com>>
Cc: Andrew Fish mailto:af...@apple.com>>
Cc: Ray Ni mailto:ray...@intel.com>>
Cc: Jiewen Yao mailto:jiewen@intel.com>>
Cc: Chao Zhang mailto:chao.b.zh...@intel.com>>

May God have mercy on your inboxes.

- Bret




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65215): https://edk2.groups.io/g/devel/message/65215
Mute This Topic: https://groups.io/mt/75057702/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version

2020-09-13 Thread Matthew Carlson

That’s correct. Sent from Mail for Windows 10 From: gaolimingSent: Sunday, September 13, 2020 8:15 PMTo: devel@edk2.groups.io; matthewfcarl...@gmail.comCc: Bob Feng; Yuwei Chen; Sean BroganSubject: 回复: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version Matthew:  In future, when update new iasl version again, only this line "version":"20200717.0.0" will be updated, right? ThanksLiming> -邮件原件-> 发件人: bounce+27952+65199+4905953+8761...@groups.io>  代表 Matthew> Carlson> 发送时间: 2020年9月12日 4:45> 收件人: devel@edk2.groups.io> 抄送: Bob Feng ; Liming Gao> ; Yuwei Chen ; Sean> Brogan ; Matthew Carlson> > 主题: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more> modern version> > From: Matthew Carlson > > The IASL extdep is used for CI only and a recent fork of the ACPICA> repo was made to make nuget builds more regular and easier to audit.> https://dev.azure.com/projectmu/_git/acpica> > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Sean Brogan > Cc: devel@edk2.groups.io> > Signed-off-by: Matthew Carlson > --->  BaseTools/Bin/iasl_ext_dep.yaml | 6 +++--->  1 file changed, 3 insertions(+), 3 deletions(-)> > diff --git a/BaseTools/Bin/iasl_ext_dep.yaml> b/BaseTools/Bin/iasl_ext_dep.yaml> index 1d81e89cf3a6..ea2bc315d184 100644> --- a/BaseTools/Bin/iasl_ext_dep.yaml> +++ b/BaseTools/Bin/iasl_ext_dep.yaml> @@ -14,8 +14,8 @@>    "id": "iasl-ci-1",> >    "scope": "cibuild",> >    "type": "nuget",> > -  "name": "iasl",> > -  "source": "https://api.nuget.org/v3/index.json",> > -  "version": "20190215.0.0",> > +  "name": "edk2-acpica-iasl",> > +  "source":> "https://pkgs.dev.azure.com/projectmu/acpica/_packaging/mu_iasl/nuget/v> 3/index.json",> > +  "version": "20200717.0.0",> >    "flags": ["set_path", "host_specific"]> >  }> > --> 2.28.0.windows.1> > > -=-=-=-=-=-=> Groups.io Links: You receive all messages sent to this group.> > View/Reply Online (#65199): https://edk2.groups.io/g/devel/message/65199> Mute This Topic: https://groups.io/mt/76788780/4905953> Group Owner: devel+ow...@edk2.groups.io> Unsubscribe: https://edk2.groups.io/g/devel/unsub> [gaolim...@byosoft.com.cn]> -=-=-=-=-=-=

_._,_._,_

Groups.io Links:


You receive all messages sent to this group.





View/Reply Online (#65214) |





|



Mute This Topic


| New Topic





Your Subscription |
Contact Group Owner |

Unsubscribe

 [arch...@mail-archive.com]
_._,_._,_

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-13 Thread Vladimir Olovyannikov via groups.io

Hi Zhichao,
Thank you for reviewing.

> -Original Message-
> From: Gao, Zhichao 
> Sent: Sunday, September 13, 2020 5:52 PM
> To: Vladimir Olovyannikov ; Laszlo
> Ersek ; devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan ; Ni, Ray
> ; Gao, Liming ; Nd
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>
> Subject: RE: [PATCH v11 0/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
>
> Hi Vladimir/Laszlo,
>
> Sorry for the late response. Recently, I am busy with other works for
> recent
> weeks. So I cannot spend much time on EDK2 open source. Apologize for the
> inconvenient.
>
> I didn’t give the comments on the time function because I found it is
> copied
> from EmbeddedPkg's TimeBaseLib. And I assumes it works fine without any
> issue as it has been in the trunk for a long time. But actually it cannot
> pass the
> MS VS X64 build. The lib was not added in the package dsc file so the
> build
> error was not found before. I hope we can directly use the TimeBaseLib
> instead of just use its header file and keep the duplicated code. This can
> be a
> future fix/optimization.
Yes, this initially was the intention, but x64 build of
ShellPkg/HttpDynamicCommand failed, so
I switched to the hybrid: Use constants from TimeBaseLib, and duplicate the
function in the HttpDynamicCommand itself.
>
> Other code doesn't change the logic since V9. So I have no comments on the
> implementation except the new time function. With the time function issue
> fixed, I am glad to give the R-B and help to merge the patch.
Can you please let me know what the issue is? The return now corresponds to
TimeBaseLib return values.
TimeBaseLib library itself needs to be fixed to return proper type of
EfiTimeToEpoch.
Am I missing anything?

Thank you,
Vladimir
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: Vladimir Olovyannikov 
> > Sent: Saturday, September 12, 2020 1:04 AM
> > To: Laszlo Ersek ; devel@edk2.groups.io
> > Cc: Gao, Zhichao ; Maciej Rabeda
> > ; Wu, Jiaxin ; Fu,
> > Siyuan ; Ni, Ray ; Gao, Liming
> > ; Nd ; Samer El-Haj-Mahmoud
> > 
> > Subject: RE: [PATCH v11 0/1] ShellPkg/DynamicCommand: add
> > HttpDynamicCommand
> >
> > > -Original Message-
> > > From: Laszlo Ersek 
> > > Sent: Friday, September 11, 2020 12:20 AM
> > > To: Vladimir Olovyannikov ;
> > > devel@edk2.groups.io
> > > Cc: Zhichao Gao ; Maciej Rabeda
> > > ; Jiaxin Wu ;
> > > Siyuan Fu ; Ray Ni ; Liming
> > > Gao ; Nd ; Samer El-Haj-
> Mahmoud
> > > 
> > > Subject: Re: [PATCH v11 0/1] ShellPkg/DynamicCommand: add
> > > HttpDynamicCommand
> > >
> > > On 09/10/20 22:33, Vladimir Olovyannikov wrote:
> > > > Hi Laszlo,
> > > >
> > > >> -Original Message-
> > > >> From: Laszlo Ersek 
> > > >> Sent: Wednesday, September 9, 2020 11:33 PM
> > >
> > > >>> PATCH v11 changes:
> > > >>> Address comments from Laszlo:
> > > >>>   - use TimeBaseLib.h header to get rid of duplicated constants;
> > > >>>   - explicitly return UINT32 in EfiTimeToEpoch().
> > > >>
> > > >> to be clear, I explicitly *disagree* with returning UINT32 from
> > > >> EfiTimeToEpoch().
> > > >>
> > > >> I'm not "demanding" (or even suggesting) that you update the
> > > >> EfiTimeToEpoch() implementation in this patch to return UINTN,
> > > >> but I'd like to be very clear that, IMO, for EfiTimeToEpoch() to
> > > >> suffer from a year 2106 problem on 64-bit systems too, is bad
> > > >> design. So please don't list the UINT32 return type as my
> > > >> suggestion -- that's the exact opposite of what I'd actually
> > > >> suggest.
> > >
> > > > Sorry, I must have misunderstood. Do you want me to resubmit the
> > > > patch? I am open to ideas.
> > >
> > > Ideally:
> > >
> > > - change the return type of EfiTimeToEpoch() to UNITN
> > >
> > > - drop the final UINT32 cast from EfiTimeToEpoch()
> > >
> > > - change the type of ElapsedSeconds to UINTN
> > >
> > > - change the expression
> > >
> > > ElapsedSeconds > 1 ? ElapsedSeconds : 1
> > >
> > >   to
> > >
> > > ElapsedSeconds > 1 ? (UINT64)ElapsedSeconds : 1
> > >
> > > - print the expression mentioned above with the format specifier %Lu
> > I see. Basically, it is PATCH v10. I just wanted to reuse
> > TimeBaseLib.h constants in PATCH v11.
> >
> > >
> > > *BUT*. These are really just small details. It would be OK to fix
> > > these up later, incrementally. Where I see a real problem is the
> > > lack of timely feedback from the ShellPkg maintainers.
> > Agreed. Hopefully, it can be reviewed sometime soon.
> >
> > Thank you,
> > Vladimir
> > >
> > > Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65213): https://edk2.groups.io/g/devel/message/65213
Mute This Topic: https://groups.io/mt/76739443/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-13 Thread Ni, Ray

Reviewed-by: Ray Ni 

> -Original Message-
> From: Chasel Chiu 
> Sent: Monday, September 14, 2020 9:48 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Dong, Eric ;
> Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1
> ; Desimone, Nathaniel L
> 
> Subject: [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2
> only case.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2883
> 
> MpServices Ppi can be replaced by MpServices2 Ppi and MpServices2
> Ppi is mandatory for RegisterCpuFeaturesLib functionality,
> basing on this we can drop MpServices Ppi usage from the library
> and the constraint that both Ppis must be installed.
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Cc: Rahul Kumar 
> Cc: Nate DeSimone 
> Signed-off-by: Chasel Chiu 
> ---
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c   |
> 61 +++--
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.inf |  5
> ++---
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h |  6
> +++---
>  3 files changed, 28 insertions(+), 44 deletions(-)
> 
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> index 64768f7a74..4e558e9fee 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> +++
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>CPU Register Table Library functions.
> 
> -  Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
> +  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -11,7 +11,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
> 
>  #include "RegisterCpuFeatures.h"
> @@ -75,10 +74,10 @@ GetMpService (
>MP_SERVICESMpService;
> 
>//
> -  // Get MP Services Protocol
> +  // Get MP Services2 Ppi
>//
>Status = PeiServicesLocatePpi (
> - &gEfiPeiMpServicesPpiGuid,
> + &gEdkiiPeiMpServices2PpiGuid,
>   0,
>   NULL,
>   (VOID **)&MpService.Ppi
> @@ -100,17 +99,17 @@ GetProcessorIndex (
>)
>  {
>EFI_STATUS Status;
> -  EFI_PEI_MP_SERVICES_PPI*CpuMpPpi;
> +  EDKII_PEI_MP_SERVICES2_PPI *CpuMp2Ppi;
>UINTN  ProcessorIndex;
> 
> -  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
> +  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
> 
>//
>// For two reasons which use NULL for WhoAmI:
>// 1. This function will be called by APs and AP should not use PeiServices
> Table
>// 2. Check WhoAmI implementation, this parameter will not be used.
>//
> -  Status = CpuMpPpi->WhoAmI(NULL, CpuMpPpi, &ProcessorIndex);
> +  Status = CpuMp2Ppi->WhoAmI (CpuMp2Ppi, &ProcessorIndex);
>ASSERT_EFI_ERROR (Status);
>return ProcessorIndex;
>  }
> @@ -131,16 +130,15 @@ GetProcessorInformation (
>OUT EFI_PROCESSOR_INFORMATION*ProcessorInfoBuffer
>)
>  {
> -  EFI_PEI_MP_SERVICES_PPI*CpuMpPpi;
> +  EDKII_PEI_MP_SERVICES2_PPI *CpuMp2Ppi;
>EFI_STATUS Status;
>CPU_FEATURES_DATA  *CpuFeaturesData;
> 
>CpuFeaturesData = GetCpuFeaturesData ();
> -  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
> +  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
> 
> -  Status = CpuMpPpi->GetProcessorInfo (
> -   GetPeiServicesTablePointer(),
> -   CpuMpPpi,
> +  Status = CpuMp2Ppi->GetProcessorInfo (
> +   CpuMp2Ppi,
> ProcessorNumber,
> ProcessorInfoBuffer
> );
> @@ -162,18 +160,17 @@ StartupAllAPsWorker (
>)
>  {
>EFI_STATUS   Status;
> -  EFI_PEI_MP_SERVICES_PPI  *CpuMpPpi;
> +  EDKII_PEI_MP_SERVICES2_PPI   *CpuMp2Ppi;
>CPU_FEATURES_DATA*CpuFeaturesData;
> 
>CpuFeaturesData = GetCpuFeaturesData ();
> -  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
> +  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
> 
>//
>// Wakeup all APs for data collection.
>//
> -  Status = CpuMpPpi->StartupAllAPs (
> - GetPeiServicesTablePointer (),
> - CpuMpPpi,
> +  Status = CpuMp2Ppi->StartupAllAPs (
> + CpuMp2Ppi,
>   Procedure,
>   FALSE,
>   0,
> @@ -203,17 +200,7 @@ StartupAllCPUsWorker (
>//
>// Get MP Services2 Ppi
>//
> -  Status = PeiServicesLocatePpi (
> - &gEdkiiPeiMpServices2PpiGuid,
> - 0,
> - NULL,
> - (VOID **)&CpuMp2Ppi
> - );
> -  ASSERT_EFI_ERROR (Status);
> -
> -  //
> -  // Wakeup all APs for data collection.
> -  //
> +  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
>Status = CpuMp2Ppi->StartupAllCPUs (
>

回复: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version

2020-09-13 Thread gaoliming

Matthew:
  In future, when update new iasl version again, only this line "version":
"20200717.0.0" will be updated, right?

Thanks
Liming
> -邮件原件-
> 发件人: bounce+27952+65199+4905953+8761...@groups.io
>  代表 Matthew
> Carlson
> 发送时间: 2020年9月12日 4:45
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng ; Liming Gao
> ; Yuwei Chen ; Sean
> Brogan ; Matthew Carlson
> 
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more
> modern version
> 
> From: Matthew Carlson 
> 
> The IASL extdep is used for CI only and a recent fork of the ACPICA
> repo was made to make nuget builds more regular and easier to audit.
> https://dev.azure.com/projectmu/_git/acpica
> 
> Cc: Bob Feng 
> Cc: Liming Gao 
> Cc: Yuwei Chen 
> Cc: Sean Brogan 
> Cc: devel@edk2.groups.io
> 
> Signed-off-by: Matthew Carlson 
> ---
>  BaseTools/Bin/iasl_ext_dep.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Bin/iasl_ext_dep.yaml
> b/BaseTools/Bin/iasl_ext_dep.yaml
> index 1d81e89cf3a6..ea2bc315d184 100644
> --- a/BaseTools/Bin/iasl_ext_dep.yaml
> +++ b/BaseTools/Bin/iasl_ext_dep.yaml
> @@ -14,8 +14,8 @@
>"id": "iasl-ci-1",
> 
>"scope": "cibuild",
> 
>"type": "nuget",
> 
> -  "name": "iasl",
> 
> -  "source": "https://api.nuget.org/v3/index.json";,
> 
> -  "version": "20190215.0.0",
> 
> +  "name": "edk2-acpica-iasl",
> 
> +  "source":
> "https://pkgs.dev.azure.com/projectmu/acpica/_packaging/mu_iasl/nuget/v
> 3/index.json",
> 
> +  "version": "20200717.0.0",
> 
>"flags": ["set_path", "host_specific"]
> 
>  }
> 
> --
> 2.28.0.windows.1
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#65199): https://edk2.groups.io/g/devel/message/65199
> Mute This Topic: https://groups.io/mt/76788780/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65211): https://edk2.groups.io/g/devel/message/65211
Mute This Topic: https://groups.io/mt/76835016/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION

2020-09-13 Thread gaoliming

Yes. This change is correct. Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: bounce+27952+65182+4905953+8761...@groups.io
>  代表 Ni, Ray
> 发送时间: 2020年9月11日 10:19
> 收件人: Wenyi Xie ; devel@edk2.groups.io; Justen,
> Jordan L ; af...@apple.com; gaoliming
> 
> 抄送: ler...@redhat.com; songdongku...@huawei.com
> 主题: Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change
> DEC_VERSION to DEC_SPECIFICATION
> 
> + Liming who is expert on the EDK II Build spec.
> 
> > -Original Message-
> > From: Wenyi Xie 
> > Sent: Friday, September 11, 2020 9:49 AM
> > To: devel@edk2.groups.io; Justen, Jordan L ;
> af...@apple.com; Ni, Ray 
> > Cc: ler...@redhat.com; songdongku...@huawei.com;
> xiewen...@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to
> DEC_SPECIFICATION
> >
> > edk2 DEC specification document only knows about DEC_SPECIFICATION,
> > so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> > correct.
> >
> > Cc: Jordan Justen 
> > Cc: Andrew Fish 
> > Cc: Ray Ni 
> > Signed-off-by: Wenyi Xie 
> > ---
> >  EmulatorPkg/EmulatorPkg.dec | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> > index 90a8d2a8681a..064f963c72c6 100644
> > --- a/EmulatorPkg/EmulatorPkg.dec
> > +++ b/EmulatorPkg/EmulatorPkg.dec
> > @@ -11,7 +11,7 @@
> >  ##
> >
> >  [Defines]
> > -  DEC_VERSION= 0x00010005
> > +  DEC_SPECIFICATION  = 0x00010005
> >PACKAGE_NAME   = EmulatorPkg
> >PACKAGE_GUID   =
> 36E48BD7-7D92-5A47-A2CD-513F072E3300
> >PACKAGE_VERSION= 0.1
> > --
> > 2.20.1.windows.1
> 
> 
> 




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65210): https://edk2.groups.io/g/devel/message/65210
Mute This Topic: https://groups.io/mt/76834779/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-13 Thread Chiu, Chasel

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2883

MpServices Ppi can be replaced by MpServices2 Ppi and MpServices2
Ppi is mandatory for RegisterCpuFeaturesLib functionality,
basing on this we can drop MpServices Ppi usage from the library
and the constraint that both Ppis must be installed.

Cc: Eric Dong 
Cc: Ray Ni 
Cc: Laszlo Ersek 
Cc: Rahul Kumar 
Cc: Nate DeSimone 
Signed-off-by: Chasel Chiu 
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c   | 61 
+++--
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.inf |  5 
++---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h |  6 
+++---
 3 files changed, 28 insertions(+), 44 deletions(-)

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index 64768f7a74..4e558e9fee 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -1,7 +1,7 @@
 /** @file
   CPU Register Table Library functions.
 
-  Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -11,7 +11,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include "RegisterCpuFeatures.h"
@@ -75,10 +74,10 @@ GetMpService (
   MP_SERVICESMpService;
 
   //
-  // Get MP Services Protocol
+  // Get MP Services2 Ppi
   //
   Status = PeiServicesLocatePpi (
- &gEfiPeiMpServicesPpiGuid,
+ &gEdkiiPeiMpServices2PpiGuid,
  0,
  NULL,
  (VOID **)&MpService.Ppi
@@ -100,17 +99,17 @@ GetProcessorIndex (
   )
 {
   EFI_STATUS Status;
-  EFI_PEI_MP_SERVICES_PPI*CpuMpPpi;
+  EDKII_PEI_MP_SERVICES2_PPI *CpuMp2Ppi;
   UINTN  ProcessorIndex;
 
-  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
 
   //
   // For two reasons which use NULL for WhoAmI:
   // 1. This function will be called by APs and AP should not use PeiServices 
Table
   // 2. Check WhoAmI implementation, this parameter will not be used.
   //
-  Status = CpuMpPpi->WhoAmI(NULL, CpuMpPpi, &ProcessorIndex);
+  Status = CpuMp2Ppi->WhoAmI (CpuMp2Ppi, &ProcessorIndex);
   ASSERT_EFI_ERROR (Status);
   return ProcessorIndex;
 }
@@ -131,16 +130,15 @@ GetProcessorInformation (
   OUT EFI_PROCESSOR_INFORMATION*ProcessorInfoBuffer
   )
 {
-  EFI_PEI_MP_SERVICES_PPI*CpuMpPpi;
+  EDKII_PEI_MP_SERVICES2_PPI *CpuMp2Ppi;
   EFI_STATUS Status;
   CPU_FEATURES_DATA  *CpuFeaturesData;
 
   CpuFeaturesData = GetCpuFeaturesData ();
-  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
 
-  Status = CpuMpPpi->GetProcessorInfo (
-   GetPeiServicesTablePointer(),
-   CpuMpPpi,
+  Status = CpuMp2Ppi->GetProcessorInfo (
+   CpuMp2Ppi,
ProcessorNumber,
ProcessorInfoBuffer
);
@@ -162,18 +160,17 @@ StartupAllAPsWorker (
   )
 {
   EFI_STATUS   Status;
-  EFI_PEI_MP_SERVICES_PPI  *CpuMpPpi;
+  EDKII_PEI_MP_SERVICES2_PPI   *CpuMp2Ppi;
   CPU_FEATURES_DATA*CpuFeaturesData;
 
   CpuFeaturesData = GetCpuFeaturesData ();
-  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
 
   //
   // Wakeup all APs for data collection.
   //
-  Status = CpuMpPpi->StartupAllAPs (
- GetPeiServicesTablePointer (),
- CpuMpPpi,
+  Status = CpuMp2Ppi->StartupAllAPs (
+ CpuMp2Ppi,
  Procedure,
  FALSE,
  0,
@@ -203,17 +200,7 @@ StartupAllCPUsWorker (
   //
   // Get MP Services2 Ppi
   //
-  Status = PeiServicesLocatePpi (
- &gEdkiiPeiMpServices2PpiGuid,
- 0,
- NULL,
- (VOID **)&CpuMp2Ppi
- );
-  ASSERT_EFI_ERROR (Status);
-
-  //
-  // Wakeup all APs for data collection.
-  //
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
   Status = CpuMp2Ppi->StartupAllCPUs (
  CpuMp2Ppi,
  Procedure,
@@ -234,18 +221,17 @@ SwitchNewBsp (
   )
 {
   EFI_STATUS   Status;
-  EFI_PEI_MP_SERVICES_PPI  *CpuMpPpi;
+  EDKII_PEI_MP_SERVICES2_PPI   *CpuMp2Ppi;
   CPU_FEATURES_DATA*CpuFeaturesData;
 
   CpuFeaturesData = GetCpuFeaturesData ();
-  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;
 
   //
   // Wakeup all APs for data collection.
   //
-  Status = CpuMpPpi->SwitchBSP (
- GetPeiServicesTablePointer (),
- Cp

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-13 Thread Gao, Zhichao

Hi Vladimir/Laszlo,

Sorry for the late response. Recently, I am busy with other works for recent 
weeks. So I cannot spend much time on EDK2 open source. Apologize for the 
inconvenient.

I didn’t give the comments on the time function because I found it is copied 
from EmbeddedPkg's TimeBaseLib. And I assumes it works fine without any issue 
as it has been in the trunk for a long time. But actually it cannot pass the MS 
VS X64 build. The lib was not added in the package dsc file so the build error 
was not found before. I hope we can directly use the TimeBaseLib instead of 
just use its header file and keep the duplicated code. This can be a future 
fix/optimization.

Other code doesn't change the logic since V9. So I have no comments on the 
implementation except the new time function. With the time function issue 
fixed, I am glad to give the R-B and help to merge the patch.

Thanks,
Zhichao

> -Original Message-
> From: Vladimir Olovyannikov 
> Sent: Saturday, September 12, 2020 1:04 AM
> To: Laszlo Ersek ; devel@edk2.groups.io
> Cc: Gao, Zhichao ; Maciej Rabeda
> ; Wu, Jiaxin ; Fu, Siyuan
> ; Ni, Ray ; Gao, Liming
> ; Nd ; Samer El-Haj-Mahmoud
> 
> Subject: RE: [PATCH v11 0/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
> 
> > -Original Message-
> > From: Laszlo Ersek 
> > Sent: Friday, September 11, 2020 12:20 AM
> > To: Vladimir Olovyannikov ;
> > devel@edk2.groups.io
> > Cc: Zhichao Gao ; Maciej Rabeda
> > ; Jiaxin Wu ;
> > Siyuan Fu ; Ray Ni ; Liming Gao
> > ; Nd ; Samer El-Haj-Mahmoud
> > 
> > Subject: Re: [PATCH v11 0/1] ShellPkg/DynamicCommand: add
> > HttpDynamicCommand
> >
> > On 09/10/20 22:33, Vladimir Olovyannikov wrote:
> > > Hi Laszlo,
> > >
> > >> -Original Message-
> > >> From: Laszlo Ersek 
> > >> Sent: Wednesday, September 9, 2020 11:33 PM
> >
> > >>> PATCH v11 changes:
> > >>> Address comments from Laszlo:
> > >>>   - use TimeBaseLib.h header to get rid of duplicated constants;
> > >>>   - explicitly return UINT32 in EfiTimeToEpoch().
> > >>
> > >> to be clear, I explicitly *disagree* with returning UINT32 from
> > >> EfiTimeToEpoch().
> > >>
> > >> I'm not "demanding" (or even suggesting) that you update the
> > >> EfiTimeToEpoch() implementation in this patch to return UINTN, but
> > >> I'd like to be very clear that, IMO, for EfiTimeToEpoch() to suffer
> > >> from a year 2106 problem on 64-bit systems too, is bad design. So
> > >> please don't list the UINT32 return type as my suggestion -- that's
> > >> the exact opposite of what I'd actually suggest.
> >
> > > Sorry, I must have misunderstood. Do you want me to resubmit the
> > > patch? I am open to ideas.
> >
> > Ideally:
> >
> > - change the return type of EfiTimeToEpoch() to UNITN
> >
> > - drop the final UINT32 cast from EfiTimeToEpoch()
> >
> > - change the type of ElapsedSeconds to UINTN
> >
> > - change the expression
> >
> > ElapsedSeconds > 1 ? ElapsedSeconds : 1
> >
> >   to
> >
> > ElapsedSeconds > 1 ? (UINT64)ElapsedSeconds : 1
> >
> > - print the expression mentioned above with the format specifier %Lu
> I see. Basically, it is PATCH v10. I just wanted to reuse TimeBaseLib.h 
> constants
> in PATCH v11.
> 
> >
> > *BUT*. These are really just small details. It would be OK to fix
> > these up later, incrementally. Where I see a real problem is the lack
> > of timely feedback from the ShellPkg maintainers.
> Agreed. Hopefully, it can be reviewed sometime soon.
> 
> Thank you,
> Vladimir
> >
> > Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65208): https://edk2.groups.io/g/devel/message/65208
Mute This Topic: https://groups.io/mt/76739443/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-13 Thread Chiu, Chasel


Thanks Ray. This is good catch and it was no issue because both MpServices and 
MpServices2 at the same time.
I will update INF.

Thanks,
Chasel


From: Ni, Ray 
Sent: Saturday, September 12, 2020 2:37 AM
To: Dong, Eric ; Chiu, Chasel ; 
devel@edk2.groups.io
Cc: Chiu, Chasel ; Laszlo Ersek ; 
Kumar, Rahul1 ; Desimone, Nathaniel L 

Subject: Re: [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 
only case.

A rough check in phone. Why inf file is not changed?


发件人: Dong, Eric mailto:eric.d...@intel.com>>
发送时间: Friday, September 11, 2020 10:31:32 AM
收件人: Chiu, Chasel mailto:chasel.c...@intel.com>>; 
devel@edk2.groups.io 
mailto:devel@edk2.groups.io>>
抄送: Chiu, Chasel mailto:chasel.c...@intel.com>>; Ni, Ray 
mailto:ray...@intel.com>>; Laszlo Ersek 
mailto:ler...@redhat.com>>; Kumar, Rahul1 
mailto:rahul1.ku...@intel.com>>; Desimone, Nathaniel L 
mailto:nathaniel.l.desim...@intel.com>>
主题: RE: [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only 
case.

Reviewed-by: Eric Dong mailto:eric.d...@intel.com>>

-Original Message-
From: Chasel Chiu mailto:chasel.c...@intel.com>>
Sent: Thursday, September 10, 2020 5:03 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel mailto:chasel.c...@intel.com>>; Dong, 
Eric mailto:eric.d...@intel.com>>; Ni, Ray 
mailto:ray...@intel.com>>; Laszlo Ersek 
mailto:ler...@redhat.com>>; Kumar, Rahul1 
mailto:rahul1.ku...@intel.com>>; Desimone, Nathaniel L 
mailto:nathaniel.l.desim...@intel.com>>
Subject: [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only 
case.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2883

MpServices Ppi can be replaced by MpServices2 Ppi and MpServices2 Ppi is 
mandatory for RegisterCpuFeaturesLib functionality, basing on this we can drop 
MpServices Ppi usage from the library and the constraint that both Ppis must be 
installed.

Cc: Eric Dong mailto:eric.d...@intel.com>>
Cc: Ray Ni mailto:ray...@intel.com>>
Cc: Laszlo Ersek mailto:ler...@redhat.com>>
Cc: Rahul Kumar mailto:rahul1.ku...@intel.com>>
Cc: Nate DeSimone 
mailto:nathaniel.l.desim...@intel.com>>
Signed-off-by: Chasel Chiu mailto:chasel.c...@intel.com>>
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c | 61 
+++--
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h   |  6 
+++---
 2 files changed, 26 insertions(+), 41 deletions(-)

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index 64768f7a74..4e558e9fee 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLi
+++ b.c
@@ -1,7 +1,7 @@
 /** @file
   CPU Register Table Library functions.

-  Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2020, Intel Corporation. All rights
+ reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/
@@ -11,7 +11,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 

 #include "RegisterCpuFeatures.h"
@@ -75,10 +74,10 @@ GetMpService (
   MP_SERVICESMpService;

   //
-  // Get MP Services Protocol
+  // Get MP Services2 Ppi
   //
   Status = PeiServicesLocatePpi (
- &gEfiPeiMpServicesPpiGuid,
+ &gEdkiiPeiMpServices2PpiGuid,
  0,
  NULL,
  (VOID **)&MpService.Ppi
@@ -100,17 +99,17 @@ GetProcessorIndex (
   )
 {
   EFI_STATUS Status;
-  EFI_PEI_MP_SERVICES_PPI*CpuMpPpi;
+  EDKII_PEI_MP_SERVICES2_PPI *CpuMp2Ppi;
   UINTN  ProcessorIndex;

-  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;

   //
   // For two reasons which use NULL for WhoAmI:
   // 1. This function will be called by APs and AP should not use PeiServices 
Table
   // 2. Check WhoAmI implementation, this parameter will not be used.
   //
-  Status = CpuMpPpi->WhoAmI(NULL, CpuMpPpi, &ProcessorIndex);
+  Status = CpuMp2Ppi->WhoAmI (CpuMp2Ppi, &ProcessorIndex);
   ASSERT_EFI_ERROR (Status);
   return ProcessorIndex;
 }
@@ -131,16 +130,15 @@ GetProcessorInformation (
   OUT EFI_PROCESSOR_INFORMATION*ProcessorInfoBuffer
   )
 {
-  EFI_PEI_MP_SERVICES_PPI*CpuMpPpi;
+  EDKII_PEI_MP_SERVICES2_PPI *CpuMp2Ppi;
   EFI_STATUS Status;
   CPU_FEATURES_DATA  *CpuFeaturesData;

   CpuFeaturesData = GetCpuFeaturesData ();
-  CpuMpPpi = CpuFeaturesData->MpService.Ppi;
+  CpuMp2Ppi = CpuFeaturesData->MpService.Ppi;

-  Status = CpuMpPpi->GetProcessorInfo (
-   GetPeiServicesTablePointer(),
-   CpuMpPpi,
+  Status = CpuMp2Ppi->GetProcessorInfo (
+   CpuMp2Ppi,
ProcessorNumber,
ProcessorInfoBuffer
);
@@ -162,

[edk2-devel] Hang in CoreCheckTimers

2020-09-13 Thread Stanley Gan

Hi All,



I have some questions about MdeModulePkg\Core\Dxe\Event\Timer.c
CoreCheckTimers.

My system will keep looping in CoreCheckTimers in some scenarios:

· CPU run very slow (Cache disabled)

· A lot of timer event (Network stack enabled)

In normal boot, CoreCheckTimers will execute two times. 1st time, it
actually signifies timer event. 2nd time, because there is no expired
timer, it will exit quickly.

In my scenario, another time interrupt comes and updates EfiSystemTime at
second CoreCheckTimers. The system will keep looping in CoreCheckTimers.

My questions are:

1.   Is the " CoreSignalEvent (mEfiCheckTimerEvent)" line below
necessary? Can we disable interrupt at TPL 30?

  //

  // If that's before now, then reset the timer to start from now

  //

  if (Event->Timer.TriggerTime <= SystemTime) {

Event->Timer.TriggerTime = SystemTime;

CoreSignalEvent (mEfiCheckTimerEvent);

  }

2.   If the system runs slowly, do we need to expand the timer
interrupt interval? Is there any requirments about the ratio between CPU
speed and timer interval?

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65206): https://edk2.groups.io/g/devel/message/65206
Mute This Topic: https://groups.io/mt/76816935/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

回复: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version

回复: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION

[edk2-devel] [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Re: [edk2-devel] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

[edk2-devel] Hang in CoreCheckTimers

10 matches

Site Navigation

Mail list logo

Footer information