[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Rename PlatformMultiPhaseLibSample.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Basing on offline feedbacks to rename
FspWrapperPlatformMultiPhaseLibSample to
FspWrapperPlatformMultiPhaseLibNull.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/Library/{BaseFspWrapperPlatformMultiPhaseLibSample/FspWrapperPlatformMultiPhaseLibSample.c
=>
BaseFspWrapperPlatformMultiPhaseLibNull/FspWrapperPlatformMultiPhaseLibNull.c}
| 0
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
| 4 ++--
IntelFsp2WrapperPkg/Library/{BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf
=>
BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf}
| 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/FspWrapperPlatformMultiPhaseLibSample.c
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/FspWrapperPlatformMultiPhaseLibNull.c
similarity index 100%
rename from
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/FspWrapperPlatformMultiPhaseLibSample.c
rename to
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/FspWrapperPlatformMultiPhaseLibNull.c
diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
index 79a5c7f13d..b1fc2291c8 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
@@ -48,7 +48,7 @@
FspWrapperApiLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/BaseFspWrapperApiLib.inf
FspWrapperApiTestLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiTestLibNull/BaseFspWrapperApiTestLibNull.inf
FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf
-
FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf
+
FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf
FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf
# FSP platform sample
@@ -93,7 +93,7 @@
IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/BaseFspWrapperApiLib.inf
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
-
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf
+
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf
IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf
[PcdsFixedAtBuild.common]
diff --git
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf
similarity index 90%
rename from
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf
rename to
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf
index 607ad41a23..4580e80e2e 100644
---
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf
+++
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf
@@ -10,7 +10,7 @@
[Defines]
INF_VERSION= 0x00010005
- BASE_NAME = BaseFspWrapperPlatformMultiPhaseLibSample
+ BASE_NAME = BaseFspWrapperPlatformMultiPhaseLibNull
FILE_GUID = DB63E5AA-21C6-40BB-879A-CD1762C8427B
MODULE_TYPE= BASE
VERSION_STRING = 1.0
@@ -23,7 +23,7 @@
#
[Sources]
- FspWrapperPlatformMultiPhaseLibSample.c
+ FspWrapperPlatformMultiPhaseLibNull.c
[Packages]
MdePkg/MdePkg.dec
--
2.35.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93025): https://edk2.groups.io/g/devel/message/93025
Mute This Topic: https://groups.io/mt/93389107/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/NvmExpressPei: Use PCI_DEVICE_PPI to manage Nvme device
Patch merged via:
PR - https://github.com/tianocore/edk2/pull/3267
Commit -
https://github.com/tianocore/edk2/commit/9ca7ece8b3b1743b6ee76f5f20f2c5eeed001d72
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Tuesday, August 30, 2022 2:27 PM
> To: Chen, Xiao X ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/NvmExpressPei:
> Use PCI_DEVICE_PPI to manage Nvme device
>
> Thanks.
> Reviewed-by: Hao A Wu
>
> Will wait a couple of days before merging to see if comments from other
> reviewers.
>
> Best Regards,
> Hao Wu
>
> > -Original Message-
> > From: Chen, Xiao X
> > Sent: Tuesday, August 30, 2022 1:47 PM
> > To: devel@edk2.groups.io
> > Cc: Chen, Xiao X ; Wu, Hao A
> > ; Ni, Ray
> > Subject: [PATCH v2 1/1] MdeModulePkg/NvmExpressPei: Use
> PCI_DEVICE_PPI
> > to manage Nvme device
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4017
> >
> > This change modifies NvmExpressPei library to allow usage both
> > EDKII_PCI_DEVICE_PPI and EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI
> > to manage Nvme device.
> >
> > Cc: Hao A Wu
> > Cc: Ray Ni
> > Signed-off-by: Xiao X Chen
> > ---
> > .../Bus/Pci/NvmExpressPei/DevicePath.c| 44 --
> > .../Bus/Pci/NvmExpressPei/NvmExpressPei.c | 639 --
> > .../Bus/Pci/NvmExpressPei/NvmExpressPei.h | 54 ++
> > .../Bus/Pci/NvmExpressPei/NvmExpressPei.inf | 3 +-
> > 4 files changed, 488 insertions(+), 252 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/DevicePath.c
> > b/MdeModulePkg/Bus/Pci/NvmExpressPei/DevicePath.c
> > index 9b454a7dd8f4..307045be70ea 100644
> > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/DevicePath.c
> > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/DevicePath.c
> > @@ -37,50 +37,6 @@ EFI_DEVICE_PATH_PROTOCOL
> > mNvmeEndDevicePathNodeTemplate = {
> >}
> > };
> >
> > -/**
> > - Returns the 16-bit Length field of a device path node.
> > -
> > - Returns the 16-bit Length field of the device path node specified by
> > Node.
> > - Node is not required to be aligned on a 16-bit boundary, so it is
> > recommended
> > - that a function such as ReadUnaligned16() be used to extract the
> > contents of
> > - the Length field.
> > -
> > - If Node is NULL, then ASSERT().
> > -
> > - @param Node A pointer to a device path node data structure.
> > -
> > - @return The 16-bit Length field of the device path node specified by
> Node.
> > -
> > -**/
> > -UINTN
> > -DevicePathNodeLength (
> > - IN CONST VOID *Node
> > - )
> > -{
> > - ASSERT (Node != NULL);
> > - return ReadUnaligned16 ((UINT16 *)&((EFI_DEVICE_PATH_PROTOCOL
> > *)(Node))->Length[0]); -}
> > -
> > -/**
> > - Returns a pointer to the next node in a device path.
> > -
> > - If Node is NULL, then ASSERT().
> > -
> > - @param NodeA pointer to a device path node data structure.
> > -
> > - @return a pointer to the device path node that follows the device
> > path node
> > - specified by Node.
> > -
> > -**/
> > -EFI_DEVICE_PATH_PROTOCOL *
> > -NextDevicePathNode (
> > - IN CONST VOID *Node
> > - )
> > -{
> > - ASSERT (Node != NULL);
> > - return (EFI_DEVICE_PATH_PROTOCOL *)((UINT8 *)(Node) +
> > DevicePathNodeLength (Node)); -}
> > -
> > /**
> >Get the size of the current device path instance.
> >
> > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c
> > b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c
> > index 2d6a79028fcd..0d02c2785da7 100644
> > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c
> > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c
> > @@ -40,6 +40,18 @@ EFI_PEI_NOTIFY_DESCRIPTOR
> > mNvmeEndOfPeiNotifyListTemplate = {
> >NvmePeimEndOfPei
> > };
> >
> > +EFI_PEI_NOTIFY_DESCRIPTOR mNvmeHostControllerNotify = {
> > + (EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK |
> > +EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),
> > + ,
> > + NvmeHostControllerPpiInstallationCallback
> > +};
> > +
> > +EFI_PEI_NOTIFY_DESCRIPTOR mPciDevicePpiNotify = {
> > + (EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK |
> > +EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),
> > + ,
> > + NvmePciDevicePpiInstallationCallback
> > +};
> > +
> > /**
> >Check if the specified Nvm Express device namespace is active, and
> > then get the Identify
> >Namespace data.
> > @@ -212,30 +224,27 @@ NvmePeimEndOfPei ( }
> >
> > /**
> > - Entry point of the PEIM.
> > + Initialize and install PrivateData PPIs.
> >
> > - @param[in] FileHandle Handle of the file being invoked.
> > - @param[in] PeiServicesDescribes the list of possible PEI Services.
> > -
> > - @retval EFI_SUCCESSPPI successfully installed.
> > + @param[in] MmioBaseMMIO base address of specific Nvme
> > controller
> > + @param[in] DevicePath A pointer to the
> > EFI_DEVICE_PATH_PROTOCOL
> > + structure.
> > + @param[in] DevicePathLengthLength of the device
Re: [edk2-devel] Python368 socket support #includes
The socket module is not enabled in the Open source version of the Python UEFI interpreter available in edk2-libc. It needs some porting effort. Regards, JP From: devel@edk2.groups.io On Behalf Of chesig...@gmail.com Sent: 30 August 2022 23:51 To: devel@edk2.groups.io Subject: [edk2-devel] Python368 socket support #includes Hello Ive tried building python368 in edk2 environment and Ive came across some issues. I cant seem to be able to import urllib or socket in a uefi shell env. The error reads, import _socket fails because _socket does not exist. Can anyone please provide a full guide on how to build python368 or miceopython with socket support on ubuntu 20 or 22 ? Is this a bug ? Thank you very much -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93023): https://edk2.groups.io/g/devel/message/93023 Mute This Topic: https://groups.io/mt/93356814/21656 Mute #includes:https://edk2.groups.io/g/devel/mutehashtag/includes Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
[AMD Official Use Only - General] Hi Richard, I can see the value of this driver to communicate with the BMC USB ECM NIC. I am doing the same thing here and I just realize that you already had the solution. One question: Why do we create a new package for this? The UsbCDC* and UsbRndis driver can be perfectly put under MdeModulePkg/Bus/Usb as the USB class driver. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of > RichardHo [???] via groups.io > Sent: Thursday, September 1, 2022 11:47 AM > To: gaoliming ; devel@edk2.groups.io > Cc: 'Andrew Fish' ; 'Leif Lindholm' > ; 'Michael D Kinney' > ; 'Michael Kubacki' > ; 'Leif Lindholm' ; > 'Zhiguang Liu' ; 'Hao A Wu' ; > 'Ray Ni' ; TonyLo [羅金松] ; 'Demeter, > Miki' > Subject: Re: 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network > devices support > > [CAUTION: External Email] > > Hi Liming, > > Please see more information in ReadMe.md for your question. > > Thanks, > Richard > > > -Original Message- > From: gaoliming > Sent: 2022年8月31日 5:47 PM > To: devel@edk2.groups.io; RichardHo [何明忠] > Cc: 'Andrew Fish' ; 'Leif Lindholm' > ; 'Michael D Kinney' > ; 'Michael Kubacki' > ; 'Leif Lindholm' ; > 'Zhiguang Liu' ; 'Hao A Wu' ; > 'Ray Ni' ; TonyLo [羅金松] ; 'Demeter, > Miki' > Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB > network devices support > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance.** > > Richard: > Thanks for your contribution. This is new feature. Can you submit feature > request to > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz > illa.tianocore.org%2Fdata=05%7C01%7Cabner.chang%40amd.com%7C > 86bcef7381834f71fe7708da8bcc99a7%7C3dd8961fe4884e608e11a82d994e183 > d%7C0%7C0%7C637976008136351675%7CUnknown%7CTWFpbGZsb3d8eyJW > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 3000%7C%7C%7Csdata=lDd57mIm1npsAw43ZYK23mSzn75zlC6sHUU5R > XLTi%2Bs%3Dreserved=0? If you have no account in > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz > illa.tianocore.org%2Fdata=05%7C01%7Cabner.chang%40amd.com%7C > 86bcef7381834f71fe7708da8bcc99a7%7C3dd8961fe4884e608e11a82d994e183 > d%7C0%7C0%7C637976008136351675%7CUnknown%7CTWFpbGZsb3d8eyJW > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 3000%7C%7C%7Csdata=lDd57mIm1npsAw43ZYK23mSzn75zlC6sHUU5R > XLTi%2Bs%3Dreserved=0, you can ask help for 'Demeter, Miki' deme...@intel.com>. > > For the code, what's the purpose of > UsbNetworkPkg/NetworkCommon/PxeFunction.c? Does NetworkCommon > support PXE? > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 RichardHo > > [何明忠] via groups.io > > 发送时间: 2022年8月31日 10:31 > > 收件人: devel@edk2.groups.io > > 抄送: Andrew Fish ; Leif Lindholm > > ; Michael D Kinney > > ; Michael Kubacki > > ; Leif Lindholm ; > > Zhiguang Liu ; Liming Gao > > ; Hao A Wu ; Ray Ni > > ; TonyLo [羅金松] > > 主题: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices > > support > > > > UsbNetworkPkg provides network functions for USB ACM, USB NCM, and > USB > > RNDIS network device. > > > > Signed-off-by: Richard Ho > > Cc: Andrew Fish > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Michael Kubacki > > Cc: Leif Lindholm > > Cc: Zhiguang Liu > > Acked-by: Michael D Kinney > > Acked-by: Liming Gao > > Acked-by: Leif Lindholm > > Reviewed-by: Hao A Wu > > Reviewed-by: Ray Ni > > Reviewed-by: Tony Lo > > --- > > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc|9 + > > .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 + > > .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 21 + > > .../Config/UsbNetworkPkgDefines.inc.dsc | 23 + > > .../Include/Protocol/UsbEthernetProtocol.h| 872 + > > UsbNetworkPkg/NetworkCommon/ComponentName.c | 264 +++ > > UsbNetworkPkg/NetworkCommon/DriverBinding.c | 583 ++ > > UsbNetworkPkg/NetworkCommon/DriverBinding.h | 263 +++ > > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 43 + > > UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1734 > > + > > UsbNetworkPkg/ReadMe.md | 65 + > > UsbNetworkPkg/ReleaseNotes.md | 11 + > > UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 ++ > > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c | 504 + > > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h | 211 ++ > > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf | 41 + > > UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c | 861 > > UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170 ++ > > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c | 508 + > > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h | 245 +++ > > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf | 41 + > > UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c | 946 + > > UsbNetworkPkg/UsbNetworkPkg.dec
[edk2-devel] [PATCH V2] RedfishPkg/RedfishDiscoverDxe: Install EFI_DISCOVER_PROTOCOL on each network interface
From: Abner Chang
BZ 4037:
Install EFI_DISCOVER_PROTOCOL on each network interface.
This fixes the issue that causes the high-level Redfish driver
on the network interface is stopped when:
1. EFI_DISCOVER_PROTOCOL is reinstalled on a new-found network
interface, or
2. EFI_DISCOVER_PROTOCOL is stopped on the network interface
other than the one which is used to communicate with Redfish
service.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Abner Chang
---
.../RedfishDiscoverInternal.h | 7 +
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 140 ++
2 files changed, 88 insertions(+), 59 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h
b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h
index 4d1319b2641..04fa09e1cc2 100644
--- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h
+++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h
@@ -2,6 +2,7 @@
This file defines the EFI Redfish Discover Protocol interface.
(C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2022, AMD Incorporated. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -107,6 +108,12 @@ typedef struct {
///< NETWORK_INTERFACE_PROTOCOL_TYPE.
REDFISH_DISCOVER_NETWORK_INTERFACE_PROTOCOLNetworkInterfaceProtocolInfo;
///< Network interface protocol information.
EFI_HANDLE RestExHandle;
///< REST EX handle associated with this network interface.
+ //
+ // EFI_REDFISH_DISCOVER_PROTOCOL instance installed
+ // on this network interface.
+ //
+ EFI_HANDLE
EfiRedfishDiscoverProtocolHandle; ///< EFI_REDFISH_DISCOVER_PROTOTOCOL instance
installed
+
///< on this network interface.
} EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL;
//
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
index bf50c78c928..a271f6e942d 100644
--- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
+++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
@@ -3,6 +3,7 @@
The implementation of EFI Redfidh Discover Protocol.
(C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2022, AMD Incorporated. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -23,8 +24,6 @@ EFI_GUID mRedfishDiscoverTcp4InstanceGuid =
EFI_REDFISH_DISCOVER_TCP4_INSTANC
EFI_GUID mRedfishDiscoverTcp6InstanceGuid =
EFI_REDFISH_DISCOVER_TCP6_INSTANCE_GUID;
EFI_GUID mRedfishDiscoverRestExInstanceGuid =
EFI_REDFISH_DISCOVER_REST_EX_INSTANCE_GUID;
-EFI_HANDLE EfiRedfishDiscoverProtocolHandle = NULL;
-
EFI_STATUS
EFIAPI
Tcp4GetSubnetInfo (
@@ -325,6 +324,38 @@ GetTargetNetworkInterfaceInternal (
return NULL;
}
+/**
+ This function searches EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL
+ instance with the given Controller handle.
+
+ @param[in] ControllerHandle The controller handle associated with network
interface.
+
+ @retval Non-NULL EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL is
returned.
+ @retval NULL Non of EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL
instance is returned.
+**/
+EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL *
+GetTargetNetworkInterfaceInternalByController (
+ IN EFI_HANDLE ControllerHandle
+ )
+{
+ EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL *ThisNetworkInterface;
+
+ ThisNetworkInterface = (EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL
*)GetFirstNode ();
+ while (TRUE) {
+if (ThisNetworkInterface->OpenDriverControllerHandle == ControllerHandle) {
+ return ThisNetworkInterface;
+}
+
+if (IsNodeAtEnd (,
>Entry)) {
+ return NULL;
+}
+
+ThisNetworkInterface = (EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL
*)GetNextNode (,
>Entry);
+ }
+
+ return NULL;
+}
+
/**
This function validate if target network interface is ready for discovering
Redfish service.
@@ -1619,29 +1650,30 @@ BuildupNetworkInterface (
EFI_OPEN_PROTOCOL_BY_DRIVER
);
if (!EFI_ERROR (Status)) {
-if ((EfiRedfishDiscoverProtocolHandle == NULL) &&
-(gRequiredProtocol[Index].ProtocolType == ProtocolTypeRestEx) &&
-!IsListEmpty ()
-)
-{
- // Install the fisrt Redfish Discover Protocol when EFI REST EX
protcol is discovered.
- // This ensures EFI REST EX is ready while
EFI_REDFISH_DISCOVER_PROTOCOL consumer acquires
- // Redfish serivce over network interface.
-
- Status = gBS->InstallProtocolInterface (
- ,
- ,
- EFI_NATIVE_INTERFACE,
-
Re: 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
Hi Liming, Please see more information in ReadMe.md for your question. Thanks, Richard -Original Message- From: gaoliming Sent: 2022年8月31日 5:47 PM To: devel@edk2.groups.io; RichardHo [何明忠] Cc: 'Andrew Fish' ; 'Leif Lindholm' ; 'Michael D Kinney' ; 'Michael Kubacki' ; 'Leif Lindholm' ; 'Zhiguang Liu' ; 'Hao A Wu' ; 'Ray Ni' ; TonyLo [羅金松] ; 'Demeter, Miki' Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Richard: Thanks for your contribution. This is new feature. Can you submit feature request to https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fdata=05%7C01%7Crichardho%40ami.com%7C5f950debbf01487623db08da8b35b846%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C637975360096010785%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=zl%2F13Q5OOLBzRtb37HvG5j0i6x6fh%2BCIo0fqkWnbaJU%3Dreserved=0? If you have no account in https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fdata=05%7C01%7Crichardho%40ami.com%7C5f950debbf01487623db08da8b35b846%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C637975360096010785%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=zl%2F13Q5OOLBzRtb37HvG5j0i6x6fh%2BCIo0fqkWnbaJU%3Dreserved=0, you can ask help for 'Demeter, Miki' . For the code, what's the purpose of UsbNetworkPkg/NetworkCommon/PxeFunction.c? Does NetworkCommon support PXE? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 RichardHo > [何明忠] via groups.io > 发送时间: 2022年8月31日 10:31 > 收件人: devel@edk2.groups.io > 抄送: Andrew Fish ; Leif Lindholm > ; Michael D Kinney > ; Michael Kubacki > ; Leif Lindholm ; > Zhiguang Liu ; Liming Gao > ; Hao A Wu ; Ray Ni > ; TonyLo [羅金松] > 主题: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices > support > > UsbNetworkPkg provides network functions for USB ACM, USB NCM, and USB > RNDIS network device. > > Signed-off-by: Richard Ho > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Michael Kubacki > Cc: Leif Lindholm > Cc: Zhiguang Liu > Acked-by: Michael D Kinney > Acked-by: Liming Gao > Acked-by: Leif Lindholm > Reviewed-by: Hao A Wu > Reviewed-by: Ray Ni > Reviewed-by: Tony Lo > --- > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc|9 + > .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 + > .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 21 + > .../Config/UsbNetworkPkgDefines.inc.dsc | 23 + > .../Include/Protocol/UsbEthernetProtocol.h| 872 + > UsbNetworkPkg/NetworkCommon/ComponentName.c | 264 +++ > UsbNetworkPkg/NetworkCommon/DriverBinding.c | 583 ++ > UsbNetworkPkg/NetworkCommon/DriverBinding.h | 263 +++ > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 43 + > UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1734 > + > UsbNetworkPkg/ReadMe.md | 65 + > UsbNetworkPkg/ReleaseNotes.md | 11 + > UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 ++ > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c | 504 + > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h | 211 ++ > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf | 41 + > UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c | 861 > UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170 ++ > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c | 508 + > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h | 245 +++ > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf | 41 + > UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c | 946 + > UsbNetworkPkg/UsbNetworkPkg.dec | 32 + > UsbNetworkPkg/UsbRndis/ComponentName.c| 172 ++ > UsbNetworkPkg/UsbRndis/UsbRndis.c | 848 > UsbNetworkPkg/UsbRndis/UsbRndis.h | 569 ++ > UsbNetworkPkg/UsbRndis/UsbRndis.inf | 41 + > UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1587 > +++ > 28 files changed, 10854 insertions(+) create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc > create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc > create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf > create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc > create mode 100644 > UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h > create mode 100644 > UsbNetworkPkg/NetworkCommon/ComponentName.c > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h > create mode 100644 > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf > create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c > create mode 100644
Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
Hi Rebecca,
All files are new. I sent it with "git send-email".
I don't have account to push the code into branch.
Thanks,
Richard
-Original Message-
From: Rebecca Cran
Sent: 2022年8月31日 9:28 PM
To: devel@edk2.groups.io; RichardHo [何明忠]
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
; Zhiguang Liu ; Liming
Gao ; TonyLo [羅金松]
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network
devices support
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Do you have a public branch somewhere I could pull this code from?
Much of the patch appears to have been mangled during sending, with extra blank
lines.
--
Rebecca Cran
On 8/31/22 01:51, RichardHo [何明忠] via groups.io wrote:
> new file mode 100644
> index 00..1c1a450920
> --- /dev/null
> +++ b/UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h
> @@ -0,0 +1,872 @@
> +/** @file
>
> + Header file contains code for USB Ethernet Protocol
>
> + definitions
>
> +
>
> + Copyright (c) 2022, American Megatrends International LLC. All rights
> reserved.
>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
>
> +**/
>
> +
>
> +#ifndef _USB_ETHERNET_PROTOCOL_H
>
> +#define _USB_ETHERNET_PROTOCOL_H
>
> +
>
> +#define USB_ETHERNET_PROTOCOL_GUID \
>
> +{0x8d8969cc, 0xfeb0, 0x4303, {0xb2, 0x1a, 0x1f, 0x11, 0x6f, 0x38, 0x56,
> 0x43}}
>
> +
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93019): https://edk2.groups.io/g/devel/message/93019
Mute This Topic: https://groups.io/mt/93121092/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 09/01/2022 #cal-reminder
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* 09/01/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%226e4ce4c4-1242-431b-9a51-92cd01a5df3c%22%7d *Organizer:* Miki Demeter View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1624383 ) *Description:* Microsoft Teams meeting *Join on your computer or mobile app* Click here to join the meeting ( https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%226e4ce4c4-1242-431b-9a51-92cd01a5df3c%22%7d ) Meeting ID: 283 318 374 436 Passcode: 633zLo Download Teams ( https://www.microsoft.com/en-us/microsoft-teams/download-app ) | Join on the web ( https://www.microsoft.com/microsoft-teams/join-a-meeting ) *Join with a video conferencing device* te...@conf.intel.com Video Conference ID: 119 493 012 8 Alternate VTC instructions ( https://conf.intel.com/teams/?conf=1194930128=teams=conf.intel.com=test_call ) Learn More ( https://aka.ms/JoinTeamsMeeting ) | Meeting options ( https://teams.microsoft.com/meetingOptions/?organizerId=6e4ce4c4-1242-431b-9a51-92cd01a5df3c=46c98d88-e344-4ed4-8496-4ed7712e255d=19_meeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2@thread.v2=0=en-US ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93018): https://edk2.groups.io/g/devel/message/93018 Mute This Topic: https://groups.io/mt/93387051/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting
Pushed as 3c3b116801..d9994fa7e1 -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, August 31, 2022 5:55 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel ; Gao, Liming ; Dong, Eric ; Chaganty, Rangasai V ; Luo, Heng ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Hi Isaac, Good cleanup! For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Friday, July 22, 2022 11:46 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric ; Chaganty, Rangasai V ; Luo, Heng ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting These changes simplify the logic for board porting by creating common include files for initializing PCD and for some stage specific logic commonly implemented. Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable only. Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure. Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disable handler profiling on RELEASE builds. The net result is removal of unnecessary or duplicate options and the reduction in duplicate code with increases in comments. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Sai Chaganty Cc: Heng Luo Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Isaac Oram (13): MinPlatformPkg/Include: Simplify board creation WhitleyOpenBoardPkg/Build: Reduce duplicate code Features/Intel: Reduce duplicate code WhitleyOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg/Include: Simplify build logic BoardModulePkg/Include: Add include for stage behavior logic WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code TigerLakeOpenBoardPkg/Build: Reduce unnecessary code SimicsOpenBoardPkg/Build: Reduce unnecessary code PurleyOpenBoardPkg/Build: Reduce unnecessary code KabylakeOpenBoardPkg/Build: Reduce unnecessary code CometlakeOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg: Remove unnecessary feature controls .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++-- .../AcpiDebugFeaturePkg.dsc | 12 ++-- .../BeepDebugFeaturePkg.dsc | 15 ++-- .../PostCodeDebugFeaturePkg.dsc | 15 ++-- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++-- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++-- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++-- .../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++-- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++-- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++-- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++-- .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++-- .../VirtualKeyboardFeaturePkg.dsc | 13 ++-- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++ .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 - .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 -- .../GalagoPro3/OpenBoardPkgPcd.dsc| 51 - .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 - .../Include/Dsc/CoreCommonLib.dsc | 6 +- .../Include/Dsc/CoreDxeInclude.dsc| 23 +++--- .../Dsc/MinPlatformFeaturesPcd.dsc.inc| 25 +++ .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++-- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 -- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 - .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 -- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 - .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 -- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 - .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 - .../Aowanda/PlatformPkg.dsc | 3 - .../BoardPortTemplate/PlatformPkg.dsc | 50 + ...blePerformanceMonitoringInfrastructure.dsc | 5 +- ...anceMonitoringInfrastructurePostMemory.fdf | 5 +- ...manceMonitoringInfrastructurePreMemory.fdf | 2 +- .../JunctionCity/PlatformPkg.dsc | 3 - .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++- .../WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 39 files changed, 382 insertions(+), 645 deletions(-) create mode 100644 Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93017):
Re: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting
Hi Isaac, Good cleanup! For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Friday, July 22, 2022 11:46 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric ; Chaganty, Rangasai V ; Luo, Heng ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting These changes simplify the logic for board porting by creating common include files for initializing PCD and for some stage specific logic commonly implemented. Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable only. Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure. Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disable handler profiling on RELEASE builds. The net result is removal of unnecessary or duplicate options and the reduction in duplicate code with increases in comments. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Sai Chaganty Cc: Heng Luo Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Isaac Oram (13): MinPlatformPkg/Include: Simplify board creation WhitleyOpenBoardPkg/Build: Reduce duplicate code Features/Intel: Reduce duplicate code WhitleyOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg/Include: Simplify build logic BoardModulePkg/Include: Add include for stage behavior logic WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code TigerLakeOpenBoardPkg/Build: Reduce unnecessary code SimicsOpenBoardPkg/Build: Reduce unnecessary code PurleyOpenBoardPkg/Build: Reduce unnecessary code KabylakeOpenBoardPkg/Build: Reduce unnecessary code CometlakeOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg: Remove unnecessary feature controls .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++-- .../AcpiDebugFeaturePkg.dsc | 12 ++-- .../BeepDebugFeaturePkg.dsc | 15 ++-- .../PostCodeDebugFeaturePkg.dsc | 15 ++-- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++-- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++-- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++-- .../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++-- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++-- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++-- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++-- .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++-- .../VirtualKeyboardFeaturePkg.dsc | 13 ++-- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++ .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 - .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 -- .../GalagoPro3/OpenBoardPkgPcd.dsc| 51 - .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 - .../Include/Dsc/CoreCommonLib.dsc | 6 +- .../Include/Dsc/CoreDxeInclude.dsc| 23 +++--- .../Dsc/MinPlatformFeaturesPcd.dsc.inc| 25 +++ .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++-- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 -- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 - .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 -- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 - .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 -- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 - .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 - .../Aowanda/PlatformPkg.dsc | 3 - .../BoardPortTemplate/PlatformPkg.dsc | 50 + ...blePerformanceMonitoringInfrastructure.dsc | 5 +- ...anceMonitoringInfrastructurePostMemory.fdf | 5 +- ...manceMonitoringInfrastructurePreMemory.fdf | 2 +- .../JunctionCity/PlatformPkg.dsc | 3 - .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++- .../WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 39 files changed, 382 insertions(+), 645 deletions(-) create mode 100644 Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93016): https://edk2.groups.io/g/devel/message/93016 Mute This Topic: https://groups.io/mt/92554226/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.
This sample library does not do anything. If the design is such that a NULL library is functional, then a NULL library should be implemented. Having a sample library that has the same function as a NULL library doesn't make sense to me. It looks like a NULL library would work fine in this design. If you update to IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf, that would be acceptable to me. Regards, Isaac -Original Message- From: Chiu, Chasel Sent: Wednesday, August 31, 2022 11:19 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc index 8e91dba6ac..d4191c4b01 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc @@ -54,6 +54,8 @@ TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf+ FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf+ FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf -- 2.35.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93015): https://edk2.groups.io/g/devel/message/93015 Mute This Topic: https://groups.io/mt/93377589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg: Add FspNvsBuffer compression option
I agree with Michael that keeping the API interface for LargeVariableLib focused on a single capability would more closely follow the single responsibility principle and therefore be desirable. Adding the capability to select between compressed vs. un-compressed would complicate the API to the point of making the library rigid. Where things become unclear to me is how compression should be applied. Ultimately, the knowledge of whether the NVS buffer data/memory training data is sparse enough to merit spending CPU cycles on compression is knowledge that the producer of the data set would have the most insight on. Most of the past MRC implementations on typical Intel platforms just happen to produce sparse data, but that is not necessarily always going to be the case. Moreover, due to the NVS data structures frequently involving repetitions of similar data, compression ratios would be best if the entire data set was compressed as a single block. Functionally, this limits the number of places that we could do compression effectively to two: 1. In the implementation of LargeVariableLib 2. Before calling LargeVariableLib We have already thoroughly discussed #1, so I don't think we need to beat that dead horse any further. That leads me to #2. Again, since the producer of the data will have the best knowledge on the compressibility of that data, I think it makes sense for the request to compress to come from the FSP. I also agree that it makes sense that platforms would want to have control over the compression algorithms used. That makes me lean towards adding new PPIs for compression and decompression. In FSP dispatch mode, those PPIs can be produced by platform and consumed by FSP. The FSP would invoke the PPI to compress the data, and then the data that comes out of FspNvsBuffer would already have the platform preferred compression applied to the fragments of the data for which compression makes sense. What do you think? Thanks, Nate -Original Message- From: Michael Kubacki Sent: Friday, August 26, 2022 9:36 AM To: Oram, Isaac W ; Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Chiu, Chasel ; Gao, Liming ; Dong, Eric Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg: Add FspNvsBuffer compression option Honestly, I forgot about the open board packages, I can definitely update support for thosee. Automating Contribution Expectations As Tianocore modernizes its development process, PR template checklists and CI including board package builds would automate a broad range of contribution expectations including what packages need to build against what targets, toolchains, analysis tools, etc. In this case, I understand what needs to be done but others might not. Board vs FSP Compression I agree that the wrapper should be responsible for determining how to manage data. For the reasons Isaac mentioned - platform selection of compression algorithms, cohesive platform data managment in its data store, minimizing FSP size, etc. By FSP focusing on only what it requires, it provides opportunity for simpler and more flexible integration and optimization around its interface. LargeVariableLib Support I am in favor of not modifying LargeVariableLib. Going back to the FSP compression topic, I prefer simple (single responsibility) interfaces. FSP initializes silicon. As part of its input interface, it needs some context data (NVS buffer data) to determine its internal state transitions. By decoupling peripheral functionality from within FSP, it can easily be reasoned that data compression is not silicon init, therefore, FSP should not perform data compression. Interfaces often require data input. We (everyone) have a tendency to extend those interface with various options for data transformation over time. For example, this has made the UEFI variable interface error prone and cumbersome to adapt to different environments. When I look at LargeVariableWriteLib.h and LargeVariableReadLib.h, I see a wrapper around the UEFI variable services that is relatively easy to understand and to determine if it fits my use case - I want to work around the maximum UEFI variable size set on a platform. On the surface at least, the interface is simple - it mostly mirrors the UEFI RT Services functions, the use case is easy to understand, and the expected behavior is easy to comprehend. I'm trying to understand what advantage there is to complicating this. Compression already has an abstraction in its library classes - CompressLib and UefiDecompressLib. Those could be more symmetrical, etc. but they're relatively easy to understand and reason about as well. So this is a question of whether to invoke that abstraction outside the LargeVariableLib interfaces or underneath its implementation. When outside: - The caller is given a simpler LargeVariableLib
[edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.
FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc index 8e91dba6ac..d4191c4b01 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc @@ -54,6 +54,8 @@ TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf + FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf + FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf -- 2.35.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93013): https://edk2.groups.io/g/devel/message/93013 Mute This Topic: https://groups.io/mt/93377589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
Patch1 and patch2 have been merged: https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee96f462676e7 https://github.com/tianocore/edk2/commit/31a94f7fba2a2c1244fc35b6f631e235e267715b Rest of the patches will be merged later. Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, August 9, 2022 5:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916 > > Add FSP 2.4 MultiPhase interfaces and implementation. > > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > > V2: > . Add FspMultiPhasePlatformGetNumberOfPhases() and > FspWrapperPlatformMultiPhaseHandler() to support platform porting. > > . Add FSP reset support in FspWrapperVariableRequestHandler() > > . Fix bug that wrong parameter given when calling > FspWrapperVariableRequestHandler() > > . Corrected code comments. > > Chasel Chiu (4): > IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface. > IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface. > IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions. > IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers. > > IntelFsp2Pkg/FspSecCore/SecFsp.c > | 4 > IntelFsp2Pkg/FspSecCore/SecFspApiChk.c > | 9 + > IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c > | 184 > + > + > ++ > IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c > | 30 ++ > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > | 33 + > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > | 27 +-- > > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/Fs > pWrapperPlatformMultiPhaseLibSample.c | 49 > + > > IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapper > MultiPhaseProcessLib.c | 355 > + > + > + > + > + > ++ > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf > | 75 > + > ++ > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf > | 59 +++ > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > | 304 > + > + > + > + > > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm > | 101 > + > > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm > | 3 +++ > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > | 303 > + > + > + > + > +++ > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm > | 108 > + > +++ > IntelFsp2Pkg/FspSecCore/X64/FspApiEntryCommon.nasm > | 3 +++ > IntelFsp2Pkg/Include/FspEas/FspApi.h > | 62 - > - > IntelFsp2Pkg/Include/FspGlobalData.h > | 5 - > IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h > | 54 ++ > IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > | 19 +++ > IntelFsp2Pkg/IntelFsp2Pkg.dec >| > 12 ++-- > IntelFsp2Pkg/IntelFsp2Pkg.dsc >| > 4 > IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf > | 50 ++ > IntelFsp2Pkg/Tools/SplitFspBin.py > | 48 +--- >
[edk2-devel] [PATCH] MdeModulePkg/CapsuleApp: support on-disk with undefined BootOrder
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4038
When BootOrder is not defined, CapsuleApp.efi will not find a file system
to store the capsule for on-disk update because GetUpdateFileSystem() will
fail.
BootOrder is an EFI Global Variable, which default state is firmware vendor
specific. It is possible for BootOrder to not be defined as mentioned in
the UEFI Specification in chapter 3.4.3, "Boot Option Variables Default
Boot Behavior".
Relax the check to allow that case.
Signed-off-by: Vincent Stehlé
---
Hi,
This has passed CI with pull request
https://github.com/tianocore/edk2/pull/3263.
Best regards,
Vincent.
MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
index 5ce5a50f7b..f04de00f65 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
@@ -456,10 +456,7 @@ GetUpdateFileSystem (
// 2. Get EFI system partition form boot options.
//
BootOptionBuffer = EfiBootManagerGetLoadOptions (,
LoadOptionTypeBoot);
- if ((BootOptionBuffer == NULL) ||
- ((BootOptionCount == 0) && (Map == NULL))
- )
- {
+ if ((BootOptionBuffer != NULL) && (BootOptionCount == 0) && (Map == NULL)) {
return EFI_NOT_FOUND;
}
--
2.35.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93011): https://edk2.groups.io/g/devel/message/93011
Mute This Topic: https://groups.io/mt/93376313/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 1/1] DynamicTablesPkg: Fix typo in AmlCodeGenRdMemory32Fixed doxygen comment
Fix typo of "Address". Signed-off-by: Rebecca Cran --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c index dafbd19fde15..32c3ab534d0b 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c @@ -619,7 +619,7 @@ AmlCodeGenRdDWordMemory ( See ACPI 6.4 spec, s19.2.8 for more. @param [in] IsReadWrite ReadAndWrite parameter. - @param [in] Addres AddressBase parameter. + @param [in] Address AddressBase parameter. @param [in] RangeLength Range length. @param [in] NameOpNode NameOp object node defining a named object. If provided, append the new resource data -- 2.30.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93010): https://edk2.groups.io/g/devel/message/93010 Mute This Topic: https://groups.io/mt/93374776/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - 09/01/2022 #cal-reminder
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* 09/01/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?subject=Re:%20Event:%20TianoCore%20edk2-test%20Bug%20Triage%20Meeting ) View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1621539 ) *Description:* -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93009): https://edk2.groups.io/g/devel/message/93009 Mute This Topic: https://groups.io/mt/93371494/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
Do you have a public branch somewhere I could pull this code from?
Much of the patch appears to have been mangled during sending, with extra blank
lines.
--
Rebecca Cran
On 8/31/22 01:51, RichardHo [何明忠] via groups.io wrote:
new file mode 100644
index 00..1c1a450920
--- /dev/null
+++ b/UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h
@@ -0,0 +1,872 @@
+/** @file
+ Header file contains code for USB Ethernet Protocol
+ definitions
+
+ Copyright (c) 2022, American Megatrends International LLC. All rights
reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#ifndef _USB_ETHERNET_PROTOCOL_H
+#define _USB_ETHERNET_PROTOCOL_H
+
+#define USB_ETHERNET_PROTOCOL_GUID \
+{0x8d8969cc, 0xfeb0, 0x4303, {0xb2, 0x1a, 0x1f, 0x11, 0x6f, 0x38, 0x56,
0x43}}
+
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93008): https://edk2.groups.io/g/devel/message/93008
Mute This Topic: https://groups.io/mt/93121092/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
A lot of the patch appears to have been mangled, with extra blank lines (I've snipped an example below). Did you send it with "git send-email"? If not, could you re-send it please? -- Rebecca Cran On 8/30/22 20:31, RichardHo [何明忠] via groups.io wrote: diff --git a/UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h b/UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h new file mode 100644 index 00..1c1a450920 --- /dev/null +++ b/UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h @@ -0,0 +1,872 @@ +/** @file + Header file contains code for USB Ethernet Protocol + definitions + + Copyright (c) 2022, American Megatrends International LLC. All rights reserved. + SPDX-License-Identifier: BSD-2-Clause-Patent -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93007): https://edk2.groups.io/g/devel/message/93007 Mute This Topic: https://groups.io/mt/93121092/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
Richard: Thanks for your contribution. This is new feature. Can you submit feature request to https://bugzilla.tianocore.org/? If you have no account in https://bugzilla.tianocore.org/, you can ask help for 'Demeter, Miki' . For the code, what's the purpose of UsbNetworkPkg/NetworkCommon/PxeFunction.c? Does NetworkCommon support PXE? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 RichardHo > [何明忠] via groups.io > 发送时间: 2022年8月31日 10:31 > 收件人: devel@edk2.groups.io > 抄送: Andrew Fish ; Leif Lindholm > ; Michael D Kinney > ; Michael Kubacki > ; Leif Lindholm ; > Zhiguang Liu ; Liming Gao > ; Hao A Wu ; Ray Ni > ; TonyLo [�_金松] > 主题: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices > support > > UsbNetworkPkg provides network functions for USB ACM, USB NCM, > and USB RNDIS network device. > > Signed-off-by: Richard Ho > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Michael Kubacki > Cc: Leif Lindholm > Cc: Zhiguang Liu > Acked-by: Michael D Kinney > Acked-by: Liming Gao > Acked-by: Leif Lindholm > Reviewed-by: Hao A Wu > Reviewed-by: Ray Ni > Reviewed-by: Tony Lo > --- > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc|9 + > .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 + > .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 21 + > .../Config/UsbNetworkPkgDefines.inc.dsc | 23 + > .../Include/Protocol/UsbEthernetProtocol.h| 872 + > UsbNetworkPkg/NetworkCommon/ComponentName.c | 264 +++ > UsbNetworkPkg/NetworkCommon/DriverBinding.c | 583 ++ > UsbNetworkPkg/NetworkCommon/DriverBinding.h | 263 +++ > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 43 + > UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1734 > + > UsbNetworkPkg/ReadMe.md | 65 + > UsbNetworkPkg/ReleaseNotes.md | 11 + > UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 ++ > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c | 504 + > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h | 211 ++ > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf | 41 + > UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c | 861 > UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170 ++ > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c | 508 + > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h | 245 +++ > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf | 41 + > UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c | 946 + > UsbNetworkPkg/UsbNetworkPkg.dec | 32 + > UsbNetworkPkg/UsbRndis/ComponentName.c| 172 ++ > UsbNetworkPkg/UsbRndis/UsbRndis.c | 848 > UsbNetworkPkg/UsbRndis/UsbRndis.h | 569 ++ > UsbNetworkPkg/UsbRndis/UsbRndis.inf | 41 + > UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1587 > +++ > 28 files changed, 10854 insertions(+) > create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc > create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc > create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf > create mode 100644 > UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc > create mode 100644 > UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h > create mode 100644 > UsbNetworkPkg/NetworkCommon/ComponentName.c > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h > create mode 100644 > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf > create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c > create mode 100644 UsbNetworkPkg/ReadMe.md > create mode 100644 UsbNetworkPkg/ReleaseNotes.md > create mode 100644 UsbNetworkPkg/UsbCdcEcm/ComponentName.c > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c > create mode 100644 UsbNetworkPkg/UsbCdcNcm/ComponentName.c > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c > create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec > create mode 100644 UsbNetworkPkg/UsbRndis/ComponentName.c > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.inf > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93006): https://edk2.groups.io/g/devel/message/93006 Mute This Topic: https://groups.io/mt/93367418/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub
Re: 回复: [edk2-devel] 回复: [PATCH EDK2 v1 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
Hi, Liming:
This patch didn't pass CI because it had a format problem. I had run
Uncrustify locally to fixed it and sent a new patch in 8/18.
Thanks
Wenyi
On 2022/8/17 15:34, gaoliming wrote:
> Weiyi:
> This patch doesn't pass CI. Please check
> https://github.com/tianocore/edk2/pull/3208
>
>> -邮件原件-
>> 发件人: devel@edk2.groups.io 代表 gaoliming via
>> groups.io
>> 发送时间: 2022年8月12日 12:53
>> 收件人: 'Wenyi Xie' ; devel@edk2.groups.io;
>> jian.j.w...@intel.com; zhichao@intel.com; ray...@intel.com
>> 抄送: songdongku...@huawei.com
>> 主题: [edk2-devel] 回复: [PATCH EDK2 v1 1/1]
>> MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
>>
>> Agree this fix to add the check for this case. Reviewed-by: Liming Gao
>>
>>
>> Thanks
>> Liming
>>> -邮件原件-
>>> 发件人: Wenyi Xie
>>> 发送时间: 2022年8月11日 16:32
>>> 收件人: devel@edk2.groups.io; jian.j.w...@intel.com;
>>> gaolim...@byosoft.com.cn; zhichao@intel.com; ray...@intel.com
>>> 抄送: songdongku...@huawei.com; xiewen...@huawei.com
>>> 主题: [PATCH EDK2 v1 1/1] MdeModulePkg/BaseBmpSupportLib: Fix
>>> ColorMap issue
>>>
>>> When BitPerPixel is 1,4,8, there should be a color map in bmp file. But
> if
>>> the format of bmp file is error, it maybe has no color map when
>> BitPerPixel
>>> is 1,4,8. The condition checking now can not catch this issue.
>>>
>>> Cc: Jian J Wang
>>> Cc: Liming Gao
>>> Cc: Zhichao Gao
>>> Cc: Ray Ni
>>> Signed-off-by: Wenyi Xie
>>> ---
>>> MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 5 +
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
>>> b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
>>> index c5e885d7a6d5..bea89d530de6 100644
>>> --- a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
>>> +++ b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
>>> @@ -236,6 +236,11 @@ TranslateBmpToGopBlt (
>>> return RETURN_UNSUPPORTED;
>>>}
>>>
>>> + if ((BmpHeader->ImageOffset == sizeof (BMP_IMAGE_HEADER)) &&
>>> + ((BmpHeader->BitPerPixel & 0x0D) != 0)) {
>>> +return RETURN_UNSUPPORTED;
>>> + }
>>> +
>>>if (BmpHeader->ImageOffset > sizeof (BMP_IMAGE_HEADER)) {
>>> switch (BmpHeader->BitPerPixel) {
>>>case 1:
>>> --
>>> 2.20.1.windows.1
>>
>>
>>
>>
>>
>>
>>
>
>
>
> .
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93005): https://edk2.groups.io/g/devel/message/93005
Mute This Topic: https://groups.io/mt/93076276/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] BaseTools: Support COMPAT16 section generation
In my free time I learn UEFI/edk2. I've noticed that there are not
many lessons about edk2 programming, so I've decided to write my own:
https://github.com/Kostr/UEFI-Lessons
I've found this issue while I was writing a lesson about file
sections. I've just tried to work with every possible section type and
have noticed problems with some cases, including COMPAT16.
Just in case the draft for this lesson is here
https://github.com/Kostr/UEFI-Lessons/blob/master/Lessons_uncategorized/Lesson_FDF_FV_3/README.md
On Wed, Aug 31, 2022 at 4:42 AM gaoliming wrote:
>
> Aladyshev:
> The change is good. Reviewed-by: Liming Gao
>
> Besides, how do you find this issue? Have you such test case or usage?
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Konstantin
> > Aladyshev
> > 发送时间: 2022年8月30日 18:20
> > 收件人: devel@edk2.groups.io
> > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> > yuwei.c...@intel.com; Konstantin Aladyshev
> > 主题: [edk2-devel] [PATCH v2] BaseTools: Support COMPAT16 section
> > generation
> >
> > Currently COMPAT16 section type is not recognized and GenSec is called
> > without the "-s [SectionType]" argument.
> > Add COMPAT16 type to the SectionType dictionary to fix the issue.
> >
> > Now this syntax works correctly:
> > ```
> > FILE FREEFORM = {
> > SECTION COMPAT16 =
> > }
> > ```
> >
> > Signed-off-by: Konstantin Aladyshev
> > ---
> > BaseTools/Source/Python/GenFds/Section.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Source/Python/GenFds/Section.py
> > b/BaseTools/Source/Python/GenFds/Section.py
> > index 447828c8e5..859db7230a 100644
> > --- a/BaseTools/Source/Python/GenFds/Section.py
> > +++ b/BaseTools/Source/Python/GenFds/Section.py
> > @@ -28,6 +28,7 @@ class Section (SectionClassObject):
> > BINARY_FILE_TYPE_PIC : 'EFI_SECTION_PIC',
> >
> > BINARY_FILE_TYPE_TE: 'EFI_SECTION_TE',
> >
> > 'FV_IMAGE' : 'EFI_SECTION_FIRMWARE_VOLUME_IMAGE',
> >
> > +'COMPAT16' : 'EFI_SECTION_COMPATIBILITY16',
> >
> > BINARY_FILE_TYPE_DXE_DEPEX : 'EFI_SECTION_DXE_DEPEX',
> >
> > BINARY_FILE_TYPE_PEI_DEPEX : 'EFI_SECTION_PEI_DEPEX',
> >
> > 'GUIDED': 'EFI_SECTION_GUID_DEFINED',
> >
> > --
> > 2.25.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#92976): https://edk2.groups.io/g/devel/message/92976
> > Mute This Topic: https://groups.io/mt/93345713/4905953
> > Group Owner: devel+ow...@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaolim...@byosoft.com.cn]
> > -=-=-=-=-=-=
> >
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93003): https://edk2.groups.io/g/devel/message/93003
Mute This Topic: https://groups.io/mt/93366218/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
