回复: Re: [edk2-devel] Is DEBUG output function safe for MP case?

2024-06-03 Thread Jeff Fan via groups.io 
As Andrew mentioned, DEBUG() is NOT safe for MP. 

Generally, kernel modules are not suggested to use DEBUG() in AP code becasue 
they are not the decision maker on the final DebuLib instance.
If you could make sure the DebugLib instance platform selected only based on 
I/O or MMIO operations, you could use DEBUG() in AP for debuging or testing 
purpose.
To avoid mess output message due to multiple APs, you may use spinlock to 
protect DEBUG() invoking.

For runtime (for example SMM AP code),  the upper method may not work becaseu 
OS may take control on Serial Port.  




fanjianf...@byosoft.com.cn
 
发件人： Yoshinoya
发送时间： 2024-06-03 16:24
收件人： devel; fanjianfeng
主题： Re:回复: [edk2-devel] Is DEBUG output function safe for MP case?
Hi, Jeff:
If AP code use base-typed debuglib, then it's mp safe?

Thanks





At 2024-05-31 14:33:40, "Jeff Fan via groups.io" 
 wrote:
AP cannot run any UEFI Service. Please make sure AP code use base-typed 
DebugLib instance (Such as BaseDebugLibSerialport.inf from MdePkg)




fanjianf...@byosoft.com.cn
 
发件人： Yoshinoya
发送时间： 2024-05-31 14:22
收件人： devel@edk2.groups.io
主题： [edk2-devel] Is DEBUG output function safe for MP case?
Hello
I ask for help for debug output in multi-core case.

Is the current DEBUG marco safe for AP Cores to output message?
If the output message is too long, it takes too much time, will it cause some 
abnormal exception?

Thanks



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119441): https://edk2.groups.io/g/devel/message/119441
Mute This Topic: https://groups.io/mt/106475080/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, June 3, 2024 #cal-notice

2024-06-03 Thread Group Notification 
*Tools, CI, Code base construction meeting series*

*When:*
Monday, June 3, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2159801 )

*Description:*

TianoCore community,

Microsoft and Intel will be hosting a series of open meetings to discuss build, 
CI, tools, and other related topics. If you are interested, have ideas/opinions 
please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft 
Teams.

MS Teams Link in following discussion: * 
https://github.com/tianocore/edk2/discussions/2614

Anyone is welcome to join.

* tianocore/edk2: EDK II (github.com)
* tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module 
(github.com) https://github.com/tianocore/edk2-basetools
* tianocore/edk2-pytool-extensions: Extensions to the edk2 build system 
allowing for a more robust and plugin based build system and tool execution 
environment (github.com) https://github.com/tianocore/edk2-pytool-extensions
* tianocore/edk2-pytool-library: Python library package that supports UEFI 
development (github.com) https://github.com/tianocore/edk2-pytool-library

MS Teams Browser Clients * 
https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119440): https://edk2.groups.io/g/devel/message/119440
Mute This Topic: https://groups.io/mt/106473451/21656
Mute #cal-notice:https://edk2.groups.io/g/devel/mutehashtag/cal-notice
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 3, 2024 #cal-reminder

2024-06-03 Thread Group Notification 
*Reminder: Tools, CI, Code base construction meeting series*

*When:*
Monday, June 3, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2159801 )

*Description:*

TianoCore community,

Microsoft and Intel will be hosting a series of open meetings to discuss build, 
CI, tools, and other related topics. If you are interested, have ideas/opinions 
please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft 
Teams.

MS Teams Link in following discussion: * 
https://github.com/tianocore/edk2/discussions/2614

Anyone is welcome to join.

* tianocore/edk2: EDK II (github.com)
* tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module 
(github.com) https://github.com/tianocore/edk2-basetools
* tianocore/edk2-pytool-extensions: Extensions to the edk2 build system 
allowing for a more robust and plugin based build system and tool execution 
environment (github.com) https://github.com/tianocore/edk2-pytool-extensions
* tianocore/edk2-pytool-library: Python library package that supports UEFI 
development (github.com) https://github.com/tianocore/edk2-pytool-library

MS Teams Browser Clients * 
https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119439): https://edk2.groups.io/g/devel/message/119439
Mute This Topic: https://groups.io/mt/106453021/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB

2024-06-03 Thread Witt, Sebastian via groups.io 

Fix calculation of first section in FileFindSection for FILE2 headers in 
UefiPayloadEntry module.

Signed-of-by: Sebastian Witt 
---
 UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c 
b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
index 898d610951..9cb6edefcf 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
@@ -211,13 +211,14 @@ FileFindSection (
 
   if (IS_FFS_FILE2 (FileHeader)) {
 FileSize = FFS_FILE2_SIZE (FileHeader);
+Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 
*)FileHeader) + 1);
   } else {
 FileSize = FFS_FILE_SIZE (FileHeader);
+Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
   }
 
   FileSize -= sizeof (EFI_FFS_FILE_HEADER);
 
-  Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
   Index   = 0;
   while (Index < FileSize) {
 if (Section->Type == SectionType) {
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119435): https://edk2.groups.io/g/devel/message/119435
Mute This Topic: https://groups.io/mt/106471262/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] CryptoPkg: Fix BaseCryptLib CrtWrapper strcpy

2024-06-03 Thread Witt, Sebastian via groups.io 

strcpy fails when strSource is closer than 4096 bytes after strDest.

This is caused by an overlap check in AsciiStrCpyS:
  //
  // 5. Copying shall not take place between objects that overlap.
  //
  SAFE_STRING_CONSTRAINT_CHECK (InternalSafeStringNoAsciiStrOverlap 
(Destination, DestMax, (CHAR8 *)Source, SourceLen + 1), RETURN_ACCESS_DENIED);

Since DestMax is MAX_STRING_SIZE (0x1000) and with a Source
that is in this area behind Destination, AsciiStrCpyS will fail
and strcpy will do nothing.

When called by CRYPTO_strdup in openssl this leads to uninitialzed
memory that gets accessed instead of the copied string.

Signed-of-by: Sebastian Witt 
---
 CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c 
b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
index 37cdecc9bd..880ed140fd 100644
--- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
+++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
@@ -271,7 +271,7 @@ strcpy (
   const char  *strSource
   )
 {
-  AsciiStrCpyS (strDest, MAX_STRING_SIZE, strSource);
+  AsciiStrCpyS (strDest, AsciiStrnSizeS (strSource, MAX_STRING_SIZE), 
strSource);
   return strDest;
 }
 
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119436): https://edk2.groups.io/g/devel/message/119436
Mute This Topic: https://groups.io/mt/106471263/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path

2024-06-03 Thread Prachotan Bathi 
Worked on the following protocols’ test cases as we have seen PCIe card UEFI 
driver related failures with these test cases:
EFI_HII_CONFIG_ACCESS_PROTOCOL
EFI_ADAPTER_INFORMATION_PROTOCOL
EFI_SIMPLE_NETWORK_PROTOCOL
EFI_PXE_BASE_CODE_PROTOCOL
Output of a failed PCIe test

Auto Conformance Test for Arp



Logfile: "\EFI\BOOT\bbr\SCT\Overall\Summary.log"

Test Started: 02/16/23  05:04p



EFI_PXE_BASE_CODE_PROTOCOL.Start - Check Return Code -- FAILURE

6A8CAA83-B9DA-46C7-98F6-D4969DABDAA0

/home/cherat01/ATEG/SystemReady/SystemReady/arm-systemready/SR/scripts/edk2-test/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestConformance.c:2140:Status
 - Unsupported

 

Returned Status Code: Unsupported

 

Arp_Conf: [FAILED]

  Passes... 0

  Warnings. 0

  Errors... 1

 

We want to see message like COMPONENT_NAME2_PROTOCOL test case having the 
message in red to show what device/driver was tested.



Conformance Test for GetControllerName



Logfile: "\EFI\BOOT\bbr\SCT\Overall\Summary.log"

Test Started: 02/16/23  05:14p



Device Path: 
Fv(5C60F367-A505-419A-859E-2A4FF6CA6FE5)/FvFile(F2AD0AD0-D4B6-11E3-9C1A-0800200C9A66)

 

COMPONENT_NAME2_PROTOCOL.GetControllerName - GetControllerName() returns 
EFI_INVALID_PARAMETER with a NULL ControllerHandle -- FAILURE

C38A85AF-2D0A-4BFA-8F44-A247F1FD7B94

/home/cherat01/ATEG/SystemReady/SystemReady/arm-systemready/SR/scripts/edk2-test/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ComponentName2/BlackBoxTest/ComponentName2BBTestConformance.c:551:
 Language - en, Status - Success, NULL


Found the device path from the protocol handle. Used 
SctDevicePathToStr(DevicePath) to print as str.
Tested on rpi and AADP systems.
https://github.com/PrachotanReddy/edk2-test

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Supreeth Venkatesh 

Prachotan Bathi (1):
  EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path for 
PCIe card/device related SCT failures.

 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoProtocolBBTest.inf
  |2 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBBTest.inf
  |3 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTest.inf
  |4 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestMain.h
|   17 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|6 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestMain.h
|6 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestMain.h
|6 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
 |   63 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestMain.c
|   96 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestConformance.c
 |   48 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.c
|   67 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestConformance.c
 |  305 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestMain.c
| 1158 +---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestConformance.c
 |  258 -
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestMain.c
|   96 ++
 15 files changed, 1451 insertions(+), 684 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119438): https://edk2.groups.io/g/devel/message/119438
Mute This Topic: https://groups.io/mt/106471265/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-03 Thread Michael D Kinney 
The reason to allow a draft PR is to allow contributors to run all the
CI tests to see if they pass and resolve issues before starting a review.

The CI tests include combinations of OS/compiler that not all contributors
have available.

Mike

> -Original Message-
> From: Neal Gompa 
> Sent: Monday, June 3, 2024 11:47 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> Hmm, I don't see a setting for it anymore, maybe that's not a thing anymore?
> 
> I seemingly recall that draft PRs didn't get CI runs, but if that's
> not a thing anymore, then that's fine.
> 
> That said, draft PRs cannot be reviewed, so we should not be telling
> people to make draft PRs.
> 
> 
> On Mon, Jun 3, 2024 at 12:26 PM Michael D Kinney via groups.io
> 
>  wrote:
> >
> > CI jobs are dispatched to both GitHub Actions and Azure Pipelines.
> >
> > For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running.
> >
> > This must imply that edk2 repo allows this.  Do you happen to know where
> > this is configurable or a link to GitHub docs for configuration?
> >
> > Mike
> >
> > > -Original Message-
> > > From: Neal Gompa 
> > > Sent: Monday, June 3, 2024 9:13 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D 
> > > Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> > >
> > > On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
> > >  wrote:
> > > >
> > > > Hello,
> > > >
> > > > The GitHub PR code review process is now active.  Please
> > > > use the new PR based code review process for all new
> > > > submissions starting today.
> > > >
> > > > * The Wiki has been updated with the process changes.
> > > >
> > > >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> Development-
> > > Process
> > > >
> > > >   Big thanks to Michael Kubacki for writing up all the
> > > >   changes based on the RFC proposal and community discussions.
> > > >
> > > >   We will learn by using, so if you see anything missing or
> > > >   incorrect or clarifications needed, please send feedback
> > > >   here so the Wiki pages can be updated quickly for everyone.
> > > >
> > > > * The edk2 repo settings have been updated to require
> > > >   a GitHub PR code review approval before merging and
> > > >   all conversations must be resolved before merging.
> > > >
> > > > * A PR has been opened that removes the requirement for
> > > >   Cc: tags in the commit messages and is the first PR
> > > >   that will use the new process. This PR needs to be
> > > >   reviewed and merged to support the revised commit
> > > >   message format.
> > > >
> > > >   https://github.com/tianocore/edk2/pull/5688
> > > >
> > > >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> > > Format
> > > >
> > > > * Please use "Draft" PRs to run CI without any reviews.
> > > >   Once ready for reviews, convert from "Draft" to
> > > >   "Ready for Review".
> > > >
> > >
> > > Generally GitHub doesn't allow CI to run on PRs created as draft pull
> > > requests. Was this changed for edk2?
> > >
> > >
> > > --
> > > 真実はいつも一つ！/ Always, there's only one truth!
> >
> >
> > 
> >
> >
> 
> 
> --
> 真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119434): https://edk2.groups.io/g/devel/message/119434
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-03 Thread Neal Gompa 
Hmm, I don't see a setting for it anymore, maybe that's not a thing anymore?

I seemingly recall that draft PRs didn't get CI runs, but if that's
not a thing anymore, then that's fine.

That said, draft PRs cannot be reviewed, so we should not be telling
people to make draft PRs.


On Mon, Jun 3, 2024 at 12:26 PM Michael D Kinney via groups.io

 wrote:
>
> CI jobs are dispatched to both GitHub Actions and Azure Pipelines.
>
> For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running.
>
> This must imply that edk2 repo allows this.  Do you happen to know where
> this is configurable or a link to GitHub docs for configuration?
>
> Mike
>
> > -Original Message-
> > From: Neal Gompa 
> > Sent: Monday, June 3, 2024 9:13 AM
> > To: devel@edk2.groups.io; Kinney, Michael D 
> > Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> >
> > On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
> >  wrote:
> > >
> > > Hello,
> > >
> > > The GitHub PR code review process is now active.  Please
> > > use the new PR based code review process for all new
> > > submissions starting today.
> > >
> > > * The Wiki has been updated with the process changes.
> > >
> > >   
> > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> > Process
> > >
> > >   Big thanks to Michael Kubacki for writing up all the
> > >   changes based on the RFC proposal and community discussions.
> > >
> > >   We will learn by using, so if you see anything missing or
> > >   incorrect or clarifications needed, please send feedback
> > >   here so the Wiki pages can be updated quickly for everyone.
> > >
> > > * The edk2 repo settings have been updated to require
> > >   a GitHub PR code review approval before merging and
> > >   all conversations must be resolved before merging.
> > >
> > > * A PR has been opened that removes the requirement for
> > >   Cc: tags in the commit messages and is the first PR
> > >   that will use the new process. This PR needs to be
> > >   reviewed and merged to support the revised commit
> > >   message format.
> > >
> > >   https://github.com/tianocore/edk2/pull/5688
> > >
> > >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> > Format
> > >
> > > * Please use "Draft" PRs to run CI without any reviews.
> > >   Once ready for reviews, convert from "Draft" to
> > >   "Ready for Review".
> > >
> >
> > Generally GitHub doesn't allow CI to run on PRs created as draft pull
> > requests. Was this changed for edk2?
> >
> >
> > --
> > 真実はいつも一つ！/ Always, there's only one truth!
>
>
> 
>
>


--
真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119433): https://edk2.groups.io/g/devel/message/119433
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 3, 2024 #cal-reminder

2024-06-03 Thread Sean 

confirming this meeting will be held today.

Topics and agenda posted: Tools and CI Meeting - Date 6/3 · 
tianocore/edk2 · Discussion #5723 (github.com) 



Add additional agenda topics to the github discussion.

Thanks

Sean



On 6/2/2024 4:30 PM, Group Notification wrote:


*Reminder: Tools, CI, Code base construction meeting series*

*When:*
Monday, June 3, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d 



View Event 

*Description:*

TianoCore community,

Microsoft and Intel will be hosting a series of open meetings to 
discuss build, CI, tools, and other related topics. If you are 
interested, have ideas/opinions please join us. These meetings will be 
Monday 4:30pm Pacific Time on Microsoft Teams.


MS Teams Link in following discussion: * 
https://github.com/tianocore/edk2/discussions/2614


Anyone is welcome to join.

  * tianocore/edk2: EDK II (github.com)
  * tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP
module (github.com) https://github.com/tianocore/edk2-basetools
  * tianocore/edk2-pytool-extensions: Extensions to the edk2 build
system allowing for a more robust and plugin based build system
and tool execution environment (github.com)
https://github.com/tianocore/edk2-pytool-extensions
  * tianocore/edk2-pytool-library: Python library package that
supports UEFI development (github.com)
https://github.com/tianocore/edk2-pytool-library

MS Teams Browser Clients * 
https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119432): https://edk2.groups.io/g/devel/message/119432
Mute This Topic: https://groups.io/mt/106453021/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmCallSmc() and SMCCC specification

2024-06-03 Thread Leif Lindholm 

Hi Marcin.

A few high-level thoughs below.

On 2024-05-31 08:14, Marcin Juszkiewicz wrote:

EDK2/ArmPkg/Library/ArmSmcLib has code to do SMC calls.

There are ArmCallSmc[0-3]() functions for up to 3 arguments/results and 
ArmCallSmc() function which can use 7 arguments and get 4 results back.


This implementation looks like version B (Nov 2016) of SMCCC 
specification [1] with one more register used.


1. https://developer.arm.com/documentation/den0028/b/

In 2020 we got version C of spec (and then D, E, F) which allows to use 
more registers:


 > Allow R4—R7 (SMC32/HVC32) to be used as result registers.
 > Allow X8—X17 to be used as parameter registers in SMC64/HVC64.
 > Allow X4—X17 to be used as result registers in SMC64/HVC64.

And I started to wonder how to update EDK2 to newer version of SMCCC 
spec as one of in-progress QemuSbsa SMC calls may return more than 4 
values.


Yes, definitely. This has been a wishlist item for some time, but in 
reality we've only ever updated these when we needed new functionality.


ARM_SMC_ARGS in ArmSmcLib.h can be expanded to handle up to Arg17 in an 
easy way and guarded by "#if defined(__aarch64__)" to not change it on 
Arm32.


Then ArmCallSmc() in {AArch64,Arm}/ArmSmc.S needs changes. But here it 
gets tricky.


On Arm we preserve r4-r8 and restore them after call like spec says. 
Which we do not do on AArch64 as version B of spec did not required that 
(and this changed in version C).


If we start handling more than 4 results then we need to know how many 
results are expected and restore rest of r4-r7/x4-x17 registers:


Yeah, it feels like we may want to add a version field or/and number of 
registers to save/restore to a new struct. And we should definitely 
align Arm/AArch64 behaviour.


 From what I saw in both edk2/ and edk2-platforms/ most of code uses 
ArmCallSmc() function with ARM_SMC_ARGS structure populared with 
arguments. ArmCallSmc[0-3]() are used by Smbios, Psci and QemuSbsa code 
only.


The ArmCallSmc[0-3] helpers were only added as shorthand for most common 
cases. I don't think we should worry about how those work for making any 
design decisions. Everything they do can be described by the main 
ArmCallSmc functions and a few lines of struct stuffing.



Now the question is: how to handle change?


It could be that it would be easiest to add a new call function, and 
maybe even ra new egister struct, than trying to adapt the existing ones 
in ways that doesn't break existing users?


That is if we care about existing users. We could always modify it to 
guarantee breakage and expect users to update their code. Since this is 
a library, and not a protocol, we *mostly* don't need to worry about 
users mixing prebuilt binaries using old structs with new functions.


We could add ArmCallSmc[4-17] but that name only tells how many 
arguments we pass to SMC call, not how many results we expect. Or should 
we add NumberOfResults argument to ArmCallSmc() to know which registers 
we should preserve and which are results? And how complicated this 
assembly function will become?


I don't think the assembly function needs to be that complicated. It'd 
be a bit tedious with a bunch of tests, but...


/
Leif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119431): https://edk2.groups.io/g/devel/message/119431
Mute This Topic: https://groups.io/mt/106403741/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-03 Thread Michael D Kinney 
CI jobs are dispatched to both GitHub Actions and Azure Pipelines.

For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running.

This must imply that edk2 repo allows this.  Do you happen to know where
this is configurable or a link to GitHub docs for configuration?

Mike

> -Original Message-
> From: Neal Gompa 
> Sent: Monday, June 3, 2024 9:13 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
>  wrote:
> >
> > Hello,
> >
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> Process
> >
> >   Big thanks to Michael Kubacki for writing up all the
> >   changes based on the RFC proposal and community discussions.
> >
> >   We will learn by using, so if you see anything missing or
> >   incorrect or clarifications needed, please send feedback
> >   here so the Wiki pages can be updated quickly for everyone.
> >
> > * The edk2 repo settings have been updated to require
> >   a GitHub PR code review approval before merging and
> >   all conversations must be resolved before merging.
> >
> > * A PR has been opened that removes the requirement for
> >   Cc: tags in the commit messages and is the first PR
> >   that will use the new process. This PR needs to be
> >   reviewed and merged to support the revised commit
> >   message format.
> >
> >   https://github.com/tianocore/edk2/pull/5688
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> Format
> >
> > * Please use "Draft" PRs to run CI without any reviews.
> >   Once ready for reviews, convert from "Draft" to
> >   "Ready for Review".
> >
> 
> Generally GitHub doesn't allow CI to run on PRs created as draft pull
> requests. Was this changed for edk2?
> 
> 
> --
> 真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119430): https://edk2.groups.io/g/devel/message/119430
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-03 Thread Neal Gompa 
On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
 wrote:
>
> Hello,
>
> The GitHub PR code review process is now active.  Please
> use the new PR based code review process for all new
> submissions starting today.
>
> * The Wiki has been updated with the process changes.
>
>   
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
>   Big thanks to Michael Kubacki for writing up all the
>   changes based on the RFC proposal and community discussions.
>
>   We will learn by using, so if you see anything missing or
>   incorrect or clarifications needed, please send feedback
>   here so the Wiki pages can be updated quickly for everyone.
>
> * The edk2 repo settings have been updated to require
>   a GitHub PR code review approval before merging and
>   all conversations must be resolved before merging.
>
> * A PR has been opened that removes the requirement for
>   Cc: tags in the commit messages and is the first PR
>   that will use the new process. This PR needs to be
>   reviewed and merged to support the revised commit
>   message format.
>
>   https://github.com/tianocore/edk2/pull/5688
>
>   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
>
> * Please use "Draft" PRs to run CI without any reviews.
>   Once ready for reviews, convert from "Draft" to
>   "Ready for Review".
>

Generally GitHub doesn't allow CI to run on PRs created as draft pull
requests. Was this changed for edk2?


-- 
真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119429): https://edk2.groups.io/g/devel/message/119429
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-06-03 Thread PierreGondois 

Hello,
Just a ping in case this was left aside and as the patch-set (+ Leif's initial
patch) are a prerequisite to enable arm64 native instruction support for the
openssllib, which would also allow to use openssl's DRBG,

Regards,
Pierre

On 3/14/24 15:51, Pierre Gondois wrote:

v2:
- Move files to MdePkg/Include/Register/ instead of  MdePkg/Include/

This patch relies on [1].

Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
move the Chipset/* files to the MdePkg as the Armlib.h relies on
them.

These patches span over multiple packages as these Chipset/* files
are relocated to a new directory and include paths must be updated.

[1] https://edk2.groups.io/g/devel/message/111566

Cc: Ard Biesheuvel 
Cc: Gerd Hoffmann 
Cc: Jiewen Yao 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Michael D Kinney 
Cc: Pierre Gondois 
Cc: Sami Mujawar 
Cc: Zhiguang Liu 

Pierre Gondois (2):
   ArmPkg,MdePkg: Move ArmPkg/Chipset/AArch64[|Mmu].h to MdePkg
   ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg

  ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
  ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
  ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
  ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
  ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
  ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
  ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
  ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
  ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
  ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
  ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
  ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
  ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
  ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
  ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
  MdePkg/Include/Library/ArmLib.h   | 4 ++--
  .../Chipset => MdePkg/Include/Register/AArch64}/AArch64.h | 2 +-
  .../Chipset => MdePkg/Include/Register/AArch64}/AArch64Mmu.h  | 0
  .../Chipset/ArmV7.h => MdePkg/Include/Register/Arm/AArch32.h  | 2 +-
  .../ArmV7Mmu.h => MdePkg/Include/Register/Arm/AArch32Mmu.h| 0
  20 files changed, 19 insertions(+), 19 deletions(-)
  rename {ArmPkg/Include/Chipset => MdePkg/Include/Register/AArch64}/AArch64.h 
(94%)
  rename {ArmPkg/Include/Chipset => 
MdePkg/Include/Register/AArch64}/AArch64Mmu.h (100%)
  rename ArmPkg/Include/Chipset/ArmV7.h => 
MdePkg/Include/Register/Arm/AArch32.h (94%)
  rename ArmPkg/Include/Chipset/ArmV7Mmu.h => 
MdePkg/Include/Register/Arm/AArch32Mmu.h (100%)




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119428): https://edk2.groups.io/g/devel/message/119428
Mute This Topic: https://groups.io/mt/104927819/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-06-03 Thread Michael Kubacki 
As a follow up, I created the following PR to specify the exact version 
of queries to use for a given CodeQL CLI release. Now that both are 
explicitly specified (the CLI and the query version), there should not 
be any mismatch in the future where we're using an older CodeQL CLI 
against the latest (incompatible) queries.


https://github.com/tianocore/edk2/pull/5720

On 5/20/2024 9:40 PM, Michael Kubacki wrote:
Just wanted to send a reminder that I recommend 
https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for 
those that are currently trying to test changes.


Thanks,
Michael

On 5/17/2024 8:10 PM, Kinney, Michael D wrote:

Approved. I agree there is no impact to FW.

Mike


-Original Message-
From: Michael Kubacki 
Sent: Friday, May 17, 2024 4:28 PM
To: Kinney, Michael D ; 
devel@edk2.groups.io;
Andrew Fish ; Leif Lindholm 
;

Liming Gao 
Cc: Feng, Bob C ; Joey Vagedes
; Rebecca Cran ; Sean Brogan
; Chen, Christine 
Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

Forgot about the hard freeze.

Added remaining stewards to consider merging this. It has no impact on
firmware but is needed to unblock an immediate issue in CI where the
CodeQL queries being fetched are newer and incompatible with the CodeQL
CLI being used.

As I mentioned in the release notes, I will follow up in the future for
a change that should be able to lock the CodeQL query versions against
the CLI version.

Thanks,
Michael



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119427): https://edk2.groups.io/g/devel/message/119427
Mute This Topic: https://groups.io/mt/106161774/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 6/6] UefiPayloadPkg: Update UefiPayload driver for FDT support.

2024-06-03 Thread Dhaval Sharma 
BuildFitLoadablesFvHob:

   - Fdt variable is not initialized.
   - It ONLY gets initialized if GuidHob is found. What if it is not found?
   - FdtCheckHeader still evaluating it?


On Mon, Jun 3, 2024 at 7:49 AM Linus Liu  wrote:

> Add FDT detection and comsume FDT when needed.
> Move some x86 specific function in the x86 folder.
> Create HandOffHob via FDT memory node.
>
> Cc: Benny Lin 
> Cc: Gua Guo 
> Cc: Chasel Chiu 
> Cc: James Lu 
> Cc: Dhaval Sharma 
>
> Signed-off-by: Linus Liu 
> ---
>  UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c
>  | 428 +---
>  UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c
>  |  12 +
>  UefiPayloadPkg/UefiPayloadEntry/Ia32/{DxeLoadFunc.c => DxeLoadFuncFit.c}
> |  32 +-
>  UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c
>  |  50 +++
>  UefiPayloadPkg/UefiPayloadEntry/PrintHob.c
>  |   6 +-
>  UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> |   6 -
>  UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c
> |  12 +
>  UefiPayloadPkg/UefiPayloadEntry/X64/{DxeLoadFunc.c => DxeLoadFuncFit.c}
> |  31 +-
>  UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
>  |  20 +-
>  UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
>  |  68 
>  UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> |  16 +-
>  UefiPayloadPkg/UefiPayloadPkg.dsc
> |  29 +-
>  12 files changed, 443 insertions(+), 267 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c
> b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c
> index eb0b325369a0..813d656950d1 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c
> +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c
> @@ -6,6 +6,8 @@
>  #include "UefiPayloadEntry.h"
>  #include 
>  #include 
> +#include 
> +#include 
>
>  #define MEMORY_ATTRIBUTE_MASK  (EFI_RESOURCE_ATTRIBUTE_PRESENT
>  |\
>
> EFI_RESOURCE_ATTRIBUTE_INITIALIZED | \
> @@ -23,6 +25,15 @@
> EFI_RESOURCE_ATTRIBUTE_INITIALIZED
> | \
> EFI_RESOURCE_ATTRIBUTE_TESTED
> )
>
> +EFI_MEMORY_TYPE_INFORMATION  mDefaultMemoryTypeInformation[] = {
> +  { EfiACPIReclaimMemory,   FixedPcdGet32
> (PcdMemoryTypeEfiACPIReclaimMemory)   },
> +  { EfiACPIMemoryNVS,   FixedPcdGet32
> (PcdMemoryTypeEfiACPIMemoryNVS)   },
> +  { EfiReservedMemoryType,  FixedPcdGet32
> (PcdMemoryTypeEfiReservedMemoryType)  },
> +  { EfiRuntimeServicesData, FixedPcdGet32
> (PcdMemoryTypeEfiRuntimeServicesData) },
> +  { EfiRuntimeServicesCode, FixedPcdGet32
> (PcdMemoryTypeEfiRuntimeServicesCode) },
> +  { EfiMaxMemoryType,   0
>}
> +};
> +
>  extern VOID  *mHobList;
>
>  CHAR8  *mLineBuffer = NULL;
> @@ -36,6 +47,78 @@ PrintHob (
>IN CONST VOID  *HobStart
>);
>
> +/**
> +  Add HOB into HOB list
> +  @param[in]  HobThe HOB to be added into the HOB list.
> +**/
> +VOID
> +AddNewHob (
> +  IN EFI_PEI_HOB_POINTERS  *Hob
> +  );
> +
> +/**
> +  Found the Resource Descriptor HOB that contains a range (Base, Top)
> +  @param[in] HobListHob start address
> +  @param[in] Base   Memory start address
> +  @param[in] TopMemory end address.
> +  @retval The pointer to the Resource Descriptor HOB.
> +**/
> +EFI_HOB_RESOURCE_DESCRIPTOR *
> +FindResourceDescriptorByRange (
> +  IN VOID  *HobList,
> +  IN EFI_PHYSICAL_ADDRESS  Base,
> +  IN EFI_PHYSICAL_ADDRESS  Top
> +  );
> +
> +/**
> +  Find the highest below 4G memory resource descriptor, except the input
> Resource Descriptor.
> +  @param[in] HobList Hob start address
> +  @param[in] MinimalNeededSize   Minimal needed size.
> +  @param[in] ExceptResourceHob   Ignore this Resource Descriptor.
> +  @retval The pointer to the Resource Descriptor HOB.
> +**/
> +EFI_HOB_RESOURCE_DESCRIPTOR *
> +FindAnotherHighestBelow4GResourceDescriptor (
> +  IN VOID *HobList,
> +  IN UINTNMinimalNeededSize,
> +  IN EFI_HOB_RESOURCE_DESCRIPTOR  *ExceptResourceHob
> +  );
> +
> +/**
> +  Check the HOB and decide if it is need inside Payload
> +  Payload maintainer may make decision which HOB is need or needn't
> +  Then add the check logic in the function.
> +  @param[in] Hob The HOB to check
> +  @retval TRUE  If HOB is need inside Payload
> +  @retval FALSE If HOB is needn't inside Payload
> +**/
> +BOOLEAN
> +FitIsHobNeed (
> +  EFI_PEI_HOB_POINTERS  Hob
> +  );
> +
> +/**
> +  Check the HOB and decide if it is need inside Payload
> +
> +  Payload maintainer may make decision which HOB is need or needn't
> +  Then add the check logic in the function.
> +
> +  @param[in] Hob The HOB to check
> +
> +  @retval TRUE  If HOB is need inside Payload
> +  @retval FALSE If HOB is needn't inside Payload
> +**/
> +BOOLEAN
> +IsHobNeed (
> +  EFI_PEI_HOB_POINTERS  Hob
> +  );
> +
> +VOID
> +EFIAPI
> +ProcessLibraryConstructorList (
> +  VOID
> +  );
> +
>  /**

Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

2024-06-03 Thread Gerd Hoffmann 
  Hi,

> > I have a draft PR open with this fixed:
> > https://github.com/tianocore/edk2/pull/5696
> > 
> > Can you check this works for bhyve?
> 
> Works. Thanks!

Thanks for testing, flipped PR to 'Ready'.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119425): https://edk2.groups.io/g/devel/message/119425
Mute This Topic: https://groups.io/mt/104052591/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: 回复: [edk2-devel] Is DEBUG output function safe for MP case?

2024-06-03 Thread Yoshinoya 
Hi, Jeff:

If AP code use base-typed debuglib, then it's mp safe?




Thanks
















At 2024-05-31 14:33:40, "Jeff Fan via groups.io" 
 wrote:

AP cannot run any UEFI Service. Please make sure AP code use base-typed 
DebugLib instance (Such as BaseDebugLibSerialport.inf from MdePkg)




fanjianf...@byosoft.com.cn
 
发件人： Yoshinoya
发送时间： 2024-05-31 14:22
收件人： devel@edk2.groups.io
主题： [edk2-devel] Is DEBUG output function safe for MP case?
Hello
I ask for help for debug output in multi-core case.


Is the current DEBUG marco safe for AP Cores to output message?
If the output message is too long, it takes too much time, will it cause some 
abnormal exception?


Thanks


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119424): https://edk2.groups.io/g/devel/message/119424
Mute This Topic: https://groups.io/mt/106403392/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

2024-06-03 Thread Corvin Köhne 
On Thu, 2024-05-30 at 11:03 +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > > -    SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed,
> > > 0x06);
> > > +    SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed,
> > > MTRR_CACHE_WRITE_BACK);
> > >  ZeroMem (&MtrrSettings.Variables, sizeof
> > > MtrrSettings.Variables);
> > > -    MtrrSettings.MtrrDefType |= BIT11 | BIT10 | 6;
> > > +    MtrrSettings.MtrrDefType |= BIT10;
> > >  MtrrSetAllMtrrs (&MtrrSettings);
> > >  
> > >  //
> > 
> > This has to be changed for OvmfPkg/Bhyve/PlatformPei/MemDetect.c
> > too.
> 
> I have a draft PR open with this fixed:
>   https://github.com/tianocore/edk2/pull/5696
> 
> Can you check this works for bhyve?
> 
> thanks,
>   Gerd
> 

Works. Thanks!


-- 
Kind regards,
Corvin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119423): https://edk2.groups.io/g/devel/message/119423
Mute This Topic: https://groups.io/mt/104052591/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




signature.asc
Description: This is a digitally signed message part