Re: 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
Thanks you so much Liming.
Regards,
Praveen Sankar
-Original Message-
From: gaoliming
Sent: Friday, May 10, 2024 6:16 AM
To: devel@edk2.groups.io; Praveen Sankar N
Cc: Srinivasan Mani ; Sundaresan S ;
michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Rabisha R
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR
table Revision 4 structure
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
It has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Praveen Sankar N
> via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> 主题: Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
> Hi Liming,
> Pull request is done and pipelines are built successfully and
> the patch is ready to push to the master.
>
> Thanks,
> Praveen Sankar
>
> -Original Message-
> From: gaoliming
> Sent: Monday, May 6, 2024 7:53 AM
> To: Praveen Sankar N ; devel@edk2.groups.io
> Cc: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
>
> **CAUTION: The e-mail below is from an external source. Please
> exercise caution before opening attachments, clicking links, or
> following guidance.**
>
> Reviewed-by: Liming Gao
>
> > -邮件原件-
> > 发件人: Praveen Sankar N
> > 发送时间: 2024年5月2日 19:16
> > 收件人: devel@edk2.groups.io
> > 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> > Sundaresan S ; michael.d.kin...@intel.com;
> > zhiguang@intel.com; Felix Polyudov ; Rabisha R
> >
> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Revision 4, which has to be added in
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> >
> > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> >
> > Cc: michael.d.kin...@intel.com
> >
> > Cc: gaolim...@byosoft.com.cn
> >
> > Cc: zhiguang@intel.com
> >
> > Cc: fel...@ami.com
> >
> > Cc: srinivas...@ami.com
> >
> > Cc: sundares...@ami.com
> >
> > Cc: rabis...@ami.com
> > ---
> > .../SerialPortConsoleRedirectionTable.h | 32 +++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > index eb5ae28390..bf967880ab 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > @@ -23,6 +23,7 @@
> > ///
> >
> > #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
> >
> >
> >
> > +#define
> > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> > 0x04
> >
> > ///
> >
> > /// Serial Port Console Redirection Table Format
> >
> > ///
> >
> > @@ -50,6 +51,37 @@ typedef struct {
> >UINT32Reserved3;
> >
> > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > +///
> >
> > +/// Serial Port Console Redirection Table Format Revision 4
> >
> > +///
> >
> > +typedef struct {
> >
> > + EFI_ACPI_DESCRIPTION_HEADER Header;
> >
> > + UINT8 InterfaceType;
> >
> > + UINT8 Reserved1[3];
> >
> > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
> >
> > + UINT8 InterruptType;
> >
> > + UINT8 Irq;
> >
> > + UINT32
> > GlobalSystemInterrupt;
> >
> > + UINT8 BaudRate;
> >
> > + UINT8 Parity;
> >
> > + UINT8 StopBits;
> >
> > + UINT8
Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
Hi Liming,
Pull request is done and pipelines are built successfully and the patch
is ready to push to the master.
Thanks,
Praveen Sankar
-Original Message-
From: gaoliming
Sent: Monday, May 6, 2024 7:53 AM
To: Praveen Sankar N ; devel@edk2.groups.io
Cc: Srinivasan Mani ; Sundaresan S ;
michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Rabisha R
Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4
structure
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Praveen Sankar N
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> Sundaresan S ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Revision 4, which has to be added in
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
>
> Signed-off-by: Praveen Sankar N praveensank...@ami.com
>
> Cc: michael.d.kin...@intel.com
>
> Cc: gaolim...@byosoft.com.cn
>
> Cc: zhiguang@intel.com
>
> Cc: fel...@ami.com
>
> Cc: srinivas...@ami.com
>
> Cc: sundares...@ami.com
>
> Cc: rabis...@ami.com
> ---
> .../SerialPortConsoleRedirectionTable.h | 32 +++
> 1 file changed, 32 insertions(+)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..bf967880ab 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -23,6 +23,7 @@
> ///
>
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
>
>
>
> +#define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> 0x04
>
> ///
>
> /// Serial Port Console Redirection Table Format
>
> ///
>
> @@ -50,6 +51,37 @@ typedef struct {
>UINT32Reserved3;
>
> } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
> +///
>
> +/// Serial Port Console Redirection Table Format Revision 4
>
> +///
>
> +typedef struct {
>
> + EFI_ACPI_DESCRIPTION_HEADER Header;
>
> + UINT8 InterfaceType;
>
> + UINT8 Reserved1[3];
>
> + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
>
> + UINT8 InterruptType;
>
> + UINT8 Irq;
>
> + UINT32
> GlobalSystemInterrupt;
>
> + UINT8 BaudRate;
>
> + UINT8 Parity;
>
> + UINT8 StopBits;
>
> + UINT8 FlowControl;
>
> + UINT8 TerminalType;
>
> + UINT8 Reserved2;
>
> + UINT16PciDeviceId;
>
> + UINT16PciVendorId;
>
> + UINT8 PciBusNumber;
>
> + UINT8 PciDeviceNumber;
>
> + UINT8 PciFunctionNumber;
>
> + UINT32PciFlags;
>
> + UINT8 PciSegment;
>
> + UINT32UartClockFrequency;
>
> + UINT32PreciseBaudRate;
>
> + UINT16
> NameSpaceStrLength;
>
> + UINT16
> NameSpaceStrOffset;
>
> + CHAR8
> NameSpaceString[0];
>
> +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
> +
>
> #pragma pack()
>
>
>
> //
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at
Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
Liming,
Please refer the below link for reference to view the pipelines results.
https://github.com/tianocore/edk2/pull/5641
Thanks,
Praveen Sankar
-Original Message-
From: Praveen Sankar N
Sent: Thursday, May 9, 2024 12:03 PM
To: 'gaoliming' ; devel@edk2.groups.io
Cc: Srinivasan Mani ; Sundaresan S ;
michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Rabisha R
Subject: RE: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
Revision 4 structure
Hi Liming,
Pull request is done and pipelines are built successfully and the patch
is ready to push to the master.
Thanks,
Praveen Sankar
-Original Message-
From: gaoliming
Sent: Monday, May 6, 2024 7:53 AM
To: Praveen Sankar N ; devel@edk2.groups.io
Cc: Srinivasan Mani ; Sundaresan S ;
michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Rabisha R
Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4
structure
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Praveen Sankar N
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> Sundaresan S ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Revision 4, which has to be added in
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
>
> Signed-off-by: Praveen Sankar N praveensank...@ami.com
>
> Cc: michael.d.kin...@intel.com
>
> Cc: gaolim...@byosoft.com.cn
>
> Cc: zhiguang@intel.com
>
> Cc: fel...@ami.com
>
> Cc: srinivas...@ami.com
>
> Cc: sundares...@ami.com
>
> Cc: rabis...@ami.com
> ---
> .../SerialPortConsoleRedirectionTable.h | 32 +++
> 1 file changed, 32 insertions(+)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..bf967880ab 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -23,6 +23,7 @@
> ///
>
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
>
>
>
> +#define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> 0x04
>
> ///
>
> /// Serial Port Console Redirection Table Format
>
> ///
>
> @@ -50,6 +51,37 @@ typedef struct {
>UINT32Reserved3;
>
> } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
> +///
>
> +/// Serial Port Console Redirection Table Format Revision 4
>
> +///
>
> +typedef struct {
>
> + EFI_ACPI_DESCRIPTION_HEADER Header;
>
> + UINT8 InterfaceType;
>
> + UINT8 Reserved1[3];
>
> + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
>
> + UINT8 InterruptType;
>
> + UINT8 Irq;
>
> + UINT32
> GlobalSystemInterrupt;
>
> + UINT8 BaudRate;
>
> + UINT8 Parity;
>
> + UINT8 StopBits;
>
> + UINT8 FlowControl;
>
> + UINT8 TerminalType;
>
> + UINT8 Reserved2;
>
> + UINT16PciDeviceId;
>
> + UINT16PciVendorId;
>
> + UINT8 PciBusNumber;
>
> + UINT8 PciDeviceNumber;
>
> + UINT8 PciFunctionNumber;
>
> + UINT32PciFlags;
>
> + UINT8 PciSegment;
>
> + UINT32UartClockFrequency;
>
> + UINT32PreciseBaudRate;
>
> + UINT16
> NameSpaceStrLength;
>
> + UINT16
> NameSpaceStrOffset;
>
> + CHAR8
> NameSpaceString[0];
>
> +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
> +
>
> #pragma pack()
>
>
>
> //
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all
[edk2-devel] [PATCH v3 1/2] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.
In SPCR table, 4 structure members have been added newly as per
SPCR table Rev4, which has to be added in
MdePkg/SerialPortConsoleRedirectionTable.h file.
Signed-off-by: Praveen Sankar N praveensank...@ami.com
CC: michael.d.kin...@intel.com
CC: gaolim...@byosoft.com.cn
CC: zhiguang@intel.com
CC: fel...@ami.com
CC: srinivas...@ami.com
CC: sundares...@ami.com
---
.../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index eb5ae28390..f0001ab137 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -47,7 +47,11 @@ typedef struct {
UINT8 PciFunctionNumber;
UINT32PciFlags;
UINT8 PciSegment;
- UINT32Reserved3;
+ UINT32UartClockFrequency;
+ UINT32PreciseBaudRate;
+ UINT16NameSpaceStrLength;
+ UINT16NameSpaceStrOffset;
+ CHAR8 NameSpaceString[0];
} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
#pragma pack()
--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118693): https://edk2.groups.io/g/devel/message/118693
Mute This Topic: https://groups.io/mt/105984699/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
In SPCR table, 4 structure members have been added newly as per SPCR
table Revision 4, which has to be added in
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
Signed-off-by: Praveen Sankar N praveensank...@ami.com
Cc: michael.d.kin...@intel.com
Cc: gaolim...@byosoft.com.cn
Cc: zhiguang@intel.com
Cc: fel...@ami.com
Cc: srinivas...@ami.com
Cc: sundares...@ami.com
Cc: rabis...@ami.com
---
.../SerialPortConsoleRedirectionTable.h | 32 +++
1 file changed, 32 insertions(+)
diff --git
a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index eb5ae28390..bf967880ab 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -23,6 +23,7 @@
///
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
+#define EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x04
///
/// Serial Port Console Redirection Table Format
///
@@ -50,6 +51,37 @@ typedef struct {
UINT32Reserved3;
} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
+///
+/// Serial Port Console Redirection Table Format Revision 4
+///
+typedef struct {
+ EFI_ACPI_DESCRIPTION_HEADER Header;
+ UINT8 InterfaceType;
+ UINT8 Reserved1[3];
+ EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
+ UINT8 InterruptType;
+ UINT8 Irq;
+ UINT32GlobalSystemInterrupt;
+ UINT8 BaudRate;
+ UINT8 Parity;
+ UINT8 StopBits;
+ UINT8 FlowControl;
+ UINT8 TerminalType;
+ UINT8 Reserved2;
+ UINT16PciDeviceId;
+ UINT16PciVendorId;
+ UINT8 PciBusNumber;
+ UINT8 PciDeviceNumber;
+ UINT8 PciFunctionNumber;
+ UINT32PciFlags;
+ UINT8 PciSegment;
+ UINT32UartClockFrequency;
+ UINT32PreciseBaudRate;
+ UINT16NameSpaceStrLength;
+ UINT16NameSpaceStrOffset;
+ CHAR8 NameSpaceString[0];
+} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
+
#pragma pack()
//
--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118695): https://edk2.groups.io/g/devel/message/118695
Mute This Topic: https://groups.io/mt/105984701/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v3 2/2] MdePkg: Added new SPCR table Revision 4 structure
In SPCR table, 4 structure members have been added newly as per SPCR
table Revision 4, which has to be added in
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
Signed-off-by: Praveen Sankar N praveensank...@ami.com
Cc: michael.d.kin...@intel.com
Cc: gaolim...@byosoft.com.cn
Cc: zhiguang@intel.com
Cc: fel...@ami.com
Cc: srinivas...@ami.com
Cc: sundares...@ami.com
Cc: rabis...@ami.com
---
.../IndustryStandard/SerialPortConsoleRedirectionTable.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index f0001ab137..3979baf594 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -21,7 +21,7 @@
///
/// SPCR Revision (defined in spec)
///
-#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x04
///
/// Serial Port Console Redirection Table Format
@@ -52,7 +52,7 @@ typedef struct {
UINT16NameSpaceStrLength;
UINT16NameSpaceStrOffset;
CHAR8 NameSpaceString[0];
-} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
+} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_V4;
#pragma pack()
--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118694): https://edk2.groups.io/g/devel/message/118694
Mute This Topic: https://groups.io/mt/105984700/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v3 0/2] MdePkg: Added new SPCR table Revision 4 structure
praveensankarn (2): Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4. MdePkg: Added new SPCR table Revision 4 structure .../SerialPortConsoleRedirectionTable.h| 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.38.1.windows.1 -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118692): https://edk2.groups.io/g/devel/message/118692 Mute This Topic: https://groups.io/mt/105984698/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.
Hi Liming,
We are updating the ACPI tables with newer revision released recently and
SPCR table has its revision 4 upgradation. So, we updated the SPCR table to
revision 4, tested in our AMI BIOS environment and validated Windows Server EMS
functionality.
Thanks,
Praveen Sankar
-Original Message-
From: gaoliming
Sent: Monday, April 29, 2024 6:27 AM
To: devel@edk2.groups.io; Praveen Sankar N
Cc: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Srinivasan Mani ; Sundaresan S
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
MdePkg:Added new SPCR table stucture members as in Rev4.
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Praveen:
I want to know what will happen if the platform doesn't make changes with the
updated table.
According to its impact, we can make direction how and when to merge this
patch.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Praveen Sankar N
> via groups.io
> 发送时间: 2024年4月26日 12:58
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> ; Srinivasan Mani ; Sundaresan S
>
> 主题: Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added
> new SPCR table stucture members as in Rev4.
>
> Hi Liming,
> I am about to resubmit the patch with the changes in the files
> SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure
> from SerialPortConsoleRedirectionTable.h file and these files
> seemingly initializes the SPCR structure members. So please let me
> know about your opinion on this and I think you mean the incompatible
> change as these files are affected with the initial patch.
>
> Thanks,
> Praveen Sankar N
>
> -Original Message-
> From: gaoliming
> Sent: Tuesday, April 23, 2024 6:47 PM
> To: Praveen Sankar N ; devel@edk2.groups.io
> Cc: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> ; Srinivasan Mani ; Sundaresan S
>
> Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added
> new SPCR table stucture members as in Rev4.
>
>
> **CAUTION: The e-mail below is from an external source. Please
> exercise caution before opening attachments, clicking links, or
> following guidance.**
>
> Seemly, this is an incompatible change. What's impact with this change?
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Praveen Sankar N
> > 发送时间: 2024年4月22日 19:26
> > 收件人: devel@edk2.groups.io
> > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> > zhiguang@intel.com; Felix Polyudov ; Srinivasan
> > Mani ; Sundaresan S
> > 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> > stucture members as in Rev4.
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Rev4, which has to be added in
> > MdePkg/SerialPortConsoleRedirectionTable.h file.
> >
> > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> > Cc: michael.d.kin...@intel.com
> > Cc: gaolim...@byosoft.com.cn
> > Cc: zhiguang@intel.com
> > Cc: fel...@ami.com
> > Cc: srinivas...@ami.com
> > Cc: sundares...@ami.com
> > ---
> > .../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > index eb5ae28390..f0001ab137 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > @@ -47,7 +47,11 @@ typedef struct {
> >UINT8
> PciFunctionNumber;
> >
> >UINT32PciFlags;
> >
> >UINT8 PciSegment;
> >
> > - UINT32Reserved3;
> >
> > + UINT32
> UartClockFrequency;
> >
> > + UINT32PreciseBaudRate;
> >
> > + UINT16
> > NameSpaceStrLength;
> >
> > + UINT16
> > NameSpaceStrOffset;
> >
> > + CHAR8
> > NameSpaceString[0];
> >
> > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > #pragma pack()
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
>
Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.
Hi Liming,
I am about to resubmit the patch with the changes in the files
SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure from
SerialPortConsoleRedirectionTable.h file and these files seemingly initializes
the SPCR structure members. So please let me know about your opinion on this
and I think you mean the incompatible change as these files are affected with
the initial patch.
Thanks,
Praveen Sankar N
-Original Message-
From: gaoliming
Sent: Tuesday, April 23, 2024 6:47 PM
To: Praveen Sankar N ; devel@edk2.groups.io
Cc: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Srinivasan Mani ; Sundaresan S
Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR
table stucture members as in Rev4.
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Seemly, this is an incompatible change. What's impact with this change?
Thanks
Liming
> -邮件原件-
> 发件人: Praveen Sankar N
> 发送时间: 2024年4月22日 19:26
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Felix Polyudov ; Srinivasan
> Mani ; Sundaresan S
> 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> stucture members as in Rev4.
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Rev4, which has to be added in
> MdePkg/SerialPortConsoleRedirectionTable.h file.
>
> Signed-off-by: Praveen Sankar N praveensank...@ami.com
> Cc: michael.d.kin...@intel.com
> Cc: gaolim...@byosoft.com.cn
> Cc: zhiguang@intel.com
> Cc: fel...@ami.com
> Cc: srinivas...@ami.com
> Cc: sundares...@ami.com
> ---
> .../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..f0001ab137 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -47,7 +47,11 @@ typedef struct {
>UINT8 PciFunctionNumber;
>
>UINT32PciFlags;
>
>UINT8 PciSegment;
>
> - UINT32Reserved3;
>
> + UINT32UartClockFrequency;
>
> + UINT32PreciseBaudRate;
>
> + UINT16
> NameSpaceStrLength;
>
> + UINT16
> NameSpaceStrOffset;
>
> + CHAR8
> NameSpaceString[0];
>
> } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
> #pragma pack()
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118351): https://edk2.groups.io/g/devel/message/118351
Mute This Topic: https://groups.io/mt/105689097/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 0/1]
*** BLURB HERE *** praveensankarn (1): Subject: MdePkg:Added new SPCR table stucture members as in Rev4. .../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.38.1.windows.1 -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118148): https://edk2.groups.io/g/devel/message/118148 Mute This Topic: https://groups.io/mt/105690933/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.
In SPCR table, 4 structure members have been added newly as per
SPCR table Rev4, which has to be added in
MdePkg/SerialPortConsoleRedirectionTable.h file.
Signed-off-by: Praveen Sankar N praveensank...@ami.com
Cc: michael.d.kin...@intel.com
Cc: gaolim...@byosoft.com.cn
Cc: zhiguang@intel.com
Cc: fel...@ami.com
Cc: srinivas...@ami.com
Cc: sundares...@ami.com
---
.../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index eb5ae28390..f0001ab137 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -47,7 +47,11 @@ typedef struct {
UINT8 PciFunctionNumber;
UINT32PciFlags;
UINT8 PciSegment;
- UINT32Reserved3;
+ UINT32UartClockFrequency;
+ UINT32PreciseBaudRate;
+ UINT16NameSpaceStrLength;
+ UINT16NameSpaceStrOffset;
+ CHAR8 NameSpaceString[0];
} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
#pragma pack()
--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118149): https://edk2.groups.io/g/devel/message/118149
Mute This Topic: https://groups.io/mt/105690934/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] MdePkg-SerialPortConsoleRedirectionTable_h-SPCRTable-Upgrade-Rev-4
Since ACPI SPCR table has been upgraded with new revision Rev-4,
SerialPortConsoleRedirectionTable.h file should be added with
new field members which are added in Rev-4.
Signed-off-by: Praveen Sankar N praveensank...@ami.com
To: praveensank...@ami.com
---
.../IndustryStandard/SerialPortConsoleRedirectionTable.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index eb5ae28390..c432db4319 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -47,7 +47,12 @@ typedef struct {
UINT8 PciFunctionNumber;
UINT32PciFlags;
UINT8 PciSegment;
- UINT32Reserved3;
+ // Version 4 Fields
+ UINT32UartClockFrequency;
+ UINT32PreciseBaudRate;
+ UINT16NameSpaceStrLength;
+ UINT16NameSpaceStrOffset;
+ CHAR8 NameSpaceString[0];
} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
#pragma pack()
--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115657): https://edk2.groups.io/g/devel/message/115657
Mute This Topic: https://groups.io/mt/104469273/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
