Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
[AMD Official Use Only - AMD Internal Distribution Only] That is awesome! Thank you! Abner > -Original Message- > From: Nhi Pham > Sent: Thursday, May 16, 2024 4:50 PM > To: Chang, Abner ; devel@edk2.groups.io; > nick...@nvidia.com; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 5/16/2024 3:44 PM, Chang, Abner wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > Hi Nhi, > > Are you using SSIF as the transport interface based on the ManabeabilityPkg > framework? If yes, will you contribute that driver? > > > > yes, we are. I will need to update the SSIF driver to be compatible with > the ManabeabilityPkg and upstream it. > > Regards, > Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118953): https://edk2.groups.io/g/devel/message/118953 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
On 5/16/2024 3:44 PM, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Nhi, Are you using SSIF as the transport interface based on the ManabeabilityPkg framework? If yes, will you contribute that driver? yes, we are. I will need to update the SSIF driver to be compatible with the ManabeabilityPkg and upstream it. Regards, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118952): https://edk2.groups.io/g/devel/message/118952 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
[AMD Official Use Only - AMD Internal Distribution Only] Hi Nhi, Are you using SSIF as the transport interface based on the ManabeabilityPkg framework? If yes, will you contribute that driver? Thanks Abner > -Original Message- > From: Nhi Pham > Sent: Thursday, May 16, 2024 4:40 PM > To: devel@edk2.groups.io; nick...@nvidia.com; Chang, Abner > ; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Thanks Nickle. I'm reviewing and testing it. Will get back to you soon. > > On 5/15/2024 10:14 PM, Nickle Wang via groups.io wrote: > > Hi Nhi, > > > > Version 2 patch files are sent for review here: > https://edk2.groups.io/g/devel/message/118914 and > https://edk2.groups.io/g/devel/message/118922 > > > > For your convenience, below are two pull requests if you would like to test > them. > > > > 1) https://github.com/tianocore/edk2/pull/5660 > > 2) https://github.com/tianocore/edk2-platforms/pull/76 > > > > I had tried to address review comments as much as I can. Please feel free to > let me know if you see any issue in this version of patch set. > > > > Thanks, > > Nickle > > > >> -Original Message- > >> From: Nhi Pham > >> Sent: Tuesday, May 14, 2024 10:26 AM > >> To: Nickle Wang ; devel@edk2.groups.io; > >> abner.ch...@amd.com; Rebecca Cran > >> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul > Lateef) > >> ; Tinh Nguyen > >> > >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > >> support for the phosphor ipmi blob transfer protocol > >> > >> External email: Use caution opening links or attachments > >> > >> > >> Thanks Nickle. I will help review and verify your patch. > >> > >> On 5/14/2024 8:56 AM, Nickle Wang wrote: > >>> Hi Nhi, > >>> > >>> This task is on my list but with lower priority. I will try to provide > >>> version 2 > patch > >> for review here by the end of this week. > >>> > >>> Thanks, > >>> Nickle > >>> > >>>> -Original Message- > >>>> From: Nhi Pham > >>>> Sent: Monday, May 13, 2024 5:02 PM > >>>> To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang > >>>> ; Rebecca Cran > >>>> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul > >>>> Lateef) ; Tinh Nguyen > >>>> > >>>> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: > >>>> add support for the phosphor ipmi blob transfer protocol > >>>> > >>>> External email: Use caution opening links or attachments > >>>> > >>>> > >>>> On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: > >>>>> [AMD Official Use Only - General] > >>>>> > >>>>> Yeah, I forget this patch set and seems we don't have any follow up > >>>>> conversation > >>>> after below feedbacks from community. > >>>>> > >>>>> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed > >>>>> > >> > k2%2F=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35 > 108d > >> c > >>>>> > >> > 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63851 > 25035 > >> 6068 > >>>>> > >> > 8708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l > uMzIi > >> LCJ > >>>>> > >> > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C=%2BCkaU%2Fcd > G1v > >> r6uPsA > >>>>> 7fqrvhvxg%2FX5FqcmJ6fizaa9fA%3D=0 > >>>>> .groups.io%2Fg%2Fdevel%2Fmessage%2F103116=05%7C02%7 > Cnickle > >> w > >>>> %40nvi > >>>>> > >>>> > >> > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c > 1b7db > >>>> 39efd > >>>>> > >>>> > >> > 9ccc17a%7C0%7C0%7C638511877469561600%7CUnknown%7CTWFpbGZs > b3d8 > >>>> eyJWIjoiM > >>>>> > >>>> > >> > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Thanks Nickle. I'm reviewing and testing it. Will get back to you soon. On 5/15/2024 10:14 PM, Nickle Wang via groups.io wrote: Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922 For your convenience, below are two pull requests if you would like to test them. 1) https://github.com/tianocore/edk2/pull/5660 2) https://github.com/tianocore/edk2-platforms/pull/76 I had tried to address review comments as much as I can. Please feel free to let me know if you see any issue in this version of patch set. Thanks, Nickle -Original Message- From: Nhi Pham Sent: Tuesday, May 14, 2024 10:26 AM To: Nickle Wang ; devel@edk2.groups.io; abner.ch...@amd.com; Rebecca Cran Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Tinh Nguyen Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol External email: Use caution opening links or attachments Thanks Nickle. I will help review and verify your patch. On 5/14/2024 8:56 AM, Nickle Wang wrote: Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle -Original Message- From: Nhi Pham Sent: Monday, May 13, 2024 5:02 PM To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang ; Rebecca Cran Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Tinh Nguyen Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol External email: Use caution opening links or attachments On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah, I forget this patch set and seems we don't have any follow up conversation after below feedbacks from community. https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed k2%2F=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35108d c 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6385125035 6068 8708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi LCJ BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C=%2BCkaU%2FcdG1v r6uPsA 7fqrvhvxg%2FX5FqcmJ6fizaa9fA%3D=0 .groups.io%2Fg%2Fdevel%2Fmessage%2F103116=05%7C02%7Cnickle w %40nvi dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db 39efd 9ccc17a%7C0%7C0%7C638511877469561600%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiM C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 C%7C =N4eDH668lBSFxq9r81QrhMgpULvht8isrrEI9lipVKc%3D=0 https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed k2%2F=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35108d c 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6385125035 6070 0897%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi LCJ BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C=KFd86NhmrQeGqEB 8%2FJy 0qnbMkb%2Furpo8YCsVbVsOxNk%3D=0 .groups.io%2Fg%2Fdevel%2Fmessage%2F103087=05%7C02%7Cnickle w %40nvi dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db 39efd 9ccc17a%7C0%7C0%7C638511877469569817%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiM C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 C%7C =7p0BHb8RFRapFyygr35u0hQBK2bQwKPSypBaUi6cMIQ%3D=0 So Nickle, does NV still has the plan to upstream IPMI blob edk2 implementation? We should keep driving upstream the implementation as industry needs it to incorporate with OpenBMC. Hi Rebessa, As we are on Chinese New Year holidays now, please expect the delay response. Thanks Abner Hi Nickle and Abner, May I know the status of upstreaming the IPMI Blob Transfer Protocol? I'm planning to upstream the SMBIOS transfer to OpenBMC by leveraging this protocol. Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118950): https://edk2.groups.io/g/devel/message/118950 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922 For your convenience, below are two pull requests if you would like to test them. 1) https://github.com/tianocore/edk2/pull/5660 2) https://github.com/tianocore/edk2-platforms/pull/76 I had tried to address review comments as much as I can. Please feel free to let me know if you see any issue in this version of patch set. Thanks, Nickle > -Original Message- > From: Nhi Pham > Sent: Tuesday, May 14, 2024 10:26 AM > To: Nickle Wang ; devel@edk2.groups.io; > abner.ch...@amd.com; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > External email: Use caution opening links or attachments > > > Thanks Nickle. I will help review and verify your patch. > > On 5/14/2024 8:56 AM, Nickle Wang wrote: > > Hi Nhi, > > > > This task is on my list but with lower priority. I will try to provide > > version 2 patch > for review here by the end of this week. > > > > Thanks, > > Nickle > > > >> -Original Message- > >> From: Nhi Pham > >> Sent: Monday, May 13, 2024 5:02 PM > >> To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang > >> ; Rebecca Cran > >> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul > >> Lateef) ; Tinh Nguyen > >> > >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: > >> add support for the phosphor ipmi blob transfer protocol > >> > >> External email: Use caution opening links or attachments > >> > >> > >> On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: > >>> [AMD Official Use Only - General] > >>> > >>> Yeah, I forget this patch set and seems we don't have any follow up > >>> conversation > >> after below feedbacks from community. > >>> > >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed > >>> > k2%2F=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35108d > c > >>> > 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6385125035 > 6068 > >>> > 8708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJ > >>> > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C=%2BCkaU%2FcdG1v > r6uPsA > >>> 7fqrvhvxg%2FX5FqcmJ6fizaa9fA%3D=0 > >>> .groups.io%2Fg%2Fdevel%2Fmessage%2F103116=05%7C02%7Cnickle > w > >> %40nvi > >>> > >> > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db > >> 39efd > >>> > >> > 9ccc17a%7C0%7C0%7C638511877469561600%7CUnknown%7CTWFpbGZsb3d8 > >> eyJWIjoiM > >>> > >> > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > >> C%7C > >>> =N4eDH668lBSFxq9r81QrhMgpULvht8isrrEI9lipVKc%3D=0 > >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed > >>> > k2%2F=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35108d > c > >>> > 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6385125035 > 6070 > >>> > 0897%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJ > >>> > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C=KFd86NhmrQeGqEB > 8%2FJy > >>> 0qnbMkb%2Furpo8YCsVbVsOxNk%3D=0 > >>> .groups.io%2Fg%2Fdevel%2Fmessage%2F103087=05%7C02%7Cnickle > w > >> %40nvi > >>> > >> > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db > >> 39efd > >>> > >> > 9ccc17a%7C0%7C0%7C638511877469569817%7CUnknown%7CTWFpbGZsb3d8 > >> eyJWIjoiM > >>> > >> > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > >> C%7C > >>> > >> > =7p0BHb8RFRapFyygr35u0hQBK2bQwKPSypBaUi6cMIQ%3D=0 > >>> > >>> So Nickle, does NV still has the plan to upstream IPMI blob edk2 > >> implementation? We should keep driving upstream the implementation as > >> industry needs it to incorporate with OpenBMC. > >>> > >>> Hi Rebessa, > >>> As we are on Chinese New Year holidays now, please expect the delay > response. > >>> Thanks > >>> Abner > >>> > >> > >> Hi Nickle and Abner, > >> > >> May I know the status of upstreaming the IPMI Blob Transfer Protocol? > >> I'm planning to upstream the SMBIOS transfer to OpenBMC by leveraging > >> this protocol. > >> > >> Thanks, > >> Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118923): https://edk2.groups.io/g/devel/message/118923 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Thanks Nickle. I will help review and verify your patch. On 5/14/2024 8:56 AM, Nickle Wang wrote: Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle -Original Message- From: Nhi Pham Sent: Monday, May 13, 2024 5:02 PM To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang ; Rebecca Cran Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Tinh Nguyen Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol External email: Use caution opening links or attachments On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah, I forget this patch set and seems we don't have any follow up conversation after below feedbacks from community. https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2 .groups.io%2Fg%2Fdevel%2Fmessage%2F103116=05%7C02%7Cnicklew %40nvi dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db 39efd 9ccc17a%7C0%7C0%7C638511877469561600%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiM C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 C%7C =N4eDH668lBSFxq9r81QrhMgpULvht8isrrEI9lipVKc%3D=0 https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2 .groups.io%2Fg%2Fdevel%2Fmessage%2F103087=05%7C02%7Cnicklew %40nvi dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db 39efd 9ccc17a%7C0%7C0%7C638511877469569817%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiM C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 C%7C =7p0BHb8RFRapFyygr35u0hQBK2bQwKPSypBaUi6cMIQ%3D=0 So Nickle, does NV still has the plan to upstream IPMI blob edk2 implementation? We should keep driving upstream the implementation as industry needs it to incorporate with OpenBMC. Hi Rebessa, As we are on Chinese New Year holidays now, please expect the delay response. Thanks Abner Hi Nickle and Abner, May I know the status of upstreaming the IPMI Blob Transfer Protocol? I'm planning to upstream the SMBIOS transfer to OpenBMC by leveraging this protocol. Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118879): https://edk2.groups.io/g/devel/message/118879 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle > -Original Message- > From: Nhi Pham > Sent: Monday, May 13, 2024 5:02 PM > To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang > ; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > External email: Use caution opening links or attachments > > > On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: > > [AMD Official Use Only - General] > > > > Yeah, I forget this patch set and seems we don't have any follow up > > conversation > after below feedbacks from community. > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2 > > .groups.io%2Fg%2Fdevel%2Fmessage%2F103116=05%7C02%7Cnicklew > %40nvi > > > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db > 39efd > > > 9ccc17a%7C0%7C0%7C638511877469561600%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiM > > > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > C%7C > > =N4eDH668lBSFxq9r81QrhMgpULvht8isrrEI9lipVKc%3D=0 > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2 > > .groups.io%2Fg%2Fdevel%2Fmessage%2F103087=05%7C02%7Cnicklew > %40nvi > > > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db > 39efd > > > 9ccc17a%7C0%7C0%7C638511877469569817%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiM > > > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > C%7C > > > =7p0BHb8RFRapFyygr35u0hQBK2bQwKPSypBaUi6cMIQ%3D=0 > > > > So Nickle, does NV still has the plan to upstream IPMI blob edk2 > implementation? We should keep driving upstream the implementation as > industry needs it to incorporate with OpenBMC. > > > > Hi Rebessa, > > As we are on Chinese New Year holidays now, please expect the delay > > response. > > Thanks > > Abner > > > > Hi Nickle and Abner, > > May I know the status of upstreaming the IPMI Blob Transfer Protocol? > I'm planning to upstream the SMBIOS transfer to OpenBMC by leveraging this > protocol. > > Thanks, > Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118878): https://edk2.groups.io/g/devel/message/118878 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah, I forget this patch set and seems we don't have any follow up conversation after below feedbacks from community. https://edk2.groups.io/g/devel/message/103116 https://edk2.groups.io/g/devel/message/103087 So Nickle, does NV still has the plan to upstream IPMI blob edk2 implementation? We should keep driving upstream the implementation as industry needs it to incorporate with OpenBMC. Hi Rebessa, As we are on Chinese New Year holidays now, please expect the delay response. Thanks Abner Hi Nickle and Abner, May I know the status of upstreaming the IPMI Blob Transfer Protocol? I'm planning to upstream the SMBIOS transfer to OpenBMC by leveraging this protocol. Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118860): https://edk2.groups.io/g/devel/message/118860 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Hello Nick,
CalculateCrc16 function has already defined in
edk2-platforms/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h
and edk2/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c.
This patch adds another CalculateCrc16 declaration.
There was an attempt to unify Crc16 calculation [*], but it left
implementations mentioned above untouched.
I would suggest to rename CalculateCrc16 provided by this path to
something like CalculateCrc16Ccitt.
It could be easy moved to MdePkg later.
[*] https://bugzilla.tianocore.org/show_bug.cgi?id=3871
On Wed, Apr 12, 2023 at 6:17 AM Nickle Wang via groups.io
wrote:
>
> This change implements the blob transfer protocol used in OpenBmc
> documented here: https://github.com/openbmc/phosphor-ipmi-blobs
>
> Signed-off-by: Nick Ramirez
> Cc: Abner Chang
> Cc: Isaac Oram
> Cc: Abdul Lateef Attar
> Cc: Nickle Wang
> Cc: Tinh Nguyen
> ---
> .../ManageabilityPkg/ManageabilityPkg.dec |6 +
> .../Include/Dsc/Manageability.dsc |4 +-
> .../IpmiBlobTransferDxe.inf | 39 +
> .../IpmiBlobTransferTestUnitTestsHost.inf | 40 +
> .../Include/Protocol/IpmiBlobTransfer.h | 136 ++
> .../InternalIpmiBlobTransfer.h| 363 ++
> .../IpmiBlobTransferDxe/IpmiBlobTransferDxe.c | 799
> .../UnitTest/IpmiBlobTransferTestUnitTests.c | 1113 +
> .../Universal/IpmiBlobTransferDxe/Readme.md | 24 +
> 9 files changed, 2523 insertions(+), 1 deletion(-)
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBlobTransferTestUnitTestsHost.inf
> create mode 100644
> Features/ManageabilityPkg/Include/Protocol/IpmiBlobTransfer.h
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/InternalIpmiBlobTransfer.h
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.c
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBlobTransferTestUnitTests.c
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/Readme.md
>
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
> b/Features/ManageabilityPkg/ManageabilityPkg.dec
> index 9a930d3e4b..e2d650 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dec
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -4,6 +4,7 @@
> # those are related to the platform management.
> #
> # Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
> @@ -48,3 +49,8 @@
>gManageabilityProtocolMctpGuid= { 0x76FED8F1, 0x0BE5, 0x4269, { 0xA3,
> 0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
># Manageability Protocol PLDM
>gManageabilityProtocolPldmGuid= { 0x3958090D, 0x69DD, 0x4868, { 0x9C,
> 0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
> +
> +[Protocols]
> +
> + ## Include/Protocol/IpmiBlobTransfer.h
> + gEdkiiIpmiBlobTransferProtocolGuid = { 0x05837c75, 0x1d65, 0x468b, { 0xb1,
> 0xc2, 0x81, 0xaf, 0x9a, 0x31, 0x5b, 0x2c } }
> diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> index 0d868fdf4a..111d6b91dc 100644
> --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> @@ -2,11 +2,13 @@
> # Common libraries for Manageabilty Package
> #
> # Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
> [LibraryClasses]
>
> ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> +
> IpmiLib|MdeModulePkg/Library/DxeIpmiLibIpmiProtocol/DxeIpmiLibIpmiProtocol.inf
>
> [LibraryClasses.ARM, LibraryClasses.AARCH64]
>#
> @@ -22,4 +24,4 @@
> [Components.X64]
>ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
>ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
> -
> + ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
> diff --git
> a/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
>
> b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
> new file mode 100644
> index 00..28e9d293c1
> --- /dev/null
> +++
> b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
> @@ -0,0 +1,39 @@
> +## @file
> +# IPMI Blob Transfer Protocol DXE Driver.
> +#
> +# Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> +#
> +#
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Hi Abner,
On 17/04/2023 10:01, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
-Original Message-
From: Tinh Nguyen
Sent: Monday, April 17, 2023 10:25 AM
To: Chang, Abner ; Nickle Wang
; devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: add support for the
phosphor ipmi blob transfer protocol
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
On 4/16/2023 5:50 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender.
Please be mindful of safe email handling and proprietary information
protection practices.]
[AMD Official Use Only - General]
Tink and Nickle,
Two feedbacks in below,
-Original Message-
From: Tinh Nguyen
Sent: Sunday, April 16, 2023 6:29 PM
To: Nickle Wang;devel@edk2.groups.io
Cc: Chang, Abner; Isaac Oram
; Attar, AbdulLateef (Abdul Lateef)
Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: add support for
the
phosphor ipmi blob transfer protocol
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Hi Nickle,
Please find my inline comments below
On 4/12/2023 10:17 AM, Nickle Wang wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender.
Please be mindful of safe email handling and proprietary information
protection practices.]
This change implements the blob transfer protocol used in OpenBmc
documented here:https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Cc: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../ManageabilityPkg/ManageabilityPkg.dec |6 +
.../Include/Dsc/Manageability.dsc |4 +-
.../IpmiBlobTransferDxe.inf | 39 +
.../IpmiBlobTransferTestUnitTestsHost.inf | 40 +
.../Include/Protocol/IpmiBlobTransfer.h | 136 ++
.../InternalIpmiBlobTransfer.h| 363 ++
.../IpmiBlobTransferDxe/IpmiBlobTransferDxe.c | 799
.../UnitTest/IpmiBlobTransferTestUnitTests.c | 1113
+
.../Universal/IpmiBlobTransferDxe/Readme.md | 24 +
9 files changed, 2523 insertions(+), 1 deletion(-)
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransf
erDxe.inf
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBl
obTransferTestUnitTestsHost.inf
create mode 100644
Features/ManageabilityPkg/Include/Protocol/IpmiBlobTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/InternalIpmiBlo
bTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransf
erDxe.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBl
obTransferTestUnitTests.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/Readme.md
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..e2d650 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -4,6 +4,7 @@
# those are related to the platform management.
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -48,3 +49,8 @@
gManageabilityProtocolMctpGuid= { 0x76FED8F1, 0x0BE5, 0x4269,
{ 0xA3, 0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
# Manageability Protocol PLDM
gManageabilityProtocolPldmGuid= { 0x3958090D, 0x69DD, 0x4868,
{ 0x9C, 0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
+
+[Protocols]
+
+ ## Include/Protocol/IpmiBlobTransfer.h
+ gEdkiiIpmiBlobTransferProtocolGuid = { 0x05837c75, 0x1d65, 0x468b,
{ 0xb1, 0xc2, 0x81, 0xaf, 0x9a, 0x31, 0x5b, 0x2c } }
diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
index 0d868fdf4a..111d6b91dc 100644
--- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
+++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
@@ -2,11 +2,13 @@
# Common libraries for Manageabilty Package
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
[LibraryClasses]
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
On 4/16/2023 5:50 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
Tink and Nickle,
Two feedbacks in below,
-Original Message-
From: Tinh Nguyen
Sent: Sunday, April 16, 2023 6:29 PM
To: Nickle Wang;devel@edk2.groups.io
Cc: Chang, Abner; Isaac Oram
; Attar, AbdulLateef (Abdul Lateef)
Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: add support for the
phosphor ipmi blob transfer protocol
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Hi Nickle,
Please find my inline comments below
On 4/12/2023 10:17 AM, Nickle Wang wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender.
Please be mindful of safe email handling and proprietary information
protection practices.]
This change implements the blob transfer protocol used in OpenBmc
documented here:https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Cc: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../ManageabilityPkg/ManageabilityPkg.dec |6 +
.../Include/Dsc/Manageability.dsc |4 +-
.../IpmiBlobTransferDxe.inf | 39 +
.../IpmiBlobTransferTestUnitTestsHost.inf | 40 +
.../Include/Protocol/IpmiBlobTransfer.h | 136 ++
.../InternalIpmiBlobTransfer.h| 363 ++
.../IpmiBlobTransferDxe/IpmiBlobTransferDxe.c | 799
.../UnitTest/IpmiBlobTransferTestUnitTests.c | 1113
+
.../Universal/IpmiBlobTransferDxe/Readme.md | 24 +
9 files changed, 2523 insertions(+), 1 deletion(-)
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransf
erDxe.inf
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBl
obTransferTestUnitTestsHost.inf
create mode 100644
Features/ManageabilityPkg/Include/Protocol/IpmiBlobTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/InternalIpmiBlo
bTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransf
erDxe.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBl
obTransferTestUnitTests.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/Readme.md
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..e2d650 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -4,6 +4,7 @@
# those are related to the platform management.
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -48,3 +49,8 @@
gManageabilityProtocolMctpGuid= { 0x76FED8F1, 0x0BE5, 0x4269,
{ 0xA3, 0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
# Manageability Protocol PLDM
gManageabilityProtocolPldmGuid= { 0x3958090D, 0x69DD, 0x4868,
{ 0x9C, 0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
+
+[Protocols]
+
+ ## Include/Protocol/IpmiBlobTransfer.h
+ gEdkiiIpmiBlobTransferProtocolGuid = { 0x05837c75, 0x1d65, 0x468b,
{ 0xb1, 0xc2, 0x81, 0xaf, 0x9a, 0x31, 0x5b, 0x2c } }
diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
index 0d868fdf4a..111d6b91dc 100644
--- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
+++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
@@ -2,11 +2,13 @@
# Common libraries for Manageabilty Package
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
[LibraryClasses]
ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageabi
lityTransportHelperLib/BaseManageabilityTransportHelper.inf
+
IpmiLib|MdeModulePkg/Library/DxeIpmiLibIpmiProtocol/DxeIpmiLibIpmiPr
otocol.inf
[LibraryClasses.ARM, LibraryClasses.AARCH64]
#
@@ -22,4 +24,4 @@
[Components.X64]
ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
-
+
ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
diff --git
a/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTran
sferDxe.inf
b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTran
sferDxe.inf
new file mode 100644
index 00..28e9d293c1
--- /dev/null
+++
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
Hi Nickle,
Please find my inline comments below
On 4/12/2023 10:17 AM, Nickle Wang wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Cc: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../ManageabilityPkg/ManageabilityPkg.dec |6 +
.../Include/Dsc/Manageability.dsc |4 +-
.../IpmiBlobTransferDxe.inf | 39 +
.../IpmiBlobTransferTestUnitTestsHost.inf | 40 +
.../Include/Protocol/IpmiBlobTransfer.h | 136 ++
.../InternalIpmiBlobTransfer.h| 363 ++
.../IpmiBlobTransferDxe/IpmiBlobTransferDxe.c | 799
.../UnitTest/IpmiBlobTransferTestUnitTests.c | 1113 +
.../Universal/IpmiBlobTransferDxe/Readme.md | 24 +
9 files changed, 2523 insertions(+), 1 deletion(-)
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBlobTransferTestUnitTestsHost.inf
create mode 100644
Features/ManageabilityPkg/Include/Protocol/IpmiBlobTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/InternalIpmiBlobTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBlobTransferTestUnitTests.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/Readme.md
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..e2d650 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -4,6 +4,7 @@
# those are related to the platform management.
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -48,3 +49,8 @@
gManageabilityProtocolMctpGuid= { 0x76FED8F1, 0x0BE5, 0x4269, { 0xA3,
0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
# Manageability Protocol PLDM
gManageabilityProtocolPldmGuid= { 0x3958090D, 0x69DD, 0x4868, { 0x9C,
0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
+
+[Protocols]
+
+ ## Include/Protocol/IpmiBlobTransfer.h
+ gEdkiiIpmiBlobTransferProtocolGuid = { 0x05837c75, 0x1d65, 0x468b, { 0xb1,
0xc2, 0x81, 0xaf, 0x9a, 0x31, 0x5b, 0x2c } }
diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
index 0d868fdf4a..111d6b91dc 100644
--- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
+++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
@@ -2,11 +2,13 @@
# Common libraries for Manageabilty Package
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
[LibraryClasses]
ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+
IpmiLib|MdeModulePkg/Library/DxeIpmiLibIpmiProtocol/DxeIpmiLibIpmiProtocol.inf
[LibraryClasses.ARM, LibraryClasses.AARCH64]
#
@@ -22,4 +24,4 @@
[Components.X64]
ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
-
+ ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
diff --git
a/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
new file mode 100644
index 00..28e9d293c1
--- /dev/null
+++
b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
@@ -0,0 +1,39 @@
+## @file
+# IPMI Blob Transfer Protocol DXE Driver.
+#
+# Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights
reserved.
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+[Defines]
+ INF_VERSION= 0x00010005
+ BASE_NAME = IpmiBlobTransferDxe
+ FILE_GUID = 6357c804-78bb-4b0c-abdf-c75df942f319
+ MODULE_TYPE= DXE_DRIVER
+ VERSION_STRING = 1.0
+ ENTRY_POINT= IpmiBlobTransferDxeDriverEntryPoint
+
+[Sources.common]
+ IpmiBlobTransferDxe.c
+
+[LibraryClasses]
+ BaseLib
+ BaseMemoryLib
+ DebugLib
+ IpmiLib
+ MemoryAllocationLib
+ PcdLib
+
Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
[AMD Official Use Only - General]
Hi Nickle,
Could you please create a BZ ticket for this? Pease also run Uncristify on
these files.
Feedback inline,
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, April 12, 2023 11:17 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Isaac Oram
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH] ManageabilityPkg: add support for the
> phosphor ipmi blob transfer protocol
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> This change implements the blob transfer protocol used in OpenBmc
> documented here: https://github.com/openbmc/phosphor-ipmi-blobs
>
> Signed-off-by: Nick Ramirez
> Cc: Abner Chang
> Cc: Isaac Oram
> Cc: Abdul Lateef Attar
> Cc: Nickle Wang
> Cc: Tinh Nguyen
> ---
> .../ManageabilityPkg/ManageabilityPkg.dec |6 +
> .../Include/Dsc/Manageability.dsc |4 +-
> .../IpmiBlobTransferDxe.inf | 39 +
> .../IpmiBlobTransferTestUnitTestsHost.inf | 40 +
> .../Include/Protocol/IpmiBlobTransfer.h | 136 ++
> .../InternalIpmiBlobTransfer.h| 363 ++
> .../IpmiBlobTransferDxe/IpmiBlobTransferDxe.c | 799
> .../UnitTest/IpmiBlobTransferTestUnitTests.c | 1113 +
> .../Universal/IpmiBlobTransferDxe/Readme.md | 24 +
> 9 files changed, 2523 insertions(+), 1 deletion(-)
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransf
> erDxe.inf
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBl
> obTransferTestUnitTestsHost.inf
> create mode 100644
> Features/ManageabilityPkg/Include/Protocol/IpmiBlobTransfer.h
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/InternalIpmiBlo
> bTransfer.h
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransf
> erDxe.c
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBl
> obTransferTestUnitTests.c
> create mode 100644
> Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/Readme.md
>
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
> b/Features/ManageabilityPkg/ManageabilityPkg.dec
> index 9a930d3e4b..e2d650 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dec
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -4,6 +4,7 @@
> # those are related to the platform management.
> #
> # Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
> @@ -48,3 +49,8 @@
>gManageabilityProtocolMctpGuid= { 0x76FED8F1, 0x0BE5, 0x4269, { 0xA3,
> 0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
># Manageability Protocol PLDM
>gManageabilityProtocolPldmGuid= { 0x3958090D, 0x69DD, 0x4868, { 0x9C,
> 0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
> +
> +[Protocols]
> +
> + ## Include/Protocol/IpmiBlobTransfer.h
> + gEdkiiIpmiBlobTransferProtocolGuid = { 0x05837c75, 0x1d65, 0x468b, { 0xb1,
> 0xc2, 0x81, 0xaf, 0x9a, 0x31, 0x5b, 0x2c } }
> diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> index 0d868fdf4a..111d6b91dc 100644
> --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> @@ -2,11 +2,13 @@
> # Common libraries for Manageabilty Package
> #
> # Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
> [LibraryClasses]
>
> ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageabi
> lityTransportHelperLib/BaseManageabilityTransportHelper.inf
> +
> IpmiLib|MdeModulePkg/Library/DxeIpmiLibIpmiProtocol/DxeIpmiLibIpmiPr
> otocol.inf
>
> [LibraryClasses.ARM, LibraryClasses.AARCH64]
>#
> @@ -22,4 +24,4 @@
> [Components.X64]
>ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
>ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
> -
> +
> ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
> diff --git
> a/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTran
> sferDxe.inf
> b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTran
> sferDxe.inf
> new file mode 100644
> index 00..28e9d293c1
> --- /dev/null
> +++
> b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTran
> sferDxe.inf
> @@ -0,0 +1,39 @@
> +## @file
> +# IPMI Blob Transfer Protocol DXE Driver.
> +#
> +# Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights
Is 2022-2023 correct? This
[edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol
This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Cc: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../ManageabilityPkg/ManageabilityPkg.dec |6 +
.../Include/Dsc/Manageability.dsc |4 +-
.../IpmiBlobTransferDxe.inf | 39 +
.../IpmiBlobTransferTestUnitTestsHost.inf | 40 +
.../Include/Protocol/IpmiBlobTransfer.h | 136 ++
.../InternalIpmiBlobTransfer.h| 363 ++
.../IpmiBlobTransferDxe/IpmiBlobTransferDxe.c | 799
.../UnitTest/IpmiBlobTransferTestUnitTests.c | 1113 +
.../Universal/IpmiBlobTransferDxe/Readme.md | 24 +
9 files changed, 2523 insertions(+), 1 deletion(-)
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBlobTransferTestUnitTestsHost.inf
create mode 100644
Features/ManageabilityPkg/Include/Protocol/IpmiBlobTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/InternalIpmiBlobTransfer.h
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/UnitTest/IpmiBlobTransferTestUnitTests.c
create mode 100644
Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/Readme.md
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..e2d650 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -4,6 +4,7 @@
# those are related to the platform management.
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -48,3 +49,8 @@
gManageabilityProtocolMctpGuid= { 0x76FED8F1, 0x0BE5, 0x4269, { 0xA3,
0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
# Manageability Protocol PLDM
gManageabilityProtocolPldmGuid= { 0x3958090D, 0x69DD, 0x4868, { 0x9C,
0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
+
+[Protocols]
+
+ ## Include/Protocol/IpmiBlobTransfer.h
+ gEdkiiIpmiBlobTransferProtocolGuid = { 0x05837c75, 0x1d65, 0x468b, { 0xb1,
0xc2, 0x81, 0xaf, 0x9a, 0x31, 0x5b, 0x2c } }
diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
index 0d868fdf4a..111d6b91dc 100644
--- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
+++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
@@ -2,11 +2,13 @@
# Common libraries for Manageabilty Package
#
# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
[LibraryClasses]
ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+
IpmiLib|MdeModulePkg/Library/DxeIpmiLibIpmiProtocol/DxeIpmiLibIpmiProtocol.inf
[LibraryClasses.ARM, LibraryClasses.AARCH64]
#
@@ -22,4 +24,4 @@
[Components.X64]
ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
-
+ ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
diff --git
a/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
new file mode 100644
index 00..28e9d293c1
--- /dev/null
+++
b/Features/ManageabilityPkg/Universal/IpmiBlobTransferDxe/IpmiBlobTransferDxe.inf
@@ -0,0 +1,39 @@
+## @file
+# IPMI Blob Transfer Protocol DXE Driver.
+#
+# Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights
reserved.
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+[Defines]
+ INF_VERSION= 0x00010005
+ BASE_NAME = IpmiBlobTransferDxe
+ FILE_GUID = 6357c804-78bb-4b0c-abdf-c75df942f319
+ MODULE_TYPE= DXE_DRIVER
+ VERSION_STRING = 1.0
+ ENTRY_POINT= IpmiBlobTransferDxeDriverEntryPoint
+
+[Sources.common]
+ IpmiBlobTransferDxe.c
+
+[LibraryClasses]
+ BaseLib
+ BaseMemoryLib
+ DebugLib
+ IpmiLib
+ MemoryAllocationLib
+ PcdLib
+ UefiBootServicesTableLib
+ UefiDriverEntryPoint
+
+[Packages]
+ MdePkg/MdePkg.dec
+ MdeModulePkg/MdeModulePkg.dec
+ ManageabilityPkg/ManageabilityPkg.dec
+
+[Protocols]
+ gEdkiiIpmiBlobTransferProtocolGuid
+
+[Depex]
+ TRUE
diff --git
