Re: [edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes
Hi Jeremy, > That is unfortunate. Which revision/how much RAM? Can you paste the > before/after kernel/pci output like: My RPi4 is a 8GB revision d03114. Here's the pci output before applying your ranges tweak: [3.697773] brcm-pcie fd50.pcie: host bridge /scb/pcie@7d50 ranges: [3.706020] brcm-pcie fd50.pcie: No bus range found for /scb/pcie@7d50, using [bus 00-ff] [3.716271] brcm-pcie fd50.pcie: MEM 0x06..0x063fff -> 0x00c000 [3.726229] brcm-pcie fd50.pcie: IB MEM 0x00..0x00bfff -> 0x00 [3.737357] brcm-pcie fd50.pcie: PCI host bridge to bus :00 [3.743891] pci_bus :00: root bus resource [bus 00-ff] [3.749530] pci_bus :00: root bus resource [mem 0x6-0x63fff] (bus address [0xc000-0x]) And after: [3.781758] brcm-pcie fd50.pcie: host bridge /scb/pcie@7d50 ranges: [3.789907] brcm-pcie fd50.pcie: No bus range found for /scb/pcie@7d50, using [bus 00-ff] [3.800230] brcm-pcie fd50.pcie: MEM 0x06..0x0603ff -> 0x00f800 [3.809721] brcm-pcie fd50.pcie: IB MEM 0x00..0x00bfff -> 0x00 [3.828359] brcm-pcie fd50.pcie: PCI host bridge to bus :00 [3.835812] pci_bus :00: root bus resource [bus 00-ff] [3.845651] pci_bus :00: root bus resource [mem 0x6-0x603ff] (bus address [0xf800-0xfbff]) I tested with the latest binaries and DT from https://github.com/raspberrypi/firmware (master), same issue with the USB. Here's the firmware version I'm running (got that from Raspbian), are you using a different/more recent one? $ vcgencmd version Aug 26 2022 14:03:16 Copyright (c) 2012 Broadcom version 102f1e848393c2112206fadffaaf86db04e98326 (clean) (release) (start) > So the first patch makes sense, but I think it should probably be > checking both DT property names (pci0,0 and pci1,0) since we probably > want maximum compatibility with differing DT's the user might swap in, > and the upstream linux change which changes the node from 1,0 to 0,0 is > from august of last year, so not old at all.. Sounds good, I can submit a v2 handling both variants > The second one, I'm less sure about, since the primary thing your > changing (AFAIK) is whether the XHCI BIOS handoff is being checked, and > since EDK2 supports the hand-off and Linux doesn't throw the XHCI bios > failure message I think we actually want to leave that in place. If you > have debugging turned on, the XHCI/LegacyBios ownership control is the > message you see during exit boot services that says > "XhciClearBiosOwnership: called to clear BIOS ownership". I suspect the > kernel patch is yet another case of "UBOOT and/or the pi foundation > firmware is broken so we fixed the kernel" > > Do you see a difference with/without the second patch? Thanks for explaining this. I can't see a difference with/without the second patch. AFAICT the hand-off check seems to execute without issue on Linux. It makes sense to me to drop this second patch since the hand-off is supported by EDK2. Adrien -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94718): https://edk2.groups.io/g/devel/message/94718 Mute This Topic: https://groups.io/mt/94002759/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes
Hi, On 9/30/22 13:47, Adrien Thierry wrote: Hi Jeremy, If you just add the range tweak, does that fix the XHCI config in your setup too? I tested applying the range tweak in your patch, unfortunately it doesn't seem to work on my setup. I'm still getting "usb 1-1: device descriptor > read/64, error -71" errors. That is unfortunate. Which revision/how much RAM? Can you paste the before/after kernel/pci output like: ] brcm-pcie fd50.pcie: host bridge /scb/pcie@7d50 ranges: ] brcm-pcie fd50.pcie: No bus range found for /scb/pcie@7d50, using [bus 00-ff] ] brcm-pcie fd50.pcie: MEM 0x06..0x0603ff -> 0x00f800 ] brcm-pcie fd50.pcie: IB MEM 0x00..0x00bfff -> 0x00 ] brcm-pcie fd50.pcie: PCI host bridge to bus :00 ] pci_bus :00: root bus resource [bus 00-ff] ] pci_bus :00: root bus resource [mem 0x6-0x603ff] (bus address [0xf800-0xfbff]) I tested it on a C0 with 8G and a B0 with 4G, and it seems to work on both, although the C0 might have been misbehaving a bit (likely unrelated). In both cases I swapped in the latest Pi foundation DT (https://github.com/raspberrypi/firmware/blob/master/boot/bcm2711-rpi-4-b.dtb) which uses the address you suggest, and it still seems to work either way (with or without the reset). If we reroll the PFTF firmware it is usually with the latest pi foundation DTs. So the first patch makes sense, but I think it should probably be checking both DT property names (pci0,0 and pci1,0) since we probably want maximum compatibility with differing DT's the user might swap in, and the upstream linux change which changes the node from 1,0 to 0,0 is from august of last year, so not old at all.. The second one, I'm less sure about, since the primary thing your changing (AFAIK) is whether the XHCI BIOS handoff is being checked, and since EDK2 supports the hand-off and Linux doesn't throw the XHCI bios failure message I think we actually want to leave that in place. If you have debugging turned on, the XHCI/LegacyBios ownership control is the message you see during exit boot services that says "XhciClearBiosOwnership: called to clear BIOS ownership". I suspect the kernel patch is yet another case of "UBOOT and/or the pi foundation firmware is broken so we fixed the kernel" Do you see a difference with/without the second patch? Here's my SyncPcie function with the range tweak applied [1] I'm running upstream linux 6.0-rc6 with the downstream device tree provided in [2] Thank you, Adrien [1] http://pastebin.test.redhat.com/1075875 [2] https://github.com/pftf/RPi4/releases/tag/v1.33 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94688): https://edk2.groups.io/g/devel/message/94688 Mute This Topic: https://groups.io/mt/94002759/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes
Hi Jeremy, > If you just add the range tweak, does that fix the XHCI config in your setup > too? I tested applying the range tweak in your patch, unfortunately it doesn't seem to work on my setup. I'm still getting "usb 1-1: device descriptor read/64, error -71" errors. Here's my SyncPcie function with the range tweak applied [1] I'm running upstream linux 6.0-rc6 with the downstream device tree provided in [2] Thank you, Adrien [1] http://pastebin.test.redhat.com/1075875 [2] https://github.com/pftf/RPi4/releases/tag/v1.33 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94598): https://edk2.groups.io/g/devel/message/94598 Mute This Topic: https://groups.io/mt/94002759/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes
On 9/29/22 14:53, Adrien Thierry wrote: This patch series does a few fixes in the SyncPcie() function, more specifically in the logic that deletes the pci node to prevent Linux from resetting the XHCI controller. Hmm, that code not being exactly right isn't surprising, I went through about a dozen revisions looking for the one that fixed it consistently and in the end this version worked with some older kernels (and likely dt) but doesn't work with any of the recent ones. But... I think I found an actual fix a couple months ago while testing the DT->SMCCC pci config space code. Which is to update the ranges property as well. With that change the firmware can reset the XHCI controller in recent Linux's, so there isn't a need to remove the XHCI node. There is a copy of the patch hiding on my github https://github.com/jlinton/edk2-platforms/commit/50540bd24f93b633c3597b5dc58c1a1a3b49bf7f#diff-373e67aaa16dd9ac2428d5acc3d73ef218b2ed6d24f3350d5af558cba03cf5adR378 along with a change to update the compatible property to pci-host-smc-generic and remove the ranges property which should be ignored... :) If you just add the range tweak, does that fix the XHCI config in your setup too? I really need to start getting many of those old/stale patches cleaned up and merged, but its not been a high priority. Adrien Thierry (2): Platform/RaspberryPi: fix pci DT node address in SyncPcie() Platform/RaspberryPi: delete usb node instead of pci in SyncPcie() Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: e55f0527dde48a5f139c1b8f35acc4e6b59dd794 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94572): https://edk2.groups.io/g/devel/message/94572 Mute This Topic: https://groups.io/mt/94002759/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes
This patch series does a few fixes in the SyncPcie() function, more specifically in the logic that deletes the pci node to prevent Linux from resetting the XHCI controller. Adrien Thierry (2): Platform/RaspberryPi: fix pci DT node address in SyncPcie() Platform/RaspberryPi: delete usb node instead of pci in SyncPcie() Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: e55f0527dde48a5f139c1b8f35acc4e6b59dd794 -- 2.37.3 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94533): https://edk2.groups.io/g/devel/message/94533 Mute This Topic: https://groups.io/mt/94002759/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
