Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei
Merged https://github.com/tianocore/edk2/pull/3814
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, December 21, 2022 4:13 PM
> To: Gerd Hoffmann ; devel@edk2.groups.io;
> anthony.per...@citrix.com
> Cc: Ard Biesheuvel ; Justen, Jordan L
>
> Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info
> HOB in XenPlatformPei
>
> Acked-by: Jiewen Yao
>
> > -Original Message-
> > From: Gerd Hoffmann
> > Sent: Tuesday, December 20, 2022 3:26 PM
> > To: devel@edk2.groups.io; anthony.per...@citrix.com
> > Cc: Ard Biesheuvel ; Yao, Jiewen
> > ; Justen, Jordan L
> > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform
> info
> > HOB in XenPlatformPei
> >
> > On Mon, Dec 19, 2022 at 04:36:20PM +, Anthony PERARD via groups.io
> > wrote:
> > > From: Anthony PERARD
> > >
> > > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
> > >
> > > QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> > > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not
> > > check if the HOB is actually present for example and try to use a NULL
> > > pointer.
> > >
> > > Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove
> > mQemuFwCfgSupported + mQemuFwCfgDmaSupported")
> > > Signed-off-by: Anthony PERARD
> >
> > Reviewed-by: Gerd Hoffmann
> >
> > You might also consider moving global variables to the PlatformInfoHob
> > or use PlatformInitLib functions instead of your own copy or both.
> >
> > take care,
> > Gerd
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97686): https://edk2.groups.io/g/devel/message/97686
Mute This Topic: https://groups.io/mt/95768201/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei
Acked-by: Jiewen Yao
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, December 20, 2022 3:26 PM
> To: devel@edk2.groups.io; anthony.per...@citrix.com
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L
> Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info
> HOB in XenPlatformPei
>
> On Mon, Dec 19, 2022 at 04:36:20PM +, Anthony PERARD via groups.io
> wrote:
> > From: Anthony PERARD
> >
> > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
> >
> > QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not
> > check if the HOB is actually present for example and try to use a NULL
> > pointer.
> >
> > Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove
> mQemuFwCfgSupported + mQemuFwCfgDmaSupported")
> > Signed-off-by: Anthony PERARD
>
> Reviewed-by: Gerd Hoffmann
>
> You might also consider moving global variables to the PlatformInfoHob
> or use PlatformInitLib functions instead of your own copy or both.
>
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97682): https://edk2.groups.io/g/devel/message/97682
Mute This Topic: https://groups.io/mt/95768201/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei
On Mon, Dec 19, 2022 at 04:36:20PM +, Anthony PERARD via groups.io wrote:
> From: Anthony PERARD
>
> Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
>
> QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not
> check if the HOB is actually present for example and try to use a NULL
> pointer.
>
> Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported +
> mQemuFwCfgDmaSupported")
> Signed-off-by: Anthony PERARD
Reviewed-by: Gerd Hoffmann
You might also consider moving global variables to the PlatformInfoHob
or use PlatformInitLib functions instead of your own copy or both.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97616): https://edk2.groups.io/g/devel/message/97616
Mute This Topic: https://groups.io/mt/95768201/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
