Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-20 Thread Ni, Ray 
OK. I see. I am fine with that.

Reviewed-by: Ray Ni 

> -Original Message-
> From: Guo, Gua 
> Sent: Tuesday, December 20, 2022 9:33 AM
> To: Ni, Ray ; Liu, KasimX ; 
> devel@edk2.groups.io
> Cc: Dong, Guo ; Lu, James 
> Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD
> 
> The goal reduce macro requirement to build UniversalPayloadBuild.py.
> 
> For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB.
> 
> For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate 
> HOB data.
> 
> So the change is move these PCD have compatibility FixedAtBuild only to 
> FixedAtBuild + Dynamic.
> 
> Thanks,
> Gua Guo
> 
> -Original Message-
> From: Ni, Ray 
> Sent: Monday, December 19, 2022 3:43 PM
> To: Liu, KasimX ; devel@edk2.groups.io
> Cc: Dong, Guo ; Lu, James ; Guo, Gua 
> 
> Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD
> 
> The initial goal was to remove dynamic PCD dependency from bootloader.
> Is that still the goal?
> If yes, maybe depending on dynamic PCD is not a good idea.
> 
> Thanks,
> Ray
> 
> > -Original Message-
> > From: Liu, KasimX 
> > Sent: Monday, December 19, 2022 3:40 PM
> > To: devel@edk2.groups.io
> > Cc: Liu, KasimX ; Dong, Guo
> > ; Ni, Ray ; Lu, James
> > ; Guo, Gua 
> > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD
> >
> > From: KasimX Liu 
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193
> >
> > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro
> > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to
> > PcdsDynamicEx
> >
> > Cc: Guo Dong 
> > Cc: Ray Ni 
> > Cc: James Lu 
> > Cc: Gua Guo 
> > Signed-off-by: KasimX Liu 
> > ---
> >  PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec
> > b/PcAtChipsetPkg/PcAtChipsetPkg.dec
> > index ed2d95550b..a53ca777e8 100644
> > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec
> > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec
> > @@ -84,6 +84,14 @@
> ># @Prompt RTC Target Register address
> >
> >
> > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x
> > 0023
> >
> >
> >
> > +  ## Specifies RTC Index Register address in I/O space.
> >
> > +  # @Prompt RTC Index Register address
> >
> > +
> > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0
> > + 01E
> >
> > +
> >
> > +  ## Specifies RTC Target Register address in I/O space.
> >
> > +  # @Prompt RTC Target Register address
> >
> > +
> > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x
> > + 001F
> >
> > +
> >
> >  [PcdsFixedAtBuild, PcdsPatchableInModule]
> >
> >## Defines the ACPI register set base address.
> >
> >#  The invalid 0x is as its default value. It must be configured to 
> > the real value.
> >
> > @@ -146,14 +154,6 @@
> ># @Prompt Initial value for Register_D in RTC.
> >
> >
> > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0
> > x001D
> >
> >
> >
> > -  ## Specifies RTC Index Register address in I/O space.
> >
> > -  # @Prompt RTC Index Register address
> >
> > -
> > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x001
> > E
> >
> > -
> >
> > -  ## Specifies RTC Target Register address in I/O space.
> >
> > -  # @Prompt RTC Target Register address
> >
> > -
> > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x00
> > 1F
> >
> > -
> >
> >## RTC Update Timeout Value(microsecond).
> >
> ># @Prompt RTC Update Timeout Value.
> >
> >
> > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|10|UIN
> > T32|0x0020
> >
> > --
> > 2.32.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97625): https://edk2.groups.io/g/devel/message/97625
Mute This Topic: https://groups.io/mt/95760949/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-19 Thread Guo, Gua 
The goal reduce macro requirement to build UniversalPayloadBuild.py.

For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB.

For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate 
HOB data.

So the change is move these PCD have compatibility FixedAtBuild only to 
FixedAtBuild + Dynamic.

Thanks,
Gua Guo

-Original Message-
From: Ni, Ray  
Sent: Monday, December 19, 2022 3:43 PM
To: Liu, KasimX ; devel@edk2.groups.io
Cc: Dong, Guo ; Lu, James ; Guo, Gua 

Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

The initial goal was to remove dynamic PCD dependency from bootloader.
Is that still the goal?
If yes, maybe depending on dynamic PCD is not a good idea.

Thanks,
Ray

> -Original Message-
> From: Liu, KasimX 
> Sent: Monday, December 19, 2022 3:40 PM
> To: devel@edk2.groups.io
> Cc: Liu, KasimX ; Dong, Guo 
> ; Ni, Ray ; Lu, James 
> ; Guo, Gua 
> Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD
> 
> From: KasimX Liu 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193
> 
> In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro 
> list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to 
> PcdsDynamicEx
> 
> Cc: Guo Dong 
> Cc: Ray Ni 
> Cc: James Lu 
> Cc: Gua Guo 
> Signed-off-by: KasimX Liu 
> ---
>  PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec 
> b/PcAtChipsetPkg/PcAtChipsetPkg.dec
> index ed2d95550b..a53ca777e8 100644
> --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec
> +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec
> @@ -84,6 +84,14 @@
># @Prompt RTC Target Register address
> 
>
> gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x
> 0023
> 
> 
> 
> +  ## Specifies RTC Index Register address in I/O space.
> 
> +  # @Prompt RTC Index Register address
> 
> +  
> + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0
> + 01E
> 
> +
> 
> +  ## Specifies RTC Target Register address in I/O space.
> 
> +  # @Prompt RTC Target Register address
> 
> +  
> + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x
> + 001F
> 
> +
> 
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
> 
>## Defines the ACPI register set base address.
> 
>#  The invalid 0x is as its default value. It must be configured to 
> the real value.
> 
> @@ -146,14 +154,6 @@
># @Prompt Initial value for Register_D in RTC.
> 
>
> gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0
> x001D
> 
> 
> 
> -  ## Specifies RTC Index Register address in I/O space.
> 
> -  # @Prompt RTC Index Register address
> 
> -  
> gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x001
> E
> 
> -
> 
> -  ## Specifies RTC Target Register address in I/O space.
> 
> -  # @Prompt RTC Target Register address
> 
> -  
> gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x00
> 1F
> 
> -
> 
>## RTC Update Timeout Value(microsecond).
> 
># @Prompt RTC Update Timeout Value.
> 
>
> gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|10|UIN
> T32|0x0020
> 
> --
> 2.32.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97596): https://edk2.groups.io/g/devel/message/97596
Mute This Topic: https://groups.io/mt/95760949/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-18 Thread Ni, Ray 
The initial goal was to remove dynamic PCD dependency from bootloader.
Is that still the goal?
If yes, maybe depending on dynamic PCD is not a good idea.

Thanks,
Ray

> -Original Message-
> From: Liu, KasimX 
> Sent: Monday, December 19, 2022 3:40 PM
> To: devel@edk2.groups.io
> Cc: Liu, KasimX ; Dong, Guo ; Ni, 
> Ray ; Lu, James
> ; Guo, Gua 
> Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD
> 
> From: KasimX Liu 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193
> 
> In order to remove RTC_INDEX/RTC_TARGET from
> the UplBuild macro list,change the RTC_INDEX
> /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx
> 
> Cc: Guo Dong 
> Cc: Ray Ni 
> Cc: James Lu 
> Cc: Gua Guo 
> Signed-off-by: KasimX Liu 
> ---
>  PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec 
> b/PcAtChipsetPkg/PcAtChipsetPkg.dec
> index ed2d95550b..a53ca777e8 100644
> --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec
> +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec
> @@ -84,6 +84,14 @@
># @Prompt RTC Target Register address
> 
>gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0023
> 
> 
> 
> +  ## Specifies RTC Index Register address in I/O space.
> 
> +  # @Prompt RTC Index Register address
> 
> +  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x001E
> 
> +
> 
> +  ## Specifies RTC Target Register address in I/O space.
> 
> +  # @Prompt RTC Target Register address
> 
> +  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x001F
> 
> +
> 
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
> 
>## Defines the ACPI register set base address.
> 
>#  The invalid 0x is as its default value. It must be configured to 
> the real value.
> 
> @@ -146,14 +154,6 @@
># @Prompt Initial value for Register_D in RTC.
> 
>
> gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0x001D
> 
> 
> 
> -  ## Specifies RTC Index Register address in I/O space.
> 
> -  # @Prompt RTC Index Register address
> 
> -  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x001E
> 
> -
> 
> -  ## Specifies RTC Target Register address in I/O space.
> 
> -  # @Prompt RTC Target Register address
> 
> -  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x001F
> 
> -
> 
>## RTC Update Timeout Value(microsecond).
> 
># @Prompt RTC Update Timeout Value.
> 
>
> gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|10|UINT32|0x0020
> 
> --
> 2.32.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97550): https://edk2.groups.io/g/devel/message/97550
Mute This Topic: https://groups.io/mt/95760949/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-