Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
W dniu 4.04.2023 o 20:29, Michael D Kinney pisze: Add GCC and leave GCC5 for now and give time for all downstream consumers to accommodate the name change. At a later date, remove GCC5. In meantime you may also have message "GCC5 is deprecated, please switch to GCC" + few seconds delay. We handled deprecation in one project that way. For EDK2 I would add such message at start and at the end of build process. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102611): https://edk2.groups.io/g/devel/message/102611 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On Tue, 4 Apr 2023 at 20:36, Rebecca Cran wrote: > > Thanks, deprecating it for a while makes a lot of sense. We can consider > removing it in 6-12 months maybe? > I would at least wait for a stable release to appear that supports both GCC5 and GCC/GCCNOLTO, and then perhaps queue the removal (and document it) for the subsequent one? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102552): https://edk2.groups.io/g/devel/message/102552 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Thanks, deprecating it for a while makes a lot of sense. We can consider removing it in 6-12 months maybe? -- Rebecca Cran On 4/4/2023 12:29 PM, Kinney, Michael D wrote: Add GCC and leave GCC5 for now and give time for all downstream consumers to accommodate the name change. At a later date, remove GCC5. We have seen significant downstream issues on name changes in the past. Splitting into 2 different patch series allows downstream to merge in the change that adds the new name. Give time to update all dependencies to use the new name, and then at a later date remove the old name. This is a common practice to announce deprecation and support new and old for a period of time. Mike -Original Message- From: Rebecca Cran Sent: Tuesday, April 4, 2023 11:04 AM To: Pedro Falcato ; Kinney, Michael D Cc: devel@edk2.groups.io; Leif Lindholm ; Gao, Liming ; Oliver Smith- Denny ; Jiang, Guomin ; Lu, Xiaoyu1 ; Wang, Jian J ; Yao, Jiewen ; Ard Biesheuvel ; Justen, Jordan L ; Gerd Hoffmann ; Feng, Bob C ; Andrew Fish Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC On 4/4/23 11:57 AM, Pedro Falcato wrote: On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D wrote: I see value in adding a new name. I see no value in a non-backwards compatible change to delete/rename a fully supported one. As Leif said, you reduce all sorts of possible confusion. VS2013 builds only for Visual Studio 2013 tools, VS2017 does the same for 2017, GCC5 meanwhile builds on anything from (probably GCC 4.x, since LTO, 2011) to GCC 13 (to be released soon, 2023). Surely downstreams can adapt to *this one cosmetic change* that changes no behavior. Nope, GCC5 currently only builds on GCC _6_ and newer, since we don't specify -std=c++11. Which makes this discussion even more ridiculous IMO. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102533): https://edk2.groups.io/g/devel/message/102533 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Add GCC and leave GCC5 for now and give time for all downstream consumers to accommodate the name change. At a later date, remove GCC5. We have seen significant downstream issues on name changes in the past. Splitting into 2 different patch series allows downstream to merge in the change that adds the new name. Give time to update all dependencies to use the new name, and then at a later date remove the old name. This is a common practice to announce deprecation and support new and old for a period of time. Mike > -Original Message- > From: Rebecca Cran > Sent: Tuesday, April 4, 2023 11:04 AM > To: Pedro Falcato ; Kinney, Michael D > > Cc: devel@edk2.groups.io; Leif Lindholm ; Gao, > Liming ; Oliver Smith- > Denny ; Jiang, Guomin ; Lu, > Xiaoyu1 ; Wang, Jian J > ; Yao, Jiewen ; Ard Biesheuvel > ; Justen, Jordan L > ; Gerd Hoffmann ; Feng, Bob C > ; Andrew Fish > > Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] > BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete > CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS > 2008-2013, EBC > > > On 4/4/23 11:57 AM, Pedro Falcato wrote: > > On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D > > wrote: > >> I see value in adding a new name. > >> > >> I see no value in a non-backwards compatible change to delete/rename a > >> fully supported one. > > As Leif said, you reduce all sorts of possible confusion. > > > > VS2013 builds only for Visual Studio 2013 tools, VS2017 does the same > > for 2017, GCC5 meanwhile builds on anything from (probably GCC 4.x, > > since LTO, 2011) to GCC 13 (to be released soon, 2023). > > > > Surely downstreams can adapt to *this one cosmetic change* that > > changes no behavior. > > Nope, GCC5 currently only builds on GCC _6_ and newer, since we don't > specify -std=c++11. Which makes this discussion even more ridiculous IMO. > > > -- > Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102532): https://edk2.groups.io/g/devel/message/102532 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On Tue, 4 Apr 2023 at 20:03, Rebecca Cran wrote: > > > On 4/4/23 11:57 AM, Pedro Falcato wrote: > > On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D > > wrote: > >> I see value in adding a new name. > >> > >> I see no value in a non-backwards compatible change to delete/rename a > >> fully supported one. > > As Leif said, you reduce all sorts of possible confusion. > > > > VS2013 builds only for Visual Studio 2013 tools, VS2017 does the same > > for 2017, GCC5 meanwhile builds on anything from (probably GCC 4.x, > > since LTO, 2011) to GCC 13 (to be released soon, 2023). > > > > Surely downstreams can adapt to *this one cosmetic change* that > > changes no behavior. > > Nope, GCC5 currently only builds on GCC _6_ and newer, since we don't > specify -std=c++11. Which makes this discussion even more ridiculous IMO. > > I agree with Mike here. 'GCC' does not exist today, so dropping GCC5 at the same time makes this a flag day change, which is never great. Imagine having to bisect through that, and having to figure out at each step whether to use GCC5 or GCC. It's much better to have GCC5 and GCC co-exist for a little while, even if the former only exists as an alias that is documented as being obsolete and scheduled for removal. -- Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102531): https://edk2.groups.io/g/devel/message/102531 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On 4/4/23 11:57 AM, Pedro Falcato wrote: On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D wrote: I see value in adding a new name. I see no value in a non-backwards compatible change to delete/rename a fully supported one. As Leif said, you reduce all sorts of possible confusion. VS2013 builds only for Visual Studio 2013 tools, VS2017 does the same for 2017, GCC5 meanwhile builds on anything from (probably GCC 4.x, since LTO, 2011) to GCC 13 (to be released soon, 2023). Surely downstreams can adapt to *this one cosmetic change* that changes no behavior. Nope, GCC5 currently only builds on GCC _6_ and newer, since we don't specify -std=c++11. Which makes this discussion even more ridiculous IMO. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102517): https://edk2.groups.io/g/devel/message/102517 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D wrote: > > I see value in adding a new name. > > I see no value in a non-backwards compatible change to delete/rename a fully > supported one. As Leif said, you reduce all sorts of possible confusion. VS2013 builds only for Visual Studio 2013 tools, VS2017 does the same for 2017, GCC5 meanwhile builds on anything from (probably GCC 4.x, since LTO, 2011) to GCC 13 (to be released soon, 2023). Surely downstreams can adapt to *this one cosmetic change* that changes no behavior. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102515): https://edk2.groups.io/g/devel/message/102515 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
I see value in adding a new name. I see no value in a non-backwards compatible change to delete/rename a fully supported one. Mike > -Original Message- > From: Rebecca Cran > Sent: Tuesday, April 4, 2023 10:49 AM > To: Kinney, Michael D ; devel@edk2.groups.io; > Leif Lindholm ; > pedro.falc...@gmail.com > Cc: Gao, Liming ; Oliver Smith-Denny > ; Jiang, Guomin > ; Lu, Xiaoyu1 ; Wang, Jian J > ; Yao, Jiewen > ; Ard Biesheuvel ; Justen, > Jordan L ; Gerd > Hoffmann ; Feng, Bob C ; Andrew Fish > > Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] > BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete > CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS > 2008-2013, EBC > > I've already added changes to the patch series to fix EDK2 CI to use the > new name. Fortunately there aren't many places that need updated. > > Downstream scripts should be trivial to change: just do a find/replace > for GCC5. > > > -- > Rebecca Cran > > > On 4/4/23 11:45 AM, Kinney, Michael D wrote: > > Changing the toolchain tag name from GCC5 to GCC will break > > EDK II CI and likely 100's of downstream developer/CI scripts. > > > > Can we keep GCC5 and add GCC that is identical to GCC5? > > > > Mike > > > >> -Original Message- > >> From: devel@edk2.groups.io On Behalf Of Rebecca Cran > >> Sent: Tuesday, April 4, 2023 10:01 AM > >> To: Leif Lindholm ; devel@edk2.groups.io; > >> pedro.falc...@gmail.com > >> Cc: Gao, Liming ; Oliver Smith-Denny > >> ; Jiang, Guomin > >> ; Lu, Xiaoyu1 ; Wang, Jian J > >> ; Yao, Jiewen > >> ; Ard Biesheuvel ; > >> Justen, Jordan L ; Gerd > >> Hoffmann ; Feng, Bob C ; Andrew > >> Fish ; Kinney, Michael D > >> > >> Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] > >> BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete > >> CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete > >> VS 2008-2013, EBC > >> > >> > >> On 4/4/23 10:32 AM, Leif Lindholm wrote: > >>> On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: > >>>> On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: > >>>>> Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 > >>>>> and GCC5. > >>>> Please rename them? There's no point in keeping their current names > >>>> anyway. I guarantee you that most people are not really able to guess > >>>> GCC49 to be the "non-LTO" flavor. > >>>> > >>>> And IMO Ard has already proved the value in non-LTO builds anyway, so > >>>> yeah. GCC and GCCNOLTO please. > >>> Agreed. I don't think there are any outstanding items that need > >>> resolving. > >>> > >>> I'd be very happy to stop hearing "you need GCC 5 in order to build > >>> edk2" misunderstandings. > >> Thanks! As a new co-maintainer I was trying to be diplomatic, but I > >> really don't see any reason to keep the existing names. > >> > >> I'll send out a v3 patch series with all the fixes I and others have > >> identified. > >> > >> > >> -- > >> Rebecca Cran > >> > >> > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102514): https://edk2.groups.io/g/devel/message/102514 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
I've already added changes to the patch series to fix EDK2 CI to use the new name. Fortunately there aren't many places that need updated. Downstream scripts should be trivial to change: just do a find/replace for GCC5. -- Rebecca Cran On 4/4/23 11:45 AM, Kinney, Michael D wrote: Changing the toolchain tag name from GCC5 to GCC will break EDK II CI and likely 100's of downstream developer/CI scripts. Can we keep GCC5 and add GCC that is identical to GCC5? Mike -Original Message- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Tuesday, April 4, 2023 10:01 AM To: Leif Lindholm ; devel@edk2.groups.io; pedro.falc...@gmail.com Cc: Gao, Liming ; Oliver Smith-Denny ; Jiang, Guomin ; Lu, Xiaoyu1 ; Wang, Jian J ; Yao, Jiewen ; Ard Biesheuvel ; Justen, Jordan L ; Gerd Hoffmann ; Feng, Bob C ; Andrew Fish ; Kinney, Michael D Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC On 4/4/23 10:32 AM, Leif Lindholm wrote: On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 and GCC5. Please rename them? There's no point in keeping their current names anyway. I guarantee you that most people are not really able to guess GCC49 to be the "non-LTO" flavor. And IMO Ard has already proved the value in non-LTO builds anyway, so yeah. GCC and GCCNOLTO please. Agreed. I don't think there are any outstanding items that need resolving. I'd be very happy to stop hearing "you need GCC 5 in order to build edk2" misunderstandings. Thanks! As a new co-maintainer I was trying to be diplomatic, but I really don't see any reason to keep the existing names. I'll send out a v3 patch series with all the fixes I and others have identified. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102513): https://edk2.groups.io/g/devel/message/102513 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Changing the toolchain tag name from GCC5 to GCC will break EDK II CI and likely 100's of downstream developer/CI scripts. Can we keep GCC5 and add GCC that is identical to GCC5? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Tuesday, April 4, 2023 10:01 AM > To: Leif Lindholm ; devel@edk2.groups.io; > pedro.falc...@gmail.com > Cc: Gao, Liming ; Oliver Smith-Denny > ; Jiang, Guomin > ; Lu, Xiaoyu1 ; Wang, Jian J > ; Yao, Jiewen > ; Ard Biesheuvel ; Justen, > Jordan L ; Gerd > Hoffmann ; Feng, Bob C ; Andrew Fish > ; Kinney, Michael D > > Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] > BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete > CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS > 2008-2013, EBC > > > On 4/4/23 10:32 AM, Leif Lindholm wrote: > > On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: > >> On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: > >>> Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 > >>> and GCC5. > >> Please rename them? There's no point in keeping their current names > >> anyway. I guarantee you that most people are not really able to guess > >> GCC49 to be the "non-LTO" flavor. > >> > >> And IMO Ard has already proved the value in non-LTO builds anyway, so > >> yeah. GCC and GCCNOLTO please. > > Agreed. I don't think there are any outstanding items that need > > resolving. > > > > I'd be very happy to stop hearing "you need GCC 5 in order to build > > edk2" misunderstandings. > > Thanks! As a new co-maintainer I was trying to be diplomatic, but I > really don't see any reason to keep the existing names. > > I'll send out a v3 patch series with all the fixes I and others have > identified. > > > -- > Rebecca Cran > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102512): https://edk2.groups.io/g/devel/message/102512 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On 4/4/23 10:32 AM, Leif Lindholm wrote: On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 and GCC5. Please rename them? There's no point in keeping their current names anyway. I guarantee you that most people are not really able to guess GCC49 to be the "non-LTO" flavor. And IMO Ard has already proved the value in non-LTO builds anyway, so yeah. GCC and GCCNOLTO please. Agreed. I don't think there are any outstanding items that need resolving. I'd be very happy to stop hearing "you need GCC 5 in order to build edk2" misunderstandings. Thanks! As a new co-maintainer I was trying to be diplomatic, but I really don't see any reason to keep the existing names. I'll send out a v3 patch series with all the fixes I and others have identified. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102510): https://edk2.groups.io/g/devel/message/102510 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: > On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: > > > > Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 > > and GCC5. > > Please rename them? There's no point in keeping their current names > anyway. I guarantee you that most people are not really able to guess > GCC49 to be the "non-LTO" flavor. > > And IMO Ard has already proved the value in non-LTO builds anyway, so > yeah. GCC and GCCNOLTO please. Agreed. I don't think there are any outstanding items that need resolving. I'd be very happy to stop hearing "you need GCC 5 in order to build edk2" misunderstandings. / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102501): https://edk2.groups.io/g/devel/message/102501 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: > > Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 > and GCC5. Please rename them? There's no point in keeping their current names anyway. I guarantee you that most people are not really able to guess GCC49 to be the "non-LTO" flavor. And IMO Ard has already proved the value in non-LTO builds anyway, so yeah. GCC and GCCNOLTO please. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102497): https://edk2.groups.io/g/devel/message/102497 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 and GCC5. -- Rebecca Cran On 4/3/23 7:31 PM, gaoliming wrote: Rebecca: There are more discussion on GCC49 tool chain. So, I think it is the safe way to keep GCC49 and GCC5 now. We can make the changes for other tool chains first. Thanks Liming -邮件原件- 发件人: Rebecca Cran 发送时间: 2023年4月3日 5:51 收件人: Pedro Falcato ; devel@edk2.groups.io 抄送: gaoliming ; Oliver Smith-Denny ; Guomin Jiang ; Xiaoyu Lu ; Jian J Wang ; Jiewen Yao ; Ard Biesheuvel ; Jordan Justen ; Gerd Hoffmann ; Bob Feng ; Andrew Fish ; Leif Lindholm ; Michael D Kinney 主题: Re: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC On 4/2/23 12:38 PM, Pedro Falcato wrote: As expressed off-list on UEFI talkbox, I like GCCNOLTO, but I would rather keep GCC5 as GCC5, for the next future iteration of "lets bump a new toolchain because we need feature X". Given we've gone from GCC 5 through 12 with no new toolchains, I'd prefer to just have GCC. This is unsurprising, plenty of NOLTO build breakage. Since no one seems to use this, could we think about axing this or? Just seems silly to have an extra toolchain (with extra cognitive overhead for anyone looking at tools_def) for s/-flto//g Since Liming wants to keep it, let's make all the other changes (deleting VS 2008-2013, CLANG35, CLANG38 etc.) and keep GCCNOLTO and GCC for now. If nobody fixes the problems with GCCNOLTO, maybe we can revisit dropping it in a few months? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102496): https://edk2.groups.io/g/devel/message/102496 Mute This Topic: https://groups.io/mt/98051589/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
