RE: Problem with SMPP smsc-password being too long
> 2002-07-05 20:51:43 [0] INFO: MAIN: Start-up done, entering mainloop > 2002-07-05 20:51:43 [8] DEBUG: sms_router: time to sleep > 2002-07-05 20:51:43 [8] DEBUG: sms_router: list_len = 0 > 2002-07-05 20:51:43 [6] PANIC: gw/smpp_pdu.def:60: smpp_pdu_pack: > Assertion > `octstr_len(p->password) < 9' failed. re ... I understand that the password being longer is not allowed, but closeing with panic is not bad idea on simple configuration mistake. should not it be a warning/error, but to allow to continue? the same about all other similar checks - quitting with panic if even a part of the system can run, is not a good idea. and note if somebody will take a time and re-code kannel so that smsc connections can be reconfigured and added on-line, such a practice is not acceptable anyway ... kaido
RE: Problem with SMPP smsc-password being too long
> > 2002-07-05 20:51:43 [0] INFO: MAIN: Start-up done, entering mainloop > > 2002-07-05 20:51:43 [8] DEBUG: sms_router: time to sleep > > 2002-07-05 20:51:43 [8] DEBUG: sms_router: list_len = 0 > > 2002-07-05 20:51:43 [6] PANIC: gw/smpp_pdu.def:60: smpp_pdu_pack: > > Assertion > > `octstr_len(p->password) < 9' failed. > > > re ... > > I understand that the password being longer is not allowed, but closeing > with panic is not bad idea on simple configuration mistake. huff .. my typo: it should read: ' .. is not good idea .. ' :) kaido
Re: Problem with SMPP smsc-password being too long
Kaido Karner wrote: > > > 2002-07-05 20:51:43 [0] INFO: MAIN: Start-up done, entering mainloop > > 2002-07-05 20:51:43 [8] DEBUG: sms_router: time to sleep > > 2002-07-05 20:51:43 [8] DEBUG: sms_router: list_len = 0 > > 2002-07-05 20:51:43 [6] PANIC: gw/smpp_pdu.def:60: smpp_pdu_pack: > > Assertion > > `octstr_len(p->password) < 9' failed. > > re ... > > I understand that the password being longer is not allowed, but closeing > with panic is not bad idea on simple configuration mistake. should not it be > a warning/error, but to allow to continue? the same about all other similar > checks - quitting with panic if even a part of the system can run, is not a > good idea. and note if somebody will take a time and re-code kannel so that > smsc connections can be reconfigured and added on-line, such a practice is > not acceptable anyway ... contiue? why? the password is logically longer than 8 octects, but the SMPP spec does not accept it to put it in the appropriate PDUs. So what should you do then? Cut the Password to 8 chars long and send the login sequence anyway? No, I don't think so. The assertion check fails, and a failing assertion check means a non recoverable state within the system, hence panic! This is my opinion about the functional logic. Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
RE: Problem with SMPP smsc-password being too long
> contiue? why? why? to allow other connections to come up and run .. > the password is logically longer than 8 octects, but the > SMPP spec does not accept it to put it in the appropriate PDUs. So > what should you do then? Cut the Password to 8 chars long and send the > login sequence anyway? No, I don't think so. > The assertion check fails, and a failing assertion check means a non > recoverable state within the system, hence panic! This is my opinion > about the functional logic. disable/ignore the violating connection, and let other stuff run .. k
Re: Problem with SMPP smsc-password being too long
On Mon, 8 Jul 2002, Stipe Tolj wrote: > contiue? why? the password is logically longer than 8 octects, but the > SMPP spec does not accept it to put it in the appropriate PDUs. So > what should you do then? Cut the Password to 8 chars long and send the > login sequence anyway? No, I don't think so. > > The assertion check fails, and a failing assertion check means a non > recoverable state within the system, hence panic! This is my opinion > about the functional logic. But if you want to implement reloading of the configuration, non-fatal errors should not cause panic (in fact, no error except running out of memory, perhaps. Just revert to old configuration if the new one is unacceptable). And this error is not fatal, it simply means that this SMPP connection cannot be used (well, sort of). If you want to exit because of faulty configuration that is okay, but panic should be avoided as long as possible (and it is horror to debug panics ;) -- &kalle marjola product concept manager NETikos finland (http://www.netikos.fi)
Re: Problem with SMPP smsc-password being too long
Kaido Karner wrote: 2002-07-05 20:51:43 [0] INFO: MAIN: Start-up done, entering mainloop 2002-07-05 20:51:43 [8] DEBUG: sms_router: time to sleep 2002-07-05 20:51:43 [8] DEBUG: sms_router: list_len = 0 2002-07-05 20:51:43 [6] PANIC: gw/smpp_pdu.def:60: smpp_pdu_pack: Assertion `octstr_len(p->password) < 9' failed. re ... I understand that the password being longer is not allowed, but closeing with panic is not bad idea on simple configuration mistake. should not it be a warning/error, but to allow to continue? the same about all other similar checks - quitting with panic if even a part of the system can run, is not a good idea. and note if somebody will take a time and re-code kannel so that smsc connections can be reconfigured and added on-line, such a practice is not acceptable anyway ... You are right - the module should simply terminate with an error and not a panic, the way that other modules are doing when encountering a configuration error. -- Oded Arbel m-Wise mobile solutions
Re: Problem with SMPP smsc-password being too long
> You are right - the module should simply terminate with an error and > not a panic, the way that other modules are doing when encountering > a configuration error. In this case we should not do assertion checking here, right?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: Problem with SMPP smsc-password being too long
Stipe Tolj wrote: You are right - the module should simply terminate with an error and not a panic, the way that other modules are doing when encountering a configuration error. In this case we should not do assertion checking here, right?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are My thought exactly. assertion is when some error is so greivous that the entire system must go down (IMO - there is no such error condition : everything can be delt with properly), this is clearly not the case. -- Oded Arbel m-Wise mobile solutions
