Re: [PATCH] Service routing based on the account field
Alejandro Guerrieri wrote: I've noticed there were no way for Kannel to do service routing based on the account field. This is specially handy when you use an HTTP module to receive messages and the smsc gets encoded on the account field, so you get a single smsc with different accounts depending on the carrier. I'm attaching a patch that adds two new sms-service parameters: accepted-account and accepted-account-regex. Their functionality it's exactly as their smsc counterparts (accepted-smsc and accepted-smsc-regex) only that they do their logic on the account field. Hi Alejandro, we have pretty hot temperatures currently in central europe, maybe it's because of that... but I didn't get the point for this one :) This sounds to me like you use a HTTP SMSC module (maybe even own API?) and then use the passed 'account' field to 'represent' the smsc-id ? So it seems to me that you have one inbound (MO) HTTP SMSC that passes you MOs from several operators, and provides you an 'account id' whole passing the MO. You put the MO into account and would like to route on smsbox level via account. Right? If this is the case, then Kannel does not know about that multi-plexing of operators behing the logical _ONE_ HTTP SMSC. I'm not quite sure if we should support this behaviour, since it does not corelate with generical architecture assuptions of Kannel. I'm currently between -0 and +0 for this, until none of you guys can explain why this is the super-fancy-we-have-to-have-it-feature ;) A GENERAL NOTE: We, and I really think I can talk to others that contribute to Kannel and mostly to those that have cvs write permission and those that shortly may have (we have some candidates on the list ;) _appritiate_ any patch that people submit and they feel it's a benefit to Kannel. So please don't get upsad, if we have our critisicm on it. We try to deal with all corners of the perspective. Some contributers do not, they see their own need and usually have a more subjective way in seeing the need of a patch. Stipe --- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org ---
Re: [PATCH] Service routing based on account field
Alejandro Guerrieri wrote: Seems like the list server rejected my last email because of the attachment, here goes again with the patch inline. g don't inline patches, we'll never get them out of the mail clean for review and patching local test trees. :( At least I got the last mail with the patch attached. Currently we have a limit of 40k for attachements. Your patch should be definetly 40k. Stipe --- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org ---
RE: [PATCH] Service routing based on the account field
I agree with Stipe on this one (for a change ;]). Why don't you just use smsc-id for what you want to accomplish? Or otherwise: Please explain more. Rene Kluwen Chimit -Original Message- From: Stipe Tolj [mailto:[EMAIL PROTECTED] Sent: zaterdag 22 juli 2006 14:14 To: Alejandro Guerrieri Cc: devel@kannel.org Subject: Re: [PATCH] Service routing based on the account field Alejandro Guerrieri wrote: I've noticed there were no way for Kannel to do service routing based on the account field. This is specially handy when you use an HTTP module to receive messages and the smsc gets encoded on the account field, so you get a single smsc with different accounts depending on the carrier. I'm attaching a patch that adds two new sms-service parameters: accepted-account and accepted-account-regex. Their functionality it's exactly as their smsc counterparts (accepted-smsc and accepted-smsc-regex) only that they do their logic on the account field. Hi Alejandro, we have pretty hot temperatures currently in central europe, maybe it's because of that... but I didn't get the point for this one :) This sounds to me like you use a HTTP SMSC module (maybe even own API?) and then use the passed 'account' field to 'represent' the smsc-id ? So it seems to me that you have one inbound (MO) HTTP SMSC that passes you MOs from several operators, and provides you an 'account id' whole passing the MO. You put the MO into account and would like to route on smsbox level via account. Right? If this is the case, then Kannel does not know about that multi-plexing of operators behing the logical _ONE_ HTTP SMSC. I'm not quite sure if we should support this behaviour, since it does not corelate with generical architecture assuptions of Kannel. I'm currently between -0 and +0 for this, until none of you guys can explain why this is the super-fancy-we-have-to-have-it-feature ;) A GENERAL NOTE: We, and I really think I can talk to others that contribute to Kannel and mostly to those that have cvs write permission and those that shortly may have (we have some candidates on the list ;) _appritiate_ any patch that people submit and they feel it's a benefit to Kannel. So please don't get upsad, if we have our critisicm on it. We try to deal with all corners of the perspective. Some contributers do not, they see their own need and usually have a more subjective way in seeing the need of a patch. Stipe --- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org ---
Re: [PATCH] Service routing based on account field
I've provided a link also. I know inliners are problematic, but I've received a filtered content reply and I thought it was from the list server. It turned out it was from a subscriber having an email content filtering replying to list messages. Sorry for posting twice, then. Regards, On 7/22/06, Stipe Tolj [EMAIL PROTECTED] wrote: Alejandro Guerrieri wrote: Seems like the list server rejected my last email because of the attachment, here goes again with the patch inline. g don't inline patches, we'll never get them out of the mail clean for review and patching local test trees. :( At least I got the last mail with the patch attached. Currently we have a limit of 40k for attachements. Your patch should be definetly 40k. Stipe --- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org --- -- Alejandro Guerrieri Magicom http://www.magicom-bcn.net/ LinkedIn: http://www.linkedin.com/in/aguerrieri
Re: [PATCH] Service routing based on the account field
Stipe, Rene, We work with aggregators from around the world, and we are using many flavors of the HTTP smsc modules (we even made a couple of modules to support specific cases). The scenario is exactly as you described it: The account field is used to encode the real operator's smsc id, since the aggregator appears to kannel as a single smsc. Regarding architectural assumptions, I'll quote the user guide: %o account identifier/information of incoming message. The value depends on the SMSC module and has been introduced to allow the forwarding of an operator ID from aggregator SMSCs to the application layer, hence the smsbox HTTP calling instance. So it seems that this was one of the purposes for the account field. It looked logic to me to be able to do some routing on it, so that's why I've made that patch. It works for us, maybe it's useful for other people. I don't think it hurts to have this feature available, but I'm not the one deciding here :) Regarding criticism, don't be afraid, I won't get mad at it, all the contrary! I don't pretend for you guys to include this patch in the core kannel at all. I've just feel that it's a nice feature to have and maybe other people are having similar scenarios as I do, so making it public could help other kannel users. YOU (meaning core kannel developers in general) have all the rights in the world to decide what's right and what's not regarding kannel. I think maybe other kannel users may benefit from this patch, and maybe if you consider it's worth having it on the core could be applied to CVS, but as I've said before, that wasn't the reason why I've send it. Best regards, Alejandro. On 7/22/06, Stipe Tolj [EMAIL PROTECTED] wrote: Alejandro Guerrieri wrote: I've noticed there were no way for Kannel to do service routing based on the account field. This is specially handy when you use an HTTP module to receive messages and the smsc gets encoded on the account field, so you get a single smsc with different accounts depending on the carrier. I'm attaching a patch that adds two new sms-service parameters: accepted-account and accepted-account-regex. Their functionality it's exactly as their smsc counterparts (accepted-smsc and accepted-smsc-regex) only that they do their logic on the account field. Hi Alejandro, we have pretty hot temperatures currently in central europe, maybe it's because of that... but I didn't get the point for this one :) This sounds to me like you use a HTTP SMSC module (maybe even own API?) and then use the passed 'account' field to 'represent' the smsc-id ? So it seems to me that you have one inbound (MO) HTTP SMSC that passes you MOs from several operators, and provides you an 'account id' whole passing the MO. You put the MO into account and would like to route on smsbox level via account. Right? If this is the case, then Kannel does not know about that multi-plexing of operators behing the logical _ONE_ HTTP SMSC. I'm not quite sure if we should support this behaviour, since it does not corelate with generical architecture assuptions of Kannel. I'm currently between -0 and +0 for this, until none of you guys can explain why this is the super-fancy-we-have-to-have-it-feature ;) A GENERAL NOTE: We, and I really think I can talk to others that contribute to Kannel and mostly to those that have cvs write permission and those that shortly may have (we have some candidates on the list ;) _appritiate_ any patch that people submit and they feel it's a benefit to Kannel. So please don't get upsad, if we have our critisicm on it. We try to deal with all corners of the perspective. Some contributers do not, they see their own need and usually have a more subjective way in seeing the need of a patch. Stipe --- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org --- -- Alejandro Guerrieri Magicom http://www.magicom-bcn.net/ LinkedIn: http://www.linkedin.com/in/aguerrieri
RE:[PATCH] Service routing based on account field
Hi, Alejandro, your patch seems interesting and can be useful, however the patch seems to not have an explanation for the userguide. Please would you include an explanation and example for the userguide. This can be done by making changes to the CVS userguide. It will help others use this patch, should it be accepted. A lot of people who use Kannel don't monitor the Kannel Devel lists and would otherwise not know how or why to use your patch. Rgds