[PATCH] libsdb support in 1.3.1

2003-07-02 Thread John . Vandenberg





Hi Stipe,

> The stable 1.2.1 is pretty old and there have been some changes in the
> code since then.

While it is old, we will need to recommend our clients use 1.2.1 until a
new stable has been branched.

attached is the patch against trunk.

--
John Mark Vandenberg
Callista Software Services
www.callista.com.au
Tel: +61 3 9685 7923

(See attached file: sdb.diff)

sdb.diff
Description: Binary data


Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread Alexander Malysh
Hi John,

thank you very much for fixing some stupid bugs introduced by me :(
Can you please send diff with whitespace ignore flag set. (cvs diff -Naub)

Thanks in advance...

P.S. Stipe, I will look in it and commit relevant parts...

Am Mittwoch, 2. Juli 2003 09:40 schrieb [EMAIL PROTECTED]:
> Hi Stipe,
>
> > The stable 1.2.1 is pretty old and there have been some changes in the
> > code since then.
>
> While it is old, we will need to recommend our clients use 1.2.1 until a
> new stable has been branched.
>
> attached is the patch against trunk.
>
> --
> John Mark Vandenberg
> Callista Software Services
> www.callista.com.au
> Tel: +61 3 9685 7923
>
> (See attached file: sdb.diff)

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: a.malysh at centrium.de
web: www.centrium.de
msn: olek2002 at hotmail.com
icq: 98063111
___

Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html




Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread Stipe Tolj
Alexander Malysh schrieb:
> 
> Hi John,
> 
> thank you very much for fixing some stupid bugs introduced by me :(
> Can you please send diff with whitespace ignore flag set. (cvs diff -Naub)
> 
> Thanks in advance...
> 
> P.S. Stipe, I will look in it and commit relevant parts...

ok, please test against mysql and oracle if possible.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread John . Vandenberg
> thank you very much for fixing some stupid bugs introduced by me :( Not a problem; the re-write is lots easier to work with. John


sdb-ignore.diff
Description: Binary data


Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread Alexander Malysh
Hi John,

just commited fixed version for sdb support. I have added LIMIT 1 alternative 
for Oracle (ROWNUM < 2) also. This version was successfully tested against 
Oracle 8i. Please check out new version and try it.

NOTE: libsdb has very bad Oracle support. I have seen, that no permanent 
connection to Oracle supported (for every sql statement, connection will be 
opened and closed). Opening connection to Oracle need more time as e.q. 
select statement itself. It would be better to add native support for Oracle 
into kannel...

Am Mittwoch, 2. Juli 2003 13:56 schrieb [EMAIL PROTECTED]:
> > thank you very much for fixing some stupid bugs introduced by me :(
>
>  
> Not a problem; the re-write is lots easier to work with.
>  
> John

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: a.malysh at centrium.de
web: www.centrium.de
msn: olek2002 at hotmail.com
icq: 98063111
___

Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html




Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread Stipe Tolj
Alexander Malysh wrote:
> 
> Hi John,
> 
> just commited fixed version for sdb support. I have added LIMIT 1 alternative
> for Oracle (ROWNUM < 2) also. This version was successfully tested against
> Oracle 8i. Please check out new version and try it.
> 
> NOTE: libsdb has very bad Oracle support. I have seen, that no permanent
> connection to Oracle supported (for every sql statement, connection will be
> opened and closed). Opening connection to Oracle need more time as e.q.
> select statement itself. It would be better to add native support for Oracle
> into kannel...

agreed.

LibSDB was a quick shoot which did work. That was the intention. It
was not a concern of performance or speed.

BTW, same for PostgreSQL. I guess having Oracle, MySQL and PostgreSQL
support would be what be want here, right?!

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread Alexander Malysh
Am Mittwoch, 2. Juli 2003 18:49 schrieb Stipe Tolj:
> Alexander Malysh wrote:
> > Hi John,
> >
> > just commited fixed version for sdb support. I have added LIMIT 1
> > alternative for Oracle (ROWNUM < 2) also. This version was successfully
> > tested against Oracle 8i. Please check out new version and try it.
> >
> > NOTE: libsdb has very bad Oracle support. I have seen, that no permanent
> > connection to Oracle supported (for every sql statement, connection will
> > be opened and closed). Opening connection to Oracle need more time as
> > e.q. select statement itself. It would be better to add native support
> > for Oracle into kannel...
>
> agreed.
>
> LibSDB was a quick shoot which did work. That was the intention. It
> was not a concern of performance or speed.
>
> BTW, same for PostgreSQL. I guess having Oracle, MySQL and PostgreSQL
> support would be what be want here, right?!

agreed. Oracle/Mysql/Postresql are the most used databases (imo)...

>
> Stipe
>
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
>
> Vogelsanger Weg 80
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: a.malysh at centrium.de
web: www.centrium.de
msn: olek2002 at hotmail.com
icq: 98063111
___

Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html




Re: [PATCH] libsdb support in 1.3.1

2003-07-02 Thread Andreas Fink
On Mittwoch, Juli 2, 2003, at 07:10  Uhr, Alexander Malysh wrote:

Am Mittwoch, 2. Juli 2003 18:49 schrieb Stipe Tolj:
Alexander Malysh wrote:
Hi John,

just commited fixed version for sdb support. I have added LIMIT 1
alternative for Oracle (ROWNUM < 2) also. This version was 
successfully
tested against Oracle 8i. Please check out new version and try it.

NOTE: libsdb has very bad Oracle support. I have seen, that no 
permanent
connection to Oracle supported (for every sql statement, connection 
will
be opened and closed). Opening connection to Oracle need more time as
e.q. select statement itself. It would be better to add native 
support
for Oracle into kannel...
agreed.

LibSDB was a quick shoot which did work. That was the intention. It
was not a concern of performance or speed.
BTW, same for PostgreSQL. I guess having Oracle, MySQL and PostgreSQL
support would be what be want here, right?!
agreed. Oracle/Mysql/Postresql are the most used databases (imo)...
maybe add DB2 as well...

Andreas Fink
Global Networks Switzerland AG
--
Tel: +41-61-333  Fax: +41-61-334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--