Re: FW: Updated Charset.c with greek Alphabet 7-bit encoding

2003-06-19 Thread Stipe Tolj
Andreas Fink wrote:
> 
> will probably mean it works in greece but breaks compatibility in other countries.
> I vote -1 for this patch as is. Proper implementation of greek has to be made 
> different. ISO-8859-1 is also not appropriate so there's more to this.

ok, these are serious concerns from Andreas.

Is there a chance that we can use iconv for the mapping?!

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



Re: FW: Updated Charset.c with greek Alphabet 7-bit encoding

2003-06-19 Thread Stipe Tolj
Nisan Bloch wrote:
> 
> Hi
> 
> Why not just use the iconv support that is allready present in some
> of the smsc modules?

yep, the iconv support should be abstracted to the smsccon layer to
provide it to all SMSC module types.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



Re: FW: Updated Charset.c with greek Alphabet 7-bit encoding

2003-06-18 Thread Nisan Bloch

Hi
Why not just use the iconv support that is allready present in some of
the smsc modules?
Nisan
At 03:46 PM 6/18/03 +0200, Andreas Fink wrote:
On Mercredi, juin 18, 2003, at
03:39  Uhr, Antonis Spirou wrote: 
I hope i did it ok.. 
We needed to map greek  characters according to GSM 338 
So there it is.. 
Antonis 

there's no way of mapping something on one side to map to something which
doesn't exist. 
This line is invalid C code: 
//91,
/* A dieresis */ 
(// is valid in C++ but not in ANSI C, even gcc accepts it) 
those lines: 
-   'E', /*
approximate E grave */ 
+   25, /* theta
greek */ 
will probably mean it works in greece but breaks compatibility in other
countries. 
I vote -1 for this patch as is. Proper implementation of greek has to be
made different. ISO-8859-1 is also not appropriate so there's more to
this. 

Andreas Fink 
Global Networks Switzerland AG 
-- 
Tel: +41-61-333  Fax: +41-61-334   Mobile:
+41-79-2457333 
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland 
Web:
http://www.global-networks.ch/
 [EMAIL PROTECTED] 
-- 

 


Re: FW: Updated Charset.c with greek Alphabet 7-bit encoding

2003-06-18 Thread Andreas Fink

On Mercredi, juin 18, 2003, at 03:39  Uhr, Antonis Spirou wrote:

I hope i did it ok..

We needed to map greek  characters according to GSM 338

So there it is..

Antonis


there's no way of mapping something on one side to map to something which doesn't exist.

This line is invalid C code:
//91, /* A dieresis */

(// is valid in C++ but not in ANSI C, even gcc accepts it)

those lines:

-	'E', /* approximate E grave */
+	25, /* theta greek */

will probably mean it works in greece but breaks compatibility in other countries.
I vote -1 for this patch as is. Proper implementation of greek has to be made different. ISO-8859-1 is also not appropriate so there's more to this.


Andreas Fink
Global Networks Switzerland AG

--
Tel: +41-61-333  Fax: +41-61-334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--



RE: FW: Updated Charset.c with greek Alphabet 7-bit encoding

2003-06-18 Thread Antonis Spirou
I hope i did it ok..

We needed to map greek  characters according to GSM 338

So there it is..

Antonis

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of
Andreas Fink
Sent: Wednesday, June 18, 2003 3:40 PM
To: Antonis Spirou
Cc: [EMAIL PROTECTED]
Subject: Re: FW: Updated Charset.c with greek Alphabet 7-bit encoding


What did you change in this file?
We would need a unified patch to apply.

And as iso-latin1 doesn't have the chars mapped, it would make sense to
support the greek iso instead.


On Mercredi, juin 18, 2003, at 02:11 Uhr, Antonis Spirou wrote:



-Original Message-
From: Antonis Spirou [mailto:[EMAIL PROTECTED]
Sent: Tuesday, June 10, 2003 6:07 PM
To: [EMAIL PROTECTED]
Subject: Updated Charset.c with greek Alphabet 7-bit encoding

Please find attached the charset.c that we patched to make it work with
7-bit encoding (we needed greek but not UTF or binary)

Please include it on the next distribution


Regards,
Antonis Spirou
Systems &Network Engineer



Andreas Fink
Global Networks Switzerland AG

--
Tel: +41-61-333 Fax: +41-61-334 Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--


greek.charset.patch
Description: Binary data


Re: FW: Updated Charset.c with greek Alphabet 7-bit encoding

2003-06-18 Thread Andreas Fink
What did you change in this file?
We would need a unified patch to apply.

And as iso-latin1 doesn't have the chars mapped, it would make sense to support the greek iso instead.


On Mercredi, juin 18, 2003, at 02:11  Uhr, Antonis Spirou wrote:

 
-Original Message-
From: Antonis Spirou [mailto:[EMAIL PROTECTED]
Sent: Tuesday, June 10, 2003 6:07 PM
To: [EMAIL PROTECTED]
Subject: Updated Charset.c with greek Alphabet 7-bit encoding

Please find attached the charset.c that we patched to make it work with 7-bit encoding (we needed greek but not UTF or binary)
 
Please include it on the next distribution
 
 
Regards,
Antonis Spirou
Systems &Network Engineer
 

Andreas Fink
Global Networks Switzerland AG

--
Tel: +41-61-333  Fax: +41-61-334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--