Re: Compilation issue after gcc removal
On Fri, 20 Jul 2018 01:08:55 +0200, Marcin Zajączkowski wrote: > On 2018-07-20 00:26, Artur Iwicki wrote: > > I looked at libattr and in the changelog, there's this: > >> * Tue Jul 17 2018 Kamil Dudka 2.4.48-3 > >> - temporarily provide attr/xattr.h symlink until users are migrated > >> (#1601482) > > > > The bugzilla ticket says that attr/xattr.h was removed from libattr and is > > now a symlink to sys/xattr.h. Taking a look at those two files, the old > > attr/xattr.h has these lines in it: > >> #ifndef ENOATTR > >> # define ENOATTR ENODATA/* No such attribute */ > >> #endif > > These are absent in sys/xattr.h, so the compiler rightfully complains that > > it does not know of ENOATTR. I guess you should either add a patch that > > replaces usages of ENOATTR to ENODATA, or a patch that adds this define > > somewhere. > > Thanks Artur for your findings! Trying to report that problem upstream I > founded this thread: https://github.com/iustin/pyxattr/pull/15 > > I will give it a few days to work out some general way to solve it. The fix is valid. It also affects other projects. For reference: http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/M6FZOBL7LKNOMMEJBERIDIOMDNX3JWQH/
Compilation issue after gcc removal
On 2018-07-20 00:26, Artur Iwicki wrote: > I looked at libattr and in the changelog, there's this: >> * Tue Jul 17 2018 Kamil Dudka 2.4.48-3 >> - temporarily provide attr/xattr.h symlink until users are migrated >> (#1601482) > > The bugzilla ticket says that attr/xattr.h was removed from libattr and is > now a symlink to sys/xattr.h. Taking a look at those two files, the old > attr/xattr.h has these lines in it: >> #ifndef ENOATTR >> # define ENOATTR ENODATA/* No such attribute */ >> #endif > These are absent in sys/xattr.h, so the compiler rightfully complains that it > does not know of ENOATTR. I guess you should either add a patch that replaces > usages of ENOATTR to ENODATA, or a patch that adds this define somewhere. Thanks Artur for your findings! Trying to report that problem upstream I founded this thread: https://github.com/iustin/pyxattr/pull/15 I will give it a few days to work out some general way to solve it. Marcin -- https://blog.solidsoft.info/ - Working code is not enough ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/XDBPYWNUBEMRVB3KH2BJGUGCTY2NTO5A/
Re: Compilation issue after gcc removal
I looked at libattr and in the changelog, there's this: >* Tue Jul 17 2018 Kamil Dudka 2.4.48-3 >- temporarily provide attr/xattr.h symlink until users are migrated (#1601482) The bugzilla ticket says that attr/xattr.h was removed from libattr and is now a symlink to sys/xattr.h. Taking a look at those two files, the old attr/xattr.h has these lines in it: >#ifndef ENOATTR ># define ENOATTR ENODATA/* No such attribute */ >#endif These are absent in sys/xattr.h, so the compiler rightfully complains that it does not know of ENOATTR. I guess you should either add a patch that replaces usages of ENOATTR to ENODATA, or a patch that adds this define somewhere. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/XDBIKZGW62EI4T3TXH5EOIVHWEW2UZMU/
Compilation issue after gcc removal
Hi,
After the recent gcc removal from build root [1] I added explicit
dependency on gcc [2], but even though my pyxattr package started to
fail with [3][4]:
> xattr.c:532:56: error: 'ENOATTR' undeclared (first use in this function); did
> you mean 'ENOTTY'?
I've checked it and ENOATTR should be defined in attr/xattr.h which is
provided by the build dependency - libattr-devel. In addition are
installed glibc-headers [5].
I haven't been programming in C for years. Do you know what can be a reason?
[1] - https://fedoraproject.org/wiki/Changes/Remove_GCC_from_BuildRoot
[2] -
https://src.fedoraproject.org/rpms/pyxattr/c/3e584e38e14140ee9c4287cfcff75a79268ba3da?branch=master
[3] - https://kojipkgs.fedoraproject.org//work/tasks/2137/28452137/build.log
[4] - https://koji.fedoraproject.org/koji/taskinfo?taskID=28452137
[5] - https://kojipkgs.fedoraproject.org//work/tasks/2137/28452137/root.log
> gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Werror=format-security
> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
> -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
> -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
> -fexceptions -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
> -D_GNU_SOURCE -fPIC -fwrapv -O2 -g -pipe -Wall -Werror=format-security
> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
> -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC
> -D_XATTR_VERSION="0.5.3" -D_XATTR_AUTHOR="Iustin Pop"
> -D_XATTR_EMAIL="iu...@k1024.org" -I/usr/include/python2.7 -c xattr.c -o
> build/temp.linux-x86_64-2.7/xattr.o -Wall -Werror
> xattr.c: In function 'get_all':
> xattr.c:532:56: error: 'ENOATTR' undeclared (first use in this function); did
> you mean 'ENOTTY'?
> } else if(errno == ENODATA || errno == ENOATTR) {
> ^~~
> ENOTTY
> xattr.c:532:56: note: each undeclared identifier is reported only once for
> each function it appears in
> error: command 'gcc' failed with exit status 1
Marcin
--
https://blog.solidsoft.info/ - Working code is not enough
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CX7NL6VOXD7JMM3Q2SZU7K46VS2SDITR/
