Re: How to determine FAS from BZ email?

2012-02-27 Thread Miroslav Suchý

On 02/23/2012 04:48 PM, Ken Dreyer wrote:

I'm in agreement with this. Do we need to open a ticket with the FPC?


https://fedorahosted.org/fpc/ticket/147

--
Miroslav Suchy
Red Hat Satellite Engineering
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

How to determine FAS from BZ email?

2012-02-23 Thread Miroslav Suchý

Hi,
I have question about Fedora Review Process. [1]

First time submitter should block FE-NEEDSPONSOR. But since they are new 
to the process they very often forgot to do that.
So I always try to check whether given bugzilla email already has FAS 
account and if it is in packager group.


But I find incredibly hard to find relation between bugzilla email and 
FAS account.

How do you do this check?

I recently asked few developers and they confirm that it is hard and 
non-deterministics.


Therefore I suggest to enhance template of [2] to include line:
FAS account: your FAS login


[1] http://fedoraproject.org/wiki/Package_Review_Process
[2] 
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedoraformat=fedora-review


--
Miroslav Suchy
Red Hat Satellite Engineering
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Thomas Spura
2012/2/23 Miroslav Suchý msu...@redhat.com:
 But I find incredibly hard to find relation between bugzilla email and FAS
 account.
 How do you do this check?

Show all useres in the cla_signed group [3] and search for the mail
address. When it's not there it may be overritten in [4].
When it's not there either, the user has not signed cla yet and cannot
be a packager, yet.

 I recently asked few developers and they confirm that it is hard and
 non-deterministics.

I'd say this is deterministic :)

 Therefore I suggest to enhance template of [2] to include line:
 FAS account: your FAS login

-1, I'm sure it's possible to use the fas2 client from python-fedora
directly somehow to do the check (but don't know how, didn't try it
yet)...

 [1] http://fedoraproject.org/wiki/Package_Review_Process
 [2]
 https://bugzilla.redhat.com/enter_bug.cgi?product=Fedoraformat=fedora-review

[3] https://admin.fedoraproject.org/accounts/group/members/cla_done
with * as user
[4] /usr/lib/python2.7/site-packages/fedora/client/fas2.py


Greetings,
Tom
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Jamie Nguyen
Thomas Spura wrote:
 2012/2/23 Miroslav Suchý msu...@redhat.com:
 But I find incredibly hard to find relation between bugzilla email and FAS
 account.
 How do you do this check?

 Show all useres in the cla_signed group [3] and search for the mail
 address. When it's not there it may be overritten in [4].
 When it's not there either, the user has not signed cla yet and cannot
 be a packager, yet.

You can't be a packager without signing the CLA, but you can sign the
CLA without being a packager.

I signed my CLA well before being sponsored, so it wouldn't indicate
to Miroslav that I should have blocked FE-NEEDSPONSOR.


Jamie
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Thomas Spura
On Thu, Feb 23, 2012 at 3:24 PM, Jamie Nguyen ja...@tomoyolinux.co.uk wrote:
 Thomas Spura wrote:
 2012/2/23 Miroslav Suchý msu...@redhat.com:
 But I find incredibly hard to find relation between bugzilla email and FAS
 account.
 How do you do this check?

 Show all useres in the cla_signed group [3] and search for the mail
 address. When it's not there it may be overritten in [4].
 When it's not there either, the user has not signed cla yet and cannot
 be a packager, yet.

 You can't be a packager without signing the CLA, but you can sign the
 CLA without being a packager.

Yes, no cla - no packager, like I wrote above.
When someone has signed the cla, you then need to look if the user is
already member of the packager group...

Greetings,
Tom
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Jamie Nguyen
Thomas Spura toms...@fedoraproject.org wrote:
 On Thu, Feb 23, 2012 at 3:24 PM, Jamie Nguyen ja...@tomoyolinux.co.uk wrote:
 Thomas Spura wrote:
 2012/2/23 Miroslav Suchý msu...@redhat.com:
 But I find incredibly hard to find relation between bugzilla email and FAS
 account.
 How do you do this check?

 Show all useres in the cla_signed group [3] and search for the mail
 address. When it's not there it may be overritten in [4].
 When it's not there either, the user has not signed cla yet and cannot
 be a packager, yet.

 You can't be a packager without signing the CLA, but you can sign the
 CLA without being a packager.

 Yes, no cla - no packager, like I wrote above.
 When someone has signed the cla, you then need to look if the user is
 already member of the packager group...

Perhaps I misunderstand, but I think the real problem is that the
email used for bugzilla doesn't have to be the same as the email
specified when signing up for a FAS account. So if the bugzilla email
isn't found in FAS, it doesn't necessarily mean that they don't yet
have a FAS account. Similarly, it also doesn't necessarily mean that
they haven't signed the CLA yet.

I don't know how these queries are done, but I would have thought that
if you can query whether any members of the CLA group have the email
address in question, you might as well query the Packager group from
the start.


Jamie
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Johannes Lips
Isn't it easiest to just ask for the FAS name of the person who wants to
become a packager? I don't really see how this should be less efficient
than searching the mail address in the FAS database.


On Thu, Feb 23, 2012 at 3:23 PM, Jamie Nguyen ja...@tomoyolinux.co.ukwrote:

 Thomas Spura toms...@fedoraproject.org wrote:
  On Thu, Feb 23, 2012 at 3:24 PM, Jamie Nguyen ja...@tomoyolinux.co.uk
 wrote:
  Thomas Spura wrote:
  2012/2/23 Miroslav Suchý msu...@redhat.com:
  But I find incredibly hard to find relation between bugzilla email
 and FAS
  account.
  How do you do this check?
 
  Show all useres in the cla_signed group [3] and search for the mail
  address. When it's not there it may be overritten in [4].
  When it's not there either, the user has not signed cla yet and cannot
  be a packager, yet.
 
  You can't be a packager without signing the CLA, but you can sign the
  CLA without being a packager.
 
  Yes, no cla - no packager, like I wrote above.
  When someone has signed the cla, you then need to look if the user is
  already member of the packager group...

 Perhaps I misunderstand, but I think the real problem is that the
 email used for bugzilla doesn't have to be the same as the email
 specified when signing up for a FAS account. So if the bugzilla email
 isn't found in FAS, it doesn't necessarily mean that they don't yet
 have a FAS account. Similarly, it also doesn't necessarily mean that
 they haven't signed the CLA yet.

 I don't know how these queries are done, but I would have thought that
 if you can query whether any members of the CLA group have the email
 address in question, you might as well query the Packager group from
 the start.


 Jamie
 --
 devel mailing list
 devel@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/devel

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Ken Dreyer
2012/2/23 Miroslav Suchý msu...@redhat.com:
 But I find incredibly hard to find relation between bugzilla email and FAS
 account.
 How do you do this check?

I use zodbot's fasinfo command, because it's faster than searching the
FAS web interface.

 Therefore I suggest to enhance template of [2] to include line:
 FAS account: your FAS login

I'm in agreement with this. Do we need to open a ticket with the FPC?

- Ken
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Jamie Nguyen
Ken Dreyer wrote:
 2012/2/23 Miroslav Suchý msu...@redhat.com:
 But I find incredibly hard to find relation between bugzilla email and FAS
 account.
 How do you do this check?

 I use zodbot's fasinfo command, because it's faster than searching the
 FAS web interface.

 Therefore I suggest to enhance template of [2] to include line:
 FAS account: your FAS login

 I'm in agreement with this. Do we need to open a ticket with the FPC?

If you know the email but not the FAS username, then fas
em...@email.com to query an email. But yes, the template solution is
best.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread John5342
On Thu, Feb 23, 2012 at 15:33, Jamie Nguyen ja...@tomoyolinux.co.uk wrote:
 Yes. Since the emails don't necessarily match up, I don't think you
 can rely on querying the database. Not only is it less efficient, it
 can break too! (In most cases the emails probably will match up
 anyway, but you can't rely on it.)

It is possible that they don't match but they are more or less
required to though. Last i checked the bugzilla editbugs permissions
and the like are set from fas by email address so if the addresses
don't match up then the user won't be able to manage bugzilla properly
anyway. If the user doesn't match up then they should probably be
warned before they are sponsored so the extra request for fas along
with a warning i think is a good thing.

-- 
There are 10 kinds of people in the world: Those who understand binary
and those who don't...
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: How to determine FAS from BZ email?

2012-02-23 Thread Garrett Holmstrom

On 2012-02-23 10:20, John5342 wrote:

It is possible that they don't match but they are more or less
required to though. Last i checked the bugzilla editbugs permissions
and the like are set from fas by email address so if the addresses
don't match up then the user won't be able to manage bugzilla properly
anyway.


Even that may not be true, as the infrastructure team has mapped FAS 
accounts to Bugzilla accounts with different e-mail addresses in the past.

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel