Re: Replace buildroot overrides with user side tags?
On Wed, Apr 22, 2020 at 12:29:23PM +0200, Miro Hrončok wrote: > On 22. 04. 20 12:18, Alexander Ploumistos wrote: > > Are we supposed to clean up after ourselves, i.e. delete the side tags > > after submitting the updates to bodhi, or are the tags deleted > > automatically? If we are to delete them, at which point in the > > updates' life cycle is it safe to do so? After submission? When they > > hit stable? > > AFAIK You don't need to clean anything. Indeed. On stable releases the side tag is removed when the update is created while on rawhide the side-tag is only removed when the update lands in the rawhide buildroot (ie: the update is pushed to stable). Pierre ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On 22. 04. 20 12:18, Alexander Ploumistos wrote: Are we supposed to clean up after ourselves, i.e. delete the side tags after submitting the updates to bodhi, or are the tags deleted automatically? If we are to delete them, at which point in the updates' life cycle is it safe to do so? After submission? When they hit stable? AFAIK You don't need to clean anything. If you had to, I'd suggest doing it after the update hits stable, co you don't delete it before that happens, only to realize you need to change something based on the update feedback. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
Yesterday I had to use that functionality for the very first time and with Mohan's comment in mind about the resource cost, I was leaning towards using buildroot overrides. I ended up creating side tags, for the simple reason that the available documentation was much more clearer. Are we supposed to clean up after ourselves, i.e. delete the side tags after submitting the updates to bodhi, or are the tags deleted automatically? If we are to delete them, at which point in the updates' life cycle is it safe to do so? After submission? When they hit stable? ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
This is a great idea, but I wouldn't recommend removing buildroot overrides totally for one more reason than the others that are already mentioned here. Side tags are resource intensive compared to buildroot override as each side tag needs its own buildroot. On Sat, Apr 4, 2020 at 5:02 PM Richard Shaw wrote: > > On Sat, Apr 4, 2020 at 3:52 PM Neal Gompa wrote: >> >> On Sat, Apr 4, 2020 at 4:50 PM Richard Shaw wrote: >> > >> > To be clear, I've only used them for rawhide, but can they be used in >> > other branches? >> > >> >> As of last Monday, yes. There are still some quirks to iron out, though... > > > Awesome! Not only are they easier to use but being able to choose the side > tag in the Bodhi web interface makes pushing the updates painless! > > Thanks, > Richard > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 4, 2020 at 3:52 PM Neal Gompa wrote: > On Sat, Apr 4, 2020 at 4:50 PM Richard Shaw wrote: > > > > To be clear, I've only used them for rawhide, but can they be used in > other branches? > > > > As of last Monday, yes. There are still some quirks to iron out, though... > Awesome! Not only are they easier to use but being able to choose the side tag in the Bodhi web interface makes pushing the updates painless! Thanks, Richard ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 4, 2020 at 4:50 PM Richard Shaw wrote: > > To be clear, I've only used them for rawhide, but can they be used in other > branches? > As of last Monday, yes. There are still some quirks to iron out, though... -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
To be clear, I've only used them for rawhide, but can they be used in other branches? Thanks, Richard ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 04, 2020 at 02:30:41PM -0500, Richard Shaw wrote: > Also, it doesn't take NEAR as long for the package to be available in a > side tag then a buildroot override... > > Been waiting almost an hour for one in f32... This is due to kojira (the koji process that handles making new repos) not working as expected. https://pagure.io/koji/issue/2119 is the upstream issue where we are trying to sort it out. kevin signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 04, 2020 at 09:22:29AM -0400, Neal Gompa wrote: > On Sat, Apr 4, 2020 at 8:57 AM Richard Shaw wrote: > > > > Perhaps this has been discussed already but I found the new user side tags > > a much easier process than using buildroot overrides. > > > > Is the only *effective* difference that with a buildroot override that > > *everyone* can use it (on purpose or not) and with side tags only the > > creator (or users shared to) can use the package? > > > > Just to simply things I would be in favor of using side tags across the > > board and dropping buildroot overrides but there's probably some situations > > I'm not thinking of. > > > > That is pretty much the only difference. That said, anyone can build > in a particular side tag once it's created, so I think this matters a > lot less than people would think. > > I think once the side tag update workflow becomes more performant and > reliable, we probably could eliminate the usage of overrides. +1. There still seems to be a few issues with side tags, but once they are all sorted I think this is a great idea. kevin signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
Also, it doesn't take NEAR as long for the package to be available in a side tag then a buildroot override... Been waiting almost an hour for one in f32... Thanks, Richard ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 4, 2020 at 8:46 AM Miro Hrončok wrote: > > Just to simply things I would be in favor of using side tags across the > board > > and dropping buildroot overrides but there's probably some situations > I'm not > > thinking of. > > For an update that can potentially break other packages building, I submit > a > buildroot override before pushing it to stable to see how the Koschei > builds are > affected. That could be solved on Koschei level by including > updates-testing by > default somehow. > Ok, yeah, it's not practical (or necessary) to rebuild all dependent packages in cases like that. I've only done the typical major library update and rebuild all dependencies. The biggest one of which has 10 packages needing rebuilding. Thanks, Richard ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On 04. 04. 20 14:56, Richard Shaw wrote: Perhaps this has been discussed already but I found the new user side tags a much easier process than using buildroot overrides. Is the only *effective* difference that with a buildroot override that *everyone* can use it (on purpose or not) and with side tags only the creator (or users shared to) can use the package? Yes please! Especially for highly depended on packages (e.g. gcc/annobin), this should really be the default. Just to simply things I would be in favor of using side tags across the board and dropping buildroot overrides but there's probably some situations I'm not thinking of. For an update that can potentially break other packages building, I submit a buildroot override before pushing it to stable to see how the Koschei builds are affected. That could be solved on Koschei level by including updates-testing by default somehow. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 4, 2020 at 8:23 AM Neal Gompa wrote: > On Sat, Apr 4, 2020 at 8:57 AM Richard Shaw wrote: > > > > Perhaps this has been discussed already but I found the new user side > tags a much easier process than using buildroot overrides. > > > > Is the only *effective* difference that with a buildroot override that > *everyone* can use it (on purpose or not) and with side tags only the > creator (or users shared to) can use the package? > > > > Just to simply things I would be in favor of using side tags across the > board and dropping buildroot overrides but there's probably some situations > I'm not thinking of. > > > > That is pretty much the only difference. That said, anyone can build > in a particular side tag once it's created, so I think this matters a > lot less than people would think. > Ok, so they just need to know the name of the side tag, whereas buildroot overrides you get it whether you want it or not. Thanks, Richard ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Replace buildroot overrides with user side tags?
On Sat, Apr 4, 2020 at 8:57 AM Richard Shaw wrote: > > Perhaps this has been discussed already but I found the new user side tags a > much easier process than using buildroot overrides. > > Is the only *effective* difference that with a buildroot override that > *everyone* can use it (on purpose or not) and with side tags only the creator > (or users shared to) can use the package? > > Just to simply things I would be in favor of using side tags across the board > and dropping buildroot overrides but there's probably some situations I'm not > thinking of. > That is pretty much the only difference. That said, anyone can build in a particular side tag once it's created, so I think this matters a lot less than people would think. I think once the side tag update workflow becomes more performant and reliable, we probably could eliminate the usage of overrides. -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
