Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
Hi all, decided to disable aspell support in mc as a whole. Note it is disabled by default configure option in mc anyway. A beneficial side effect is we have now even smaller dependency footprint and the annoying message while editing *any* file goes away without aspell + friends installed. This whole feature just opens can of worms on so many levels. Jindrich On Wed, Oct 9, 2019 at 2:01 PM Nikola Forró wrote: > On Tue, 2019-10-08 at 18:42 +0100, Tomasz Kłoczko wrote: > > IMO above shows clearly that adding "aspell-en" in mc or aspell > > dependencies does not solve issue .. at all. > > Kind of mitigation of that problem should be IMO change aspell error > > message (by add Fedora/any rpm based distro patch) informing that > > system has missing aspell- package. > > This sounds reasonable, making a maintainable downstream patch could be > tricky though. I'll try to come up with something. > > Thanks, > Nikola > > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Tue, 2019-10-08 at 18:42 +0100, Tomasz Kłoczko wrote: > IMO above shows clearly that adding "aspell-en" in mc or aspell > dependencies does not solve issue .. at all. > Kind of mitigation of that problem should be IMO change aspell error > message (by add Fedora/any rpm based distro patch) informing that > system has missing aspell- package. This sounds reasonable, making a maintainable downstream patch could be tricky though. I'll try to come up with something. Thanks, Nikola ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Tue, Oct 08, 2019 at 06:42:40PM +0100, Tomasz Kłoczko wrote: > To be honest IMO separating aspell dictionaries is a bit illogical because > on distribution layer language dependent resources should be described by > %lang() and chosen on install stage by %_install_langs. > Ergo: all "langpack" (like aspell-* of Libreoffice- or firefox-* etc) > packages should disappear. That doesn't work well, because then one can't easily install support for additional languages, which is pretty common thing. One installs support of a primary language, then figures out that he needs this and that language too. With %_install_langs, you need to uninstall and install again, or force reinstall or something similar. Jakub ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Tue, 8 Oct 2019 at 17:15, Nikola Forró wrote: > On Tue, 2019-10-08 at 12:22 +0200, Jindrich Novy wrote: > > Nikola, is it intended that aspell doesn't depend on any dictionary? > > E.g. aspell-en? Please see the email bellow. > > Hi, > > it seems it is intentional [1], this is probably the reason [2]. > I suppose aspell could recommend aspell-en, to prevent circular > dependency (assuming weak dependencies actually do prevent it). > > Thanks, > Nikola > > [1] > https://src.fedoraproject.org/rpms/aspell/c/405c4df7ef4bcd93103c57e3e910e2f82a045c24 > [2] https://bugzilla.redhat.com/show_bug.cgi?id=485210 It is very easy to fix this by merge build of the aspell and aspell-en. Build processes should not be affecting how final packages should be used and in this case it is like this. Someone choose that clean build is more important than dependencies between those packages. To be honest IMO separating aspell dictionaries is a bit illogical because on distribution layer language dependent resources should be described by %lang() and chosen on install stage by %_install_langs. Ergo: all "langpack" (like aspell-* of Libreoffice- or firefox-* etc) packages should disappear. As long as rpm packages exist only in form of solid archives it is not possible precisely choose to download only resources which does not depends on any %lang() + those which depends on set of languages listed in %_install_langs. This is why IPS has concept of facets and because package exist only as set of files with attributes in IPS repository, by this repository can stream to client (where packages will be installed) *only* that files which have been requested but not on boundaries of the packages existing on build stage. This is one of the biggest weakness of the rpm or more precisely any PM software which uses packages as archives. Nevertheless problem still is not correctly described. To be more precise aspell does not need aspell-en but any dictionary which is needed by current local settings (system one or user one or even user session one). *If I'll be using for example locale pl_PL and will have installed aspell-en mcedit still will be barking that about missing dictionary!!!* In other words .. aspell should not require aspel-en but at least one/some dictionary package. Nevertheless in current state of the rpm adding dependencies which depends on *current locale settings* is unsolvable by definition. All what is possible to do is provide GoodEnouhg(tm) solution. IMO above shows clearly that adding "aspell-en" in mc or aspell dependencies does not solve issue .. at all. Kind of mitigation of that problem should be IMO change aspell error message (by add Fedora/any rpm based distro patch) informing that system has missing aspell- package. Workaround 1: add in aspell "%bcond_with bootstrap" and when package will be build "--with boostrap" disable "Requires: aspell-en". aspell used as only as aspell-devel will not break any other packages builds. Workaround 2: add in each aspell- "Provides: aspell-dictionary" and in aspell "Requires: aspell-dictionary". With that aspell-en can be build as long will have stored any aspell- package. Conclusion: for me still it is clear that mc should stay untouched and any other steps should be done outside of the mc package. PS. BTW anaconda/kickstart still does not setup /etc/rpm/macro file with %_install_langs with list of choose languages support. kloczek -- Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Tue, 2019-10-08 at 12:22 +0200, Jindrich Novy wrote: > Nikola, is it intended that aspell doesn't depend on any dictionary? > E.g. aspell-en? Please see the email bellow. Hi, it seems it is intentional [1], this is probably the reason [2]. I suppose aspell could recommend aspell-en, to prevent circular dependency (assuming weak dependencies actually do prevent it). Thanks, Nikola [1] https://src.fedoraproject.org/rpms/aspell/c/405c4df7ef4bcd93103c57e3e910e2f82a045c24 [2] https://bugzilla.redhat.com/show_bug.cgi?id=485210 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
Adding Nikola.
Nikola, is it intended that aspell doesn't depend on any dictionary? E.g.
aspell-en? Please see the email bellow.
Thanks,
Jindrich
On Mon, Oct 7, 2019 at 5:14 PM Tomasz Kłoczko
wrote:
> On Mon, 7 Oct 2019 at 15:30, Jindrich Novy wrote:
> [..]
>
>> BTW mc.
>>> Also I do not understand why FC31 release comity ignored my objection to
>>> push mc 4.8.23 to fc31 since it core dumps sometimes few times per hour of
>>> active use.
>>>
>>
>> You commented on the F29 update (not F31) here:
>> https://bodhi.fedoraproject.org/updates/FEDORA-2019-e3e2bc7747 and
>> failed to reply to my comment.
>>
>
> I did not receive any notification about that comment.
>
>> > now we have pollution of the mc static dependencies by add aspell-en.
>> > mc does not need aspell-en but aspell does because aspell to work
>> properly needs at least
>> > some dictionary.
>>
>> Adding Requires of aspell-en fixes this:
>>
>> https://antonishapsas.wordpress.com/2019/01/18/midnight-commander-no-word-lists-can-be-found-for-the-language-en/
>>
>
> Again .. where never aspell is used without installed dictionary it will
> fail (not only in mc).
> This is not mc bu aspell issue.
> Please d knot try to fix the issue (real issue) in wrong package.
>
> [tkloczko@domek ~]$ rpm -q --qf "[%{REQUIRENAME} %{REQUIREFLAGS:depflags}
> %{REQUIREVERSION}\n]" aspell
> /usr/bin/sh
> libaspell.so.15()(64bit)
> libc.so.6()(64bit)
> libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit)
> libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit)
> libc.so.6(GLIBC_2.7)(64bit)
> libdl.so.2()(64bit)
> libdl.so.2(GLIBC_2.2.5)(64bit)
> libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit)
> libm.so.6(GLIBC_2.29)(64bit)
> libncursesw.so.6()(64bit)
> libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit)
> libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit)
> libstdc++.so.6(GLIBCXX_3.4.15)(64bit)
> libtinfo.so.6()(64bit)
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(FileDigests) <= 4.6.0-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> rpmlib(PayloadIsZstd) <= 5.4.18-1
> rtld(GNU_HASH)
>
> As you see current aspell does not requires installing any dictionaries
> and this is causing that mc barks about missing dictionary.
>
> kloczek
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Mon, 7 Oct 2019 at 15:30, Jindrich Novy wrote:
[..]
> BTW mc.
>> Also I do not understand why FC31 release comity ignored my objection to
>> push mc 4.8.23 to fc31 since it core dumps sometimes few times per hour of
>> active use.
>>
>
> You commented on the F29 update (not F31) here:
> https://bodhi.fedoraproject.org/updates/FEDORA-2019-e3e2bc7747 and failed
> to reply to my comment.
>
I did not receive any notification about that comment.
> > now we have pollution of the mc static dependencies by add aspell-en.
> > mc does not need aspell-en but aspell does because aspell to work
> properly needs at least
> > some dictionary.
>
> Adding Requires of aspell-en fixes this:
>
> https://antonishapsas.wordpress.com/2019/01/18/midnight-commander-no-word-lists-can-be-found-for-the-language-en/
>
Again .. where never aspell is used without installed dictionary it will
fail (not only in mc).
This is not mc bu aspell issue.
Please d knot try to fix the issue (real issue) in wrong package.
[tkloczko@domek ~]$ rpm -q --qf "[%{REQUIRENAME} %{REQUIREFLAGS:depflags}
%{REQUIREVERSION}\n]" aspell
/usr/bin/sh
libaspell.so.15()(64bit)
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.7)(64bit)
libdl.so.2()(64bit)
libdl.so.2(GLIBC_2.2.5)(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libm.so.6(GLIBC_2.29)(64bit)
libncursesw.so.6()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit)
libstdc++.so.6(GLIBCXX_3.4.15)(64bit)
libtinfo.so.6()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1
rtld(GNU_HASH)
As you see current aspell does not requires installing any dictionaries and
this is causing that mc barks about missing dictionary.
kloczek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Mon, Oct 7, 2019 at 3:21 PM Tomasz Kłoczko wrote: > On Mon, 7 Oct 2019 at 13:28, Jindrich Novy wrote: > >> Hi Tomasz, >> >> > On top of removing perl-generators which add for mc proper perl modules >> dependencies for >> > patchfs >> >> Can you please elaborate on the above? patchfs works for me despite >> missing perl-generators? This is not raised by me but the following request >> from an user: >> - >> Hi Jindrich, >> >> I did a minimal install of CentOS 8 with mc and saw that it pulls in perl >> due to (I guess) BuildRequires: perl-generators in the spec file. I >> looked at mc upstream and they do not list perl as a requirement: >> https://github.com/MidnightCommander/mc/blob/master/doc/INSTALL >> >> Did I miss something or is perl no more needed? I'd be happy to file a >> BZ, just let me know. >> > > Without installed perl(File::Temp) perl module when someone will enter > into patch to use patchfs it will be be not working. > If you want to fix that you should try to rewrite patchfs perl backend > script in POSIX sh. > I'm almost sure that using perl in patchfs or zipfs is obverkill. > > As well rpmfs is written is perl (many years ago when I've rewrote rpmfs > scrip it was using only POSIX sh with rpm as only external command .. > however in meantime someone made here some "progress"). > Thanks, the BR: perl-generators is now added back. > > Next time instead using you proven packager privileges at least please try > to contact someone who actively is maintaining some package. > Note I'm still official fedora maintainer of mc: https://src.fedoraproject.org/rpms/mc > BTW mc. > Also I do not understand why FC31 release comity ignored my objection to > push mc 4.8.23 to fc31 since it core dumps sometimes few times per hour of > active use. > You commented on the F29 update (not F31) here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e3e2bc7747 and failed to reply to my comment. >From end user point of view difference between mc 4.8.22 and 4.8.23 are > negligible. > I have opened ticket with that issue > http://midnight-commander.org/ticket/4023 > Thanks. Also please reply to my questions you deleted from previous email - we need to be sure what to do WRT aspell in mc and whether it makes sense: > now we have pollution of the mc static dependencies by add aspell-en. > mc does not need aspell-en but aspell does because aspell to work properly needs at least > some dictionary. Adding Requires of aspell-en fixes this: https://antonishapsas.wordpress.com/2019/01/18/midnight-commander-no-word-lists-can-be-found-for-the-language-en/ which is very annoying and lot of users are complaining about it. Every time you edit a file you need to confirm the "No word list can be found for language en." For aspell vs aspell-en you suggest mc be dependent on aspell directly? Is there any bug requesting Requires: aspell-en from aspell? Other option is just to disable spellchecking as a whole. I'm in doubt anybody is using it. For me it is important we get rid of annoying UX issues encountered every time when user edits a file. I'm happy to discuss any possible/more appropriate ways to address this instead of this workaround. Tomasz, regarding to patches you added downstream: mc-default_setup.patch - Can you propose this upstream? mc-python3.patch - Can you propose this upstream? mc-rpm.patch - Can you propose this upstream? mc-spec.syntax.patch - Can you propose this upstream? Please do not pollute downstream with these patches - better way is to do a PR upstream - once merged we can do a release candidate in rawhide with the upstream checked-out tarball. Extensive patching downstream without any upstream involvement requires lots of maintenance/forwardporting. Thanks, Jindrich ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Mon, 7 Oct 2019 at 13:28, Jindrich Novy wrote:
> Hi Tomasz,
>
> > On top of removing perl-generators which add for mc proper perl modules
> dependencies for
> > patchfs
>
> Can you please elaborate on the above? patchfs works for me despite
> missing perl-generators? This is not raised by me but the following request
> from an user:
> -
> Hi Jindrich,
>
> I did a minimal install of CentOS 8 with mc and saw that it pulls in perl
> due to (I guess) BuildRequires: perl-generators in the spec file. I
> looked at mc upstream and they do not list perl as a requirement:
> https://github.com/MidnightCommander/mc/blob/master/doc/INSTALL
>
> Did I miss something or is perl no more needed? I'd be happy to file a
> BZ, just let me know.
>
$ rpm -q --qf "[%{REQUIRENAME} %{REQUIREFLAGS:depflags}
%{REQUIREVERSION}\n]" mc | grep perl
/usr/bin/perl
perl(File::Basename)
perl(File::Temp)
perl(POSIX)
perl(bytes)
perl(strict)
For generating those perl dependencies is responsible per-generators
package which you've removed from BRs.
$ grep ^use /usr/libexec/mc/extfs.d/*
/usr/libexec/mc/extfs.d/mailfs:use bytes;
/usr/libexec/mc/extfs.d/patchfs:use bytes;
/usr/libexec/mc/extfs.d/patchfs:use strict;
/usr/libexec/mc/extfs.d/patchfs:use POSIX;
/usr/libexec/mc/extfs.d/patchfs:use File::Temp 'tempfile';
/usr/libexec/mc/extfs.d/uzip:use POSIX;
/usr/libexec/mc/extfs.d/uzip:use File::Basename;
/usr/libexec/mc/extfs.d/uzip:use strict;
$ rpm -q --qf "[%{REQUIRENAME} %{REQUIREFLAGS:depflags}
%{REQUIREVERSION}\n]" mc | grep perl | xargs rpm -q --whatprovides
perl-interpreter-5.30.0-446.fc32.x86_64
perl-interpreter-5.30.0-446.fc32.x86_64
perl-File-Temp-0.230.900-439.fc31.noarch
perl-interpreter-5.30.0-446.fc32.x86_64
perl-interpreter-5.30.0-446.fc32.x86_64
perl-libs-5.30.0-446.fc32.x86_64
Without installed perl(File::Temp) perl module when someone will enter into
patch to use patchfs it will be be not working.
If you want to fix that you should try to rewrite patchfs perl backend
script in POSIX sh.
I'm almost sure that using perl in patchfs or zipfs is obverkill.
As well rpmfs is written is perl (many years ago when I've rewrote rpmfs
scrip it was using only POSIX sh with rpm as only external command ..
however in meantime someone made here some "progress").
Next time instead using you proven packager privileges at least please try
to contact someone who actively is maintaining some package.
You last two commits should be rolled back.
BTW mc.
Also I do not understand why FC31 release comity ignored my objection to
push mc 4.8.23 to fc31 since it core dumps sometimes few times per hour of
active use.
>From end user point of view difference between mc 4.8.22 and 4.8.23 are
negligible.
I have opened ticket with that issue
http://midnight-commander.org/ticket/4023
kloczek
--
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: jnovy pushed to mc (master). "- just keep perl-interpreter BR because of man2hlp, (..more)"
On Mon, 7 Oct 2019 at 12:04, wrote:
> Notification time stamped 2019-10-07 11:04:36 UTC
>
> From c0792d465daa3db808d63086a1524e786b213fe2 Mon Sep 17 00:00:00 2001
> From: Jindrich Novy
> Date: Oct 07 2019 11:04:05 +
> Subject: - just keep perl-interpreter BR because of man2hlp,
>
> it is a perl script required by build
> - require aspell-en, otherwise an annoying error prompt
> is displayed while editing any file
>
> ---
>
> diff --git a/mc.spec b/mc.spec
> index a800397..40dada6 100644
> --- a/mc.spec
> +++ b/mc.spec
> @@ -4,7 +4,7 @@ Summary:User-friendly text console file manager
> and visual shell
> Name: mc
> Epoch: 1
> Version: 4.8.23
> -Release: 4%{?dist}
> +Release: 5%{?dist}
> License: GPLv3+
> URL: http://www.midnight-commander.org/
> Source0:
> http://www.midnight-commander.org/downloads/mc-%{version}.tar.xz
> @@ -22,6 +22,8 @@ BuildRequires:groff-base
> BuildRequires: libssh2-devel >= 1.2.5
> BuildRequires: %{?with_slang:slang-devel}%{!?with_slang:ncurses-devel}
> BuildRequires: pkgconfig
> +BuildRequires: perl-interpreter
> +Requires: aspell-en
> Suggests: mc-python
>
On top of removing perl-generators which add for mc proper perl modules
dependencies for patchfs now we have pollution of the mc static
dependencies by add aspell-en.
mc does not need aspell-en but aspell does because aspell to work properly
needs at least some dictionary.
Jindrich please rollback your last two commits.
kloczek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
