Re: rpmbuild: File listed twice (but only build-ids)

2019-01-23 Thread Richard Shaw
For now I've gotten rid of off the globs/excludes but this really needs to
be fixed somehow...

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: rpmbuild: File listed twice (but only build-ids)

2019-01-15 Thread Mark Wielaard
On Tue, 2019-01-15 at 10:40 -0600, Richard Shaw wrote:
> Ooooaaa...
> 
> So this has been around since at least 2017 and there's no fix?

Much longer than that. At least since 2012, probably earlier.
%exclude is discouraged, which is why it doesn't seem to have higher
priority. See also:
https://bugzilla.redhat.com/show_bug.cgi?id=878863
(Although that bug is a little confusing since it seems to mix up two
issues with exclude files and build-id symlinks.)

It is a variant of:
https://github.com/rpm-software-management/rpm/issues/284
The fix for that excludes debug files for files which were excluded in
the non-debug package.

A similar fix should be done for generating the build-ids only for
binaries not in the pkg->fileExcludeList. Currently the
generateBuildIDs () function in build/files.c only gets the full
package file list. It probably should also get the fileExcludeList and
only generate the build-id links for files not on that list.

The interaction between the different package lists is a little
confusing though.

It is probably best to ask for guidance on the upstream mailinglist
rpm-ma...@lists.rpm.org (CCed).

> Is there an option to make it a warning again instead of an error?

I don't think without disabling build-ids completely.

Cheers,

Mark
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: rpmbuild: File listed twice (but only build-ids)

2019-01-15 Thread Richard Shaw
Ooooaaa...

So this has been around since at least 2017 and there's no fix?

Is there an option to make it a warning again instead of an error?

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: rpmbuild: File listed twice (but only build-ids)

2019-01-15 Thread Jerry James
On Tue, Jan 15, 2019 at 7:42 AM Richard Shaw  wrote:
> Is the %exclude just not working for the build-ids? That's all I can come up 
> with.

See:
https://bugzilla.redhat.com/show_bug.cgi?id=878863
https://bugzilla.redhat.com/show_bug.cgi?id=1482698
-- 
Jerry James
http://www.jamezone.org/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: rpmbuild: File listed twice (but only build-ids)

2019-01-15 Thread Tom Hughes

On 15/01/2019 14:41, Richard Shaw wrote:

Is the %exclude just not working for the build-ids? That's all I can 
come up with.


Well it is working, but it doesn't exclude them because they
don't match any of the patterns.

Those excludes only match files in %{_libdir} not in the .build-id
directory underneath it.

Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


rpmbuild: File listed twice (but only build-ids)

2019-01-15 Thread Richard Shaw
I'm working on the recent release of mythtv and everything compiled fine
until I got to the rpm packaging part which I got the following output:

   File listed twice:
/usr/lib/.build-id/01/02700911bb4fe728258f16703a35d816ddb31f
File listed twice:
/usr/lib/.build-id/5f/dc725022956f8f935afc0d29ad91594f57ee6e
File listed twice:
/usr/lib/.build-id/67/82796d2132f1b0dc2f865d208297340b1e7005
File listed twice:
/usr/lib/.build-id/83/30ab4fd5e920cc992a734b234d62fc7895db0f
File listed twice:
/usr/lib/.build-id/94/1a02be6311015e5b7f7b1778d463475925b5bc
File listed twice:
/usr/lib/.build-id/ae/d6aef663c2c17307251cb23e598212ad41d3d8
File listed twice:
/usr/lib/.build-id/d9/dfc4a918c04b597302215241b783a1fb0ca84d
File listed twice:
/usr/lib/.build-id/e6/306d3c48dc40e9927d9408900cb773dda95c48
---

For one, the output isn't very useful so I shelled into the mock and looked
up the "offending files":

02700911bb4fe728258f16703a35d816ddb31f ->
../../../../usr/lib64/libmythavformat.so.58.12.100
dc725022956f8f935afc0d29ad91594f57ee6e ->
../../../../usr/lib64/libmythavdevice.so.58.3.100
82796d2132f1b0dc2f865d208297340b1e7005 ->
../../../../usr/lib64/libmythavcodec.so.58.18.100
30ab4fd5e920cc992a734b234d62fc7895db0f ->
../../../../usr/lib64/libmythswscale.so.5.1.100
1a02be6311015e5b7f7b1778d463475925b5bc ->
../../../../usr/lib64/libmythavutil.so.56.14.100
d6aef663c2c17307251cb23e598212ad41d3d8 ->
../../../../usr/lib64/libmythpostproc.so.55.1.100
dfc4a918c04b597302215241b783a1fb0ca84d ->
../../../../usr/lib64/libmythswresample.so.3.1.100
306d3c48dc40e9927d9408900cb773dda95c48 ->
../../../../usr/lib64/libmythavfilter.so.7.16.100
---

I looked through the spec file and can't find where it's being included
twice, and why only the build-ids are listed twice, not the libraries
themselves.

$ grep "%{_libdir}" rpmbuild/mythtv/SPECS/mythtv.spec
%dir %{_libdir}/mythtv
%{_libdir}/mythtv/filters/
%dir %{_libdir}/mythtv/plugins
%exclude %{_libdir}/libmythav*.so.*
%exclude %{_libdir}/libmythpostproc.so.*
%exclude %{_libdir}/libmythswscale.so.*
%exclude %{_libdir}/libmythswresample.so.*
%{_libdir}/*.so.*
%{_libdir}/*.so
%{_libdir}/libmythav*.so.*
%{_libdir}/libmythpostproc.so.*
%{_libdir}/libmythswscale.so.*
%{_libdir}/libmythswresample.so.*
%{_libdir}/mythtv/plugins/libmytharchive.so
%{_libdir}/mythtv/plugins/libmythbrowser.so
%{_libdir}/mythtv/plugins/libmythgallery.so
%{_libdir}/mythtv/plugins/libmythgame.so
%{_libdir}/mythtv/plugins/libmythmusic.so
%{_libdir}/mythtv/plugins/libmythnews.so
%{_libdir}/mythtv/plugins/libmythweather.so
%{_libdir}/mythtv/plugins/libmythzoneminder.so
%{_libdir}/mythtv/plugins/libmythnetvision.so

Is the %exclude just not working for the build-ids? That's all I can come
up with.

Help appreciated.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org