Re: [Geany-Devel] Blank completion popups on Windows
Hi, Le 14/04/2015 21:54, Enrico Tröger a écrit : > […] > > Windows 7 with GTK 2.24.10. > Nick has the same problem, we talked about this in > http://lists.geany.org/devel/2015-January/009257.html. Dammit, I knew I saw this recently on a thread, but apparently I can't search my emails :) thanks for the link. > Your patch works for me. I personally would not mind the minimal size > increase. I completely agree it's better than an empty popup :). BTW, I think I found a way to avoid the oversize without subclassing GtkScrolledWindow, which might even be a better fix for the original issue. > What bothers me more is that for some reason this problem doesn't occur > with the cross-compiled nightly binaries. > This is what we noticed in the above mentioned thread already, I just > re-tested it to get sure. > Though I have not yet an idea what could cause the different behaviour > by the different builds :(. Interesting. It doesn't surprise me much, as my patch should not fix anything actually -- it doesn't even make sense. I just ended up seeing this change fixed the issue, but I have no clue why it would… So I guess it's some kind of memory corruption or something, due to either a bug in Geany, Scintilla or GTK, or in mingw itself… I'll try and see if I can track the issue down, but without Valgrind I'm afraid I'll have a hard time… Anyway, thanks a lot for the infos, it'll probably avoid me heading in the wrong direction :) Regards, Colomban signature.asc Description: OpenPGP digital signature ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 14.4.2015 г. 22:37, Enrico Tröger wrote: On 13/04/15 19:33, Dimitar Zhekov wrote: In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or whatever look, and you can only distinguish the current tab via a slight 3D effect. And unlike 3.x, where you can easily set the active tab I don't get it. For me it looks like as in the attached screenshot. I don't have a GTK 2.16 build at hand for a direct comparison but the notebook tabs look OK to me in the GTK 2.24 build. That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost due to the white editor background, combined with the identical unchangeable background for the tabs. Not completely indistinguishable, but much worse than 2.22, and hard on many tabs. -- E-gards: Jimmy ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Blank completion popups on Windows
Le 14/04/2015 21:54, Enrico Tröger a écrit :
>
> Windows 7 with GTK 2.24.10.
> Nick has the same problem, we talked about this in
> http://lists.geany.org/devel/2015-January/009257.html.
I just tested with GTK 2.24.10 on Windows 7, and it does fail the same.
I also tried with GTK 3.6.4 (!) and the problem wasn't present (but
there are several sub-optimal details with 3.6.
> Your patch works for me. I personally would not mind the minimal size
> increase. I completely agree it's better than an empty popup :).
>
> What bothers me more is that for some reason this problem doesn't occur
> with the cross-compiled nightly binaries.
> This is what we noticed in the above mentioned thread already, I just
> re-tested it to get sure.
> Though I have not yet an idea what could cause the different behaviour
> by the different builds :(.
I just noticed this in the debug messages:
> GLib-GObject WARNING : specified instance size for type `SmallScroller' is
> smaller than the parent type's `GtkScrolledWindow' instance size
> GLib CRITICAL : g_once_init_leave: assertion `initialization_value != 0'
> failed
> GLib-GObject CRITICAL : g_object_new: assertion `G_TYPE_IS_OBJECT
> (object_type)' failed
> Gtk CRITICAL : gtk_container_set_border_width: assertion `GTK_IS_CONTAINER
> (container)' failed
> Gtk CRITICAL : gtk_scrolled_window_set_policy: assertion
> `GTK_IS_SCROLLED_WINDOW (scrolled_window)' failed
> Gtk CRITICAL : gtk_container_add: assertion `GTK_IS_WIDGET (widget)' failed
> Gtk CRITICAL : gtk_widget_show: assertion `GTK_IS_WIDGET (widget)' failed
> Gtk CRITICAL : gtk_container_add: assertion `GTK_IS_CONTAINER (container)'
> failed
which explains at least why it's not working. Why the structure
wouldn't have the correct size is more of a mystery, as it's defined as
> typedef GtkScrolledWindow SmallScroller;
> typedef GtkScrolledWindowClass SmallScrollerClass;
…any idea? Of course if I try and see what the sizeof() of all those
are, they match (84 for the instances and 444 for the classes FTR).
The same happens if I try and create a structure wrapping them:
> typedef struct { GtkScrolledWindow parent; } SmallScroller;
> typedef struct { GtkScrolledWindowClass parent; } SmallScrollerClass;
However, a workaround is to add a small additional member:
> typedef struct { GtkScrolledWindow parent; int dummy; } SmallScroller;
> typedef struct { GtkScrolledWindowClass parent; int dummy; }
> SmallScrollerClass;
I still have no clue what the heck is going on though…
Regards,
Colomban
signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Blank completion popups on Windows
Le 15/04/2015 22:38, Colomban Wendling a écrit :
>
> I just noticed this in the debug messages:
>
>> GLib-GObject WARNING : specified instance size for type `SmallScroller' is
>> smaller than the parent type's `GtkScrolledWindow' instance size
>> GLib CRITICAL: g_once_init_leave: assertion `initialization_value !=
>> 0' failed
>> GLib-GObject CRITICAL: g_object_new: assertion `G_TYPE_IS_OBJECT
>> (object_type)' failed
>> Gtk CRITICAL : gtk_container_set_border_width: assertion `GTK_IS_CONTAINER
>> (container)' failed
>> Gtk CRITICAL : gtk_scrolled_window_set_policy: assertion
>> `GTK_IS_SCROLLED_WINDOW (scrolled_window)' failed
>> Gtk CRITICAL : gtk_container_add: assertion `GTK_IS_WIDGET (widget)' failed
>> Gtk CRITICAL : gtk_widget_show: assertion `GTK_IS_WIDGET (widget)' failed
>> Gtk CRITICAL : gtk_container_add: assertion `GTK_IS_CONTAINER (container)'
>> failed
>
> […]
>
>> typedef struct { GtkScrolledWindow parent; int dummy; } SmallScroller;
>> typedef struct { GtkScrolledWindowClass parent; int dummy; }
>> SmallScrollerClass;
>
> I still have no clue what the heck is going on though…
Hum, incidentally GtkScrolledWindow contains bitfields, would it be
possible it is a -mms-bitfields-like problem? We really seem to pass
-mms-bitfields, but maybe gtkscrolledwindow.c wasn't build with it or
something like that?
And actually the extra size is not needed in the Class.
signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 15-04-15 10:15 AM, Dimitar Zhekov wrote: On 14.4.2015 г. 22:37, Enrico Tröger wrote: On 13/04/15 19:33, Dimitar Zhekov wrote: In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or whatever look, and you can only distinguish the current tab via a slight 3D effect. And unlike 3.x, where you can easily set the active tab I don't get it. For me it looks like as in the attached screenshot. I don't have a GTK 2.16 build at hand for a direct comparison but the notebook tabs look OK to me in the GTK 2.24 build. That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost due to the white editor background, combined with the identical unchangeable background for the tabs. Not completely indistinguishable, but much worse than 2.22, and hard on many tabs. We could re-parent the Scintilla widget into a frame (or whichever is the proper widget) and set its border shadow to "in" or "etched in", which would probably look more appropriate on Windows[0][1][2], and likely still look fine on most non-Windows themes. Alternatively, we could probably tweak the default windows theme (engine) to make it look more "native". Cheers, Matthew Brush [0]: http://www.testech-elect.com/ontime/vstudio.gif [1]: http://cache.filehippo.com/img/ex/626__notepad1.png [2]: http://scitedebug.luaforge.net/scite-debug.png ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 15 April 2015 at 05:37, Enrico Tröger wrote: > On 13/04/15 19:33, Dimitar Zhekov wrote: >> On 13.4.2015 г. 04:11, Matthew Brush wrote: >> While on configuring, the README file still lists gtk+ 2.16 as a minimum requirement for Geany - but it's actually 2.18 with GtkInfoBar now, right? >>> >>> I just merged PR #245[0], so 2.24 should be good version to use. >> >> On 13.4.2015 г. 04:12, Lex Trotman wrote: >> >>> 2.18!!! c'mon, get with it, Geany is now 2.24 :) >> >> Wow, that may be not a very good news for the Windows users. >> >> In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or >> whatever look, and you can only distinguish the current tab via a slight >> 3D effect. And unlike 3.x, where you can easily set the active tab > > I don't get it. > For me it looks like as in the attached screenshot. I don't have a GTK > 2.16 build at hand for a direct comparison but the notebook tabs look OK > to me in the GTK 2.24 build. I agree that tabs displayed as per your screenshot make the active one less than visible at a quick glance, but changing the whole of GTK just to change the theming seems a bit heavy. Cheers Lex > > > Regards, > Enrico > > -- > Get my GPG key from http://www.uvena.de/pub.asc > > ___ > Devel mailing list > Devel@lists.geany.org > https://lists.geany.org/cgi-bin/mailman/listinfo/devel > ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
