Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: On 14.4.2015 г. 22:37, Enrico Tröger wrote: On 13/04/15 19:33, Dimitar Zhekov wrote: In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or whatever look, and you can only distinguish the current tab via a slight 3D effect. And unlike 3.x, where you can easily set the active tab I don't get it. For me it looks like as in the attached screenshot. I don't have a GTK 2.16 build at hand for a direct comparison but the notebook tabs look OK to me in the GTK 2.24 build. That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost due to the white editor background, combined with the identical unchangeable background for the tabs. Not completely indistinguishable, but much worse than 2.22, and hard on many tabs. In my splitwindow2 patches I underline the text label in active tab. So that the user can tell which of the 2 notebooks is active currently (the tabs alone don't show that). Would that be a worthy fix to your problem? Best regards ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On Thu, Apr 16, 2015 at 2:41 AM, Matthew Brush wrote: > > We could re-parent the Scintilla widget into a frame (or whichever is the > proper widget) and set its border shadow to "in" or "etched in", which > would probably look more appropriate on Windows[0][1][2], and likely still > look fine on most non-Windows themes. > > This is what I originally tried for https://github.com/geany/geany/pull/411 (and also sidebar and message window) but with flat themes there were suddenly too many lines (double-line border for each of the subwindows) and it only looked good for the Windows theme. Cheers, Jiri ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
Le 15/04/2015 19:15, Dimitar Zhekov a écrit : > On 14.4.2015 г. 22:37, Enrico Tröger wrote: >> On 13/04/15 19:33, Dimitar Zhekov wrote: >>> >>> In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or >>> whatever look, and you can only distinguish the current tab via a slight >>> 3D effect. And unlike 3.x, where you can easily set the active tab >> >> I don't get it. >> For me it looks like as in the attached screenshot. I don't have a GTK >> 2.16 build at hand for a direct comparison but the notebook tabs look OK >> to me in the GTK 2.24 build. > > That's exactly what I'm talking about. The white horizontal line, which > normally gives nice outline [vertical_tabs], but is almost lost due to > the white editor background, combined with the identical unchangeable > background for the tabs. Not completely indistinguishable, but much > worse than 2.22, and hard on many tabs. FWIW I get the real Windows GTK theme straight out of the GTK2 bundle ( no modification, no nothing, for some reason I didn't even have to set it), and it has a clear separation of the current tab (and feels more native/less ugly). Wouldn't this address your issue? (even better than avoiding using GTK 2.24 altogether) Or do you have another problem with the integrated theme? Regards, Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 16.4.2015 г. 03:41, Matthew Brush wrote: On 15-04-15 10:15 AM, Dimitar Zhekov wrote: That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost [...] We could re-parent the Scintilla widget into a frame (or whichever is the proper widget) and set its border shadow to "in" or "etched in", which would probably look more appropriate on Windows[0][1][2], and likely still look fine on most non-Windows themes. The Win~1 users are a minority. Maybe if it can be done depending on the OS... Alternatively, we could probably tweak the default windows theme (engine) to make it look more "native". I was unable to set the active/inactive tab backgrounds with any theme settings. In particular, the settings from gtk+ <= 2.22 did not work. -- E-gards: Jimmy ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost [...] due to the white editor background, combined with the identical unchangeable background for the tabs. Not completely indistinguishable, but much worse than 2.22, and hard on many tabs. In my splitwindow2 patches I underline the text label in active tab. So that the user can tell which of the 2 notebooks is active currently (the tabs alone don't show that). Would that be a worthy fix to your problem? Yes. The ability to have the current tab underlined, italic or bold seems like a good thing to have, irrespective of my problems with 2.24 + Win~1. It probably should be done programmatically? -- E-gards: Jimmy ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 16.4.2015 г. 14:41, Colomban Wendling wrote: Le 15/04/2015 19:15, Dimitar Zhekov a écrit : That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost [...] the white editor background, combined with the identical unchangeable background for the tabs. Not completely indistinguishable, but much worse than 2.22, and hard on many tabs. FWIW I get the real Windows GTK theme straight out of the GTK2 bundle ( no modification, no nothing, for some reason I didn't even have to set it), and it has a clear separation of the current tab (and feels more native/less ugly). Huh... What version of gtk+ is this? I was unable to set the tabs background to anything different than the default gray using .gtkrc-2.0, but maybe it takes the background color(s) from some element(s) of the Windows theme, or the rendering is different depending on the Windows version. Wouldn't this address your issue? (even better than avoiding using GTK 2.24 altogether) Or do you have another problem with the integrated theme? The problem is, it doesn't look much different than the Enrico's example, no matter the theme, though I have not tested extensively under 7even. Well, if XP is the problem, I wonder how it'll look under 10? I plan it as my next Windows version. If that's really dependent on the Windows version, it can break any moment, and I'd prefer the ability (mentioned by Thomas) to have an option for underlining the current tab text (or bold / italic it). Or should I get the heavy guns and write a plugin that displays line(s) of styled buttons that behave as tabs? The default tabs can be hidden in the interface preferences. BTW, having tabs on the left/right "solves" the problem, since the background color *is* applied to the vertical tabs. But that would be a bit unusual recommendation for all Win~1 users... -- E-gards: Jimmy ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 16/04/15 18:47, Dimitar Zhekov wrote: > On 16.4.2015 г. 12:37, Thomas Martitz wrote: >> Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: >>> That's exactly what I'm talking about. The white horizontal line, >>> which normally gives nice outline [vertical_tabs], but is almost [...] >>> due to the white editor background, combined with the identical >>> unchangeable background for the tabs. Not completely >>> indistinguishable, but much worse than 2.22, and hard on many tabs. >> >> In my splitwindow2 patches I underline the text label in active tab. So >> that the user can tell which of the 2 notebooks is active currently (the >> tabs alone don't show that). >> >> Would that be a worthy fix to your problem? > > Yes. The ability to have the current tab underlined, italic or bold > seems like a good thing to have, irrespective of my problems with 2.24 + > Win~1. It probably should be done programmatically? I sort of like the idea. And would agree that it might be not just useful on Windows. Thomas, can this be done in code so it could be enabled/disabled by a setting? Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc signature.asc Description: OpenPGP digital signature ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 15/04/15 19:15, Dimitar Zhekov wrote: > On 14.4.2015 г. 22:37, Enrico Tröger wrote: >> On 13/04/15 19:33, Dimitar Zhekov wrote: >>> >>> In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or >>> whatever look, and you can only distinguish the current tab via a slight >>> 3D effect. And unlike 3.x, where you can easily set the active tab >> >> I don't get it. >> For me it looks like as in the attached screenshot. I don't have a GTK >> 2.16 build at hand for a direct comparison but the notebook tabs look OK >> to me in the GTK 2.24 build. > > That's exactly what I'm talking about. The white horizontal line, which > normally gives nice outline [vertical_tabs], but is almost lost due to > the white editor background, combined with the identical unchangeable > background for the tabs. Not completely indistinguishable, but much > worse than 2.22, and hard on many tabs. I'm afraid I still do not completely understand the problem. I personally find the horizontal tabs nicer and easier to find the active tab than it is for the vertical tabs(as in the messages window at the bottom). There I have difficulties to easily see which tab is active. Is this what you mean or is my reception of visuals just different? Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc signature.asc Description: OpenPGP digital signature ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 16/04/15 21:51, Enrico Tröger wrote: > On 15/04/15 19:15, Dimitar Zhekov wrote: >> On 14.4.2015 г. 22:37, Enrico Tröger wrote: >>> On 13/04/15 19:33, Dimitar Zhekov wrote: In 2.24, the horizontal tabs under Win~1 have this "flat" or "modern" or whatever look, and you can only distinguish the current tab via a slight 3D effect. And unlike 3.x, where you can easily set the active tab >>> >>> I don't get it. >>> For me it looks like as in the attached screenshot. I don't have a GTK >>> 2.16 build at hand for a direct comparison but the notebook tabs look OK >>> to me in the GTK 2.24 build. >> >> That's exactly what I'm talking about. The white horizontal line, which >> normally gives nice outline [vertical_tabs], but is almost lost due to >> the white editor background, combined with the identical unchangeable >> background for the tabs. Not completely indistinguishable, but much >> worse than 2.22, and hard on many tabs. > > I'm afraid I still do not completely understand the problem. > I personally find the horizontal tabs nicer and easier to find the > active tab than it is for the vertical tabs(as in the messages window at > the bottom). There I have difficulties to easily see which tab is active. > > Is this what you mean or is my reception of visuals just different? Forget it. I finally got it. I just concentrated on your screenshot of the horizontal tabs in GTK 2.22 without realizing that it was from GTK 2.22 and not 2.24. Now I see clearly, that my screenshot also shows the problem. Sorry for the noise. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc signature.asc Description: OpenPGP digital signature ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
Le 16/04/2015 19:15, Dimitar Zhekov a écrit :
> On 16.4.2015 г. 14:41, Colomban Wendling wrote:
>> Le 15/04/2015 19:15, Dimitar Zhekov a écrit :
>>> That's exactly what I'm talking about. The white horizontal line, which
>>> normally gives nice outline [vertical_tabs], but is almost lost [...]
>>> the white editor background, combined with the identical unchangeable
>>> background for the tabs. Not completely indistinguishable, but much
>>> worse than 2.22, and hard on many tabs.
>>
>> FWIW I get the real Windows GTK theme straight out of the GTK2 bundle (
>> no modification, no nothing, for some reason I didn't even have to set
>> it), and it has a clear separation of the current tab (and feels more
>> native/less ugly).
>
> Huh... What version of gtk+ is this?
It's 2.24.10 from the official bundle, and it uses the "native" engine.
Normally you activate it by setting
gtk-theme-name = "MS-Windows"
in etc/gtk-2.0/gtkrc, as stated in the bundle's readme. But for some
reason I didn't even had to do that on Windows 7.
> I was unable to set the tabs
> background to anything different than the default gray using .gtkrc-2.0,
> but maybe it takes the background color(s) from some element(s) of the
> Windows theme, or the rendering is different depending on the Windows
> version.
I can't seem to really change the colors when using the "MS-Windows"
theme, but I guess it's kinda expected some things aren't really
overridable with a "native" theme that uses the Windows theming API or
something.
However, using "Raleigh" (the one you seem to use given the look) it's
relatively easy (well, not to guess what to change, but to change it).
Here's an example changing the *inactive* tabs (because changing the
active's background also changes the border around the tab's content and
I didn't like it):
style "notebook" {
bg[ACTIVE] = "#"
}
style "notebook-label" {
fg[ACTIVE] = "#"
}
widget "*.GtkNotebook" style "notebook"
widget "*.GtkNotebook.*GtkLabel" style "notebook-label"
(not very well tested, might override too much)
Attached screenshot shows the (ugly) result.
>> Wouldn't this address your issue? (even better than avoiding using GTK
>> 2.24 altogether) Or do you have another problem with the integrated
>> theme?
>
> The problem is, it doesn't look much different than the Enrico's
> example, no matter the theme, though I have not tested extensively under
> 7even.
Hum, to my eyes on my capture it looks quite different… and attached is
the same on XP, still using the "MS-Windows" theme.
> Well, if XP is the problem, I wonder how it'll look under 10? I
> plan it as my next Windows version.
XP is not the problem, it works just the same. Of course the
"MS-Windows" theme looks different as it tried to feel native and the
Windows themes are different, but that's all.
> […]
>
> Or should I get the heavy guns and write a plugin that displays line(s)
> of styled buttons that behave as tabs? The default tabs can be hidden in
> the interface preferences.
If you like it, sure, but it sounds a bit heavy for something that
should be solvable with a theme :)
Regards,
Colomban
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
Am 16.04.2015 um 21:47 schrieb Enrico Tröger: On 16/04/15 18:47, Dimitar Zhekov wrote: On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost [...] due to the white editor background, combined with the identical unchangeable background for the tabs. Not completely indistinguishable, but much worse than 2.22, and hard on many tabs. In my splitwindow2 patches I underline the text label in active tab. So that the user can tell which of the 2 notebooks is active currently (the tabs alone don't show that). Would that be a worthy fix to your problem? Yes. The ability to have the current tab underlined, italic or bold seems like a good thing to have, irrespective of my problems with 2.24 + Win~1. It probably should be done programmatically? I sort of like the idea. And would agree that it might be not just useful on Windows. Thomas, can this be done in code so it could be enabled/disabled by a setting? Sure, but why would you disable it? Is a pref necessary? And at least with my splitwindow2 patch set something like this is needed to determine the focused document (each notebook can have an active doc, but only one of them can be focused at any time). PS: In case it's not clear, splitwindow2 refers to my patch set that enables splitting the editor into two widgets so that 2 docs are visible at the same time. In contrast to the plugin it does this so that both widget work the same way, so support styling, keybindings and other things properly. Best regards ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
Le 16/04/2015 23:14, Thomas Martitz a écrit : > Am 16.04.2015 um 21:47 schrieb Enrico Tröger: >> On 16/04/15 18:47, Dimitar Zhekov wrote: >>> On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: > […] In my splitwindow2 patches I underline the text label in active tab. So that the user can tell which of the 2 notebooks is active currently (the tabs alone don't show that). Would that be a worthy fix to your problem? >>> Yes. The ability to have the current tab underlined, italic or bold >>> seems like a good thing to have, irrespective of my problems with 2.24 + >>> Win~1. It probably should be done programmatically? >> I sort of like the idea. And would agree that it might be not just >> useful on Windows. >> Thomas, can this be done in code so it could be enabled/disabled by a >> setting? > > Sure, but why would you disable it? Because it's damn ugly :) (and serves absolutely no purpose -- for me) > Is a pref necessary? Yes. > And at least > with my splitwindow2 patch set something like this is needed to > determine the focused document (each notebook can have an active doc, > but only one of them can be focused at any time). Only if the splitwindow is actually used. And even, underlying the tab might not be the best visual indicator ever, though I can't suggest something easy that would actually work (I'd think a better one would be some kind of slightly deactivated editor, but while doable it's a bit annoying with Scintilla). ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Blank completion popups on Windows
On 15/04/15 23:14, Colomban Wendling wrote:
> Le 15/04/2015 22:38, Colomban Wendling a écrit :
>>
>> I just noticed this in the debug messages:
>>
>>> GLib-GObject WARNING: specified instance size for type
>>> `SmallScroller' is smaller than the parent type's `GtkScrolledWindow'
>>> instance size
>>> GLib CRITICAL : g_once_init_leave: assertion `initialization_value !=
>>> 0' failed
>>> GLib-GObject CRITICAL : g_object_new: assertion `G_TYPE_IS_OBJECT
>>> (object_type)' failed
>>> Gtk CRITICAL: gtk_container_set_border_width: assertion
>>> `GTK_IS_CONTAINER (container)' failed
>>> Gtk CRITICAL: gtk_scrolled_window_set_policy: assertion
>>> `GTK_IS_SCROLLED_WINDOW (scrolled_window)' failed
>>> Gtk CRITICAL: gtk_container_add: assertion `GTK_IS_WIDGET (widget)'
>>> failed
>>> Gtk CRITICAL: gtk_widget_show: assertion `GTK_IS_WIDGET (widget)'
>>> failed
>>> Gtk CRITICAL: gtk_container_add: assertion `GTK_IS_CONTAINER
>>> (container)' failed
>>
>> […]
>>
>>> typedef struct { GtkScrolledWindow parent; int dummy; } SmallScroller;
>>> typedef struct { GtkScrolledWindowClass parent; int dummy; }
>>> SmallScrollerClass;
>>
>> I still have no clue what the heck is going on though…
>
> Hum, incidentally GtkScrolledWindow contains bitfields, would it be
> possible it is a -mms-bitfields-like problem? We really seem to pass
> -mms-bitfields, but maybe gtkscrolledwindow.c wasn't build with it or
> something like that?
Wow, great process, Colomban.
Reading your previous mail the -mms-bitfields thingy instantly came also
to my mind.
I checked the nightly builds as well the builds on my Windows VM, both
had -mms-bitfields set, also for PlatGTK.cxx.
This opton is set by gtk+-2.0.pc (GTK pkgconfig file), so it's obvious
both builds have it set.
But maybe it's related to the compiler version. The cross-compiled
nightlies are a bit special in terms of cross-compiling and that they
use a quite old mingw-gcc 3.4 while the mingw-gcc on my Windows VM is a
more recent 4.8.
I found http://gcc.gnu.org/gcc-4.7/changes.html where a short note says:
Windows mingw targets are using the -mms-bitfields option by default.
I would say this is probably not relevant because we compile our code
with -mms-bitfields in all cases because GTK pulls it in.
But IANAC (I am not a compiler :D).
Does anyone here has by accident a Windows system with a mingw-gcc < 4.7?
I'll try to further debug this on the weekend if I find time.
Regards,
Enrico
--
Get my GPG key from http://www.uvena.de/pub.asc
signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
On 15-04-16 02:20 PM, Colomban Wendling wrote: Le 16/04/2015 23:14, Thomas Martitz a écrit : Am 16.04.2015 um 21:47 schrieb Enrico Tröger: On 16/04/15 18:47, Dimitar Zhekov wrote: On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: […] In my splitwindow2 patches I underline the text label in active tab. So that the user can tell which of the 2 notebooks is active currently (the tabs alone don't show that). Would that be a worthy fix to your problem? Yes. The ability to have the current tab underlined, italic or bold seems like a good thing to have, irrespective of my problems with 2.24 + Win~1. It probably should be done programmatically? I sort of like the idea. And would agree that it might be not just useful on Windows. Thomas, can this be done in code so it could be enabled/disabled by a setting? Sure, but why would you disable it? Because it's damn ugly :) (and serves absolutely no purpose -- for me) +1, and it's also something that should be controlled by user/system themes, not the app, IMO. Is a pref necessary? Yes. +1. If people really want it, I'd appreciate to be able to disable it. And at least with my splitwindow2 patch set something like this is needed to determine the focused document (each notebook can have an active doc, but only one of them can be focused at any time). Only if the splitwindow is actually used. And even, underlying the tab might not be the best visual indicator ever, though I can't suggest something easy that would actually work (I'd think a better one would be some kind of slightly deactivated editor, but while doable it's a bit annoying with Scintilla). Or maybe just a special border around the focused scintilla or nothing at all (except the correct window title, and blinking cursor). Cheers, Matthew Brush ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD
Am 16.04.2015 um 23:20 schrieb Colomban Wendling: Is a pref necessary? Yes. In that case it's not the best solution and we should find an indication that people don't want to outright disable. The underline gets the job done but I'm not married to it. Can you suggest a better alternative? And at least with my splitwindow2 patch set something like this is needed to determine the focused document (each notebook can have an active doc, but only one of them can be focused at any time). Only if the splitwindow is actually used. And even, underlying the tab might not be the best visual indicator ever, though I can't suggest something easy that would actually work (I'd think a better one would be some kind of slightly deactivated editor, but while doable it's a bit annoying with Scintilla). And it might be barely visible depending on the color scheme. Because of that I think no indication that involves the scintilla widget alone will work for everybody. Anyway we can discuss this specifically for splitwindow2. Let's not further hijack this thread, I just wanted to throw in that a visual indication other than what GTK does by itself might become necessary anyway. Best regards. ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
