Re: [OMPI devel] Reachable framework integration

2020-01-06 Thread Zhang, William via devel
Yes, my pull request at https://github.com/open-mpi/ompi/pull/7134 (Please 
review it >=() is the first utilization of the Reachable framework. I’ve also 
been doing small documentation adjustments to make the inputs more clear.

If you have any questions on my PR, please leave feedback in the comments and I 
will address them.

Cheers,
William Zhang

From: devel  on behalf of "Barrett, Brian via 
devel" 
Reply-To: Open MPI Developers 
Date: Thursday, January 2, 2020 at 1:35 PM
To: Open MPI Developers , George Bosilca 

Cc: Brian Barrett 
Subject: Re: [OMPI devel] Reachable framework integration

Ralph -

Are you looking for the "best" single connection between two hosts, or the best 
set of pairings, or even "just any pairing that works"?  The TCP BTL code is 
complicated because it's looking for the best overall set of pairings, to 
maximize the number (and quality) of links between the two ranks.  This 
(theoretically) maximizes throughput.  The usage model for "I just want one 
connection that moves some bits" is probably a lot simpler.  I don't think you 
need to build the entire graph in that case.

Some of the complexity was also that we were trying to reuse as much code as 
possible between TCP and usnic, while making minimum changes to usnic.  Maybe 
not the best option, but AWS doesn't have a way of testing on usnic, so...

Brian

From: devel  on behalf of Ralph Castain via 
devel 
Reply-To: Open MPI Developers 
Date: Thursday, January 2, 2020 at 12:41 PM
To: George Bosilca 
Cc: Ralph Castain , OpenMPI Devel 
Subject: Re: [OMPI devel] Reachable framework integration

Hmmm...pretty complex code in there. Looks like it has to be "replicated" for 
reuse as functions are passing in btl_tcp specific structs. Is it worth 
developing an abstracted version of such functions as 
mca_btl_tcp_proc_create_interface_graph and 
mca_btl_tcp_proc_store_matched_interfaces?





On Jan 2, 2020, at 9:35 AM, George Bosilca 
mailto:bosi...@icl.utk.edu>> wrote:

Ralph,

I think the first use is still pending reviews (more precisely my review) at 
https://github.com/open-mpi/ompi/pull/7134.

  George.


On Wed, Jan 1, 2020 at 9:53 PM Ralph Castain via devel 
mailto:devel@lists.open-mpi.org>> wrote:
Hey folks

I can't find where the opal/reachable framework is being used in OMPI. I would 
like to utilize it in the PRRTE oob/tcp component, but need some guidance on 
how to do so, or pointers to an example.

Ralph





Re: [OMPI devel] Reachable framework integration

2020-01-02 Thread Barrett, Brian via devel
Ralph -

Are you looking for the "best" single connection between two hosts, or the best 
set of pairings, or even "just any pairing that works"?  The TCP BTL code is 
complicated because it's looking for the best overall set of pairings, to 
maximize the number (and quality) of links between the two ranks.  This 
(theoretically) maximizes throughput.  The usage model for "I just want one 
connection that moves some bits" is probably a lot simpler.  I don't think you 
need to build the entire graph in that case.

Some of the complexity was also that we were trying to reuse as much code as 
possible between TCP and usnic, while making minimum changes to usnic.  Maybe 
not the best option, but AWS doesn't have a way of testing on usnic, so...

Brian

From: devel  on behalf of Ralph Castain via 
devel 
Reply-To: Open MPI Developers 
Date: Thursday, January 2, 2020 at 12:41 PM
To: George Bosilca 
Cc: Ralph Castain , OpenMPI Devel 
Subject: Re: [OMPI devel] Reachable framework integration

Hmmm...pretty complex code in there. Looks like it has to be "replicated" for 
reuse as functions are passing in btl_tcp specific structs. Is it worth 
developing an abstracted version of such functions as 
mca_btl_tcp_proc_create_interface_graph and 
mca_btl_tcp_proc_store_matched_interfaces?




On Jan 2, 2020, at 9:35 AM, George Bosilca 
mailto:bosi...@icl.utk.edu>> wrote:

Ralph,

I think the first use is still pending reviews (more precisely my review) at 
https://github.com/open-mpi/ompi/pull/7134.

  George.


On Wed, Jan 1, 2020 at 9:53 PM Ralph Castain via devel 
mailto:devel@lists.open-mpi.org>> wrote:
Hey folks

I can't find where the opal/reachable framework is being used in OMPI. I would 
like to utilize it in the PRRTE oob/tcp component, but need some guidance on 
how to do so, or pointers to an example.

Ralph




Re: [OMPI devel] Reachable framework integration

2020-01-02 Thread Barrett, Brian via devel
George, this is a great reminder to please review that code.  William's being 
way too polite, and we know this helps with some of our problems :).

Brian

From: devel  on behalf of George Bosilca via 
devel 
Reply-To: Open MPI Developers 
Date: Thursday, January 2, 2020 at 9:48 AM
To: Open MPI Developers 
Cc: George Bosilca 
Subject: Re: [OMPI devel] Reachable framework integration

Ralph,

I think the first use is still pending reviews (more precisely my review) at 
https://github.com/open-mpi/ompi/pull/7134.

  George.


On Wed, Jan 1, 2020 at 9:53 PM Ralph Castain via devel 
mailto:devel@lists.open-mpi.org>> wrote:
Hey folks

I can't find where the opal/reachable framework is being used in OMPI. I would 
like to utilize it in the PRRTE oob/tcp component, but need some guidance on 
how to do so, or pointers to an example.

Ralph



Re: [OMPI devel] Reachable framework integration

2020-01-02 Thread Ralph Castain via devel
Hmmm...pretty complex code in there. Looks like it has to be "replicated" for 
reuse as functions are passing in btl_tcp specific structs. Is it worth 
developing an abstracted version of such functions as 
mca_btl_tcp_proc_create_interface_graph and 
mca_btl_tcp_proc_store_matched_interfaces?



On Jan 2, 2020, at 9:35 AM, George Bosilca mailto:bosi...@icl.utk.edu> > wrote:

Ralph,

I think the first use is still pending reviews (more precisely my review) at 
https://github.com/open-mpi/ompi/pull/7134.

  George.


On Wed, Jan 1, 2020 at 9:53 PM Ralph Castain via devel 
mailto:devel@lists.open-mpi.org> > wrote:
Hey folks

I can't find where the opal/reachable framework is being used in OMPI. I would 
like to utilize it in the PRRTE oob/tcp component, but need some guidance on 
how to do so, or pointers to an example.

Ralph





Re: [OMPI devel] Reachable framework integration

2020-01-02 Thread George Bosilca via devel
Ralph,

I think the first use is still pending reviews (more precisely my review)
at https://github.com/open-mpi/ompi/pull/7134.

  George.


On Wed, Jan 1, 2020 at 9:53 PM Ralph Castain via devel <
devel@lists.open-mpi.org> wrote:

> Hey folks
>
> I can't find where the opal/reachable framework is being used in OMPI. I
> would like to utilize it in the PRRTE oob/tcp component, but need some
> guidance on how to do so, or pointers to an example.
>
> Ralph
>
>
>


[OMPI devel] Reachable framework integration

2020-01-01 Thread Ralph Castain via devel
Hey folks

I can't find where the opal/reachable framework is being used in OMPI. I would 
like to utilize it in the PRRTE oob/tcp component, but need some guidance on 
how to do so, or pointers to an example.

Ralph