[ovirt-devel] [RFC] Proposal for dropping FC22 jenkins tests on master branch

[Sandro Bonazzola]

Hi,
can we drop FC22 testing in jenkins now that FC23 jobs are up and running?
it will reduce jenkins load. If needed we can keep FC22 builds, just
dropping the check jobs.
Comments?

-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [RFC] Proposal for dropping FC22 jenkins tests on master branch

[Nir Soffer]

fedora 23 jobs are failing because of missing dependencies.

Lets wait with this until the ci becomes stable.

On Thu, Nov 12, 2015 at 10:34 AM, Sandro Bonazzola  wrote:
> Hi,
> can we drop FC22 testing in jenkins now that FC23 jobs are up and running?
> it will reduce jenkins load. If needed we can keep FC22 builds, just
> dropping the check jobs.
> Comments?
>
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
>
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] In windows OS & firefox brower, Window.Location.replace(url) would stop System to execute Command, and would not catch any error info.But other OS like firefox in linux would not happen

[????]

HiI want to redirct the page when ovirt admin logout, so I add 
:Window.Location.replace("/test.html") in ApplicationPlaceManager.java as 
below:  @Override public void revealDefaultPlace() { PlaceRequest 
pr = getDefaultPlace(); if (pr == null) { 
//Window.Location.replace("/test.html"); //$NON-NLS-1$ } else { 
revealPlace(pr); } } or in 
LoginModel.java\BaseApplicationInit.java etc. It can achieve to redirect by 
chrome,IE and firefox in Linux, and would execute LogoutUserCommand to clean 
user session,Then at firefox in Windows no matter which version, it could 
redirect but would not execute LogoutUserCommand, so I can log into System by 
previous URL without password.  How can I redirect URL when logout?Is there any 
config files for this? I could not find it, thanks a lot :) Version-Release 
number of selected component (if applicable): 3.4.5 Steps to Reproduce: 
1.update code:ApplicationPlaceManager.java  public void revealDefaultPlace() {  
   PlaceRequest pr = getDefaultPlace(); if (pr == null) {   
  //Window.Location.replace("/test.html"); //$NON-NLS-1$ } else {   
  revealPlace(pr); } } 2.login system and logout 3.input 
previous url like :xx/ovirt-engine/webadmin/?locale=zh_CN#vms and can 
redirect. Actual results: redirect into vm page. Expected results: redirect 
into login page.___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [RFC] Proposal for dropping FC22 jenkins tests on master branch

[Sandro Bonazzola]

On Thu, Nov 12, 2015 at 9:43 AM, Nir Soffer  wrote:

> fedora 23 jobs are failing because of missing dependencies.
>
> Lets wait with this until the ci becomes stable.
>

fedora 23 VDSM jobs are failing because https://gerrit.ovirt.org/48408 has
not been merged yet.



>
> On Thu, Nov 12, 2015 at 10:34 AM, Sandro Bonazzola 
> wrote:
> > Hi,
> > can we drop FC22 testing in jenkins now that FC23 jobs are up and
> running?
> > it will reduce jenkins load. If needed we can keep FC22 builds, just
> > dropping the check jobs.
> > Comments?
> >
> > --
> > Sandro Bonazzola
> > Better technology. Faster innovation. Powered by community collaboration.
> > See how it works at redhat.com
> >
> > ___
> > Infra mailing list
> > in...@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
>



-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Jenkins build fails - bad dependency?

[David Caro]

On 11/12, Sandro Bonazzola wrote:
> On Thu, Nov 12, 2015 at 11:33 AM, Dan Kenigsberg  wrote:
> 
> > On Wed, Nov 11, 2015 at 03:41:11PM +0100, Sandro Bonazzola wrote:
> > > On Wed, Nov 11, 2015 at 12:06 PM, Eyal Edri  wrote:
> > >
> > > > ccing devel.
> > > >
> > > > On Tue, Nov 10, 2015 at 6:32 PM, Nir Soffer 
> > wrote:
> > > >
> > > >> This currently breaks the build for
> > > >> https://gerrit.ovirt.org/31162
> > > >>
> > > >> 00:08:25.505 Last metadata expiration check performed 0:00:02 ago on
> > > >> Tue Nov 10 16:24:12 2015.
> > > >>
> > > >> 00:08:30.247 Error: nothing provides ovirt-vmconsole >= 1.0.0-0 needed
> > > >> by vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > > >> vdsm-4.17.999-118.git71e8041.fc23.noarch
> > > >> 00:08:30.247 (try to add '--allowerasing' to command line to replace
> > > >> conflicting packages)
> > > >>
> > > >> Can you take a look at this?
> > > >>
> > > >
> > >
> > > looks like the automation/check-patch.repos file is missing the snapshot
> > > repo.
> >
> > heh, we simply have no automation/check-patch.repos.fc23, yet.
> > Is that
> >
> > http//gerrit.ovirt.org/48479
> >
> > all that is needed?
> >
> 
> I think so

You can try rebasing the failing patch on top of it, and sending it for review,
it will run with those changes on jenkins

> 
> -- 
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com

> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra


-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R

Tel.: +420 532 294 605
Email: dc...@redhat.com
Web: www.redhat.com
RHT Global #: 82-62605


signature.asc
Description: PGP signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] introducing F23 jobs: vdsm_master_check-patch-fc23 failure

[Dan Kenigsberg]

On Wed, Nov 11, 2015 at 03:43:14PM +0100, Sandro Bonazzola wrote:
> On Tue, Nov 10, 2015 at 1:21 PM, Dan Kenigsberg  wrote:
> 
> > Thanks for introducing the new job.
> > However, I see that the job that runs on spec changes fails:
> >
> > http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/49/
> >
> > 07:40:56 Last metadata expiration check performed 0:00:27 ago on Tue Nov
> > 10 07:40:24 2015.
> > 07:40:56 Error: nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > vdsm-4.17.999-116.git7d73f3b.fc23.noarch.
> > 07:40:56 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > vdsm-4.17.999-116.git7d73f3b.fc23.noarch.
> >
> > and another fails on
> >
> > http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc23_created/9/console
> >
> > 07:27:09 shell-scripts/mock_build_onlyrpm.sh
> > 07:27:09 + distro=fc23
> > 07:27:09 + arch=x86_64
> > 07:27:09 + project=vdsm
> > 07:27:09 + extra_packages=(vim-minimal)
> > 07:27:09 + extra_rpmbuild_options=('with_check=0' 'with_hooks=1')
> > 07:27:09 /tmp/hudson8201470295383101379.sh: line 39: syntax error near
> > unexpected token `('
> >
> >
> > Do we have an fc23 build of ovirt-vmconsole?
> > Can you fix that syntax error?
> >
> 
> Should all be fixed, only https://gerrit.ovirt.org/48408 pending merge

Taken, though for some reason, I had to manually set the CI+1 flag on it.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Update on oVirt Mirroring Status

[Anton Marchukov]

Hello All.

We have got the issue solved. I am readding mirrors back to the mirror list
as soon as I get confirmation it is working for each mirror.

At the moment we already have few mirrors back there.

Anton.

On Wed, Nov 11, 2015 at 10:45 AM, Anton Marchukov 
wrote:

> Hello All.
>
> Following previous announcement, please note that we still face a problem
> with getting updates to our mirrors. This is firewalling problem and we are
> working with IT on resolving it.
>
> I have temporarily updated mirror list to include only resources.ovirt.org
> there. It will be changed back as soon as the mirroring is restored.
>
> Please note that if you are not using the mirrorlist and include URLs
> directly and you are interested in latest snapshoots, than you may need to
> use http://resources.ovirt.org/pub/ovirt-@VERSION@/rpm/@DIST@/ directly.
>
> Will reply on this message once I get an ETA. Please contact
> in...@ovirt.org in case you have any questions.
>
> Anton.
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>


-- 
Anton Marchukov
Senior Software Engineer - RHEV CI - Red Hat
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] firewalld on vdsm host

[Fabian Deutsch]

Hey,

what is the expectation/assumption about firewalld on a CentOS 7 host
where you want to install vdsm onto?

Is vdsm taking care of it?

I'm asking this, because firewalld seems to be in the default package
(please correct me if I am wrong) set of CentOS 7 and thus installed
by default.

- fabian
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Jenkins build fails - bad dependency?

[Sandro Bonazzola]

On Thu, Nov 12, 2015 at 11:33 AM, Dan Kenigsberg  wrote:

> On Wed, Nov 11, 2015 at 03:41:11PM +0100, Sandro Bonazzola wrote:
> > On Wed, Nov 11, 2015 at 12:06 PM, Eyal Edri  wrote:
> >
> > > ccing devel.
> > >
> > > On Tue, Nov 10, 2015 at 6:32 PM, Nir Soffer 
> wrote:
> > >
> > >> This currently breaks the build for
> > >> https://gerrit.ovirt.org/31162
> > >>
> > >> 00:08:25.505 Last metadata expiration check performed 0:00:02 ago on
> > >> Tue Nov 10 16:24:12 2015.
> > >>
> > >> 00:08:30.247 Error: nothing provides ovirt-vmconsole >= 1.0.0-0 needed
> > >> by vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> > >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> > >> vdsm-4.17.999-118.git71e8041.fc23.noarch
> > >> 00:08:30.247 (try to add '--allowerasing' to command line to replace
> > >> conflicting packages)
> > >>
> > >> Can you take a look at this?
> > >>
> > >
> >
> > looks like the automation/check-patch.repos file is missing the snapshot
> > repo.
>
> heh, we simply have no automation/check-patch.repos.fc23, yet.
> Is that
>
> http//gerrit.ovirt.org/48479
>
> all that is needed?
>

I think so

-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Jenkins build fails - bad dependency?

[Dan Kenigsberg]

On Wed, Nov 11, 2015 at 03:41:11PM +0100, Sandro Bonazzola wrote:
> On Wed, Nov 11, 2015 at 12:06 PM, Eyal Edri  wrote:
> 
> > ccing devel.
> >
> > On Tue, Nov 10, 2015 at 6:32 PM, Nir Soffer  wrote:
> >
> >> This currently breaks the build for
> >> https://gerrit.ovirt.org/31162
> >>
> >> 00:08:25.505 Last metadata expiration check performed 0:00:02 ago on
> >> Tue Nov 10 16:24:12 2015.
> >>
> >> 00:08:30.247 Error: nothing provides ovirt-vmconsole >= 1.0.0-0 needed
> >> by vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch.
> >> 00:08:30.247 nothing provides ovirt-vmconsole >= 1.0.0-0 needed by
> >> vdsm-4.17.999-118.git71e8041.fc23.noarch
> >> 00:08:30.247 (try to add '--allowerasing' to command line to replace
> >> conflicting packages)
> >>
> >> Can you take a look at this?
> >>
> >
> 
> looks like the automation/check-patch.repos file is missing the snapshot
> repo.

heh, we simply have no automation/check-patch.repos.fc23, yet.
Is that

http//gerrit.ovirt.org/48479

all that is needed?
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] ?????? In windows OS & firefox brower, Window.Location.replace(url) would stop System to execute Command, and would not catch any error info.But other OS like firefox in linux would not

[????]

Hi Alexander
I tried your method ,and it works! right, I want to redirect another page 
after user logged out, but also I want Ovirt-engine could execute Logout user 
command to clear session.
I tried to insert Window.Location.replrace in LoginModel.java , 
ApplicationPlaceManager.java etc.  In any version firefox of window7 OS,  even 
if another page could be redirected correctly ,ovirt-engine would not execute 
Logout user command ,so user's session would  not be clear, and I can see 
previous  page. 
It's strange that this stuff would not happen in other browsers(chrome/IE), 
even the firefox of Linux.  I try to replace in callback() as your advice, now, 
for every browsers, ovirt-engine can execute logout command, it works! Thank 
you so much for your patience ??)




--  --
??: "Alexander Wels"; 
: 2015??11??12??(??) 10:37
??: "devel"; 
: ""; 
: Re: [ovirt-devel] In windows OS & firefox brower, 
Window.Location.replace(url) would stop System to execute Command, and would 
not catch any error info.But other OS like firefox in linux would not happen 
like that



On Thursday, November 12, 2015 01:41:38 PM  wrote:
> HiI want to redirct the page when ovirt admin logout, so I add
> :Window.Location.replace("/test.html") in ApplicationPlaceManager.java as
> below:  
> @Override
> public void revealDefaultPlace() {
> PlaceRequest pr = getDefaultPlace();
> if (pr == null) {
> //Window.Location.replace("/test.html"); //$NON-NLS-1$ 
> } else {
> revealPlace(pr); 
> }
> } or in
> LoginModel.java\BaseApplicationInit.java etc. It can achieve to redirect by
> chrome,IE and firefox in Linux, and would execute LogoutUserCommand to
> clean user session,Then at firefox in Windows no matter which version, it
> could redirect but would not execute LogoutUserCommand, so I can log into
> System by previous URL without password.  How can I redirect URL when
> logout?Is there any config files for this? I could not find it, thanks a
> lot :) Version-Release number of selected component (if applicable): 3.4.5
> Steps to Reproduce: 1.update code:ApplicationPlaceManager.java  public void
> revealDefaultPlace() { PlaceRequest pr = getDefaultPlace();
> if (pr == null) { //Window.Location.replace("/test.html");
> //$NON-NLS-1$ } else { revealPlace(pr); } }
> 2.login system and logout 3.input previous url like
> :xx/ovirt-engine/webadmin/?locale=zh_CN#vms and can redirect. Actual
> results: redirect into vm page. Expected results: redirect into login page.

Hi,

I am trying to decipher your message (it got garbled for some reason). And I 
am trying to understand what you are trying to do. If I understand correctly 
you want to redirect to some other page after you have logged out of the web 
admin.

To get back to the specifics of your question. The DefaultPlace is the #XXX in 
the URL you are sent to (note its not an actual redirect, since there is no 
round trip to the server), if you don't specify a particular place. When you 
do #vms the whole DefaultPlace mechanism is not in play since you specified a 
particular place.

What does happen is that the framework asks the LoggedInGatekeeper if the user 
is logged in (in the canReveal() method). If the user is logged in, it will 
proceed to the normal place requested (in your example #vms). If the user is 
not logged in, it will switch places to #login and display the login screen.

Now you say you are using 3.4.5 which is quite old, and its been some time 
since I worked with it. If I understand correctly what you are trying to do, 
don't mess around with the DefaultPlace. In BaseApplicationInit there should 
be a 'onLogout' method. In there should be a callback that happens AFTER the 
user is logged out from the server. Right now it says something 
Window.Location.reload() to reload the page after the logout. You should be 
able to put your Window.Location.replace in there (replace the reload with the 
replace). Which I think will do what you want.

If it doesn't do what you want, I am going to need some more information on 
what it is that you are trying to do.

Alexander___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Sandro Bonazzola]

On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer  wrote:

> Hi all,
>
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
>
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this
> header.
>
> Here are some examples how we can use it:
>
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598


infra: looking at above commit messages, can we get automatically added the
following lines?

Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation

Reviewed-by: Francesco Romani 
on patch comment



>
>
> Thanks,
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Francesco Romani]

- Original Message -
> From: "Nir Soffer" 
> To: "devel" 
> Cc: "Dan Kenigsberg" , "Francesco Romani" 
> , "Piotr Kliczewski"
> , "Adam Litke" , "Allon Mureinik" 
> 
> Sent: Thursday, November 12, 2015 3:45:13 PM
> Subject: Reported-By - giving credit to our testers
> 
> Hi all,
> 
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
> 
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this header.

Strongly agreed, let's do this!

Bests,

-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

[Fabian Deutsch]

On Thu, Nov 12, 2015 at 2:36 PM, Dan Kenigsberg  wrote:
> On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
>> Hey,
>>
>> what is the expectation/assumption about firewalld on a CentOS 7 host
>> where you want to install vdsm onto?
>>
>> Is vdsm taking care of it?
>>
>> I'm asking this, because firewalld seems to be in the default package
>> (please correct me if I am wrong) set of CentOS 7 and thus installed
>> by default.
>
> As far as I know, Vdsm runs fine in parallel to firewalld on recent
> el7.1 (there used to be problems in early 7.0 versions).
>
> If this is not the case, please file a bug with precise versions!

Bug 1281417 - vdsm host can not be added with firewalld enabled


Done. Thanks.

fabian
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] In windows OS & firefox brower, Window.Location.replace(url) would stop System to execute Command, and would not catch any error info.But other OS like firefox in linux would not hap

[Alexander Wels]

On Thursday, November 12, 2015 01:41:38 PM 温蓓 wrote:
> HiI want to redirct the page when ovirt admin logout, so I add
> :Window.Location.replace("/test.html") in ApplicationPlaceManager.java as
> below:  
> @Override
> public void revealDefaultPlace() {
> PlaceRequest pr = getDefaultPlace();
> if (pr == null) {
> //Window.Location.replace("/test.html"); //$NON-NLS-1$ 
> } else {
> revealPlace(pr); 
> }
> } or in
> LoginModel.java\BaseApplicationInit.java etc. It can achieve to redirect by
> chrome,IE and firefox in Linux, and would execute LogoutUserCommand to
> clean user session,Then at firefox in Windows no matter which version, it
> could redirect but would not execute LogoutUserCommand, so I can log into
> System by previous URL without password.  How can I redirect URL when
> logout?Is there any config files for this? I could not find it, thanks a
> lot :) Version-Release number of selected component (if applicable): 3.4.5
> Steps to Reproduce: 1.update code:ApplicationPlaceManager.java  public void
> revealDefaultPlace() { PlaceRequest pr = getDefaultPlace();
> if (pr == null) { //Window.Location.replace("/test.html");
> //$NON-NLS-1$ } else { revealPlace(pr); } }
> 2.login system and logout 3.input previous url like
> :xx/ovirt-engine/webadmin/?locale=zh_CN#vms and can redirect. Actual
> results: redirect into vm page. Expected results: redirect into login page.

Hi,

I am trying to decipher your message (it got garbled for some reason). And I 
am trying to understand what you are trying to do. If I understand correctly 
you want to redirect to some other page after you have logged out of the web 
admin.

To get back to the specifics of your question. The DefaultPlace is the #XXX in 
the URL you are sent to (note its not an actual redirect, since there is no 
round trip to the server), if you don't specify a particular place. When you 
do #vms the whole DefaultPlace mechanism is not in play since you specified a 
particular place.

What does happen is that the framework asks the LoggedInGatekeeper if the user 
is logged in (in the canReveal() method). If the user is logged in, it will 
proceed to the normal place requested (in your example #vms). If the user is 
not logged in, it will switch places to #login and display the login screen.

Now you say you are using 3.4.5 which is quite old, and its been some time 
since I worked with it. If I understand correctly what you are trying to do, 
don't mess around with the DefaultPlace. In BaseApplicationInit there should 
be a 'onLogout' method. In there should be a callback that happens AFTER the 
user is logged out from the server. Right now it says something 
Window.Location.reload() to reload the page after the logout. You should be 
able to put your Window.Location.replace in there (replace the reload with the 
replace). Which I think will do what you want.

If it doesn't do what you want, I am going to need some more information on 
what it is that you are trying to do.

Alexander
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[David Caro]

On 11/12, Francesco Romani wrote:
> - Original Message -
> > From: "Nir Soffer" 
> > To: "devel" 
> > Cc: "Dan Kenigsberg" , "Francesco Romani" 
> > , "Piotr Kliczewski"
> > , "Adam Litke" , "Allon Mureinik" 
> > 
> > Sent: Thursday, November 12, 2015 3:45:13 PM
> > Subject: Reported-By - giving credit to our testers
> > 
> > Hi all,
> > 
> > Our QE (and sometimes our users) are working hard testing and
> > reporting bugs, but
> > their effort is never mentioned in our code.
> > 
> > Looking at kernel git history, I found that they are using the
> > Reported-By header for
> > giving credit to the person reporting a bug. I suggest we adapt this header.
> 
> Strongly agreed, let's do this!

+1

> 
> Bests,
> 
> -- 
> Francesco Romani
> RedHat Engineering Virtualization R & D
> Phone: 8261328
> IRC: fromani
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel

-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R

Tel.: +420 532 294 605
Email: dc...@redhat.com
Web: www.redhat.com
RHT Global #: 82-62605


signature.asc
Description: PGP signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

[Dan Kenigsberg]

On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
> Hey,
> 
> what is the expectation/assumption about firewalld on a CentOS 7 host
> where you want to install vdsm onto?
> 
> Is vdsm taking care of it?
> 
> I'm asking this, because firewalld seems to be in the default package
> (please correct me if I am wrong) set of CentOS 7 and thus installed
> by default.

As far as I know, Vdsm runs fine in parallel to firewalld on recent
el7.1 (there used to be problems in early 7.0 versions).

If this is not the case, please file a bug with precise versions!
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

[Dan Kenigsberg]

On Thu, Nov 12, 2015 at 02:42:32PM +0100, Fabian Deutsch wrote:
> On Thu, Nov 12, 2015 at 2:36 PM, Dan Kenigsberg  wrote:
> > On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
> >> Hey,
> >>
> >> what is the expectation/assumption about firewalld on a CentOS 7 host
> >> where you want to install vdsm onto?
> >>
> >> Is vdsm taking care of it?
> >>
> >> I'm asking this, because firewalld seems to be in the default package
> >> (please correct me if I am wrong) set of CentOS 7 and thus installed
> >> by default.
> >
> > As far as I know, Vdsm runs fine in parallel to firewalld on recent
> > el7.1 (there used to be problems in early 7.0 versions).
> >
> > If this is not the case, please file a bug with precise versions!
> 
> Bug 1281417 - vdsm host can not be added with firewalld enabled

Would everything work all right if Vdsm's port (54321) is opened in
firewalld?

It seems that the host CAN be added, but remains in non-responsive mode
due to the firewall being shut. right?

Regards,
Dan.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

[Fabian Deutsch]

On Thu, Nov 12, 2015 at 2:57 PM, Dan Kenigsberg  wrote:
> On Thu, Nov 12, 2015 at 02:42:32PM +0100, Fabian Deutsch wrote:
>> On Thu, Nov 12, 2015 at 2:36 PM, Dan Kenigsberg  wrote:
>> > On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
>> >> Hey,
>> >>
>> >> what is the expectation/assumption about firewalld on a CentOS 7 host
>> >> where you want to install vdsm onto?
>> >>
>> >> Is vdsm taking care of it?
>> >>
>> >> I'm asking this, because firewalld seems to be in the default package
>> >> (please correct me if I am wrong) set of CentOS 7 and thus installed
>> >> by default.
>> >
>> > As far as I know, Vdsm runs fine in parallel to firewalld on recent
>> > el7.1 (there used to be problems in early 7.0 versions).
>> >
>> > If this is not the case, please file a bug with precise versions!
>>
>> Bug 1281417 - vdsm host can not be added with firewalld enabled
>
> Would everything work all right if Vdsm's port (54321) is opened in
> firewalld?

I did not try this yet - but I strongly assume yes.

> It seems that the host CAN be added, but remains in non-responsive mode
> due to the firewall being shut. right?

Correct, vdsm is up and all. It just seems to be the firewall.

Looking at the two bugs:
Bug 995362 - (ovirt_firewalld_support) [RFE] Support firewalld
Bug 1281417 - vdsm host can not be added with firewalld enabled

I wonder where the firewalld service configuration should happen,
currently in host-deploy, but I don#t really see why theer and not in
vdsm.

- fabian
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Reported-By - giving credit to our testers

[Nir Soffer]

Hi all,

Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.

Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.

Here are some examples how we can use it:

- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
- https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
- https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598

Thanks,
Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Piotr Kliczewski]

On Thu, Nov 12, 2015 at 3:49 PM, David Caro  wrote:

> On 11/12, Francesco Romani wrote:
> > - Original Message -
> > > From: "Nir Soffer" 
> > > To: "devel" 
> > > Cc: "Dan Kenigsberg" , "Francesco Romani" <
> from...@redhat.com>, "Piotr Kliczewski"
> > > , "Adam Litke" , "Allon
> Mureinik" 
> > > Sent: Thursday, November 12, 2015 3:45:13 PM
> > > Subject: Reported-By - giving credit to our testers
> > >
> > > Hi all,
> > >
> > > Our QE (and sometimes our users) are working hard testing and
> > > reporting bugs, but
> > > their effort is never mentioned in our code.
> > >
> > > Looking at kernel git history, I found that they are using the
> > > Reported-By header for
> > > giving credit to the person reporting a bug. I suggest we adapt this
> header.
> >
> > Strongly agreed, let's do this!
>
> +1
>
>
+1


> >
> > Bests,
> >
> > --
> > Francesco Romani
> > RedHat Engineering Virtualization R & D
> > Phone: 8261328
> > IRC: fromani
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R
>
> Tel.: +420 532 294 605
> Email: dc...@redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Alon Bar-Lev]

- Original Message -
> From: "Yaniv Kaul" 
> To: "Nir Soffer" 
> Cc: "Piotr Kliczewski" , "devel" 
> Sent: Thursday, November 12, 2015 4:55:10 PM
> Subject: Re: [ovirt-devel] Reported-By - giving credit to our testers
> 
> On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer < nsof...@redhat.com > wrote:
> 
> 
> Hi all,
> 
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
> 
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this header.
> 
> Here are some examples how we can use it:
> 
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598
> 
> Thanks,
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
> +1
> 
> In case they help with the verification of the change, I suggest adding
> Tested-By which is just as important.
> From https://www.kernel.org/doc/Documentation/SubmittingPatches :
> 
> A Tested-by: tag indicates that the patch has been successfully tested (in
> some environment) by the person named.  This tag informs maintainers that
> some testing has been performed, provides a means to locate testers for
> future patches, and ensures credit for the testers.

This meant to give credit for whoever is doing that in his own time, not for 
cooperation that pays for QA nor replace bugzilla.
If you go over the logs, you will see I provide Reported-By and Tested-By two 
who produce significant effort in helping out a case.

> 
> Y.
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Yaniv Kaul]

On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer  wrote:

> Hi all,
>
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
>
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this
> header.
>
> Here are some examples how we can use it:
>
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598
>
> Thanks,
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>

+1

In case they help with the verification of the change, I suggest adding
Tested-By which is just as important.
>From https://www.kernel.org/doc/Documentation/SubmittingPatches :

A Tested-by: tag indicates that the patch has been successfully tested (in
some environment) by the person named.  This tag informs maintainers that
some testing has been performed, provides a means to locate testers for
future patches, and ensures credit for the testers.


Y.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

[Sandro Bonazzola]

On Thu, Nov 12, 2015 at 3:06 PM, Fabian Deutsch  wrote:

> On Thu, Nov 12, 2015 at 2:57 PM, Dan Kenigsberg  wrote:
> > On Thu, Nov 12, 2015 at 02:42:32PM +0100, Fabian Deutsch wrote:
> >> On Thu, Nov 12, 2015 at 2:36 PM, Dan Kenigsberg 
> wrote:
> >> > On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
> >> >> Hey,
> >> >>
> >> >> what is the expectation/assumption about firewalld on a CentOS 7 host
> >> >> where you want to install vdsm onto?
> >> >>
> >> >> Is vdsm taking care of it?
> >> >>
> >> >> I'm asking this, because firewalld seems to be in the default package
> >> >> (please correct me if I am wrong) set of CentOS 7 and thus installed
> >> >> by default.
> >> >
> >> > As far as I know, Vdsm runs fine in parallel to firewalld on recent
> >> > el7.1 (there used to be problems in early 7.0 versions).
> >> >
> >> > If this is not the case, please file a bug with precise versions!
> >>
> >> Bug 1281417 - vdsm host can not be added with firewalld enabled
> >
> > Would everything work all right if Vdsm's port (54321) is opened in
> > firewalld?
>
> I did not try this yet - but I strongly assume yes.
>
> > It seems that the host CAN be added, but remains in non-responsive mode
> > due to the firewall being shut. right?
>
> Correct, vdsm is up and all. It just seems to be the firewall.
>
> Looking at the two bugs:
> Bug 995362 - (ovirt_firewalld_support) [RFE] Support firewalld
> Bug 1281417 - vdsm host can not be added with firewalld enabled
>
> I wonder where the firewalld service configuration should happen,
> currently in host-deploy, but I don#t really see why theer and not in
> vdsm.
>

firewalld can't be configured right now by host-deploy being the firewall
config sotred in the engine database for iptables only.
We need to add firewalld support in ovirt-engine and in ovirt-host-deploy
to properly support it.




>
> - fabian
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

[Fabian Deutsch]

On Thu, Nov 12, 2015 at 4:27 PM, Sandro Bonazzola  wrote:
>
>
> On Thu, Nov 12, 2015 at 3:06 PM, Fabian Deutsch  wrote:
>>
>> On Thu, Nov 12, 2015 at 2:57 PM, Dan Kenigsberg  wrote:
>> > On Thu, Nov 12, 2015 at 02:42:32PM +0100, Fabian Deutsch wrote:
>> >> On Thu, Nov 12, 2015 at 2:36 PM, Dan Kenigsberg 
>> >> wrote:
>> >> > On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
>> >> >> Hey,
>> >> >>
>> >> >> what is the expectation/assumption about firewalld on a CentOS 7
>> >> >> host
>> >> >> where you want to install vdsm onto?
>> >> >>
>> >> >> Is vdsm taking care of it?
>> >> >>
>> >> >> I'm asking this, because firewalld seems to be in the default
>> >> >> package
>> >> >> (please correct me if I am wrong) set of CentOS 7 and thus installed
>> >> >> by default.
>> >> >
>> >> > As far as I know, Vdsm runs fine in parallel to firewalld on recent
>> >> > el7.1 (there used to be problems in early 7.0 versions).
>> >> >
>> >> > If this is not the case, please file a bug with precise versions!
>> >>
>> >> Bug 1281417 - vdsm host can not be added with firewalld enabled
>> >
>> > Would everything work all right if Vdsm's port (54321) is opened in
>> > firewalld?
>>
>> I did not try this yet - but I strongly assume yes.
>>
>> > It seems that the host CAN be added, but remains in non-responsive mode
>> > due to the firewall being shut. right?
>>
>> Correct, vdsm is up and all. It just seems to be the firewall.
>>
>> Looking at the two bugs:
>> Bug 995362 - (ovirt_firewalld_support) [RFE] Support firewalld
>> Bug 1281417 - vdsm host can not be added with firewalld enabled
>>
>> I wonder where the firewalld service configuration should happen,
>> currently in host-deploy, but I don#t really see why theer and not in
>> vdsm.
>
>
> firewalld can't be configured right now by host-deploy being the firewall
> config sotred in the engine database for iptables only.
> We need to add firewalld support in ovirt-engine and in ovirt-host-deploy to
> properly support it.

Thanks, that gives me the bigger picture.

- fabian
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Eli Mesika]

+1

- Original Message -
> From: "Nir Soffer" 
> To: "devel" 
> Cc: "Piotr Kliczewski" 
> Sent: Thursday, November 12, 2015 4:45:13 PM
> Subject: [ovirt-devel] Reported-By - giving credit to our testers
> 
> Hi all,
> 
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
> 
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this header.
> 
> Here are some examples how we can use it:
> 
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598
> 
> Thanks,
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel