Re: [PATCH] Generate coverage analysis Report

[Cillian O'Donnell]

On Wed, 6 Jun 2018, 05:07 Vijay Kumar Banerjee, 
wrote:

> On Wed, 6 Jun 2018, 08:31 Joel Sherrill,  wrote:
>
>>
>>
>> On Tue, Jun 5, 2018, 9:54 PM Chris Johns  wrote:
>>
>>>
>>> On 31/5/18 6:44 am, Vijay Kumar Banerjee wrote:
>>> > On 31 May 2018 at 02:02, Joel Sherrill >> j...@rtems.org>>
>>> > wrote:
>>> > On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee
>>> > mailto:vijaykumar9...@gmail.com>>
>>> wrote:
>>> >
>>> > On 31 May 2018 at 00:28, Joel Sherrill >> > > wrote:
>>> > I may not understand correctly but there is test_run and
>>> > coverage_run. Someone
>>> > suggested making coverage_running an option to test_run.
>>> If that's
>>> > what's being
>>> > asked for, then I think doing it in a follow up patch is
>>> OK.
>>> >
>>> > If that's the intended request, perhaps a ticket should be
>>> filed.
>>> >
>>> >
>>> > Sorry for all the confusion.
>>> > This patch doesn't change the way test works. It only adds an
>>> option to run
>>> > the coverage script. coverage_run just runs the
>>> coverage.coverage_run
>>> >
>>> >
>>> > :) And I am saying if we want to have one test_run with an
>>> argument, do it as
>>> > a future work iteration. File a ticket.
>>> >
>>> > We need to get the code working on the master.
>>> >
>>> > Okay, we can keep that as a future work (I haven't thought about it
>>> though). :)
>>> > Getting it to work on master is our primary objective.
>>> >
>>>
>>> Was a ticket raised to removing 'coverage_run' and to use 'test_run'?
>>>
>>
>> I haven't seen tickets for any of the issues we identified.
>>
> was there supposed to be tickets for each issue?
>

So trawl back over the emails and make a ticket for anything that hasn't
been done, any suggestions for improvements related to the project. Include
things that might not be for gsoc but related to the project. They can
assigned to people and the priority determined after you've collected them
all.

>
>>> Chris
>>>
>> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Generate coverage analysis Report

[Joel Sherrill]

On Tue, Jun 5, 2018, 11:07 PM Vijay Kumar Banerjee 
wrote:

> On Wed, 6 Jun 2018, 08:31 Joel Sherrill,  wrote:
>
>>
>>
>> On Tue, Jun 5, 2018, 9:54 PM Chris Johns  wrote:
>>
>>>
>>> On 31/5/18 6:44 am, Vijay Kumar Banerjee wrote:
>>> > On 31 May 2018 at 02:02, Joel Sherrill >> j...@rtems.org>>
>>> > wrote:
>>> > On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee
>>> > mailto:vijaykumar9...@gmail.com>>
>>> wrote:
>>> >
>>> > On 31 May 2018 at 00:28, Joel Sherrill >> > > wrote:
>>> > I may not understand correctly but there is test_run and
>>> > coverage_run. Someone
>>> > suggested making coverage_running an option to test_run.
>>> If that's
>>> > what's being
>>> > asked for, then I think doing it in a follow up patch is
>>> OK.
>>> >
>>> > If that's the intended request, perhaps a ticket should be
>>> filed.
>>> >
>>> >
>>> > Sorry for all the confusion.
>>> > This patch doesn't change the way test works. It only adds an
>>> option to run
>>> > the coverage script. coverage_run just runs the
>>> coverage.coverage_run
>>> >
>>> >
>>> > :) And I am saying if we want to have one test_run with an
>>> argument, do it as
>>> > a future work iteration. File a ticket.
>>> >
>>> > We need to get the code working on the master.
>>> >
>>> > Okay, we can keep that as a future work (I haven't thought about it
>>> though). :)
>>> > Getting it to work on master is our primary objective.
>>> >
>>>
>>> Was a ticket raised to removing 'coverage_run' and to use 'test_run'?
>>>
>>
>> I haven't seen tickets for any of the issues we identified.
>>
> was there supposed to be tickets for each issue?
>

Yes. If they still apply.


>>> Chris
>>>
>>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Generate coverage analysis Report

[Vijay Kumar Banerjee]

On Wed, 6 Jun 2018, 08:31 Joel Sherrill,  wrote:

>
>
> On Tue, Jun 5, 2018, 9:54 PM Chris Johns  wrote:
>
>>
>> On 31/5/18 6:44 am, Vijay Kumar Banerjee wrote:
>> > On 31 May 2018 at 02:02, Joel Sherrill > j...@rtems.org>>
>> > wrote:
>> > On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee
>> > mailto:vijaykumar9...@gmail.com>> wrote:
>> >
>> > On 31 May 2018 at 00:28, Joel Sherrill > > > wrote:
>> > I may not understand correctly but there is test_run and
>> > coverage_run. Someone
>> > suggested making coverage_running an option to test_run. If
>> that's
>> > what's being
>> > asked for, then I think doing it in a follow up patch is OK.
>> >
>> > If that's the intended request, perhaps a ticket should be
>> filed.
>> >
>> >
>> > Sorry for all the confusion.
>> > This patch doesn't change the way test works. It only adds an
>> option to run
>> > the coverage script. coverage_run just runs the
>> coverage.coverage_run
>> >
>> >
>> > :) And I am saying if we want to have one test_run with an
>> argument, do it as
>> > a future work iteration. File a ticket.
>> >
>> > We need to get the code working on the master.
>> >
>> > Okay, we can keep that as a future work (I haven't thought about it
>> though). :)
>> > Getting it to work on master is our primary objective.
>> >
>>
>> Was a ticket raised to removing 'coverage_run' and to use 'test_run'?
>>
>
> I haven't seen tickets for any of the issues we identified.
>
was there supposed to be tickets for each issue?

>
>> Chris
>>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Generate coverage analysis Report

[Joel Sherrill]

On Tue, Jun 5, 2018, 9:54 PM Chris Johns  wrote:

>
> On 31/5/18 6:44 am, Vijay Kumar Banerjee wrote:
> > On 31 May 2018 at 02:02, Joel Sherrill  j...@rtems.org>>
> > wrote:
> > On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee
> > mailto:vijaykumar9...@gmail.com>> wrote:
> >
> > On 31 May 2018 at 00:28, Joel Sherrill  > > wrote:
> > I may not understand correctly but there is test_run and
> > coverage_run. Someone
> > suggested making coverage_running an option to test_run. If
> that's
> > what's being
> > asked for, then I think doing it in a follow up patch is OK.
> >
> > If that's the intended request, perhaps a ticket should be
> filed.
> >
> >
> > Sorry for all the confusion.
> > This patch doesn't change the way test works. It only adds an
> option to run
> > the coverage script. coverage_run just runs the
> coverage.coverage_run
> >
> >
> > :) And I am saying if we want to have one test_run with an argument,
> do it as
> > a future work iteration. File a ticket.
> >
> > We need to get the code working on the master.
> >
> > Okay, we can keep that as a future work (I haven't thought about it
> though). :)
> > Getting it to work on master is our primary objective.
> >
>
> Was a ticket raised to removing 'coverage_run' and to use 'test_run'?
>

I haven't seen tickets for any of the issues we identified.

>
> Chris
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Generate coverage analysis Report

[Chris Johns]

On 31/5/18 6:44 am, Vijay Kumar Banerjee wrote:
> On 31 May 2018 at 02:02, Joel Sherrill  >
> wrote:
> On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee
> mailto:vijaykumar9...@gmail.com>> wrote:
> 
> On 31 May 2018 at 00:28, Joel Sherrill  > wrote:
> I may not understand correctly but there is test_run and
> coverage_run. Someone
> suggested making coverage_running an option to test_run. If that's
> what's being
> asked for, then I think doing it in a follow up patch is OK.
> 
> If that's the intended request, perhaps a ticket should be filed.
>  
> 
> Sorry for all the confusion.
> This patch doesn't change the way test works. It only adds an option 
> to run 
> the coverage script. coverage_run just runs the coverage.coverage_run
> 
> 
> :) And I am saying if we want to have one test_run with an argument, do 
> it as
> a future work iteration. File a ticket. 
> 
> We need to get the code working on the master.
> 
> Okay, we can keep that as a future work (I haven't thought about it though). 
> :)
> Getting it to work on master is our primary objective. 
> 

Was a ticket raised to removing 'coverage_run' and to use 'test_run'?

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Generate coverage analysis Report

[Vijay Kumar Banerjee]

On 31 May 2018 at 02:02, Joel Sherrill  wrote:

>
>
> On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee <
> vijaykumar9...@gmail.com> wrote:
>
>> On 31 May 2018 at 00:28, Joel Sherrill  wrote:
>>
>>>
>>>
>>> I may not understand correctly but there is test_run and coverage_run.
>>> Someone
>>> suggested making coverage_running an option to test_run. If that's
>>> what's being
>>> asked for, then I think doing it in a follow up patch is OK.
>>>
>>> If that's the intended request, perhaps a ticket should be filed.
>>>
>>>
>> Sorry for all the confusion.
>> This patch doesn't change the way test works. It only adds an option to
>> run
>> the coverage script. coverage_run just runs the coverage.coverage_run
>>
>
> :) And I am saying if we want to have one test_run with an argument, do it
> as
> a future work iteration. File a ticket.
>
> We need to get the code working on the master.
>
> Okay, we can keep that as a future work (I haven't thought about it
though). :)
Getting it to work on master is our primary objective.


>
>> >
>>> >  except error.general as gerr:
>>> >  print(gerr)
>>> > diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> > index 6b5e7e6..2f89117 100644
>>> > --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> > +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> > @@ -31,9 +31,10 @@
>>> >  #
>>> >  # The Leon 3 QEMU BSP
>>> >  #
>>> > -[leon3-qemu]
>>> > +[leon3-qemu-cov]
>>> >  bsp   = leon3-qemu
>>> >  arch  = sparc
>>> > +target= sparc-rtems5
>>> >  tester= %{_rtscripts}/qemu.cfg
>>> >  bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic
>>> >  bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov
>>> > diff --git a/tester/rtems/testing/coverage/symbol-sets.ini
>>> b/tester/rtems/testing/coverage/symbol-sets.ini
>>> > new file mode 100644
>>> > index 000..a2ec7bc
>>> > --- /dev/null
>>> > +++ b/tester/rtems/testing/coverage/symbol-sets.ini
>>> > @@ -0,0 +1,36 @@
>>> > +#
>>> > +# RTEMS Tools Project (http://www.rtems.org/)
>>> > +# Copyright 2018 Chris Johns (chr...@rtems.org)
>>> > +# All rights reserved.
>>> > +#
>>> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
>>> > +#
>>> > +# Redistribution and use in source and binary forms, with or
>>> without
>>> > +# modification, are permitted provided that the following
>>> conditions are met:
>>> > +#
>>> > +# 1. Redistributions of source code must retain the above
>>> copyright notice,
>>> > +# this list of conditions and the following disclaimer.
>>> > +#
>>> > +# 2. Redistributions in binary form must reproduce the above
>>> copyright notice,
>>> > +# this list of conditions and the following disclaimer in the
>>> documentation
>>> > +# and/or other materials provided with the distribution.
>>> > +#
>>> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
>>> CONTRIBUTORS "AS IS"
>>> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
>>> LIMITED TO, THE
>>> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
>>> PARTICULAR PURPOSE
>>> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
>>> CONTRIBUTORS BE
>>> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>>> EXEMPLARY, OR
>>> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>>> PROCUREMENT OF
>>> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>>> BUSINESS
>>> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
>>> WHETHER IN
>>> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
>>> OTHERWISE)
>>> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
>>> ADVISED OF THE
>>> > +# POSSIBILITY OF SUCH DAMAGE.
>>> > +#
>>> > +
>>> > +[symbol-sets]
>>> > +sets = score,rtems
>>> > +
>>> > +[libraries]
>>> > +score = @BUILD-TARGET@/c/@BSP@/cpukit/score/libscore.a
>>> > +rtems = @BUILD-TARGET@/c/@BSP@/cpukit/rtems/librtems.a
>>> > diff --git a/tester/rtems/testing/qemu.cfg b/tester/rtems/testing/
>>> qemu.cfg
>>> > index bfcd2f5..52a3752 100644
>>> > --- a/tester/rtems/testing/qemu.cfg
>>> > +++ b/tester/rtems/testing/qemu.cfg
>>> > @@ -51,8 +51,8 @@
>>> >  #
>>> >  # Qemu common option patterns.
>>> >  #
>>> > -#%define qemu_opts_base   -no-reboot -monitor none -serial stdio
>>> -nographic
>>> > -%define qemu_opts_base   -no-reboot -serial null -serial
>>> mon:stdio -nographic
>>> > +%define qemu_opts_base   -no-reboot -monitor none -serial stdio
>>> -nographic
>>> > +#%define qemu_opts_base   -no-reboot -serial null -serial
>>> mon:stdio -nographi

Re: [PATCH] Generate coverage analysis Report

[Joel Sherrill]

On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee <
vijaykumar9...@gmail.com> wrote:

> On 31 May 2018 at 00:28, Joel Sherrill  wrote:
>
>>
>>
>> I may not understand correctly but there is test_run and coverage_run.
>> Someone
>> suggested making coverage_running an option to test_run. If that's what's
>> being
>> asked for, then I think doing it in a follow up patch is OK.
>>
>> If that's the intended request, perhaps a ticket should be filed.
>>
>>
> Sorry for all the confusion.
> This patch doesn't change the way test works. It only adds an option to
> run
> the coverage script. coverage_run just runs the coverage.coverage_run
>

:) And I am saying if we want to have one test_run with an argument, do it
as
a future work iteration. File a ticket.

We need to get the code working on the master.



> >
>> >  except error.general as gerr:
>> >  print(gerr)
>> > diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> > index 6b5e7e6..2f89117 100644
>> > --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> > +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> > @@ -31,9 +31,10 @@
>> >  #
>> >  # The Leon 3 QEMU BSP
>> >  #
>> > -[leon3-qemu]
>> > +[leon3-qemu-cov]
>> >  bsp   = leon3-qemu
>> >  arch  = sparc
>> > +target= sparc-rtems5
>> >  tester= %{_rtscripts}/qemu.cfg
>> >  bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic
>> >  bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov
>> > diff --git a/tester/rtems/testing/coverage/symbol-sets.ini
>> b/tester/rtems/testing/coverage/symbol-sets.ini
>> > new file mode 100644
>> > index 000..a2ec7bc
>> > --- /dev/null
>> > +++ b/tester/rtems/testing/coverage/symbol-sets.ini
>> > @@ -0,0 +1,36 @@
>> > +#
>> > +# RTEMS Tools Project (http://www.rtems.org/)
>> > +# Copyright 2018 Chris Johns (chr...@rtems.org)
>> > +# All rights reserved.
>> > +#
>> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
>> > +#
>> > +# Redistribution and use in source and binary forms, with or
>> without
>> > +# modification, are permitted provided that the following
>> conditions are met:
>> > +#
>> > +# 1. Redistributions of source code must retain the above
>> copyright notice,
>> > +# this list of conditions and the following disclaimer.
>> > +#
>> > +# 2. Redistributions in binary form must reproduce the above
>> copyright notice,
>> > +# this list of conditions and the following disclaimer in the
>> documentation
>> > +# and/or other materials provided with the distribution.
>> > +#
>> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
>> CONTRIBUTORS "AS IS"
>> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
>> LIMITED TO, THE
>> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
>> PARTICULAR PURPOSE
>> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
>> CONTRIBUTORS BE
>> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
>> OR
>> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>> PROCUREMENT OF
>> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>> BUSINESS
>> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
>> WHETHER IN
>> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
>> OTHERWISE)
>> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
>> ADVISED OF THE
>> > +# POSSIBILITY OF SUCH DAMAGE.
>> > +#
>> > +
>> > +[symbol-sets]
>> > +sets = score,rtems
>> > +
>> > +[libraries]
>> > +score = @BUILD-TARGET@/c/@BSP@/cpukit/score/libscore.a
>> > +rtems = @BUILD-TARGET@/c/@BSP@/cpukit/rtems/librtems.a
>> > diff --git a/tester/rtems/testing/qemu.cfg b/tester/rtems/testing/
>> qemu.cfg
>> > index bfcd2f5..52a3752 100644
>> > --- a/tester/rtems/testing/qemu.cfg
>> > +++ b/tester/rtems/testing/qemu.cfg
>> > @@ -51,8 +51,8 @@
>> >  #
>> >  # Qemu common option patterns.
>> >  #
>> > -#%define qemu_opts_base   -no-reboot -monitor none -serial stdio
>> -nographic
>> > -%define qemu_opts_base   -no-reboot -serial null -serial mon:stdio
>> -nographic
>> > +%define qemu_opts_base   -no-reboot -monitor none -serial stdio
>> -nographic
>> > +#%define qemu_opts_base   -no-reboot -serial null -serial
>> mon:stdio -nographic
>>
>> Why changing the common options for qemu?
>>
>> actually it's a bit experimental on advice of Cillian.
> It stayed in the patch.
>

 I know the impact of some of those options but maybe it would make sense
 to add a comment block with the impact of each option? It would help

Re: [PATCH] Generate coverage analysis Report

[Vijay Kumar Banerjee]

On 31 May 2018 at 00:28, Joel Sherrill  wrote:

>
>
> I may not understand correctly but there is test_run and coverage_run.
> Someone
> suggested making coverage_running an option to test_run. If that's what's
> being
> asked for, then I think doing it in a follow up patch is OK.
>
> If that's the intended request, perhaps a ticket should be filed.
>
>
Sorry for all the confusion.
This patch doesn't change the way test works. It only adds an option to run
the coverage script. coverage_run just runs the coverage.coverage_run

> >
> >  except error.general as gerr:
> >  print(gerr)
> > diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> > index 6b5e7e6..2f89117 100644
> > --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> > +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> > @@ -31,9 +31,10 @@
> >  #
> >  # The Leon 3 QEMU BSP
> >  #
> > -[leon3-qemu]
> > +[leon3-qemu-cov]
> >  bsp   = leon3-qemu
> >  arch  = sparc
> > +target= sparc-rtems5
> >  tester= %{_rtscripts}/qemu.cfg
> >  bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic
> >  bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov
> > diff --git a/tester/rtems/testing/coverage/symbol-sets.ini
> b/tester/rtems/testing/coverage/symbol-sets.ini
> > new file mode 100644
> > index 000..a2ec7bc
> > --- /dev/null
> > +++ b/tester/rtems/testing/coverage/symbol-sets.ini
> > @@ -0,0 +1,36 @@
> > +#
> > +# RTEMS Tools Project (http://www.rtems.org/)
> > +# Copyright 2018 Chris Johns (chr...@rtems.org)
> > +# All rights reserved.
> > +#
> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
> > +#
> > +# Redistribution and use in source and binary forms, with or without
> > +# modification, are permitted provided that the following
> conditions are met:
> > +#
> > +# 1. Redistributions of source code must retain the above copyright
> notice,
> > +# this list of conditions and the following disclaimer.
> > +#
> > +# 2. Redistributions in binary form must reproduce the above
> copyright notice,
> > +# this list of conditions and the following disclaimer in the
> documentation
> > +# and/or other materials provided with the distribution.
> > +#
> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS IS"
> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
> TO, THE
> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR PURPOSE
> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
> CONTRIBUTORS BE
> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
> OR
> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
> OF
> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
> BUSINESS
> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
> WHETHER IN
> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> OTHERWISE)
> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED OF THE
> > +# POSSIBILITY OF SUCH DAMAGE.
> > +#
> > +
> > +[symbol-sets]
> > +sets = score,rtems
> > +
> > +[libraries]
> > +score = @BUILD-TARGET@/c/@BSP@/cpukit/score/libscore.a
> > +rtems = @BUILD-TARGET@/c/@BSP@/cpukit/rtems/librtems.a
> > diff --git a/tester/rtems/testing/qemu.cfg b/tester/rtems/testing/
> qemu.cfg
> > index bfcd2f5..52a3752 100644
> > --- a/tester/rtems/testing/qemu.cfg
> > +++ b/tester/rtems/testing/qemu.cfg
> > @@ -51,8 +51,8 @@
> >  #
> >  # Qemu common option patterns.
> >  #
> > -#%define qemu_opts_base   -no-reboot -monitor none -serial stdio
> -nographic
> > -%define qemu_opts_base   -no-reboot -serial null -serial mon:stdio
> -nographic
> > +%define qemu_opts_base   -no-reboot -monitor none -serial stdio
> -nographic
> > +#%define qemu_opts_base   -no-reboot -serial null -serial mon:stdio
> -nographic
>
> Why changing the common options for qemu?
>
> actually it's a bit experimental on advice of Cillian.
 It stayed in the patch.

>>>
>>> I know the impact of some of those options but maybe it would make sense
>>> to add a comment block with the impact of each option? It would help
>>> future
>>> readers.
>>>
>>> And, from personal experience, qemu changes arguments from time to time.
>>> Knowing
>>> what the old intent was helps mapping to different versions and target
>>> architectures.
>>>
>>> That's a good Idea.
>>
>>>
>>>
>>>
 >  %define qemu_opts_no_net -net none
> >
> >  #
> > --
> > 2.14.3
> >
> > __

Re: [PATCH] Generate coverage analysis Report

[Joel Sherrill]

On Wed, May 30, 2018 at 1:34 PM, Vijay Kumar Banerjee <
vijaykumar9...@gmail.com> wrote:

> On 30 May 2018 at 23:29, Joel Sherrill  wrote:
>
>>
>>
>> On Wed, May 30, 2018 at 12:54 PM, Vijay Kumar Banerjee <
>> vijaykumar9...@gmail.com> wrote:
>>
>>> On 30 May 2018 at 22:51, Gedare Bloom  wrote:
>>>
 Please provide your name in your commits (git config --user.name "My
 Name") that you submit.

 OK Noted :)
>>>
 The first line of this commit, and therefore the email subject, is
 overly vague. Provide a slightly more specific description.

>>> On Wed, May 30, 2018 at 1:00 PM, thelunatic 
 wrote:
 > + Add script to run covoar and generate an html report from
 > the output generated from covoar
 > + Add symbol-sets ini file for library addresses of the symbol-sets
 > + tester/rt/test : Add options for running coverage
 >

>>>
 I'd rather see a narrative paragraph than this list of + bullet items.
 Are all of these changes required to run the report? Should they be
 broken into smaller commits that are logically related but separately
 reviewable and commited?

 OK, I will write in a descriptive paragraph.
>>> These changes are all needed to run coverage.
>>>
 > Co-author : Cillian O'Donnel 
 I don't know what Co-Author should mean. I would prefer to receive
 separate commits/patches for contributions made by different people if
 that is possible.

 Plese refer below...
>>>
 > ---
 >  tester/rt/coverage.py | 380
 ++
 >  tester/rt/test.py |  36 ++-
 >  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
 >  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
 >  tester/rtems/testing/qemu.cfg |   4 +-
 >  5 files changed, 447 insertions(+), 12 deletions(-)
 >  create mode 100644 tester/rt/coverage.py
 >  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
 >
 > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
 > new file mode 100644
 > index 000..38dcce6
 > --- /dev/null
 > +++ b/tester/rt/coverage.py
 > @@ -0,0 +1,380 @@
 > +#
 > +# RTEMS Tools Project (http://www.rtems.org/)
 > +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)

 Is this Krzysztof's code? if so, it should be added as a commit with
 him as the --author="" field of git-commit option.

 Actually this script has undergone a lot of updates.
>>> It doesn't even work the same way it used to. I am uncertain
>>> about the portions of the code that are written by him and still in
>>> the script. Basically I left the copyright notice untouched and
>>> let it be there because I am unsure of what to include there.
>>> Same is true in case of Cillian. I don't really know how much
>>> of Code is authored by him.
>>> It surely isn't the proper way to add him as the co-author in
>>> the log but that seemed like the only way to include him.
>>>
>>
>> OK. I was afraid of it being technically impossible to separate out the
>> work
>> for revision control purposes.
>>
>> Just make sure credit due is given.
>>
>>
>>>
>>>
 > +# All rights reserved.
 > +#
 > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
 > +#
 > +# Redistribution and use in source and binary forms, with or without
 > +# modification, are permitted provided that the following conditions
 are met:
 > +#
 > +# 1. Redistributions of source code must retain the above copyright
 notice,
 > +# this list of conditions and the following disclaimer.
 > +#
 > +# 2. Redistributions in binary form must reproduce the above
 copyright notice,
 > +# this list of conditions and the following disclaimer in the
 documentation
 > +# and/or other materials provided with the distribution.
 > +#
 > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
 CONTRIBUTORS 'AS IS'
 > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
 TO, THE
 > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 PURPOSE
 > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
 CONTRIBUTORS BE
 > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
 OF
 > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
 BUSINESS
 > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
 WHETHER IN
 > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
 OTHERWISE)
 > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
 ADVISED OF THE
 > +# POSSIBILITY OF SUCH DAMAGE.
 > +#
 > +
 > +from rtemstoolkit import error
 > +from rtemstoolkit import path
 > +f

Re: [PATCH] Generate coverage analysis Report

[Vijay Kumar Banerjee]

On 30 May 2018 at 23:29, Joel Sherrill  wrote:

>
>
> On Wed, May 30, 2018 at 12:54 PM, Vijay Kumar Banerjee <
> vijaykumar9...@gmail.com> wrote:
>
>> On 30 May 2018 at 22:51, Gedare Bloom  wrote:
>>
>>> Please provide your name in your commits (git config --user.name "My
>>> Name") that you submit.
>>>
>>> OK Noted :)
>>
>>> The first line of this commit, and therefore the email subject, is
>>> overly vague. Provide a slightly more specific description.
>>>
>> On Wed, May 30, 2018 at 1:00 PM, thelunatic 
>>> wrote:
>>> > + Add script to run covoar and generate an html report from
>>> > the output generated from covoar
>>> > + Add symbol-sets ini file for library addresses of the symbol-sets
>>> > + tester/rt/test : Add options for running coverage
>>> >
>>>
>>
>>> I'd rather see a narrative paragraph than this list of + bullet items.
>>> Are all of these changes required to run the report? Should they be
>>> broken into smaller commits that are logically related but separately
>>> reviewable and commited?
>>>
>>> OK, I will write in a descriptive paragraph.
>> These changes are all needed to run coverage.
>>
>>> > Co-author : Cillian O'Donnel 
>>> I don't know what Co-Author should mean. I would prefer to receive
>>> separate commits/patches for contributions made by different people if
>>> that is possible.
>>>
>>> Plese refer below...
>>
>>> > ---
>>> >  tester/rt/coverage.py | 380
>>> ++
>>> >  tester/rt/test.py |  36 ++-
>>> >  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
>>> >  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
>>> >  tester/rtems/testing/qemu.cfg |   4 +-
>>> >  5 files changed, 447 insertions(+), 12 deletions(-)
>>> >  create mode 100644 tester/rt/coverage.py
>>> >  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
>>> >
>>> > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
>>> > new file mode 100644
>>> > index 000..38dcce6
>>> > --- /dev/null
>>> > +++ b/tester/rt/coverage.py
>>> > @@ -0,0 +1,380 @@
>>> > +#
>>> > +# RTEMS Tools Project (http://www.rtems.org/)
>>> > +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)
>>>
>>> Is this Krzysztof's code? if so, it should be added as a commit with
>>> him as the --author="" field of git-commit option.
>>>
>>> Actually this script has undergone a lot of updates.
>> It doesn't even work the same way it used to. I am uncertain
>> about the portions of the code that are written by him and still in
>> the script. Basically I left the copyright notice untouched and
>> let it be there because I am unsure of what to include there.
>> Same is true in case of Cillian. I don't really know how much
>> of Code is authored by him.
>> It surely isn't the proper way to add him as the co-author in
>> the log but that seemed like the only way to include him.
>>
>
> OK. I was afraid of it being technically impossible to separate out the
> work
> for revision control purposes.
>
> Just make sure credit due is given.
>
>
>>
>>
>>> > +# All rights reserved.
>>> > +#
>>> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
>>> > +#
>>> > +# Redistribution and use in source and binary forms, with or without
>>> > +# modification, are permitted provided that the following conditions
>>> are met:
>>> > +#
>>> > +# 1. Redistributions of source code must retain the above copyright
>>> notice,
>>> > +# this list of conditions and the following disclaimer.
>>> > +#
>>> > +# 2. Redistributions in binary form must reproduce the above
>>> copyright notice,
>>> > +# this list of conditions and the following disclaimer in the
>>> documentation
>>> > +# and/or other materials provided with the distribution.
>>> > +#
>>> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>>> 'AS IS'
>>> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>>> TO, THE
>>> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>>> PURPOSE
>>> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
>>> CONTRIBUTORS BE
>>> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>>> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>>> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>>> BUSINESS
>>> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
>>> WHETHER IN
>>> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
>>> OTHERWISE)
>>> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
>>> OF THE
>>> > +# POSSIBILITY OF SUCH DAMAGE.
>>> > +#
>>> > +
>>> > +from rtemstoolkit import error
>>> > +from rtemstoolkit import path
>>> > +from rtemstoolkit import log
>>> > +from rtemstoolkit import execute
>>> > +from rtemstoolkit import macros
>>> > +
>>> > +from datetime import datetime
>>> > +
>>> > +from . import options
>>> > +
>>> > +import shutil
>>> >

Re: [PATCH] Generate coverage analysis Report

[Vijay Kumar Banerjee]

On 30 May 2018 at 22:51, Gedare Bloom  wrote:

> > +def coverage_run(opts, coverage, executables):
> > +coverage.executables = executables
> > +coverage.run()
> > +
> >  def run(command_path = None):
> >  import sys
> >  tests = []
> > @@ -221,15 +228,16 @@ def run(command_path = None):
> >  opts = None
> >  default_exefilter = '*.exe'
> >  try:
> > -optargs = { '--rtems-tools': 'The path to the RTEMS tools',
> > -'--rtems-bsp':   'The RTEMS BSP to run the test on',
> > -'--user-config': 'Path to your local user
> configuration INI file',
> > -'--report-mode': 'Reporting modes, failures
> (default),all,none',
> > -'--list-bsps':   'List the supported BSPs',
> > -'--debug-trace': 'Debug trace based on specific
> flags',
> > -'--filter':  'Glob that executables must match
> to run (default: ' +
> > +optargs = { '--rtems-tools':'The path to the RTEMS tools',
> > +'--rtems-bsp':  'The RTEMS BSP to run the test
> on',
> > +'--user-config':'Path to your local user
> configuration INI file',
> > +'--report-mode':'Reporting modes, failures
> (default),all,none',
> > +'--list-bsps':  'List the supported BSPs',
> > +'--debug-trace':'Debug trace based on specific
> flags',
> > +'--filter': 'Glob that executables must
> match to run (default: ' +
> >default_exefilter + ')',
> > -'--stacktrace':  'Dump a stack trace on a user
> termination (^C)' }
> > +'--stacktrace': 'Dump a stack trace on a user
> termination (^C)',
> > +'--coverage':   'Perform coverage analysis of
> test exectuables.'}
> Why are there changes outside of the last two lines (stacktrace and
> coverage)? Only those two need to be modified to add the new option.
>
> Spaces were added to properly format the code.

> Typo: s/exectuables/executables
>
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Generate coverage analysis Report

[Joel Sherrill]

On Wed, May 30, 2018 at 12:54 PM, Vijay Kumar Banerjee <
vijaykumar9...@gmail.com> wrote:

> On 30 May 2018 at 22:51, Gedare Bloom  wrote:
>
>> Please provide your name in your commits (git config --user.name "My
>> Name") that you submit.
>>
>> OK Noted :)
>
>> The first line of this commit, and therefore the email subject, is
>> overly vague. Provide a slightly more specific description.
>>
> On Wed, May 30, 2018 at 1:00 PM, thelunatic 
>> wrote:
>> > + Add script to run covoar and generate an html report from
>> > the output generated from covoar
>> > + Add symbol-sets ini file for library addresses of the symbol-sets
>> > + tester/rt/test : Add options for running coverage
>> >
>>
>
>> I'd rather see a narrative paragraph than this list of + bullet items.
>> Are all of these changes required to run the report? Should they be
>> broken into smaller commits that are logically related but separately
>> reviewable and commited?
>>
>> OK, I will write in a descriptive paragraph.
> These changes are all needed to run coverage.
>
>> > Co-author : Cillian O'Donnel 
>> I don't know what Co-Author should mean. I would prefer to receive
>> separate commits/patches for contributions made by different people if
>> that is possible.
>>
>> Plese refer below...
>
>> > ---
>> >  tester/rt/coverage.py | 380
>> ++
>> >  tester/rt/test.py |  36 ++-
>> >  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
>> >  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
>> >  tester/rtems/testing/qemu.cfg |   4 +-
>> >  5 files changed, 447 insertions(+), 12 deletions(-)
>> >  create mode 100644 tester/rt/coverage.py
>> >  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
>> >
>> > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
>> > new file mode 100644
>> > index 000..38dcce6
>> > --- /dev/null
>> > +++ b/tester/rt/coverage.py
>> > @@ -0,0 +1,380 @@
>> > +#
>> > +# RTEMS Tools Project (http://www.rtems.org/)
>> > +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)
>>
>> Is this Krzysztof's code? if so, it should be added as a commit with
>> him as the --author="" field of git-commit option.
>>
>> Actually this script has undergone a lot of updates.
> It doesn't even work the same way it used to. I am uncertain
> about the portions of the code that are written by him and still in
> the script. Basically I left the copyright notice untouched and
> let it be there because I am unsure of what to include there.
> Same is true in case of Cillian. I don't really know how much
> of Code is authored by him.
> It surely isn't the proper way to add him as the co-author in
> the log but that seemed like the only way to include him.
>

OK. I was afraid of it being technically impossible to separate out the work
for revision control purposes.

Just make sure credit due is given.


>
>
>> > +# All rights reserved.
>> > +#
>> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
>> > +#
>> > +# Redistribution and use in source and binary forms, with or without
>> > +# modification, are permitted provided that the following conditions
>> are met:
>> > +#
>> > +# 1. Redistributions of source code must retain the above copyright
>> notice,
>> > +# this list of conditions and the following disclaimer.
>> > +#
>> > +# 2. Redistributions in binary form must reproduce the above copyright
>> notice,
>> > +# this list of conditions and the following disclaimer in the
>> documentation
>> > +# and/or other materials provided with the distribution.
>> > +#
>> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>> 'AS IS'
>> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>> TO, THE
>> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>> PURPOSE
>> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
>> CONTRIBUTORS BE
>> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>> BUSINESS
>> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
>> IN
>> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
>> OTHERWISE)
>> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
>> OF THE
>> > +# POSSIBILITY OF SUCH DAMAGE.
>> > +#
>> > +
>> > +from rtemstoolkit import error
>> > +from rtemstoolkit import path
>> > +from rtemstoolkit import log
>> > +from rtemstoolkit import execute
>> > +from rtemstoolkit import macros
>> > +
>> > +from datetime import datetime
>> > +
>> > +from . import options
>> > +
>> > +import shutil
>> > +import os
>> > +
>> > +try:
>> > +import configparser
>> > +except:
>> > +import ConfigParser as configparser
>> > +
>> > +class summary:
>> > +def __init__(self, p_summary_dir

Re: [PATCH] Generate coverage analysis Report

[Cillian O'Donnell]

On Wed, 30 May 2018, 18:54 Vijay Kumar Banerjee, 
wrote:

> On 30 May 2018 at 22:51, Gedare Bloom  wrote:
>
>> Please provide your name in your commits (git config --user.name "My
>> Name") that you submit.
>>
>> OK Noted :)
>
>> The first line of this commit, and therefore the email subject, is
>> overly vague. Provide a slightly more specific description.
>>
> On Wed, May 30, 2018 at 1:00 PM, thelunatic 
>> wrote:
>> > + Add script to run covoar and generate an html report from
>> > the output generated from covoar
>> > + Add symbol-sets ini file for library addresses of the symbol-sets
>> > + tester/rt/test : Add options for running coverage
>> >
>>
>
>> I'd rather see a narrative paragraph than this list of + bullet items.
>> Are all of these changes required to run the report? Should they be
>> broken into smaller commits that are logically related but separately
>> reviewable and commited?
>>
>> OK, I will write in a descriptive paragraph.
> These changes are all needed to run coverage.
>
>> > Co-author : Cillian O'Donnel 
>> I don't know what Co-Author should mean. I would prefer to receive
>> separate commits/patches for contributions made by different people if
>> that is possible.
>>
>> Plese refer below...
>
>> > ---
>> >  tester/rt/coverage.py | 380
>> ++
>> >  tester/rt/test.py |  36 ++-
>> >  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
>> >  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
>> >  tester/rtems/testing/qemu.cfg |   4 +-
>> >  5 files changed, 447 insertions(+), 12 deletions(-)
>> >  create mode 100644 tester/rt/coverage.py
>> >  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
>> >
>> > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
>> > new file mode 100644
>> > index 000..38dcce6
>> > --- /dev/null
>> > +++ b/tester/rt/coverage.py
>> > @@ -0,0 +1,380 @@
>> > +#
>> > +# RTEMS Tools Project (http://www.rtems.org/)
>> > +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)
>>
>> Is this Krzysztof's code? if so, it should be added as a commit with
>> him as the --author="" field of git-commit option.
>>
>> Actually this script has undergone a lot of updates.
> It doesn't even work the same way it used to. I am uncertain
> about the portions of the code that are written by him and still in
> the script. Basically I left the copyright notice untouched and
> let it be there because I am unsure of what to include there.
> Same is true in case of Cillian. I don't really know how much
> of Code is authored by him.
> It surely isn't the proper way to add him as the co-author in
> the log but that seemed like the only way to include him.
>
>
>> > +# All rights reserved.
>> > +#
>> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
>> > +#
>> > +# Redistribution and use in source and binary forms, with or without
>> > +# modification, are permitted provided that the following conditions
>> are met:
>> > +#
>> > +# 1. Redistributions of source code must retain the above copyright
>> notice,
>> > +# this list of conditions and the following disclaimer.
>> > +#
>> > +# 2. Redistributions in binary form must reproduce the above copyright
>> notice,
>> > +# this list of conditions and the following disclaimer in the
>> documentation
>> > +# and/or other materials provided with the distribution.
>> > +#
>> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>> 'AS IS'
>> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>> TO, THE
>> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>> PURPOSE
>> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
>> CONTRIBUTORS BE
>> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>> BUSINESS
>> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
>> IN
>> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
>> OTHERWISE)
>> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
>> OF THE
>> > +# POSSIBILITY OF SUCH DAMAGE.
>> > +#
>> > +
>> > +from rtemstoolkit import error
>> > +from rtemstoolkit import path
>> > +from rtemstoolkit import log
>> > +from rtemstoolkit import execute
>> > +from rtemstoolkit import macros
>> > +
>> > +from datetime import datetime
>> > +
>> > +from . import options
>> > +
>> > +import shutil
>> > +import os
>> > +
>> > +try:
>> > +import configparser
>> > +except:
>> > +import ConfigParser as configparser
>> > +
>> > +class summary:
>> > +def __init__(self, p_summary_dir):
>> > +self.summary_file_path = path.join(p_summary_dir,
>> 'summary.txt')
>> > +self.index_file_path = path.join(p_summary_dir, 'index.html')
>> > +self.byt

Re: [PATCH] Generate coverage analysis Report

[Vijay Kumar Banerjee]

On 30 May 2018 at 22:51, Gedare Bloom  wrote:

> Please provide your name in your commits (git config --user.name "My
> Name") that you submit.
>
> OK Noted :)

> The first line of this commit, and therefore the email subject, is
> overly vague. Provide a slightly more specific description.
>
On Wed, May 30, 2018 at 1:00 PM, thelunatic 
> wrote:
> > + Add script to run covoar and generate an html report from
> > the output generated from covoar
> > + Add symbol-sets ini file for library addresses of the symbol-sets
> > + tester/rt/test : Add options for running coverage
> >
>

> I'd rather see a narrative paragraph than this list of + bullet items.
> Are all of these changes required to run the report? Should they be
> broken into smaller commits that are logically related but separately
> reviewable and commited?
>
> OK, I will write in a descriptive paragraph.
These changes are all needed to run coverage.

> > Co-author : Cillian O'Donnel 
> I don't know what Co-Author should mean. I would prefer to receive
> separate commits/patches for contributions made by different people if
> that is possible.
>
> Plese refer below...

> > ---
> >  tester/rt/coverage.py | 380
> ++
> >  tester/rt/test.py |  36 ++-
> >  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
> >  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
> >  tester/rtems/testing/qemu.cfg |   4 +-
> >  5 files changed, 447 insertions(+), 12 deletions(-)
> >  create mode 100644 tester/rt/coverage.py
> >  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
> >
> > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
> > new file mode 100644
> > index 000..38dcce6
> > --- /dev/null
> > +++ b/tester/rt/coverage.py
> > @@ -0,0 +1,380 @@
> > +#
> > +# RTEMS Tools Project (http://www.rtems.org/)
> > +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)
>
> Is this Krzysztof's code? if so, it should be added as a commit with
> him as the --author="" field of git-commit option.
>
> Actually this script has undergone a lot of updates.
It doesn't even work the same way it used to. I am uncertain
about the portions of the code that are written by him and still in
the script. Basically I left the copyright notice untouched and
let it be there because I am unsure of what to include there.
Same is true in case of Cillian. I don't really know how much
of Code is authored by him.
It surely isn't the proper way to add him as the co-author in
the log but that seemed like the only way to include him.


> > +# All rights reserved.
> > +#
> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
> > +#
> > +# Redistribution and use in source and binary forms, with or without
> > +# modification, are permitted provided that the following conditions
> are met:
> > +#
> > +# 1. Redistributions of source code must retain the above copyright
> notice,
> > +# this list of conditions and the following disclaimer.
> > +#
> > +# 2. Redistributions in binary form must reproduce the above copyright
> notice,
> > +# this list of conditions and the following disclaimer in the
> documentation
> > +# and/or other materials provided with the distribution.
> > +#
> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> 'AS IS'
> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> THE
> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> PURPOSE
> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
> CONTRIBUTORS BE
> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
> BUSINESS
> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
> IN
> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> OTHERWISE)
> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> OF THE
> > +# POSSIBILITY OF SUCH DAMAGE.
> > +#
> > +
> > +from rtemstoolkit import error
> > +from rtemstoolkit import path
> > +from rtemstoolkit import log
> > +from rtemstoolkit import execute
> > +from rtemstoolkit import macros
> > +
> > +from datetime import datetime
> > +
> > +from . import options
> > +
> > +import shutil
> > +import os
> > +
> > +try:
> > +import configparser
> > +except:
> > +import ConfigParser as configparser
> > +
> > +class summary:
> > +def __init__(self, p_summary_dir):
> > +self.summary_file_path = path.join(p_summary_dir, 'summary.txt')
> > +self.index_file_path = path.join(p_summary_dir, 'index.html')
> > +self.bytes_analyzed = 0
> > +self.bytes_not_executed = 0
> > +self.percentage_executed = 0.0
> > +self.percentage_not_executed = 100.0
> > +self.ranges_uncovered = 0
> > +

Re: [PATCH] Generate coverage analysis Report

[Cillian O'Donnell]

On Wed, 30 May 2018, 18:21 Gedare Bloom,  wrote:

> Please provide your name in your commits (git config --user.name "My
> Name") that you submit.
>
> The first line of this commit, and therefore the email subject, is
> overly vague. Provide a slightly more specific description.
>
> On Wed, May 30, 2018 at 1:00 PM, thelunatic 
> wrote:
> > + Add script to run covoar and generate an html report from
> > the output generated from covoar
> > + Add symbol-sets ini file for library addresses of the symbol-sets
> > + tester/rt/test : Add options for running coverage
> >
>
> I'd rather see a narrative paragraph than this list of + bullet items.
> Are all of these changes required to run the report? Should they be
> broken into smaller commits that are logically related but separately
> reviewable and commited?
>
> > Co-author : Cillian O'Donnel 
> I don't know what Co-Author should mean. I would prefer to receive
> separate commits/patches for contributions made by different people if
> that is possible.
>
Krystof is the original author for coverage.py, I rewrote large sections of
it and now Vijay has made some changes. It would be difficult to separate
out exactly who did what at this stage. I don't mind who gets the credit
for what, as long as it gets merged.

>
> > ---
> >  tester/rt/coverage.py | 380
> ++
> >  tester/rt/test.py |  36 ++-
> >  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
> >  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
> >  tester/rtems/testing/qemu.cfg |   4 +-
> >  5 files changed, 447 insertions(+), 12 deletions(-)
> >  create mode 100644 tester/rt/coverage.py
> >  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
> >
> > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
> > new file mode 100644
> > index 000..38dcce6
> > --- /dev/null
> > +++ b/tester/rt/coverage.py
> > @@ -0,0 +1,380 @@
> > +#
> > +# RTEMS Tools Project (http://www.rtems.org/)
> > +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)
>
> Is this Krzysztof's code? if so, it should be added as a commit with
> him as the --author="" field of git-commit option.
>
> > +# All rights reserved.
> > +#
> > +# This file is part of the RTEMS Tools package in 'rtems-tools'.
> > +#
> > +# Redistribution and use in source and binary forms, with or without
> > +# modification, are permitted provided that the following conditions
> are met:
> > +#
> > +# 1. Redistributions of source code must retain the above copyright
> notice,
> > +# this list of conditions and the following disclaimer.
> > +#
> > +# 2. Redistributions in binary form must reproduce the above copyright
> notice,
> > +# this list of conditions and the following disclaimer in the
> documentation
> > +# and/or other materials provided with the distribution.
> > +#
> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> 'AS IS'
> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> THE
> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> PURPOSE
> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
> CONTRIBUTORS BE
> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
> BUSINESS
> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
> IN
> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> OTHERWISE)
> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> OF THE
> > +# POSSIBILITY OF SUCH DAMAGE.
> > +#
> > +
> > +from rtemstoolkit import error
> > +from rtemstoolkit import path
> > +from rtemstoolkit import log
> > +from rtemstoolkit import execute
> > +from rtemstoolkit import macros
> > +
> > +from datetime import datetime
> > +
> > +from . import options
> > +
> > +import shutil
> > +import os
> > +
> > +try:
> > +import configparser
> > +except:
> > +import ConfigParser as configparser
> > +
> > +class summary:
> > +def __init__(self, p_summary_dir):
> > +self.summary_file_path = path.join(p_summary_dir, 'summary.txt')
> > +self.index_file_path = path.join(p_summary_dir, 'index.html')
> > +self.bytes_analyzed = 0
> > +self.bytes_not_executed = 0
> > +self.percentage_executed = 0.0
> > +self.percentage_not_executed = 100.0
> > +self.ranges_uncovered = 0
> > +self.branches_uncovered = 0
> > +self.branches_total = 0
> > +self.branches_always_taken = 0
> > +self.branches_never_taken = 0
> > +self.percentage_branches_covered = 0.0
> > +self.is_failure = False
> > +
> > +def parse(self):
> > +if(not path.exists(self.summary_file_path)):
> > +log.notice('summary file %s does not exi

Re: [PATCH] Generate coverage analysis Report

[Gedare Bloom]

Please provide your name in your commits (git config --user.name "My
Name") that you submit.

The first line of this commit, and therefore the email subject, is
overly vague. Provide a slightly more specific description.

On Wed, May 30, 2018 at 1:00 PM, thelunatic  wrote:
> + Add script to run covoar and generate an html report from
> the output generated from covoar
> + Add symbol-sets ini file for library addresses of the symbol-sets
> + tester/rt/test : Add options for running coverage
>

I'd rather see a narrative paragraph than this list of + bullet items.
Are all of these changes required to run the report? Should they be
broken into smaller commits that are logically related but separately
reviewable and commited?

> Co-author : Cillian O'Donnel 
I don't know what Co-Author should mean. I would prefer to receive
separate commits/patches for contributions made by different people if
that is possible.

> ---
>  tester/rt/coverage.py | 380 
> ++
>  tester/rt/test.py |  36 ++-
>  tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
>  tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
>  tester/rtems/testing/qemu.cfg |   4 +-
>  5 files changed, 447 insertions(+), 12 deletions(-)
>  create mode 100644 tester/rt/coverage.py
>  create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini
>
> diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
> new file mode 100644
> index 000..38dcce6
> --- /dev/null
> +++ b/tester/rt/coverage.py
> @@ -0,0 +1,380 @@
> +#
> +# RTEMS Tools Project (http://www.rtems.org/)
> +# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)

Is this Krzysztof's code? if so, it should be added as a commit with
him as the --author="" field of git-commit option.

> +# All rights reserved.
> +#
> +# This file is part of the RTEMS Tools package in 'rtems-tools'.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions are met:
> +#
> +# 1. Redistributions of source code must retain the above copyright notice,
> +# this list of conditions and the following disclaimer.
> +#
> +# 2. Redistributions in binary form must reproduce the above copyright 
> notice,
> +# this list of conditions and the following disclaimer in the documentation
> +# and/or other materials provided with the distribution.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 'AS IS'
> +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> +# POSSIBILITY OF SUCH DAMAGE.
> +#
> +
> +from rtemstoolkit import error
> +from rtemstoolkit import path
> +from rtemstoolkit import log
> +from rtemstoolkit import execute
> +from rtemstoolkit import macros
> +
> +from datetime import datetime
> +
> +from . import options
> +
> +import shutil
> +import os
> +
> +try:
> +import configparser
> +except:
> +import ConfigParser as configparser
> +
> +class summary:
> +def __init__(self, p_summary_dir):
> +self.summary_file_path = path.join(p_summary_dir, 'summary.txt')
> +self.index_file_path = path.join(p_summary_dir, 'index.html')
> +self.bytes_analyzed = 0
> +self.bytes_not_executed = 0
> +self.percentage_executed = 0.0
> +self.percentage_not_executed = 100.0
> +self.ranges_uncovered = 0
> +self.branches_uncovered = 0
> +self.branches_total = 0
> +self.branches_always_taken = 0
> +self.branches_never_taken = 0
> +self.percentage_branches_covered = 0.0
> +self.is_failure = False
> +
> +def parse(self):
> +if(not path.exists(self.summary_file_path)):
> +log.notice('summary file %s does not exist!' % 
> (self.summary_file_path))
> +self.is_failure = True
> +return
> +
> +with open(self.summary_file_path,'r') as summary_file:
> +   self.bytes_analyzed = self._get_next_with_colon(summary_file)
> +   self.bytes_not_executed = self._get_next_with_colon(summary_file)
> +   self.percentage_executed = self._get_next_with_colon(summary_file)
> +   self.percentage_not_executed = 
> self._get_next_with_colon(summary_file)
> +   self.ranges_uncovered = self._get_next_with

[PATCH] Generate coverage analysis Report

[thelunatic]

+ Add script to run covoar and generate an html report from
the output generated from covoar
+ Add symbol-sets ini file for library addresses of the symbol-sets
+ tester/rt/test : Add options for running coverage

Co-author : Cillian O'Donnel 
---
 tester/rt/coverage.py | 380 ++
 tester/rt/test.py |  36 ++-
 tester/rtems/testing/bsps/leon3-qemu-cov.ini  |   3 +-
 tester/rtems/testing/coverage/symbol-sets.ini |  36 +++
 tester/rtems/testing/qemu.cfg |   4 +-
 5 files changed, 447 insertions(+), 12 deletions(-)
 create mode 100644 tester/rt/coverage.py
 create mode 100644 tester/rtems/testing/coverage/symbol-sets.ini

diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
new file mode 100644
index 000..38dcce6
--- /dev/null
+++ b/tester/rt/coverage.py
@@ -0,0 +1,380 @@
+#
+# RTEMS Tools Project (http://www.rtems.org/)
+# Copyright 2014 Krzysztof Miesowicz (krzysztof.miesow...@gmail.com)
+# All rights reserved.
+#
+# This file is part of the RTEMS Tools package in 'rtems-tools'.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 'AS IS'
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+#
+
+from rtemstoolkit import error
+from rtemstoolkit import path
+from rtemstoolkit import log
+from rtemstoolkit import execute
+from rtemstoolkit import macros
+
+from datetime import datetime
+
+from . import options
+
+import shutil
+import os
+
+try:
+import configparser
+except:
+import ConfigParser as configparser
+
+class summary:
+def __init__(self, p_summary_dir):
+self.summary_file_path = path.join(p_summary_dir, 'summary.txt')
+self.index_file_path = path.join(p_summary_dir, 'index.html')
+self.bytes_analyzed = 0
+self.bytes_not_executed = 0
+self.percentage_executed = 0.0
+self.percentage_not_executed = 100.0
+self.ranges_uncovered = 0
+self.branches_uncovered = 0
+self.branches_total = 0
+self.branches_always_taken = 0
+self.branches_never_taken = 0
+self.percentage_branches_covered = 0.0
+self.is_failure = False
+
+def parse(self):
+if(not path.exists(self.summary_file_path)):
+log.notice('summary file %s does not exist!' % 
(self.summary_file_path))
+self.is_failure = True
+return
+
+with open(self.summary_file_path,'r') as summary_file:
+   self.bytes_analyzed = self._get_next_with_colon(summary_file)
+   self.bytes_not_executed = self._get_next_with_colon(summary_file)
+   self.percentage_executed = self._get_next_with_colon(summary_file)
+   self.percentage_not_executed = 
self._get_next_with_colon(summary_file)
+   self.ranges_uncovered = self._get_next_with_colon(summary_file)
+   self.branches_total = self._get_next_with_colon(summary_file)
+   self.branches_uncovered = self._get_next_with_colon(summary_file)
+   self.branches_always_taken = 
self._get_next_without_colon(summary_file)
+   self.branches_never_taken = 
self._get_next_without_colon(summary_file)
+if len(self.branches_uncovered) > 0 and len(self.branches_total) > 0:
+self.percentage_branches_covered = \
+1 - (float(self.branches_uncovered) / float(self.branches_total))
+else:
+self.percentage_branches_covered = 0.0
+return
+
+def _get_next_with_colon(self, summary_file):
+line = summary_file.readline()
+if ':' in line:
+return line.split(':')[1].strip()
+else:
+return ''
+
+def _get_next_without_colon(self, summary_file):
+line = summary_file.readline()
+return line.strip().split(' ')[0]
+
+class report_ge