Re: [PATCH 2/2] includes: Update to use the latest networking headers

[Chris Johns]

On 22/3/2023 4:20 pm, Joel Sherrill wrote:
> On Tue, Mar 21, 2023, 9:32 PM Chris Johns  > wrote:
> 
> On 22/3/2023 3:29 pm, Gedare Bloom wrote:
> > These patches look ok for rtems-net-legacy.
> 
> Yes and again sorry for the wrong subject line.
> 
> > In general, net-legacy is ok for maintenance patches. Any new features
> > will be heavily scrutinized and need additional discussions.
> 
> Agreed. These are maintenance changes only and there is a ticket. I think 
> this
> repo needs tickets for changes so these release notes contain any changes.
> 
> 
> Is this easy to enforce with git rules?
> 

I do not know and I am not a fan of git hooks on our servers for security 
reasons.

Maybe gitlab with gitlab issues can do this? :)

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] includes: Update to use the latest networking headers

[Joel Sherrill]

On Tue, Mar 21, 2023, 9:32 PM Chris Johns  wrote:

> On 22/3/2023 3:29 pm, Gedare Bloom wrote:
> > These patches look ok for rtems-net-legacy.
>
> Yes and again sorry for the wrong subject line.
>
> > In general, net-legacy is ok for maintenance patches. Any new features
> > will be heavily scrutinized and need additional discussions.
>
> Agreed. These are maintenance changes only and there is a ticket. I think
> this
> repo needs tickets for changes so these release notes contain any changes.
>

Is this easy to enforce with git rules?

>
> > Please run the python file through yapf consistent with
> > https://docs.rtems.org/branches/master/eng/python-devel.html
> > feel free to send the format fix separately. this should help reduce
> > whitespace changes in the future patches to net-legacy.
>
> Good idea. Hmmm there is a few changes so I will add this as a separate
> patch.
>
>
> Thanks for the prompt review. A v2 coming.
>
> Chris
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] includes: Update to use the latest networking headers

[Chris Johns]

On 22/3/2023 3:29 pm, Gedare Bloom wrote:
> These patches look ok for rtems-net-legacy.

Yes and again sorry for the wrong subject line.

> In general, net-legacy is ok for maintenance patches. Any new features
> will be heavily scrutinized and need additional discussions.

Agreed. These are maintenance changes only and there is a ticket. I think this
repo needs tickets for changes so these release notes contain any changes.

> Please run the python file through yapf consistent with
> https://docs.rtems.org/branches/master/eng/python-devel.html
> feel free to send the format fix separately. this should help reduce
> whitespace changes in the future patches to net-legacy.

Good idea. Hmmm there is a few changes so I will add this as a separate patch.


Thanks for the prompt review. A v2 coming.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] includes: Update to use the latest networking headers

[Gedare Bloom]

These patches look ok for rtems-net-legacy.

In general, net-legacy is ok for maintenance patches. Any new features
will be heavily scrutinized and need additional discussions.

Please run the python file through yapf consistent with
https://docs.rtems.org/branches/master/eng/python-devel.html
feel free to send the format fix separately. this should help reduce
whitespace changes in the future patches to net-legacy.

Thanks!

On Tue, Mar 21, 2023 at 6:36 PM  wrote:
>
> From: Chris Johns 
>
> - Add support for BSP configs and options if we need them
>
> Closes #4882
> ---
>  netlegacy.py | 11 +++
>  wscript  | 11 ++-
>  2 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/netlegacy.py b/netlegacy.py
> index ebab745..981fd4a 100644
> --- a/netlegacy.py
> +++ b/netlegacy.py
> @@ -46,15 +46,25 @@ for root, dirs, files in os.walk("."):
>  if ext == '.h' and name not in exclude_headers:
>  include_files[root[2:]].append(os.path.join(root, name))
>
> +
>  def find_node(bld, *paths):
>  path = os.path.join(*paths)
>  return os.path.relpath(str(bld.path.find_node(path)))
>
> +
>  def install_file_list(*paths):
>  path = os.path.join(*paths)
>  file_list = [os.path.join(path, f) for f in os.listdir(path)]
>  return file_list
>
> +def options(opt):
> +pass
> +
> +
> +def bsp_configure(conf, arch_bsp, mandatory = True):
> +pass
> +
> +
>  def build(bld):
>  include_path = []
>  ip = ''
> @@ -107,6 +117,7 @@ def build(bld):
>  bld(target='network_objects',
>  features='c',
>  includes=ip,
> +defines=['IN_HISTORICAL_NETS=1'],
>  source=source_files)
>
>  bld(target='networking',
> diff --git a/wscript b/wscript
> index 518108b..c790707 100644
> --- a/wscript
> +++ b/wscript
> @@ -49,10 +49,19 @@ def init(ctx):
>
>  def options(opt):
>  rtems.options(opt)
> +netlegacy.options(opt)
> +
> +def bsp_configure(conf, arch_bsp):
> +env = conf.env.derive()
> +ab = conf.env.RTEMS_ARCH_BSP
> +conf.msg('Configure variant: ', ab)
> +conf.setenv(ab, env)
> +netlegacy.bsp_configure(conf, arch_bsp)
> +conf.setenv(ab)
>
>
>  def configure(conf):
> -rtems.configure(conf)
> +rtems.configure(conf, bsp_configure)
>
>
>  def recurse(ctx):
> --
> 2.37.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 2/2] includes: Update to use the latest networking headers

[chrisj]

From: Chris Johns 

- Add support for BSP configs and options if we need them

Closes #4882
---
 netlegacy.py | 11 +++
 wscript  | 11 ++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/netlegacy.py b/netlegacy.py
index ebab745..981fd4a 100644
--- a/netlegacy.py
+++ b/netlegacy.py
@@ -46,15 +46,25 @@ for root, dirs, files in os.walk("."):
 if ext == '.h' and name not in exclude_headers:
 include_files[root[2:]].append(os.path.join(root, name))
 
+
 def find_node(bld, *paths):
 path = os.path.join(*paths)
 return os.path.relpath(str(bld.path.find_node(path)))
 
+
 def install_file_list(*paths):
 path = os.path.join(*paths)
 file_list = [os.path.join(path, f) for f in os.listdir(path)]
 return file_list
 
+def options(opt):
+pass
+
+
+def bsp_configure(conf, arch_bsp, mandatory = True):
+pass
+
+
 def build(bld):
 include_path = []
 ip = ''
@@ -107,6 +117,7 @@ def build(bld):
 bld(target='network_objects',
 features='c',
 includes=ip,
+defines=['IN_HISTORICAL_NETS=1'],
 source=source_files)
 
 bld(target='networking',
diff --git a/wscript b/wscript
index 518108b..c790707 100644
--- a/wscript
+++ b/wscript
@@ -49,10 +49,19 @@ def init(ctx):
 
 def options(opt):
 rtems.options(opt)
+netlegacy.options(opt)
+
+def bsp_configure(conf, arch_bsp):
+env = conf.env.derive()
+ab = conf.env.RTEMS_ARCH_BSP
+conf.msg('Configure variant: ', ab)
+conf.setenv(ab, env)
+netlegacy.bsp_configure(conf, arch_bsp)
+conf.setenv(ab)
 
 
 def configure(conf):
-rtems.configure(conf)
+rtems.configure(conf, bsp_configure)
 
 
 def recurse(ctx):
-- 
2.37.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel