Re: [Development] Proposal: Changing the default output of qDebug and friends
On Thursday 29 March 2012 10:02:59 Lincoln Ramsay wrote: On 03/29/2012 09:54 AM, ext Olivier Goffart wrote: That would be possible with runtime backtrace (#includeexecinfo.h backtrace(), on Linux) So one could add some tokens in QT_MESSAGE_PATTERN to get the backtrace. The problem is that runtime backtrace is often not really accurate. Getting a whole backtrace is another problem entirely. I'd just like to see the caller's filename and line number used when a function is trying to warn you that someone has used it incorrectly. Ant the only way to do it is to get a backtrace. But you could specify, in the pattern, the number of stack frame you want. (I suppose two would already be enough in most cases. And yeah... optimized binaries make it difficult for this to work 100% while it's an add-on to the language :( ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Proposal: Changing the default output of qDebug and friends
On 03/29/2012 05:03 PM, Koehne Kai (Nokia-MP/Berlin) wrote:
Why can't Creator just set the QT_MESSAGE_PATTERN environment
variable then and leave the default alone? Creator would not need
to show the filename and line number, just use them for when you
click on the warnings.
You're right, that's actually what I intend do for apps started from
within Qt Creator, and which is why I don't suggest including
%{file}, %{line} in the default pattern.
My bad. I thought you were suggesting them in the default :)
Anyhow: Is the current default of printing just the message really
the optimal one?
Possibly not. I suspect though that turning on all the options by
default will prove frustrating for many use cases.
Lets define some shall we?
Running an app with warnings/debugs that does to the system output. On
Linux, this is ~/.xsession-errors and here, app+pid would be useful. On
Windows this is the debug log... I can't remember if it includes app+pid
already or not. On Mac this is Console.app and this already includes
app+pid.
Running multiple apps with all output put into a single log file (say,
on an embedded system that doesn't use syslog) the app+pid would be useful.
Running an app from the command line, you don't need app+pid because
you're only looking at one app's output.
It seems to me that app+pid may not be so useful by default.
But I guess having the type (avoiding redundant warning/error), function
(avoiding Q_FUNC_INFO) and message should be ok as long as it doesn't
bloat message length too much...
--
Lincoln Ramsay - Senior Software Engineer
Qt Development Frameworks, Nokia - http://qt.nokia.com/
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Request for a new Playground project
On Thu, Mar 29, 2012 at 12:50:21AM +, ext wolfgang.b...@nokia.com wrote: Because of the feature freeze we can't merge this patch into the trunk so we want to follow the way of the playground project. this is a false dichotomy. you want a feature branch for qtbase. created. sergio and/or rohan will set up CI on request. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Hiding Tabs in QTabWidget
Hi Jordi, thanks for the answer. Im looking forward to see you changes in QT 5.1 :-). Best Regards, Carsten Am 27.03.2012 07:51, schrieb Jordi Pujol: Sorry, answer sent only to Carsten ( my mistake... ) Afaik you only have the option to remove the tab . I've implemented that functionality, but right now I cannot contribute it to Gerrit ( no maintainer for QWidgets module no plans... ). If someone can tell me how to do it I'll be glad to do it for Qt5.1 El 26/03/2012 21:43, Carsten Breuer carstenbreue...@textwork.de escribió: Hi guys, i just spend some hours with trying to hide a tab in a QTabWidget that was designed with QtCreator (ui). After searching the web it seems to me that the only way to solve this is to use the removeTab function. I don't want to use removeTab, because this means that i have to save the tab text somewherem, have to deal with translations and with tab position dependencies and much more. All stuff, that smart Qt should do for me. Is there any other function that i can use to hide tabs? Someone...please :-) Best Regards, Carsten ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] New QUrl reviewing
All is reviewed. Stage at your convenience ;-) Cheers, Lars On 3/28/12 11:42 PM, ext Thiago Macieira thiago.macie...@intel.com wrote: On quarta-feira, 28 de março de 2012 19.08.04, lars.kn...@nokia.com wrote: I'll try to go through them tonight. Thanks for the effort. I've gone over all the recommendations and made the modifications. We're pending further work on: 1) QUrlTwoFlags - a helper class like QFlags but that takes two enums not just one. I'll simplify this into QFlags if possible and make it generic later. 2) renaming the QUrlQuery methods (i.e., API review). The names were kept equal to Qt 4's for compatibility reasons, but since this is a new class and you need to touch your code anyway to use them, we could use better names. Will do after they code is in. 3) decide if QUrl::errorString() should be translatable One of the changes has already been staged (the one in qtdeclarative). The rest have been updated with the fixes. All the commits have two changes except the first two below: the first is just a rebase because Gerrit required me to rebase. The second contains the modifications. To be re-approved or reviewed for the changes: http://codereview.qt-project.org/21045 only rebase - Gerrit shows no changes http://codereview.qt-project.org/21046 only rebase - Gerrit shows no changes http://codereview.qt-project.org/21047 updated the constants to be higher http://codereview.qt-project.org/21048 only rebase - Gerrit shows no changes http://codereview.qt-project.org/21052 renamed encodedUtf8ToUcs4 to *Utf16 http://codereview.qt-project.org/21049 two changes requested by Lars http://codereview.qt-project.org/21057 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21056 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21058 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21060 improvements and test requested by Lars http://codereview.qt-project.org/21061 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21063 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21064 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21066 changes but Gerrit shows unrelated too http://codereview.qt-project.org/21067 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21068 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21751 new change -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center Intel Sweden AB - Registration Number: 556189-6027 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Request for a new Playground project
Approved. Sergio, can you help setting it up, please? Thanks, Lars On 3/29/12 2:50 AM, ext wolfgang.b...@nokia.com wolfgang.b...@nokia.com wrote: Hi guys, I'm following the steps on http://wiki.qt-project.org/Creating_a_new_module_or_tool_for_Qt To get a playground project created for qlogger in place. qlogger should be the previous discussed category logging mechanism on the developer ML. (see http://codereview.qt-project.org/#change,13226). Because of the feature freeze we can't merge this patch into the trunk so we want to follow the way of the playground project. Cheers, Wolfgang Beck ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Request for a new Playground project
On 03/29/2012 01:59 PM, Knoll Lars (Nokia-MP/Oslo) wrote: Approved. Sergio, can you help setting it up, please? Thanks, Lars So .. we'll go for a playground project instead of a branch ? I'll create playground/qlogger.git in the afternoon Cheers, -- Sergio Ahumada ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] New QUrl reviewing
Eh, after alpha please? -- .marius -Original Message- From: development-bounces+marius.storm-olsen=nokia.com@qt- project.org [mailto:development-bounces+marius.storm- olsen=nokia@qt-project.org] On Behalf Of Knoll Lars (Nokia-MP/Oslo) Sent: Thursday, March 29, 2012 6:56 AM To: thiago.macie...@intel.com; development@qt-project.org Subject: Re: [Development] New QUrl reviewing All is reviewed. Stage at your convenience ;-) Cheers, Lars On 3/28/12 11:42 PM, ext Thiago Macieira thiago.macie...@intel.com wrote: On quarta-feira, 28 de março de 2012 19.08.04, lars.kn...@nokia.com wrote: I'll try to go through them tonight. Thanks for the effort. I've gone over all the recommendations and made the modifications. We're pending further work on: 1) QUrlTwoFlags - a helper class like QFlags but that takes two enums not just one. I'll simplify this into QFlags if possible and make it generic later. 2) renaming the QUrlQuery methods (i.e., API review). The names were kept equal to Qt 4's for compatibility reasons, but since this is a new class and you need to touch your code anyway to use them, we could use better names. Will do after they code is in. 3) decide if QUrl::errorString() should be translatable One of the changes has already been staged (the one in qtdeclarative). The rest have been updated with the fixes. All the commits have two changes except the first two below: the first is just a rebase because Gerrit required me to rebase. The second contains the modifications. To be re-approved or reviewed for the changes: http://codereview.qt-project.org/21045 only rebase - Gerrit shows no changes http://codereview.qt-project.org/21046 only rebase - Gerrit shows no changes http://codereview.qt-project.org/21047 updated the constants to be higher http://codereview.qt-project.org/21048 only rebase - Gerrit shows no changes http://codereview.qt-project.org/21052 renamed encodedUtf8ToUcs4 to *Utf16 http://codereview.qt-project.org/21049 two changes requested by Lars http://codereview.qt-project.org/21057 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21056 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21058 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21060 improvements and test requested by Lars http://codereview.qt-project.org/21061 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21063 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21064 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21066 changes but Gerrit shows unrelated too http://codereview.qt-project.org/21067 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21068 only rebase - Gerrit shows unrelated http://codereview.qt-project.org/21751 new change -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center Intel Sweden AB - Registration Number: 556189-6027 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Request for a new Playground project
On 03/29/2012 02:06 PM, ext Sergio Ahumada wrote: On 03/29/2012 01:59 PM, Knoll Lars (Nokia-MP/Oslo) wrote: Approved. Sergio, can you help setting it up, please? Thanks, Lars So .. we'll go for a playground project instead of a branch ? I'll create playground/qlogger.git in the afternoon Cheers, Done. # git clone ssh://ACCOUNT@codereview.qt-project.org:29418/playground/qlogger.git https://codereview.qt-project.org/#admin,project,playground/qlogger,info Cheers, -- Sergio Ahumada ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Proposal: Changing the default output of qDebug and friends
-Original Message-
From: Ramsay Lincoln (Nokia-MP/Brisbane)
Sent: Thursday, March 29, 2012 9:20 AM
To: Koehne Kai (Nokia-MP/Berlin)
Cc: development@qt-project.org
Subject: Re: [Development] Proposal: Changing the default output of
qDebug and friends
On 03/29/2012 05:03 PM, Koehne Kai (Nokia-MP/Berlin) wrote:
Why can't Creator just set the QT_MESSAGE_PATTERN environment
variable then and leave the default alone? Creator would not need to
show the filename and line number, just use them for when you click
on the warnings.
You're right, that's actually what I intend do for apps started from
within Qt Creator, and which is why I don't suggest including %{file},
%{line} in the default pattern.
My bad. I thought you were suggesting them in the default :)
Anyhow: Is the current default of printing just the message really the
optimal one?
Possibly not. I suspect though that turning on all the options by default will
prove frustrating for many use cases.
Lets define some shall we?
Running an app with warnings/debugs that does to the system output. On
Linux, this is ~/.xsession-errors and here, app+pid would be useful. On
Windows this is the debug log... I can't remember if it includes app+pid
already or not. On Mac this is Console.app and this already includes
app+pid.
Running multiple apps with all output put into a single log file (say, on an
embedded system that doesn't use syslog) the app+pid would be useful.
Running an app from the command line, you don't need app+pid because
you're only looking at one app's output.
It seems to me that app+pid may not be so useful by default.
But I guess having the type (avoiding redundant warning/error), function
(avoiding Q_FUNC_INFO) and message should be ok as long as it doesn't
bloat message length too much...
For my original proposal I took inspiration from the KDE debug output. Anyhow,
I agree that the application name / pid just adds noise if you launched your
app yourself from the shell.
So, about [%{type}] %{function} - %{message} then?
Any other opinions? Olivier, do you think that's sensible?
Regards
Kai
--
Lincoln Ramsay - Senior Software Engineer Qt Development Frameworks,
Nokia - http://qt.nokia.com/
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qftp removal
It may not be trivial, but it's the workflow we have defined for promoting a playground module to an official add-on. Would it be any more complex than creating a new project (initialised with the contents of the previous project repo, rather than empty) and deleting the old project? And we've created projects with pre-existing git history before, when importing the Qt5 modules to gerrit. -Original Message- From: development-bounces+shane.kearns=accenture@qt-project.org [mailto:development-bounces+shane.kearns=accenture@qt-project.org] On Behalf Of Oswald Buddenhagen Sent: 28 March 2012 17:56 To: development@qt-project.org Subject: Re: [Development] Qftp removal On Wed, Mar 28, 2012 at 04:17:36PM +, ext shane.kea...@accenture.com wrote: If there are other Qt4 classes that would benefit from this approach, we can rename the repo later. well, no, we cannot (without major hassle) - gerrit doesn't support renaming. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development Subject to local law, communications with Accenture and its affiliates including telephone calls and emails (including content), may be monitored by our systems for the purposes of security and the assessment of internal compliance with Accenture policy. __ www.accenture.com ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] tracing to generate sequence diagrams (was Re: Proposal: Changing the default output of qDebug and friends)
On Wednesday, March 28, 2012 02:39:35 PM ext kai.koe...@nokia.com wrote: Hi there, In Qt 4 qDebug, qWarning etc just printed whatever was passed in. In Qt 5 we've been changing this (1) so that you can configure Qt to print additional information by setting the QT_MESSAGE_PATTERN environment variable. However, we didn't change the default so far - so without setting QT_MESSAGE_PATTERN we still just print the message. I just had a discussion (2) with Thiago Macieira and David Faure where we agreed that we'd like to still change this for Qt 5.0 ... My personal motivation is that if e.g. the type would be always part of the message Qt Creator could use this information to colorize/filter output. Adding the app name / PID would identify the app in case of system logs, adding the function would give you a clue where on earth you added this one debug statement just printing true ;) Since I'm working with mouse events lately, and event propagation is kindof confusing, I was thinking I'd like to have a qTrace() feature which would be rather like qDebug except that it would accept extra parameter(s) to define the context or flow that is being traced, and it could be separately turned on/off and separately redirected. This is what I would do with it: http://www.umlgraph.org/index.html (the lower half about sequence diagrams) In fact, a few years ago on a Qt- based project I used specially-formatted comments in code to define sequence diagrams; it's just another literate programming technique, nice to be able to define the sequence diagram inline with the code the same way as you can define your documentation inline with code. But you still have to think like a computer to make it work with comments, because the sequence does not come out of the execution order, you have to know what it will do in which order. Using qTrace would output something which depends on the actual runtime execution order, and that would vary depending on the use case, so you could generate a family of diagrams, one for each autotest as well as anything else of interest. Maybe I could use some kind of existing debugging technique (like the same way that gdb does breakpoints, make some sort of auto-continuing breakpoint which just traces the fact that it has been hit). But that would require a lot of setup to define just for one test what the breakpoints should be. Or has that problem been solved already? If there was a tool for scripting which functions need the trace breakpoints in order to document which flow, they could be applied without adding anything to the source code. But depending on the implementation of such a thing, it might be limited to tracing function enter/exit, whereas qTrace could go anywhere. Event propagation is a flow which is of long-term interest, and the correctness of the flow is important both for testing and for documentation. A lot of bugs could be found by comparing before-and-after diagrams when changes are made. Longer-term, Creator could generate selected types of diagrams whenever you use the debugger. It would give you a more zoomed-out view of execution than what you can get by just setting breakpoints and looking at stack traces (which must be repeated because unless I took notes, I probably forgot what I learned last time). Quite often in preference to using breakpoints, I add a lot of qDebugs for tracing, but it's bad etiquette to leave them in place. If there were an acceptable way of doing tracing, they could be left in the code, but the compiler would leave them out of non-debug builds. (It's of course important for performance that they disappear completely from release builds. That basically means qTrace should be a macro so it can be #defined to do nothing.) Creator's editor could optionally hide or collapse qTrace lines too, for anyone who minds the clutter. -- MVH, Shawn Rutledge ❖ ecloud on IRC ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] QT_QPA_PLATFORM=windows:fontengine=native can't work, -no-freetype is invalid too?
Hi, All, After try the current master, I found *QT_QPA_PLATFORM*=*windows:fontengine=native *don't work now, If set this env variable, will running failed on any qt apps. Then I try to re-configure with -no-freetype option. And find in currently it can't work. The font still not clear. -- Regards Loaden ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Why the UI font is not clear on Windows?
QT_QPA_PLATFORM=windows:fontengine=native can't work now, -no-freetype is invalid too? Any comments? 2012/3/21 Loaden loa...@gmail.com I found another way, just use configure option: *-no-freetype* The on Windows the issue gone. 2012/3/17 Loaden loa...@gmail.com Wow! Thanks!! BTW, My fault, the vaule should be: QT_QPA_PLATFORM to the value windows:fontengine=native I test it on Windows 7 32bit, It works well. 2012/3/17 1+1=2 dbzhang...@gmail.com QT_QPA_PLATFORM -- Regards Loaden -- Regards Loaden -- Regards Loaden ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] New QUrl reviewing
On quinta-feira, 29 de março de 2012 11.55.47, lars.kn...@nokia.com wrote: All is reviewed. Stage at your convenience ;-) Staged, re-staged, re-re-staged and once again for good measure, and it's in :-) It took two more fixes applied on top -- license headers (some files were added in September, before we changed our headers) and one behaviour change reversal caught by QDesktopServices. And one extra attempt due to a network test timeout failure. We *really* need the topic branch reviewing feature back in. It's no fun staging 19, 20, 20 and 21 changes... -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center Intel Sweden AB - Registration Number: 556189-6027 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] New QUrl reviewing
On quinta-feira, 29 de março de 2012 23.31.38, Thiago Macieira wrote: Staged, re-staged, re-re-staged and once again for good measure, and it's in :-) Oh, did I mention I had a QEXPECT_FAIL sneak in due to a feature that David added to QUrl after I had already completed my work, and to fix that particular QEXPECT_FAIL, I need to refactor quite a bit of the encoding rules? Currently, the encoding options are: - FullyEncoded - as the RFC asks - DecodeSpace - decode %20 to a space character - DecodeUnicode - decode unicode sequences to the actual characters - DecodeUnambiguousDelimiters - DecodeAllDelimiters - PrettyDecoded = DecodeUnambiguousDelimiters | DecodeSpace | DecodeUnicode - MostDecoded = DecodeAllDelimiters | DecodeSpace | DecodeUnicode The choice of the default has the unfortunate consequence that: url.setPath(/hash#in#path?); url.path() == /hash%23in%23path%3F; It seems to me that the pretty decoded form for the components is actually the MostDecoded form. But the MostDecoded form might not be the most interesting form for the full URL, especially when we consider reserved characters like \, ^ or and . There's also a side-effect of FullyDecoded being the value 0. If you had: url.toString(); // equivalent to toString(QUrl::PrettyDecoded) and you modify it to be now: url.toString(QUrl::RemovePassword); oops, that's equivalent to: url.toString(QUrl::RemovePassword | QUrl::FullyEncoded); For that reason, I need to rearrange the constants such the default parameter is a zero. I can't make PrettyDecoded == 0 because otherwise we have the reverse of the above problem with toEncoded(). -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center Intel Sweden AB - Registration Number: 556189-6027 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
