Re: [Development] Qt 5.5 for Android - More Regressions Since 5.3

[Robert Iakobashvili]

thanks
Regards,
Robert


On Mon, Aug 3, 2015 at 11:39 AM, BogDan  wrote:
> Hi,
>
> In order to see in which version they will be included, you need to check on
> each bug its "Fix/Version(s)" label.
> QTBUG-44337 is still not closed yet, I'm waiting for some folks to reply
> (check https://codereview.qt-project.org/#/c/120725/ ).
>
> I didn't had time to check QProgressDialog bug. I'm afraid I'll not have
> soon because this bug has a low priority on my list ...
>
> Cheers,
> BogDan.
>
>
>
>
>
> On Monday, August 3, 2015 9:04 AM, Robert Iakobashvili 
> wrote:
>
>
> Dear BogDan,
> Thank you for the 2 regressions being fixed.
>
> Should the fixes appear in 5.5.1?
>
> Sorry to bother you but it seems that the issue with QProgressDialog
> wasn't treated:
> QTBUG-47049
>
> [REG 5.4 -> 5.5] QProgressDialog is Shown Immediately After Allocation
> and Even Despite hide() Call.
>
> Thank you.
>
> Regards,
> Robert
>
>
> On Mon, Jul 6, 2015 at 11:37 AM, Robert Iakobashvili
>  wrote:
>> Thanks, BogDan.
>>
>> QTBUG-47049
>>
>> [REG 5.4 -> 5.5] QProgressDialog is Shown Immediately After Allocation
>> and Even Despite hide() Call.
>>
>>
>> Regards,
>> Robert
>>
>>
>> On Mon, Jul 6, 2015 at 10:31 AM, BogDan  wrote:
>>> Hi,
>>>
>>> 1 & 2. I can reproduce it, I'll try to fix it soon (though it will be
>>> quite
>>> hard to make them look good on Android).
>>> 3. Yep, please create a bug report.
>>>
>>> Cheers,
>>> BogDan.
>>>
>>>
>>>
>>> On Monday, July 6, 2015 9:50 AM, Robert Iakobashvili
>>> 
>>> wrote:
>>>
>>>
>>> Hi,
>>>
>>> Trying Qt-5.5 for Android, the following regressions since
>>> Qt-5.3 are still inside and break it:
>>>
>>> 1. QTBUG-44337 -
>>>
>>> [REG 5.3-5.4] Android: QFileDialog for Save Keeps Save Button Disabled
>>> until the filename contains a dot
>>>
>>> 2. QTBUG-44271 -
>>>
>>> [REG 5.3 -> 5.4] Android: QFontComboBox Broken
>>>
>>>
>>> and even worse:
>>>
>>> 3. QProgressDialog instances are shown immediately on allocation
>>> and even explicit hide is not helping (Android 4.4.2, Nexus-7-2013)
>>> This is a regression since 5.4
>>>
>>> Does anybody cares? If yes, I will open the issue.
>>>
>>>
>>> In Qt-5.3.1 all the above was working properly.
>>>
>>> IMHO, Qt for iOS and Android requires serious "go for stability"
>>> instead the current run for more and fancy features.
>>>
>>> Still, it might be that my visibility is limited and other people
>>> do not feel so or sales consideration require more features ASAP
>>> and do not care the quality.
>>>
>>> Thank you.
>>>
>>> Regards,
>>> Robert
>>> ___
>>> Development mailing list
>>> Development@qt-project.org
>>> http://lists.qt-project.org/mailman/listinfo/development
>>>
>>>
>
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] QtWebEngine: Chromium GStreamer backend by Samsung

[Kevin Kofler]

Hi,

is there any chance we can get this:
http://blogs.s-osg.org/announcing-a-new-gstreamer-backend-for-chromium/
merged into QtWebEngine? I would see several benefits for Qt:
* GStreamer is the multimedia framework of choice for pretty much anything
  else in Qt on GNU/Linux, at least QtMultimedia and QtWebKit use it, so it
  allows sharing code and especially codecs.
* The chance of distributions shipping QtWebEngine would increase
  significantly. And in particular, we packagers are otherwise likely to try
  to merge the backend into QtWebEngine's Chromium ourselves sooner or
  later, with all the issues such local patching entails (likely duplication
  of efforts between distributions, hard package maintenance, complicated
  support for you because of prevalent heavy downstream patching).
* Users would still be able to use the FFmpeg backend. The patches only add
  GStreamer as an additional option. You could even document GStreamer
  support as an experimental tech preview at the beginning.

The only drawback I can see is that it is still under heavy development and 
so might be problematic to keep up to date.

Kevin Kofler

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QPointer issue

[Denis Shienkov]

Ok, many thanks. Now it is clear (just need for me not to be lazy and to 
take and to read the documentation :) ).


05.08.2015 21:35, Matt Broadstone пишет:
On Wed, Aug 5, 2015 at 2:27 PM, Denis Shienkov 
mailto:denis.shien...@gmail.com>> wrote:


Hi all,

seems that QPointer::clear() does not work as expected (for me).

E.g. I assume that QPointer:clear() deletes the internal object
... but
this not happens..

So, what is way to delete an object (1 or 2)?

QPointer p = new QObject();

1) delete p;
2) delete p.data();

BR,
Denis


IIRC QPointer is just a guarded pointer, meaning you should use it to 
track the lifetime of the wrapped pointer but it doesn't actually 
assume ownership of the object. Therefore, this is working as expected.


Cheers,
Matt


___
Development mailing list
Development@qt-project.org 
http://lists.qt-project.org/mailman/listinfo/development




___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] QPointer issue

[Denis Shienkov]

Hi all,

seems that QPointer::clear() does not work as expected (for me).

E.g. I assume that QPointer:clear() deletes the internal object ... but 
this not happens..

So, what is way to delete an object (1 or 2)?

QPointer p = new QObject();

1) delete p;
2) delete p.data();

BR,
Denis


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[BogDan]

Or make it a technical preview ... It is non-crucial "nice to have" *that will 
make a lot of people happy* feature;-).


Cheers,
BogDan.


On Wednesday, August 5, 2015 6:50 PM, Thiago Macieira 
 wrote:



On Wednesday 05 August 2015 15:33:10 BogDan wrote:
>   In this case IMHO we should delay the feature freeze (and the release)
> with 5 weeks or to make it an optional technical preview with no API/ABI
> back compatibility promises. Qt Purchasing library is not crucial a crucial
> library that we can't leave without it

Your two sentences contradict each other. You said it's not a crucial library 
and that we can live without it. But you also said we should push everything 
back by 5 weeks for a non-crucial "nice to have" library.


-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] 5.5 CI having problems on tst_qmimedatabase-xml

[Thiago Macieira]

On Wednesday 05 August 2015 07:48:42 Thiago Macieira wrote:
> Uh... that indicates that the random number generator is never seeded in
> the  tests, so QTemporaryFile / QTemporaryDir always tries to create the
> same file names.
> 
> 256 is exactly the number of attempts qt_mkstemp tries before giving up.
> And  tst_qmimedatabase-xml is failing exactly because the QTemporaryDir
> creation failed.

https://codereview.qt-project.org/122839

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Thiago Macieira]

On Wednesday 05 August 2015 15:33:10 BogDan wrote:
>   In this case IMHO we should delay the feature freeze (and the release)
> with 5 weeks or to make it an optional technical preview with no API/ABI
> back compatibility promises. Qt Purchasing library is not crucial a crucial
> library that we can't leave without it

Your two sentences contradict each other. You said it's not a crucial library 
and that we can live without it. But you also said we should push everything 
back by 5 weeks for a non-crucial "nice to have" library.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Thiago Macieira]

On Wednesday 05 August 2015 07:53:40 Knoll Lars wrote:
> >The release team decided the new modules should be released under
> >Technical 
> >Preview for 5.6 (they came in 5 weeks past the deadline that Jani sent).
> >So 
> >there's no rush in reviewing the API right now, as we've given us time to
> >change it for 5.7.
> 
> 
> Well, the module has been commercially supported for a while. So it is at
> least debugged and tested for the platforms that it supports.

Right, which means we probably won't find a lot to change (or anything at all).

> TQtC will need to continue to fully support the module in the commercial
> packages, so a TP status for it will be somewhat weird. So I’d propose we
> try to do the API review in the next week or two (as Eskil said, it has
> all been reviewed already once by Qt Project approvers) and then see
> whether we can upgrade the module from TP (as per release team discussion).

The Qt Project cannot do otherwise. There isn't enough time and the module is 
5 weeks late.

I'd rather not open a precedent, otherwise anyone might say "here's a brand 
new module which I've been supporting for a while, so you can't call it a TP 
and you can't change the API"

If you're asking the Qt Project "take it or leave it", the answer would have 
to be "leave it, please submit again in one week for 5.7."
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] 5.5 CI having problems on tst_qmimedatabase-xml

[Thiago Macieira]

On Wednesday 05 August 2015 10:03:31 Sarajärvi Tony wrote:
> As I logged into that particular machine that ran that build, its
> Users\qt\AppData\Local\Temp is quite loaded with stuff like
> tst_qfileinfo-RYGJOI
> tst_qfileinfo-sXgxSH
> tst_qfileinfo-t6LYMr
> ...
> All of those folders.
> 
> If I recall, previously the tests began failing as we had 255 or 256 of
> those.

Uh... that indicates that the random number generator is never seeded in the 
tests, so QTemporaryFile / QTemporaryDir always tries to create the same file 
names.

256 is exactly the number of attempts qt_mkstemp tries before giving up. And 
tst_qmimedatabase-xml is failing exactly because the QTemporaryDir creation 
failed.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Eskil Abrahamsen Blomfeldt]

On 08/05/2015 01:08 PM, Marc Mutz wrote:
> On Wednesday 05 August 2015 09:59:52 Oswald Buddenhagen wrote:
>>> How do we handle reviews beyond that? Should I make a patch to qt5.git
>>> and collect comments there, or would it be better if I make a mock
>>> change that includes the entire code base so that we can get inline
>>> comments? I'm not sure how this has usually been done before.
>>>
>>>
>> don't make it too meta.
>> what exactly you want people to review at which granularity level?
> If you already have exsiting customers, what guarantees have you given them re
> BC and SC? IoW: are we supposed to review API as well as implementation?

I really hope we can keep source compatibility and use deprecation, etc. 
if there is a need for changes to the API. Otherwise it will likely mean 
increasing the version number of the public version and 
maintaining/supporting two separate ones for us, which of course will 
eat into the time we have for other stuff.

Binary compatibility should not really be an issue on Android or iOS, 
since the libraries are always bundled in the former case and statically 
linked in the latter. Someone correct me if I'm wrong :)

-- Eskil

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] 5.5 CI having problems on tst_qmimedatabase-xml

[Sarajärvi Tony]

I remember some test regading files and folders having a problem a year or two 
ago. The problem was that the tests weren't cleaned up. So windows ran out of 
random folder and / or files it could create. So if the next machine happened 
to pick up the build, it might pass, but the ones that had a lot of test data 
lying around couldn't test anymore.

As I logged into that particular machine that ran that build, its 
Users\qt\AppData\Local\Temp is quite loaded with stuff like
tst_qfileinfo-RYGJOI
tst_qfileinfo-sXgxSH
tst_qfileinfo-t6LYMr
...
All of those folders.

If I recall, previously the tests began failing as we had 255 or 256 of those.

The folder currently has 988 files and 3018 folders in it, beginning with tst_*
It has 23161 files and 3744 folders in total in it :P

Other files or directories mostly named the same are:
tst_qsharedpointer
tst_qsqltablemodel
tst_qdeclarativewebview
tst_qfilediaglo2
tst_qmimedatabase
etc...


I'll cleanup the temp folder now and at least this number 2 machine is then 
cleaned up from this mess.

-T



> -Original Message-
> From: development-bounces+tony.sarajarvi=theqtcompany.com@qt-
> project.org [mailto:development-
> bounces+tony.sarajarvi=theqtcompany@qt-project.org] On Behalf Of
> Thiago Macieira
> Sent: 3. elokuuta 2015 8:57
> To: development@qt-project.org
> Subject: Re: [Development] 5.5 CI having problems on tst_qmimedatabase-
> xml
> 
> On Monday 13 July 2015 14:48:40 Thiago Macieira wrote:
> > This test began failing about a week ago, for no apparent reason. I don't
> > think it's a Qt issue, but more of a CI issue.
> >
> > It's failing on:
> >
> > FAIL!  : tst_QMimeDatabase::initTestCase() 'm_temporaryDir.isValid()'
> > returned FALSE. ()
> > c:
> >
> \work\build\qt\qtbase\tests\auto\corelib\mimetypes\qmimedatabase\qmi
> medataba
> > se- xml\../tst_qmimedatabase.cpp(84) : failure location
> >
> > Since m_temporaryDir is default-constructed, this implies somehow that
> > C:\temp or C:\tmp is not writeable.
> >
> > Can someone look into this?
> 
> This is still happening.
> --
> Thiago Macieira - thiago.macieira (AT) intel.com
>   Software Architect - Intel Open Source Technology Center
> 
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Marc Mutz]

On Wednesday 05 August 2015 09:59:52 Oswald Buddenhagen wrote:
> > How do we handle reviews beyond that? Should I make a patch to qt5.git 
> > and collect comments there, or would it be better if I make a mock 
> > change that includes the entire code base so that we can get inline 
> > comments? I'm not sure how this has usually been done before.
> >
> > 
> 
> don't make it too meta.
> what exactly you want people to review at which granularity level?

If you already have exsiting customers, what guarantees have you given them re 
BC and SC? IoW: are we supposed to review API as well as implementation?

Thanks,
Marc

-- 
Marc Mutz  | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - The Qt Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Jake Petroules]

> On Aug 5, 2015, at 1:43 AM, Eskil Abrahamsen Blomfeldt 
>  wrote:
> 
> On 08/05/2015 09:31 AM, Knoll Lars wrote:
> 
>> Well, let’s create the repository today and import the codebase so
>> everybody can have a look.
> 
> Done!
> 
> The code is now in 
> https://codereview.qt-project.org/#/admin/projects/qt/qtpurchasing
> 
> I'll make a patch for qt5.git as well and collect comments on that.
> 
> -- Eskil
> 
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development


And here's the first contribution: the OS X backend: 
https://codereview.qt-project.org/#/c/122779/

Enjoy!
-- 
Jake Petroules - jake.petroules at petroules.com

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Eskil Abrahamsen Blomfeldt]

On 08/05/2015 09:31 AM, Knoll Lars wrote:

> Well, let’s create the repository today and import the codebase so
> everybody can have a look.

Done!

The code is now in 
https://codereview.qt-project.org/#/admin/projects/qt/qtpurchasing

I'll make a patch for qt5.git as well and collect comments on that.

-- Eskil

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Speech: text to speech in 5.6

[Frederik Gladhorn]

On Tuesday, August 04, 2015 11:54:16 PM Samuel Gaist wrote:
> On 4 août 2015, at 09:24, Frederik Gladhorn 
 wrote:
> > Hello all,
> > 
> > I would like to propose the tts parts of QtSpeech (the current dev branch)
> > for inclusion in Qt 5.6.0. Along with that I'd like to invite everyone to
> > review QtSpeech, it's not much code and works on most platforms. Notably
> > iOS is still missing, although I have proof of concept patches (if
> > someone wants to finish them let me know, I don't know if I'll get around
> > in time). I have no idea about non-desktop Windows in this area.
> > 
> > Cheers,
> > Frederik
> 
> Hi,
> 
> I might have some time to help on the iOS side

Thanks, I added you to the patches that I wrote half a year ago and haven't 
looked at since. I guess it means figuring out the points Tor Arne raised on 
the patches.

Cheers,
Frederik


> 
> Best regards
> Samuel

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Speech: text to speech in 5.6

[Frederik Gladhorn]

On Tuesday, August 04, 2015 01:52:57 PM Heikkinen Jani wrote:
> Hi!
> 
> Is it planned that this will be officially part of qt5.git or as tech
> preview under extra component?
> 

Considering that we're somewhat late, and there hasn't been extensive review 
and more changes are planned in the future to add the speech recognition, I'd 
say clearly tech preview.

Cheers,
Frederik


> Br,
> Jani
> 
> >>-Original Message-
> >>From: development-bounces+jani.heikkinen=theqtcompany.com@qt-
> >>project.org [mailto:development-
> >>bounces+jani.heikkinen=theqtcompany@qt-project.org] On Behalf Of
> >>Frederik Gladhorn
> >>Sent: 4. elokuuta 2015 10:25
> >>To: development@qt-project.org
> >>Subject: [Development] Qt Speech: text to speech in 5.6
> >>
> >>Hello all,
> >>
> >>I would like to propose the tts parts of QtSpeech (the current dev branch)
> >>for inclusion in Qt 5.6.0. Along with that I'd like to invite everyone to
> >>review QtSpeech, it's not much code and works on most platforms. Notably
> >>iOS is still missing, although I have proof of concept patches (if
> >>someone wants to finish them let me know, I don't know if I'll get around
> >>in time). I have no idea about non-desktop Windows in this area.
> >>
> >>Cheers,
> >>Frederik
> >>
> >>___
> >>Development mailing list
> >>Development@qt-project.org
> >>http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Oswald Buddenhagen]

On Wed, Aug 05, 2015 at 09:31:15AM +0200, Eskil Abrahamsen Blomfeldt wrote:
> The module has also been in active use for a while. My plan was to
> upload the whole history including the peer reviews (mostly done by
> Andy Nichols and me).
> 
upload from where? and what exactly do you mean by "reviews"? is this a
move from tqtc's internal gerrit?

> How do we handle reviews beyond that? Should I make a patch to qt5.git 
> and collect comments there, or would it be better if I make a mock 
> change that includes the entire code base so that we can get inline 
> comments? I'm not sure how this has usually been done before.
> 
don't make it too meta.
what exactly you want people to review at which granularity level?

> I'll try getting it up somewhere today at least, and we can at least
> try to get it in time for Qt 5.6.
> 
as noted elsewhere, you're past that deadline anyway. so adding it would
be merely an act of bundling, not endorsing, so it is uncritical.

there is technically no major issue with adding the module
post-branching, so let's handle this when i'm back from vacation next
week (i'm so not going to do that from the camping site ;).

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Please help me get my pending review count down

[Thiago Macieira]

On Tuesday 28 July 2015 19:06:59 Thiago Macieira wrote:
> Deadline: 6 weeks before Qt 5.7 feature freeze.
> 
> If we reach that date and the patches are still not integrated, I will have
> to  make a decision as Maintainer as to the future of them. It will be to
> either apply them despite any breakages caused in KDE applications or to
> drop them altogether, including all the fixes for race conditions and
> deadlocks. I will probably err on the side of caution, though.

The Qt release team has published the feature freeze date for Qt 5.7 as Dec 
18.

6 weeks before that is Nov 13.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
  PGP/GPG: 0x6EF45358; fingerprint:
  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Knoll Lars]

On 05/08/15 09:35, "Thiago Macieira"  wrote:

>On Wednesday 05 August 2015 09:31:15 Eskil Abrahamsen Blomfeldt wrote:
>> It's not huge and all changes have been through peer reviews already
>>(by 
>> approvers in the Qt Project). The module has also been in active use
>>for 
>> a while. My plan was to upload the whole history including the peer
>> reviews (mostly done by Andy Nichols and me).
>> 
>> How do we handle reviews beyond that? Should I make a patch to qt5.git
>> and collect comments there, or would it be better if I make a mock
>> change that includes the entire code base so that we can get inline
>> comments? I'm not sure how this has usually been done before.
>> 
>> I'll try getting it up somewhere today at least, and we can at least
>>try 
>> to get it in time for Qt 5.6.
>
>The release team decided the new modules should be released under
>Technical 
>Preview for 5.6 (they came in 5 weeks past the deadline that Jani sent).
>So 
>there's no rush in reviewing the API right now, as we've given us time to
>change it for 5.7.

Well, the module has been commercially supported for a while. So it is at
least debugged and tested for the platforms that it supports.

TQtC will need to continue to fully support the module in the commercial
packages, so a TP status for it will be somewhat weird. So I’d propose we
try to do the API review in the next week or two (as Eskil said, it has
all been reviewed already once by Qt Project approvers) and then see
whether we can upgrade the module from TP (as per release team discussion).

Cheers,
Lars


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Please help me get my pending review count down

[Thiago Macieira]

On Tuesday 28 July 2015 19:06:59 Thiago Macieira wrote:
> Deadline: 6 weeks before Qt 5.7 feature freeze.
> 
> If we reach that date and the patches are still not integrated, I will have
> to  make a decision as Maintainer as to the future of them. It will be to
> either apply them despite any breakages caused in KDE applications or to
> drop them altogether, including all the fixes for race conditions and
> deadlocks. I will probably err on the side of caution, though.

The Qt release team has published the feature freeze date for Qt 5.7 as Dec 
18.

6 weeks before that is Nov 13.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Thiago Macieira]

On Wednesday 05 August 2015 09:31:15 Eskil Abrahamsen Blomfeldt wrote:
> It's not huge and all changes have been through peer reviews already (by 
> approvers in the Qt Project). The module has also been in active use for 
> a while. My plan was to upload the whole history including the peer 
> reviews (mostly done by Andy Nichols and me).
> 
> How do we handle reviews beyond that? Should I make a patch to qt5.git 
> and collect comments there, or would it be better if I make a mock 
> change that includes the entire code base so that we can get inline 
> comments? I'm not sure how this has usually been done before.
> 
> I'll try getting it up somewhere today at least, and we can at least try 
> to get it in time for Qt 5.6.

The release team decided the new modules should be released under Technical 
Preview for 5.6 (they came in 5 weeks past the deadline that Jani sent). So 
there's no rush in reviewing the API right now, as we've given us time to 
change it for 5.7.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Eskil Abrahamsen Blomfeldt]

On 08/04/2015 04:12 PM, Thiago Macieira wrote:
> On Tuesday 04 August 2015 10:43:35 Eskil Abrahamsen Blomfeldt wrote:
>> Hi,
>>
>> Qt Purchasing is a commercial add-on module developed by The Qt Company
>> which implements a cross-platform API for in-app purchases on iOS and
>> Android. In order to make it easier for third parties to contribute new
>> backends for the API, we want to release it in the Qt Project under
>> LGPLv3/GPLv2/Commercial. I propose to include it as part of Qt 5.6.0.
> Do we have the time to add it a new module and review it in one week?

It's not huge and all changes have been through peer reviews already (by 
approvers in the Qt Project). The module has also been in active use for 
a while. My plan was to upload the whole history including the peer 
reviews (mostly done by Andy Nichols and me).

How do we handle reviews beyond that? Should I make a patch to qt5.git 
and collect comments there, or would it be better if I make a mock 
change that includes the entire code base so that we can get inline 
comments? I'm not sure how this has usually been done before.

I'll try getting it up somewhere today at least, and we can at least try 
to get it in time for Qt 5.6.

-- Eskil


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt Purchasing in Qt 5.6

[Knoll Lars]

On 04/08/15 21:57, "Jake Petroules"  wrote:

>
>> On Aug 4, 2015, at 7:12 AM, Thiago Macieira 
>>wrote:
>> 
>> On Tuesday 04 August 2015 10:43:35 Eskil Abrahamsen Blomfeldt wrote:
>>> Hi,
>>> 
>>> Qt Purchasing is a commercial add-on module developed by The Qt Company
>>> which implements a cross-platform API for in-app purchases on iOS and
>>> Android. In order to make it easier for third parties to contribute new
>>> backends for the API, we want to release it in the Qt Project under
>>> LGPLv3/GPLv2/Commercial. I propose to include it as part of Qt 5.6.0.
>> 
>> Do we have the time to add it a new module and review it in one week?

Well, let’s create the repository today and import the codebase so
everybody can have a look.

The code has been reviewed inside TQtC before, so it should be in good
shape. But another look is certainly a good idea. Fortunately we already
have some volunteers :)

Cheers,
Lars

>> -- 
>> Thiago Macieira - thiago.macieira (AT) intel.com
>>  Software Architect - Intel Open Source Technology Center
>> 
>> ___
>> Development mailing list
>> Development@qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/development
>
>
>I can help review the iOS port. Also, I did a quick test and changing
>around 5 lines of code gets us an OS X backend for free.
>
>After that, all that's left is WinRT I guess. Perhaps Amazon and Samsung.
>-- 
>Jake Petroules - jake.petroules at petroules.com
>
>___
>Development mailing list
>Development@qt-project.org
>http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development