Re: [Development] API breackage in Qt3D

2018-03-02 Thread Lisandro Damián Nicanor Pérez Meyer 
On 1 March 2018 at 13:22, Thiago Macieira  wrote:
[snip]
>> > Animation and Extras are tech preview. The rest are stable.
[snip]
> Please move them to another module until they're ready, or at least disable
> the building unless explicitly enabled.
>
> Debian wasn't the only one that packaged those libs and has symbol control
> enabled.

Should I file a bug about this?

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] API breackage in Qt3D

2018-03-01 Thread Thiago Macieira 
On Thursday, 1 March 2018 04:56:19 PST Kai Koehne wrote:
> > -Original Message-
> > From: Development [mailto:development-bounces+kai.koehne=qt.io@qt-
> > Subject: Re: [Development] API breackage in Qt3D
> > 
> > El 1 mar. 2018 6:11 a.m., "Sean Harmer" <s...@theharmers.co.uk
> > <mailto:s...@theharmers.co.uk> > escribió:
> > 
> > 
> > 
> > Animation and Extras are tech preview. The rest are stable.
> > 
> > 
> > 
> > Ok, so we have probably misunderstood that part.
> 
> 
> I also think this should be documented more explicitly:
> 
> https://codereview.qt-project.org/#/c/216892/
> 
> Reviews are welcome 

Please move them to another module until they're ready, or at least disable 
the building unless explicitly enabled.

Debian wasn't the only one that packaged those libs and has symbol control 
enabled.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] API breackage in Qt3D

2018-03-01 Thread Kai Koehne 
> -Original Message-
> From: Development [mailto:development-bounces+kai.koehne=qt.io@qt-
> Subject: Re: [Development] API breackage in Qt3D
> 
> El 1 mar. 2018 6:11 a.m., "Sean Harmer" <s...@theharmers.co.uk
> <mailto:s...@theharmers.co.uk> > escribió:
> 
> 
>   Animation and Extras are tech preview. The rest are stable.
> 
> 
> Ok, so we have probably misunderstood that part.

I also think this should be documented more explicitly:

https://codereview.qt-project.org/#/c/216892/

Reviews are welcome 

Kai
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] API breackage in Qt3D

2018-03-01 Thread Lisandro Damián Nicanor Pérez Meyer 
El 1 mar. 2018 6:11 a.m., "Sean Harmer"  escribió:

Animation and Extras are tech preview. The rest are stable.


Ok, so we have probably misunderstood that part.

Just as an idea, would it be possible to tag tech preview symbols as we do
for private ones?

On one hand it would make their detection easier, on the other it might
help as an incentive to not make them stable API...
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] API breackage in Qt3D

2018-03-01 Thread Sean Harmer 

Animation and Extras are tech preview. The rest are stable.

Cheers,

Sean

On 28/02/2018 16:40, Lisandro Damián Nicanor Pérez Meyer wrote:

Hi! today I was packaging Qt3D (meaning the the submodule) for Debian
and noticed that some symbols where missing. We understood that Qt3D
(the submodule) was API/ABI stable, but Konstantin Tokarev pointed
out:

   https://abi-laboratory.pro/tracker/timeline/qt/ "NOTE: The libQt53D*
objects are introduced in the library
   since 5.5.0 but with no stable ABI guarantee, so analysis of these
objects was not performed."

But then Thiago pointed out:

 well, we need to start having it stable
 it's no longer in experimental state
 $ git config -f .gitmodules --get submodule.qt3d.status
 addon
 qt3d left preview status in 5.7
 if there are libs inside that aren't stable ABI, they should
be moved to a separate module

So bringing up the issue here.




___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] API breackage in Qt3D

2018-02-28 Thread Thiago Macieira 
On Wednesday, 28 February 2018 08:40:29 PST Lisandro Damián Nicanor Pérez 
Meyer wrote:
>  if there are libs inside that aren't stable ABI, they should
> be moved to a separate module

So asking the maintainers: is the whole Qt3D module keeping binary 
compatibility?

If not, which libraries in it are not?

I haven't reviewed Lisandro's list, but at least one symbol (the first one) is 
not private API and did change.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] API breackage in Qt3D

2018-02-28 Thread Lisandro Damián Nicanor Pérez Meyer 
On 28 February 2018 at 13:40, Lisandro Damián Nicanor Pérez Meyer
 wrote:
> Hi! today I was packaging Qt3D (meaning the the submodule) for Debian
> and noticed that some symbols where missing.

Sorry, forgot to mention that the previously attached txt shows each
missing symbol. Some of them might be private. At the end of the each
line you can find the version in we first detected the symbol.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] API breackage in Qt3D

2018-02-28 Thread Lisandro Damián Nicanor Pérez Meyer 
Hi! today I was packaging Qt3D (meaning the the submodule) for Debian
and noticed that some symbols where missing. We understood that Qt3D
(the submodule) was API/ABI stable, but Konstantin Tokarev pointed
out:

  https://abi-laboratory.pro/tracker/timeline/qt/ "NOTE: The libQt53D*
objects are introduced in the library
  since 5.5.0 but with no stable ABI guarantee, so analysis of these
objects was not performed."

But then Thiago pointed out:

 well, we need to start having it stable
 it's no longer in experimental state
 $ git config -f .gitmodules --get submodule.qt3d.status
 addon
 qt3d left preview status in 5.7
 if there are libs inside that aren't stable ABI, they should
be moved to a separate module

So bringing up the issue here.


-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
+#MISSING: 5.10.1# 
_ZN13Qt3DAnimation14QChannelMapper10addMappingEPNS_15QChannelMappingE@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN13Qt3DAnimation14QChannelMapper13removeMappingEPNS_15QChannelMappingE@Qt_5 
5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras19QMetalRoughMaterial12setBaseColorERK6QColor@Qt_5 5.9.0
+#MISSING: 5.10.1# _ZN10Qt3DExtras19QMetalRoughMaterial12setMetalnessEf@Qt_5 
5.9.0
+#MISSING: 5.10.1# _ZN10Qt3DExtras19QMetalRoughMaterial12setRoughnessEf@Qt_5 
5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras19QMetalRoughMaterial16baseColorChangedERK6QColor@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras19QMetalRoughMaterial16metalnessChangedEf@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras19QMetalRoughMaterial16roughnessChangedEf@Qt_5 5.9.0
+#MISSING: 5.10.1# _ZN10Qt3DExtras22QOrbitCameraController12setLookSpeedEf@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras22QOrbitCameraController13cameraChangedEv@Qt_5 5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras22QOrbitCameraController14setLinearSpeedEf@Qt_5 5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras22QOrbitCameraController16lookSpeedChangedEv@Qt_5 5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras22QOrbitCameraController18linearSpeedChangedEv@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras22QOrbitCameraController9setCameraEPN10Qt3DRender7QCameraE@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial12setBaseColorEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial12setMetalnessEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial12setRoughnessEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial13normalChangedEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial16baseColorChangedEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial16metalnessChangedEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial16roughnessChangedEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial19setAmbientOcclusionEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial23ambientOcclusionChangedEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterial9setNormalEPN10Qt3DRender16QAbstractTextureE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterialC1ERNS_34QTexturedMetalRoughMaterialPrivateEPN8Qt3DCore5QNodeE@Qt_5
 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras27QTexturedMetalRoughMaterialC2ERNS_34QTexturedMetalRoughMaterialPrivateEPN8Qt3DCore5QNodeE@Qt_5
 5.9.0
+#MISSING: 5.10.1# _ZN10Qt3DExtras27QTexturedMetalRoughMaterialD0Ev@Qt_5 5.9.0
+#MISSING: 5.10.1# _ZN10Qt3DExtras27QTexturedMetalRoughMaterialD1Ev@Qt_5 5.9.0
+#MISSING: 5.10.1# _ZN10Qt3DExtras27QTexturedMetalRoughMaterialD2Ev@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController12setLookSpeedEf@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController13cameraChangedEv@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController14setLinearSpeedEf@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController15setAccelerationEf@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController15setDecelerationEf@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController16lookSpeedChangedEv@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController18linearSpeedChangedEv@Qt_5 
5.7.1~20161122
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController19accelerationChangedEf@Qt_5 5.9.0
+#MISSING: 5.10.1# 
_ZN10Qt3DExtras28QFirstPersonCameraController19decelerationChangedEf@Qt_5 5.9.0
+#MISSING: 5.10.1#