[Development] Qt-AES - Looking for comments

2017-07-12 Thread Matteo 
>From: Thiago Macieira 
>Date: Wed, 12 Jul 2017 10:59:30 -0700
>Subject: Re: [Development] Qt-AES - Looking for comments
>On quarta-feira, 12 de julho de 2017 09:40:17 PDT Matteo wrote:
>> >>you do, what value does your library have on top of the 4 processor
>> >>instructions?
>>
>> You mean using the AES-NI instructions?
>
>Yes, for x86. I think ARM has them too.
>
>> The tinycrypt project you show me does not look like they are using any
>> special instructions to be hardware accelerated, or am I missing
something?
>
>You're not. TinyCrypt was designed for Intel MCUs. Those don't have SSE
>registers, so they can't have AES-NI. So no one felt the need to add
support.
>
>Could be as simple as a pull request, though. The maintainer sits a couple
of
>rows from me, if necessary.

I'll definitely take a look at AES-NI.

Thank you!

-- 
Matteo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Thiago Macieira 
On quarta-feira, 12 de julho de 2017 09:40:17 PDT Matteo wrote:
> >>you do, what value does your library have on top of the 4 processor
> >>instructions?
> 
> You mean using the AES-NI instructions?

Yes, for x86. I think ARM has them too.

> The tinycrypt project you show me does not look like they are using any
> special instructions to be hardware accelerated, or am I missing something?

You're not. TinyCrypt was designed for Intel MCUs. Those don't have SSE 
registers, so they can't have AES-NI. So no one felt the need to add support.

Could be as simple as a pull request, though. The maintainer sits a couple of 
rows from me, if necessary.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Konstantin Tokarev 


12.07.2017, 19:36, "Thiago Macieira" :
> On quarta-feira, 12 de julho de 2017 09:26:52 PDT Konstantin Tokarev wrote:
>>  12.07.2017, 19:21, "Thiago Macieira" :
>>  > On quarta-feira, 12 de julho de 2017 07:52:20 PDT Matteo wrote:
>>  >> At the beginning this was for my own personal use as I was in need of
>>  >> some
>>  >> sort of encryption for a work project without using openssl, then I just
>>  >> released the code for the class on github, it's more a code exercise
>>  >> than a real usable class for the issues you pointed out.
>>  >
>>  > Try this instead: https://github.com/01org/tinycrypt
>>
>>  Or https://github.com/libtom/libtomcrypt
>
> How certified is it?
>
> The Intel implementation above is audited.

I don't know, but it's widely used as a part of Dropbear, which is the most 
popular
SSH client and server implementation for embedded systems.

>
> --
> Thiago Macieira - thiago.macieira (AT) intel.com
>   Software Architect - Intel Open Source Technology Center
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Qt-AES - Looking for comments

2017-07-12 Thread Matteo 
>From: Thiago Macieira 
>To: development@qt-project.org
>Date: Wed, 12 Jul 2017 09:20:26 -0700
>Subject: Re: [Development] Qt-AES - Looking for comments
>On quarta-feira, 12 de julho de 2017 07:52:20 PDT Matteo wrote:
>> At the beginning this was for my own personal use as I was in need of
some
>> sort of encryption for a work project without using openssl, then I just
>> released the code for the class on github, it's more a code exercise
than a
>> real usable class for the issues you pointed out.
>
>Try this instead: https://github.com/01org/tinycrypt

Thank you, I am watching it.

>>And when are you going to add support for hardware-accelerated AES? And
after
>>you do, what value does your library have on top of the 4 processor
>>instructions?

You mean using the AES-NI instructions?

The tinycrypt project you show me does not look like they are using any
special instructions to be hardware accelerated, or am I missing something?

Thank you

-- 
Matteo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Thiago Macieira 
On quarta-feira, 12 de julho de 2017 09:26:52 PDT Konstantin Tokarev wrote:
> 12.07.2017, 19:21, "Thiago Macieira" :
> > On quarta-feira, 12 de julho de 2017 07:52:20 PDT Matteo wrote:
> >>  At the beginning this was for my own personal use as I was in need of
> >> some
> >>  sort of encryption for a work project without using openssl, then I just
> >>  released the code for the class on github, it's more a code exercise
> >> than a real usable class for the issues you pointed out.
> > 
> > Try this instead: https://github.com/01org/tinycrypt
> 
> Or https://github.com/libtom/libtomcrypt

How certified is it?

The Intel implementation above is audited.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Konstantin Tokarev 


12.07.2017, 19:21, "Thiago Macieira" :
> On quarta-feira, 12 de julho de 2017 07:52:20 PDT Matteo wrote:
>>  At the beginning this was for my own personal use as I was in need of some
>>  sort of encryption for a work project without using openssl, then I just
>>  released the code for the class on github, it's more a code exercise than a
>>  real usable class for the issues you pointed out.
>
> Try this instead: https://github.com/01org/tinycrypt

Or https://github.com/libtom/libtomcrypt

>
> --
> Thiago Macieira - thiago.macieira (AT) intel.com
>   Software Architect - Intel Open Source Technology Center
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Thiago Macieira 
On quarta-feira, 12 de julho de 2017 07:52:20 PDT Matteo wrote:
> At the beginning this was for my own personal use as I was in need of some
> sort of encryption for a work project without using openssl, then I just
> released the code for the class on github, it's more a code exercise than a
> real usable class for the issues you pointed out.

Try this instead: https://github.com/01org/tinycrypt

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Matteo 
At the beginning this was for my own personal use as I was in need of some
sort of encryption for a work project without using openssl, then I just
released the code for the class on github, it's more a code exercise than a
real usable class for the issues you pointed out.

On Wed, Jul 12, 2017 at 4:43 AM, Marc Mutz  wrote:

> On 2017-07-12 00:05, Matteo wrote:
> [...]
>
>> My point was not to use openssl or external libs, i understand the
>> security issue of something that is not certified and audited.
>>
> [...]
>
> Good to know. Now you "just" need to make sure *all* your potential users
> understand this, too. Which brings me to the question: who, exactly, is the
> target audience for a non-proven, non-audited, non-certified, AES-only,
> Qt-using implementation?
>
> Thanks,
> Marc
>
>


-- 
Matteo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Thiago Macieira 
On quarta-feira, 12 de julho de 2017 04:43:48 PDT Marc Mutz wrote:
> On 2017-07-12 00:05, Matteo wrote:
> [...]
> 
> > My point was not to use openssl or external libs, i understand the
> > security issue of something that is not certified and audited.
> 
> [...]
> 
> Good to know. Now you "just" need to make sure *all* your potential
> users understand this, too. Which brings me to the question: who,
> exactly, is the target audience for a non-proven, non-audited,
> non-certified, AES-only, Qt-using implementation?

And when are you going to add support for hardware-accelerated AES? And after 
you do, what value does your library have on top of the 4 processor 
instructions?

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-12 Thread Marc Mutz 

On 2017-07-12 00:05, Matteo wrote:
[...]

My point was not to use openssl or external libs, i understand the
security issue of something that is not certified and audited.

[...]

Good to know. Now you "just" need to make sure *all* your potential 
users understand this, too. Which brings me to the question: who, 
exactly, is the target audience for a non-proven, non-audited, 
non-certified, AES-only, Qt-using implementation?


Thanks,
Marc

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-11 Thread Matteo 
Noted.

My point was not to use openssl or external libs, i understand the security
issue of something that is not certified and audited.

Thank you

On Tue, Jul 11, 2017 at 14:19 Marc Mutz  wrote:

> On 2017-07-08 00:39, Matteo wrote:
> > Hi all,
> >
> > I just finished the first preview of my QAESEncryption class and I
> > would like to have some opinions on possible improvements, issues etc.
> >
> > https://github.com/bricke/Qt-AES [1]
> >
> > This is still a work in progress but I feel it's good enough to be
> > shared and I am ready to take the heat!
>
> Don't implement the cipher yourself. Wrap an existing, widely-used and
> audited crypto library instead.
>
> Thanks,
> Marc
>
> --
Sent from iPhone
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-11 Thread Richard Moore 
On 11 July 2017 at 22:13, Marc Mutz  wrote:

> On 2017-07-08 00:39, Matteo wrote:
>
>> Hi all,
>>
>> I just finished the first preview of my QAESEncryption class and I
>> would like to have some opinions on possible improvements, issues etc.
>>
>> https://github.com/bricke/Qt-AES [1]
>>
>> This is still a work in progress but I feel it's good enough to be
>> shared and I am ready to take the heat!
>>
>
> Don't implement the cipher yourself. Wrap an existing, widely-used and
> audited crypto library instead.
>

​I'm with Marc. I'd also add that anything that uses crypto and directly
references a specific cipher is designed wrong.

Rich.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt-AES - Looking for comments

2017-07-11 Thread Marc Mutz 

On 2017-07-08 00:39, Matteo wrote:

Hi all,

I just finished the first preview of my QAESEncryption class and I
would like to have some opinions on possible improvements, issues etc.

https://github.com/bricke/Qt-AES [1]

This is still a work in progress but I feel it's good enough to be
shared and I am ready to take the heat!


Don't implement the cipher yourself. Wrap an existing, widely-used and 
audited crypto library instead.


Thanks,
Marc

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Qt-AES - Looking for comments

2017-07-07 Thread Matteo 
Hi all,

I just finished the first preview of my QAESEncryption class and I would
like to have some opinions on possible improvements, issues etc.


https://github.com/bricke/Qt-AES

This is still a work in progress but I feel it's good enough to be shared
and I am ready to take the heat!

Thank you
Best Regards

-- 
Matteo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development