Re: [Development] Two bugs in the QIcon which broke my life.
On Wednesday 08 August 2012 17:00:29 David Faure wrote: > On Wednesday 08 August 2012 14:32:36 Mark wrote: > > As for the second bug report > > (https://bugreports.qt-project.org/browse/QTBUG-12874) shouldn't the > > standard icon paths be defined in the new class QStandardPaths? Then > > QIcon can use QStandardPaths to find icons - obviously. > > > > Right now i don't see any icon related thing in > > http://doc-snapshot.qt-project.org/5.0/qstandardpaths.html Since the > > icon stuff is defined by freedesktop > > (http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.h > > tm l#directory_layout) it might as well be added in there. > > > > Adding David Faure to the cc since he invented QStandardPaths. > > QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "icons", > QStandardPaths::LocateDirectory); > > will give you all the base icon paths where to look for icon themes. Sorry, now I read the bug report which also talks about /usr/share/pixmaps. Interesting :-) The KDE icon loader code says that locating one icon can be done with: QStandardPaths::locate(QStandardPaths::GenericDataLocation, searchPath + '/' + iconName) where searchPath iterates over a list containing 1) the application-specific directory + "/pics" 2) "icons" 3) "pixmaps", but with a comment that this is historical and mostly for gnome compatibility. I had no idea that it was actually in the spec :-) I'll fix that comment. Now what's interesting is that the spec hardcodes /usr/share/pixmaps, while the KDE code makes this more generic, i.e. $XDG_DATA_DIRS/pixmaps. Anyway, to come back to the Qt code, this means: A) yes, QStandardPaths should be used to find $XDG_DATA_DIRS/icons, but that's unrelated to QTBUG-12874, which is about B) yes, Qt icon loading should look into /usr/share/pixmaps, as the spec says. I don't know qiconloader.cpp so I can't approve the rest of the patch, but the hardcoded /usr/share/pixmaps looks fine, it's as per the spec. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
On Wednesday 08 August 2012 14:32:36 Mark wrote: > As for the second bug report > (https://bugreports.qt-project.org/browse/QTBUG-12874) shouldn't the > standard icon paths be defined in the new class QStandardPaths? Then > QIcon can use QStandardPaths to find icons - obviously. > > Right now i don't see any icon related thing in > http://doc-snapshot.qt-project.org/5.0/qstandardpaths.html Since the > icon stuff is defined by freedesktop > (http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.htm > l#directory_layout) it might as well be added in there. > > Adding David Faure to the cc since he invented QStandardPaths. QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "icons", QStandardPaths::LocateDirectory); will give you all the base icon paths where to look for icon themes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
On Wed, Aug 8, 2012 at 12:43 PM, wrote: > On 08/08/2012 04:12, ext André Somers wrote: >> Op 8-8-2012 10:49, Stephen Kelly schreef: >>> On Wednesday, August 08, 2012 10:35:15 André Somers wrote: >>> > Op 8-8-2012 10:30, Stephen Kelly schreef: >>> > > On Wednesday, August 08, 2012 12:03:34 ? ??? wrote: >>> > > > In the QIcon/QIconLoader there are 2 old bugs with patches. >>> > > > - https://bugreports.qt-project.org/browse/QTBUG-17953 >>> > > > - https://bugreports.qt-project.org/browse/QTBUG-12874 >>> > > > Fixes are trivial, and are available for many years. Merging of them >>> > > > will take only an hour. >>> > > You need to submit patches to Qt through gerrit. Patches attached in >>> > > JIRA can't be applied. Note also that patches have to be applied to Qt >>> > > 5 first and unit tested. >>> > >>> > Nice, but these patches were submitted way before Gerrit was available. >>> > Are you saying we should just disgard any fixes that can be found in >>> JIRA? >>> >>> They are not covered by the CLA. >>> >> Are you sure about that? > > Yes, Stephen is correct, the CLA covers only patches which has been > submitted through Codereview.qt-project.org, so patches in > Jira/Wiki/email cannot be applied. > > Even if the author "gives" you copyright to submit it to codereview as > yourself (which is not allowed in many countries), _you_ would then be > personally responsible for granting the license to use any patents > his/her code might be infringing on. So, *don't* do that. Only submit > code you have written yourself and where you can stand by the > implementation. > > >>> Whether they are 'trivial' enough to 'not be copyrightable' isn't >>> for me to decide. I didn't look at them. >>> >>> Even when gerrit was not available, gitorious was available for all >>> the time that JIRA was available. JIRA has never been 'the way to >>> submit patches'. >> >> One of these had a MR on gitorious, actually. That got closed some >> time later because Gerrit got introduced in the meantime. So, I bet >> the contributor signed the agreement. I guess the submitter did not >> want to jump through the hoops again, in the hope that this time his >> patch *would* get accepted. > > A codereview can be done without using Gerrit of course, through email, > IRC or any other means which reaches the author. However, the CLA has > changed in several points since the Gitorious MR days (to the better, > after discussions with multiple parties active on codereview today). > This means that the old patches which were stuck or hadn't passed > through the Gitorious MR system before we switched will need to be > submitted again under the new terms. > > Frankly, the hurdle for doing so is not big, and if you have agreed to > the terms before, I'm sure the new term as just as good as the previous > ones. > > To reiterate what Stephen said, please submit patches through > http://codereview.qt-project.org, it's the only way we can properly > apply them. > > -- > .marius > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development As for the second bug report (https://bugreports.qt-project.org/browse/QTBUG-12874) shouldn't the standard icon paths be defined in the new class QStandardPaths? Then QIcon can use QStandardPaths to find icons - obviously. Right now i don't see any icon related thing in http://doc-snapshot.qt-project.org/5.0/qstandardpaths.html Since the icon stuff is defined by freedesktop (http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout) it might as well be added in there. Adding David Faure to the cc since he invented QStandardPaths. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
On 08/08/2012 04:12, ext André Somers wrote: > Op 8-8-2012 10:49, Stephen Kelly schreef: >> On Wednesday, August 08, 2012 10:35:15 André Somers wrote: >> > Op 8-8-2012 10:30, Stephen Kelly schreef: >> > > On Wednesday, August 08, 2012 12:03:34 ? ??? wrote: >> > > > In the QIcon/QIconLoader there are 2 old bugs with patches. >> > > > - https://bugreports.qt-project.org/browse/QTBUG-17953 >> > > > - https://bugreports.qt-project.org/browse/QTBUG-12874 >> > > > Fixes are trivial, and are available for many years. Merging of them >> > > > will take only an hour. >> > > You need to submit patches to Qt through gerrit. Patches attached in >> > > JIRA can't be applied. Note also that patches have to be applied to Qt >> > > 5 first and unit tested. >> > >> > Nice, but these patches were submitted way before Gerrit was available. >> > Are you saying we should just disgard any fixes that can be found in >> JIRA? >> >> They are not covered by the CLA. >> > Are you sure about that? Yes, Stephen is correct, the CLA covers only patches which has been submitted through Codereview.qt-project.org, so patches in Jira/Wiki/email cannot be applied. Even if the author "gives" you copyright to submit it to codereview as yourself (which is not allowed in many countries), _you_ would then be personally responsible for granting the license to use any patents his/her code might be infringing on. So, *don't* do that. Only submit code you have written yourself and where you can stand by the implementation. >> Whether they are 'trivial' enough to 'not be copyrightable' isn't >> for me to decide. I didn't look at them. >> >> Even when gerrit was not available, gitorious was available for all >> the time that JIRA was available. JIRA has never been 'the way to >> submit patches'. > > One of these had a MR on gitorious, actually. That got closed some > time later because Gerrit got introduced in the meantime. So, I bet > the contributor signed the agreement. I guess the submitter did not > want to jump through the hoops again, in the hope that this time his > patch *would* get accepted. A codereview can be done without using Gerrit of course, through email, IRC or any other means which reaches the author. However, the CLA has changed in several points since the Gitorious MR days (to the better, after discussions with multiple parties active on codereview today). This means that the old patches which were stuck or hadn't passed through the Gitorious MR system before we switched will need to be submitted again under the new terms. Frankly, the hurdle for doing so is not big, and if you have agreed to the terms before, I'm sure the new term as just as good as the previous ones. To reiterate what Stephen said, please submit patches through http://codereview.qt-project.org, it's the only way we can properly apply them. -- .marius ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
Op 8-8-2012 10:49, Stephen Kelly schreef: On Wednesday, August 08, 2012 10:35:15 André Somers wrote: > Op 8-8-2012 10:30, Stephen Kelly schreef: > > On Wednesday, August 08, 2012 12:03:34 ? ??? wrote: > > > In the QIcon/QIconLoader there are 2 old bugs with patches. > > > > > > > > > > > > - https://bugreports.qt-project.org/browse/QTBUG-17953 > > > > > > - https://bugreports.qt-project.org/browse/QTBUG-12874 > > > > > > > > > > > > > > > > > > Fixes are trivial, and are available for many years. Merging of them > > > > will > > > > > take only an hour. > > > > You need to submit patches to Qt through gerrit. Patches attached in > > JIRA can't be applied. Note also that patches have to be applied to Qt > > 5 first and unit tested. > > Nice, but these patches were submitted way before Gerrit was available. > Are you saying we should just disgard any fixes that can be found in JIRA? They are not covered by the CLA. Are you sure about that? Whether they are 'trivial' enough to 'not be copyrightable' isn't for me to decide. I didn't look at them. Even when gerrit was not available, gitorious was available for all the time that JIRA was available. JIRA has never been 'the way to submit patches'. One of these had a MR on gitorious, actually. That got closed some time later because Gerrit got introduced in the meantime. So, I bet the contributor signed the agreement. I guess the submitter did not want to jump through the hoops again, in the hope that this time his patch *would* get accepted. André ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
On Wednesday, August 08, 2012 10:35:15 André Somers wrote: > Op 8-8-2012 10:30, Stephen Kelly schreef: > > On Wednesday, August 08, 2012 12:03:34 ? ??? wrote: > > > In the QIcon/QIconLoader there are 2 old bugs with patches. > > > > > > > > > > > > - https://bugreports.qt-project.org/browse/QTBUG-17953 > > > > > > - https://bugreports.qt-project.org/browse/QTBUG-12874 > > > > > > > > > > > > > > > > > > Fixes are trivial, and are available for many years. Merging of them > > > > will > > > > > take only an hour. > > > > You need to submit patches to Qt through gerrit. Patches attached in > > JIRA can't be applied. Note also that patches have to be applied to Qt > > 5 first and unit tested. > > Nice, but these patches were submitted way before Gerrit was available. > Are you saying we should just disgard any fixes that can be found in JIRA? They are not covered by the CLA. Whether they are 'trivial' enough to 'not be copyrightable' isn't for me to decide. I didn't look at them. Even when gerrit was not available, gitorious was available for all the time that JIRA was available. JIRA has never been 'the way to submit patches'. Thanks, -- Stephen Kelly | Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-Independent Software Solutions signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
Op 8-8-2012 10:30, Stephen Kelly schreef: On Wednesday, August 08, 2012 12:03:34 ? ??? wrote: > In the QIcon/QIconLoader there are 2 old bugs with patches. > > - https://bugreports.qt-project.org/browse/QTBUG-17953 > - https://bugreports.qt-project.org/browse/QTBUG-12874 > > > Fixes are trivial, and are available for many years. Merging of them will > take only an hour. You need to submit patches to Qt through gerrit. Patches attached in JIRA can't be applied. Note also that patches have to be applied to Qt 5 first and unit tested. Nice, but these patches were submitted way before Gerrit was available. Are you saying we should just disgard any fixes that can be found in JIRA? André ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Two bugs in the QIcon which broke my life.
On Wednesday, August 08, 2012 12:03:34 Александр Соколов wrote: > In the QIcon/QIconLoader there are 2 old bugs with patches. > >- https://bugreports.qt-project.org/browse/QTBUG-17953 >- https://bugreports.qt-project.org/browse/QTBUG-12874 > > > Fixes are trivial, and are available for many years. Merging of them will > take only an hour. You need to submit patches to Qt through gerrit. Patches attached in JIRA can't be applied. Note also that patches have to be applied to Qt 5 first and unit tested. Although the wiki recommends qt5.git, that is a waste of time. Clone qtbase.git instead to create your patch. Thanks, -- Stephen Kelly | Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-Independent Software Solutions signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Two bugs in the QIcon which broke my life.
In the QIcon/QIconLoader there are 2 old bugs with patches. - https://bugreports.qt-project.org/browse/QTBUG-17953 - https://bugreports.qt-project.org/browse/QTBUG-12874 Fixes are trivial, and are available for many years. Merging of them will take only an hour. Despite the fact that bugs are small, they greatly complicate the development of Linux projects. For example Razor-qt have to special workaround for this - https://github.com/Razor-qt/razor-qt/tree/master/libraries/qtxdg/qiconfix. Please include these fixes in the release. -- Best regards, Alexander. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
