Re: [PATCH] mfd: DT bindings for the palmas family MFD
On Mon, Jun 03, 2013 at 03:18:51PM +0100, Lee Jones wrote: On Mon, 03 Jun 2013, J Keerthy wrote: + optional chip specific regulator fields :- + ti,warm-reset - maintain voltage during warm reset(boolean) Pushing the boat out a bit here, but is it possible to reuse 'regulator-always-on' for this? This sounds more like don't reset over reboot than never change the enable state. + ti,roof-floor - control voltage selection by pin(boolean) Is this the same as a GPIO regulator? If so, you might not need to add superfluous vendor specific properties. Lots of regulators have the ability to do things like switch between programmable voltages based on GPIOs (enabling a fast change to a known voltage) - the roof-floor naming sounds like this. Usually there's also register based element for selecting the voltage. See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, + 2 - eco, 3 - forced pwm I've seen lots of sleep-mode properties, can't we define a generic one? We should make some of this more standard (at least things like voltages) but the whole concept of what sleep mode is is at best fuzzy. You typically need different selections for suspend to RAM and suspend to disk, plus often the suspend configuration is dynamic depending on what the system is doing since suspend is just CPU suspend not system suspend and there's also some changes that might happen depending on which wake sources are currently available. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH] mfd: DT bindings for the palmas family MFD
On Mon, 03 Jun 2013, Stephen Warren wrote:
On 06/03/2013 08:18 AM, Lee Jones wrote:
On Mon, 03 Jun 2013, J Keerthy wrote:
Add the various binding files for the palmas family of chips. There is a
top level MFD binding then a seperate binding for regulators IP blocks on
chips.
diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt
b/Documentation/devicetree/bindings/mfd/palmas.txt
+Example:
+
+palmas {
Should this be 'palmas@48 {', as it has an address?
It's common to only include the unit-address (@48) if it's needed to
make the node name unique (i.e. if you had multiple palmas devices).
I was working on the basis of, if it has a 'reg' value, it should be
highlighted in the node name, but if this is the common way of doing
things then fair enough.
diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
+ ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
+ 2 - eco, 3 - forced pwm
I've seen lots of sleep-mode properties, can't we define a generic
one?
Isn't it HW-specific?
Yes, they're not all identical. I haven't studied them all in detail,
but I assumed a we would be able to do something in order to
consolidate them somewhat. If they are vastly different then no
problem, it was just an idea to cut down on vendor specific
properties.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH] mfd: DT bindings for the palmas family MFD
On Mon, 03 Jun 2013, J Keerthy wrote:
From: Graeme Gregory g...@slimlogic.co.uk
Add the various binding files for the palmas family of chips. There is a
top level MFD binding then a seperate binding for regulators IP blocks on
chips.
Signed-off-by: Graeme Gregory g...@slimlogic.co.uk
Signed-off-by: J Keerthy j-keer...@ti.com
Signed-off-by: Ian Lartey i...@slimlogic.co.uk
---
Documentation/devicetree/bindings/mfd/palmas.txt | 49 ++
.../devicetree/bindings/regulator/palmas-pmic.txt | 165
2 files changed, 214 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
create mode 100644
Documentation/devicetree/bindings/regulator/palmas-pmic.txt
diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt
b/Documentation/devicetree/bindings/mfd/palmas.txt
new file mode 100644
index 000..c6c5e78
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/palmas.txt
@@ -0,0 +1,49 @@
+* palmas device tree bindings
+
+The TI palmas family current members :-
+twl6035 (palmas)
+twl6037 (palmas)
+tps65913 (palmas)
+tps65914 (palmas)
+
+Required properties:
+- compatible : Should be from the list
+ ti,twl6035
+ ti,twl6036
+ ti,twl6037
+ ti,tps65913
+ ti,tps65914
+ ti,tps80036
+and also the generic series names
+ ti,palmas
+- interrupt-controller : palmas has its own internal IRQs
+- #interrupt-cells : should be set to 2 for IRQ number and flags
+ The first cell is the IRQ number.
+ The second cell is the flags, encoded as the trigger masks from
+ Documentation/devicetree/bindings/interrupts.txt
+- interrupt-parent : The parent interrupt controller.
+
+Optional properties:
+ ti,mux_padX : set the pad register X (1-2) to the correct muxing for the
+ hardware, if not set will use muxing in OTP.
+
+Example:
+
+palmas {
Should this be 'palmas@48 {', as it has an address?
+ compatible = ti,twl6035, ti,palmas;
+ reg = 0x48
+ interrupt-parent = intc;
+ interrupt-controller;
+ #interrupt-cells = 2;
+
+ ti,mux-pad1 = 0;
+ ti,mux-pad2 = 0;
+
+ #address-cells = 1;
+ #size-cells = 0;
+
+ pmic {
+ compatible = ti,twl6035-pmic, ti,palmas-pmic;
+
+ };
+}
diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
new file mode 100644
index 000..f7bbc3e
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
@@ -0,0 +1,165 @@
+* palmas regulator IP block devicetree bindings
+
+Required properties:
+- compatible : Should be from the list
+ ti,twl6035-pmic
+ ti,twl6036-pmic
+ ti,twl6037-pmic
+ ti,tps65913-pmic
+ ti,tps65914-pmic
+and also the generic series names
+ ti,palmas-pmic
+
+Optional properties:
+- ti,ldo6-vibrator : ldo6 is in vibrator mode
+
+Optional nodes:
+- regulators : should contain the constrains and init information for the
+regulators. It should contain a subnode per regulator from the
+list.
+For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP,
+smps45, smps457, smps7 depending on varient, smps6, smps[8-10],
+ldo[1-9], ldoln, ldousb
+
+optional chip specific regulator fields :-
+ti,warm-reset - maintain voltage during warm reset(boolean)
Pushing the boat out a bit here, but is it possible to reuse
'regulator-always-on' for this?
+ti,roof-floor - control voltage selection by pin(boolean)
Is this the same as a GPIO regulator?
If so, you might not need to add superfluous vendor specific properties.
See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
+ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
+2 - eco, 3 - forced pwm
I've seen lots of sleep-mode properties, can't we define a generic
one?
+ti,tstep - slope control 0 - Jump, 1 10mV/us, 2 5mV/us, 3
2.5mV/us
+ti,smps-range - OTP has the wrong range set for the hardware so
override
+0 - low range, 1 - high range
+
+Example:
+
+pmic@0 {
May as well drop the '@0' here unless it's meaningful.
+ compatible = ti,twl6035-pmic, ti,palmas-pmic;
+ interrupt-parent = palmas;
+ interrupts = 14 0;
Use the defines found in:
arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h
+ interrupt-name = short-irq;
+
+ ti,ldo6_vibrator;
DT doesn't like '_'s, use a '-'s instead.
+ regulators {
+ smps12_reg : smps12 {
+ regulator-name = smps12;
+ regulator-min-microvolt = 60;
+ regulator-max-microvolt = 150;
+ regulator-always-on;
+ regulator-boot-on;
+ ti,warm-reset;
Hmm.. I see you're
Re: [PATCH] mfd: DT bindings for the palmas family MFD
On 06/03/2013 08:18 AM, Lee Jones wrote:
On Mon, 03 Jun 2013, J Keerthy wrote:
Add the various binding files for the palmas family of chips. There is a
top level MFD binding then a seperate binding for regulators IP blocks on
chips.
diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt
b/Documentation/devicetree/bindings/mfd/palmas.txt
+Example:
+
+palmas {
Should this be 'palmas@48 {', as it has an address?
It's common to only include the unit-address (@48) if it's needed to
make the node name unique (i.e. if you had multiple palmas devices).
diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
+ ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
+ 2 - eco, 3 - forced pwm
I've seen lots of sleep-mode properties, can't we define a generic
one?
Isn't it HW-specific?
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
