[freenet-dev] [wininstaller beta] Testing on Windows + Uninstall survey

2009-10-03 Thread Zero3
Matthew Toseland wrote:
> On Monday 24 August 2009 17:03:21 Zero3 wrote:
>> Matthew Toseland skrev:
>>> On Friday 21 August 2009 20:12:39 Zero3 wrote:
 Matthew Toseland skrev:
> Here's another one:
>
> I accidentally built the installer with the beta branch. The tray icon 
> worked, but when I uninstalled, and told it to do the survey, the survey 
> failed (as usual), but control panel hung. Ideas? I think it might be 
> waiting for firefox to close, but this is very bad behaviour, as there 
> may be other stuff in firefox?
>
> I don't think this is specific to the beta branch - we wait for firefox 
> (or whatever browser) to close before closing control panel.
 Nop, it will not wait for the browser to close. It will exit right after 
 launching:

 [CODE]
 If (_DoSurvey)
 {
Run, http://freenetproject.org/uninstall.html, , UseErrorLevel
 }

 Exit()
 [/CODE]

 (The execute-and-wait-for-it-to-finish command is called "RunWait" as 
 opposed to the "Run" used here which will continue right away)

 Are you sure that freenetuninstaller.exe is running while the control 
 panel hangs?
>>> I don't know. I do know that control panel hangs until the browser exists.
>> Odd. Maybe it also considers processes spawned by the uninstaller as 
>> part of the uninstaller itself, and does not return control to the 
>> control panel until all of these have terminated. Would make sense, as 
>> uninstallers often continue in other processes than the originally 
>> executed one (the wininstaller uninstaller included).
>>
>> Nevertheless, this is a design choice by Microsoft. If they want to 
>> freeze out the user while any part of an uninstaller is running, I 
>> shouldn't try to (and probably can't) get around it.
> 
> There must be a way to detach it.

There might be. No idea how much hacking it would take though. IMHO I 
don't think the minor usability issue is worth the hack.

On Vista I am able to close the control panel, although not start a new 
uninstall before the browser is closed.

>> A possible workaround could be to add a message to the survey completion 
>> page simply asking the user to close the window.
> 
> Unfortunately it's broken atm.

Any update on this? Please at least remove the survey from 
http://freenetproject.org/uninstall.html and replace it with a 
"Temporary out of order" message or something. We are seriously wasting 
people's time right now.
- Zero3



[freenet-dev] [wininstaller beta] Testing on Windows + Uninstall survey

2009-10-02 Thread Zero3
Matthew Toseland wrote:
> On Monday 24 August 2009 17:03:21 Zero3 wrote:
>> Matthew Toseland skrev:
>>> On Friday 21 August 2009 20:12:39 Zero3 wrote:
 Matthew Toseland skrev:
> Here's another one:
>
> I accidentally built the installer with the beta branch. The tray icon 
> worked, but when I uninstalled, and told it to do the survey, the survey 
> failed (as usual), but control panel hung. Ideas? I think it might be 
> waiting for firefox to close, but this is very bad behaviour, as there 
> may be other stuff in firefox?
>
> I don't think this is specific to the beta branch - we wait for firefox 
> (or whatever browser) to close before closing control panel.
 Nop, it will not wait for the browser to close. It will exit right after 
 launching:

 [CODE]
 If (_DoSurvey)
 {
Run, http://freenetproject.org/uninstall.html, , UseErrorLevel
 }

 Exit()
 [/CODE]

 (The execute-and-wait-for-it-to-finish command is called "RunWait" as 
 opposed to the "Run" used here which will continue right away)

 Are you sure that freenetuninstaller.exe is running while the control 
 panel hangs?
>>> I don't know. I do know that control panel hangs until the browser exists.
>> Odd. Maybe it also considers processes spawned by the uninstaller as 
>> part of the uninstaller itself, and does not return control to the 
>> control panel until all of these have terminated. Would make sense, as 
>> uninstallers often continue in other processes than the originally 
>> executed one (the wininstaller uninstaller included).
>>
>> Nevertheless, this is a design choice by Microsoft. If they want to 
>> freeze out the user while any part of an uninstaller is running, I 
>> shouldn't try to (and probably can't) get around it.
> 
> There must be a way to detach it.

There might be. No idea how much hacking it would take though. IMHO I 
don't think the minor usability issue is worth the hack.

On Vista I am able to close the control panel, although not start a new 
uninstall before the browser is closed.

>> A possible workaround could be to add a message to the survey completion 
>> page simply asking the user to close the window.
> 
> Unfortunately it's broken atm.

Any update on this? Please at least remove the survey from 
http://freenetproject.org/uninstall.html and replace it with a 
"Temporary out of order" message or something. We are seriously wasting 
people's time right now.
- Zero3
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl