[freenet-dev] 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3

2009-07-10 Thread Matthew Toseland 
On Thursday 09 July 2009 23:23:22 Florent Daigni?re wrote:
> commit 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3
> Author: Matthew Toseland 
> Date:   Fri Jul 3 19:57:12 2009 +0100
> 
> Sanity check for UPnP bandwidth autodetection
> 
> 
> +   int upstreamBWLimit =
> bwIndicator.getUpstramMaxBitRate();
> +   if(downstreamBWLimit > 0 && downstreamBWLimit < 65536 ||
> upstreamBWLimit > 0 && ups
> +   // These are kilobits, not bits, per second,
> right?
> +   // Assume the router is buggy and don't
> autoconfigure.
> 
> ##
> 
> Congratz, you broke working code!
> 
> They are bits per second as specified by the specification. Hint: google
> for UPnP_IGD_WANPPPConnection 1.0.pdf

It was reporting kilobits for one specific router. But I agree we need some 
extra brackets. Doh.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
URL:

Re: [freenet-dev] 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3

2009-07-10 Thread Matthew Toseland 
On Thursday 09 July 2009 23:23:22 Florent Daignière wrote:
> commit 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3
> Author: Matthew Toseland 
> Date:   Fri Jul 3 19:57:12 2009 +0100
> 
> Sanity check for UPnP bandwidth autodetection
> 
> 
> +   int upstreamBWLimit =
> bwIndicator.getUpstramMaxBitRate();
> +   if(downstreamBWLimit > 0 && downstreamBWLimit < 65536 ||
> upstreamBWLimit > 0 && ups
> +   // These are kilobits, not bits, per second,
> right?
> +   // Assume the router is buggy and don't
> autoconfigure.
> 
> ##
> 
> Congratz, you broke working code!
> 
> They are bits per second as specified by the specification. Hint: google
> for UPnP_IGD_WANPPPConnection 1.0.pdf

It was reporting kilobits for one specific router. But I agree we need some 
extra brackets. Doh.


signature.asc
Description: This is a digitally signed message part.
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

[freenet-dev] 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3

2009-07-09 Thread Florent Daignière 
commit 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3
Author: Matthew Toseland 
Date:   Fri Jul 3 19:57:12 2009 +0100

Sanity check for UPnP bandwidth autodetection


+   int upstreamBWLimit =
bwIndicator.getUpstramMaxBitRate();
+   if(downstreamBWLimit > 0 && downstreamBWLimit < 65536 ||
upstreamBWLimit > 0 && ups
+   // These are kilobits, not bits, per second,
right?
+   // Assume the router is buggy and don't
autoconfigure.

##

Congratz, you broke working code!

They are bits per second as specified by the specification. Hint: google
for UPnP_IGD_WANPPPConnection 1.0.pdf

NextGen$
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL:

[freenet-dev] 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3

2009-07-09 Thread Florent Daignière 
commit 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3
Author: Matthew Toseland 
Date:   Fri Jul 3 19:57:12 2009 +0100

Sanity check for UPnP bandwidth autodetection


+   int upstreamBWLimit =
bwIndicator.getUpstramMaxBitRate();
+   if(downstreamBWLimit > 0 && downstreamBWLimit < 65536 ||
upstreamBWLimit > 0 && ups
+   // These are kilobits, not bits, per second,
right?
+   // Assume the router is buggy and don't
autoconfigure.

##

Congratz, you broke working code!

They are bits per second as specified by the specification. Hint: google
for UPnP_IGD_WANPPPConnection 1.0.pdf

NextGen$


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl