Re: CSS definitions for tags without IDs or classes
Hi Bombe, David “Bombe” Roden writes: > For Sone I have added a simple reset (i.e. “max-width: inherit;”) but other > plugins might or might not do that. So for the future I would ask everyone to > please restrict such broad definitions in CSS with an additional class (or > even better, ID) in order to have minimal impact on plugins and other pages. > That also means that we should watch out for that in future code reviews. Thank you for the warning! We had a similar problem in Freetalk once (a change to Toadlets added linebreaks after tags which broke the Freetalk messages), but I missed it in the code-review. Sorry for that :-/ Will try to look more carefully at global redefinitions in themes. Best wishes, Arne -- Unpolitisch sein heißt politisch sein ohne es zu merken signature.asc Description: PGP signature
CSS definitions for tags without IDs or classes
Hi.
I recently noticed that one of the HTML textareas in Sone is only half its
usual width and tracking the reason for that lead me to commit
c766ec1a78ffc6fdcce6178dff5688e598f240ce.
Here is the important excerpt:
+textarea {
+ max-width: 50%;
+ width: 100%;
+}
Definitions like this (i.e. a tag without any further restrictions such as
classes or IDs) are used for _all_ plugins… which usually means they mess up
all plugins. :)
For Sone I have added a simple reset (i.e. “max-width: inherit;”) but other
plugins might or might not do that. So for the future I would ask everyone to
please restrict such broad definitions in CSS with an additional class (or even
better, ID) in order to have minimal impact on plugins and other pages. That
also means that we should watch out for that in future code reviews.
Thank you!
Greetings,
--
* David ‘Bombe’ Roden
