Reviews needed for Freenet 1494

2022-09-30 Thread Dr. Arne Babenhauserheide
Hi,


We have pretty cool changes in the pipeline for 1495, but several of
those still need reviews.


The following changes are already ready to be merged and need no further
review:
https://github.com/freenet/fred/pulls?q=is%3Apr+is%3Aopen+label%3AreadyToBeMerged

I’m especially happy that I finally got to resolve the conflicts in
Eleriseth pending keys: https://github.com/freenet/fred/pull/404 This
has the potential of reducing the CPU load for fast nodes and for WoT a
lot.

The healing size increase to 250MiB should increase the lifetime of
large files a lot. Healing just didn’t work well for bigger files,
because the limit was too low (it healed at most 16MiB, so many files
bigger than 32MiB could not be healed fully by one access).

(Also there are already two CSS improvements — and one more CSS
improvement and a dark theme to file as PR in my TODO list; I’ll try to
file them soon!)


But there are a lot more pull-requests that still need review. They
include the new firsttime wizard by redwerk (I finally managed to add
the needed dependency tracking), work on bookmarks, announcement fixes
and an improvement to the m3u-player (skip to the next track if a
download failed, so you can keep it running like radio).

So if you can make some time, please have a look at one of the pull
requests that is not yet marked as readyToBeMerged:
https://github.com/freenet/fred/pulls


Thank you for your interest in Freenet!


Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de


signature.asc
Description: PGP signature


Reviews needed for Freenet 1494

2022-06-11 Thread Dr. Arne Babenhauserheide
Hi,


There is already a pretty nice collection of changes in the pipeline for
1494 (see https://github.com/freenet/fred/pulls ), but four of the
pull-requests still need a review to be able to release:


- randomize pitch black defense times
  https://github.com/freenet/fred/pull/747
  (this one is important for the long-term viability of Freenet!)

- m3u-player: more robust sizes, do not use overlay for audio.
  https://github.com/freenet/fred/pull/768
  (this enables *convenient* samizdat radio on Freesites!)

- add opens jvmargs when building on java 17
  https://github.com/freenet/fred/pull/769
  (important to have an easier start for new contributors)

- remove old unconditional logging line
  https://github.com/freenet/fred/pull/770
  (that’s a simple cleanup)


Please look into them — I cannot review them myself, because I added
them, and we need at least four eyes on every change for basic safety.


Also if you have some knowledge about our RequestStarter logic, please
have a look at https://github.com/freenet/fred/pull/777/files

According to Trivuele that improves throttling of local requests
significantly, because the existing logic was pretty inconsistent over
time, but I don’t understand the old logic well enough to see whether
the old behavior was a bug or whether there was a point to it.


Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de


signature.asc
Description: PGP signature