Re: [xwiki-devs] [XWiki Day] BFD#204

[Oana-Lavinia Florean]

Results:
https://www.xwiki.org/xwiki/bin/view/Blog/Bug%20Fixing%20Day%20204

Thanks,
Lavinia

On Thu, Jan 17, 2019 at 8:35 AM Oana-Lavinia Florean 
wrote:

> Hello devs,
>
> This Thursday is BFD#204:
> http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday
>
> Our current status is:
> * -31 bugs over 120 days (4 months), i.e. we need to close 31 bugs to have
> created bugs == closed bugs
> * -137 bugs over 365 days (1 year)
> * -147 bugs over 500 days (between 1 and 2 years)
> * -340 bugs over 1600 days (4.3 years)
>
> See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352
>
> Here's the BFD#204 dashboard to follow the progress during the day:
> https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14356
>
> Good luck at fixing bugs,
> Lavinia
>


-- 
 *Florean Oana-Lavinia*
*Software Development Engineer Intern*
oana.flor...@xwiki.com 
tel: +40 75 136 7570

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

[Adel Atallah]

On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol  wrote:
>
> Hi Adel,
>
> > On 17 Jan 2019, at 11:05, Adel Atallah  wrote:
> >
> > Hi devs,
> >
> > After discussing with Marius and Thomas, we thought it might be a good
> > idea to do the following to have a document picker in the include and
> > display maros:
> > * Remove the deprecation of the document parameter (only for the include 
> > macro).
>
> I don’t understand this part. Sounds counter-intuitive to me since we want 
> users to use the “reference” one. Could you explain?

We currently only have a document picker that we can use for
DocumentReferences. To have auto-suggestion on the "reference"
parameter, we would need to make another picker for all type of
references, not just document.

>
> Thanks
> -Vincent
>
> > * Introduce a new annotation to macro parameters to specify / override
> > its type (different from its actual java type).
> >
> > The new annotation will mostly be useful for the WYSIWYG side. In our
> > case we want to use the document parameter which is a String. The
> > annotation will allow us to work with a DocumentReference instead
> > which can be used to display the document picker when editing the
> > macro in WYSIWYG mode.
> >
> > To be clear, here is how we would use it:
> >  @PropertyType(DocumentReference.class)
> >   public void setDocument(String document)
> >
> > WDYT?
> >
> > Thanks,
> > Adel
>

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

[Vincent Massol]

Hi Adel,

> On 17 Jan 2019, at 11:05, Adel Atallah  wrote:
> 
> Hi devs,
> 
> After discussing with Marius and Thomas, we thought it might be a good
> idea to do the following to have a document picker in the include and
> display maros:
> * Remove the deprecation of the document parameter (only for the include 
> macro).

I don’t understand this part. Sounds counter-intuitive to me since we want 
users to use the “reference” one. Could you explain?

Thanks
-Vincent

> * Introduce a new annotation to macro parameters to specify / override
> its type (different from its actual java type).
> 
> The new annotation will mostly be useful for the WYSIWYG side. In our
> case we want to use the document parameter which is a String. The
> annotation will allow us to work with a DocumentReference instead
> which can be used to display the document picker when editing the
> macro in WYSIWYG mode.
> 
> To be clear, here is how we would use it:
>  @PropertyType(DocumentReference.class)
>   public void setDocument(String document)
> 
> WDYT?
> 
> Thanks,
> Adel