Hi Adel, > On 17 Jan 2019, at 11:05, Adel Atallah <adel.atal...@xwiki.com> wrote: > > Hi devs, > > After discussing with Marius and Thomas, we thought it might be a good > idea to do the following to have a document picker in the include and > display maros: > * Remove the deprecation of the document parameter (only for the include > macro).
I don’t understand this part. Sounds counter-intuitive to me since we want users to use the “reference” one. Could you explain? Thanks -Vincent > * Introduce a new annotation to macro parameters to specify / override > its type (different from its actual java type). > > The new annotation will mostly be useful for the WYSIWYG side. In our > case we want to use the document parameter which is a String. The > annotation will allow us to work with a DocumentReference instead > which can be used to display the document picker when editing the > macro in WYSIWYG mode. > > To be clear, here is how we would use it: > @PropertyType(DocumentReference.class) > public void setDocument(String document) > > WDYT? > > Thanks, > Adel
